SVNews r332535

NOTE: This service is experimental and subject to change! Use at your own risk!

2018-04-16 03:44:13 - r332535 by mav (Alexander Motin)

Complete list of files affected by revision r332535:

(Note: At the moment, these links point to ViewVC on svn.freebsd.org. They are probably slow. Do not overuse.)

   Contents     MODIFY   /stable/11  
  History   Contents   Diff   MODIFY   /stable/11/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_dataset.c  
  History   Contents   Diff   MODIFY   /stable/11/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c  

Commit message:

MFC r329783: 8942 zfs promote .../%recv should be an error

illumos/illumos-gate@add927f8c8d101e16c23eb9cd270be4fd7edf7d5

Reported on the ZFSonLinux https://github.com/zfsonlinux/zfs/issues/4843,
fixed by https://github.com/zfsonlinux/zfs/pull/6339:

If we are in the middle of an incremental zfs receive, the child .../%recv
will exist. If you concurrently run zfs promote .../%recv, it will "work",
but then zfs gets confused. For example, there's no obvious way to destroy
the containing filesystem (because it is now a clone of its invisible child).

Attempting to do this promote should be an error. We could fix this by
having zfs_ioc_promote() check if zc_name contains a %, similar to
zfs_ioc_rename().

Reviewed by: Paul Dagnelie <pcd@delphix.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Approved by: Dan McDonald <danmcd@joyent.com>
Author: loli10K <ezomori.nozomu@gmail.com>

 


Powered by Python FreeBSD support by secnetix GmbH & Co. KG

Page generated in 8 ms, 3 files printed. Current time is 2018-04-23 15:09:32. All times are in UTC/GMT.