SVNews r330833

NOTE: This service is experimental and subject to change! Use at your own risk!

2018-03-13 09:29:56 - r330833 by eadler (Eitan Adler)

Complete list of files affected by revision r330833:

(Note: At the moment, these links point to ViewVC on They are probably slow. Do not overuse.)

   Contents     MODIFY   /stable/11  
  History   Contents   Diff   MODIFY   /stable/11/sys/dev/syscons/syscons.c  

Commit message:

MFC r304161:

Change all uses of 'debugger' to kdb_active and remove this variable. This
restores avoidance of doing dangerous things like calling wakeup() and
callouts while in ddb.

Initialization of 'debugger' was broken by removing the cndbctl() console
method that was used mainly in this driver to initialize 'debugger' and
switch to the console screen on entry to ddb. The screen switch was
restored using the cngrab() method, but cngrab() is more general so it
should not initialize 'debugger' and never did. 'debugger' was just
an over-engineered alias for kdb_active anyway. It existed because
kdb_active (when it was named ddb_active) was considered as a private
kdb variable, and there are ordering problems initializing the variables
atomically with the state that they represent, but an extra variable and
method to set it increased these problems.

The bug caused LORs, but WITNESS is normally misconfigured with
WITNESS_SKIPSIN so it doesn't check the spinlocks used by wakeup() and


Powered by Python FreeBSD support by secnetix GmbH & Co. KG

Page generated in 13 ms, 2 files printed. Current time is 2018-03-18 09:33:14. All times are in UTC/GMT.