SVNews r330658

NOTE: This service is experimental and subject to change! Use at your own risk!

2018-03-08 15:53:04 - r330658 by hselasky (Hans Petter Selasky)

Complete list of files affected by revision r330658:

(Note: At the moment, these links point to ViewVC on They are probably slow. Do not overuse.)

  History   Contents   Diff   MODIFY   /head/sys/dev/mlx5/mlx5_en/mlx5_en_tx.c  

Commit message:

Fix mlx5en(4) driver to properly call m_defrag().

When the mlx5en(4) driver was converted to using BUSDMA(9) the call to
m_defrag() was moved after the part of the TX routine that strips the
header from the mbuf chain. Before it called m_defrag it first trimmed
off the now-empty mbufs from the start of the chain. This has the side
effect of also removing the head of the chain that has M_PKTHDR set.
m_defrag() will not defrag a chain that does not have M_PKTHDR set,
thus it was effectively never defragging the mbuf chains.

As it turns out, trimming the mbufs in this fashion is unnecessary since
the call to bus_dmamap_load_mbuf_sg doesn't map empty mbufs anyway, so
remove it.

Differential Revision:
Submitted by: mjoras@
MFC after: 1 week
Sponsored by: Mellanox Technologies


Powered by Python FreeBSD support by secnetix GmbH & Co. KG

Page generated in 9 ms, 1 file printed. Current time is 2018-03-18 11:50:16. All times are in UTC/GMT.