SVNews

NOTE: This service is experimental and subject to change! Use at your own risk!

Year:   Month: - or - Filter committers: - or -
Filter paths:
Include diffs if smaller than lines.

2017 - 04 - 24   (today)
16:52:26 - r317378
( 9 minutes ago)
by bcr
Affects:  /head/usr.bin/sed/sed.1
Fix the last example to really replace all occurrences of the search string
in the file by adding the global (g) option at the end. Without it, only the
first match is replaced, subsequent ones are ignored. The intention of the
example is to demonstrate something else, but adding the g matches the example
to what the description says.

Discussed with: brd (on IRC)
MFC after: 1 week
16:49:30 - r317377
( 12 minutes ago)
by andrew
Affects: 
(3 files)
/stable/11/usr.sbin/acpi/acpidump/acpi.c
/stable/11/usr.sbin/acpi/acpidump/acpidump.c
MFC r302788, r303026, r305471

r302788:
Fix the type used to hold the value returned from getopt. On arm64 char is
unsigned so will never be -1.

r303026:
Add missing flags from acpidump. These are defined in the header, but not
printed. The HW_REDUCED flag is useful as it should be set on arm64 to
comply with the ARM Server Base Boot Requirements.

r305471:
Teach acpidump how to parse ACPI 5.1 tables found on the development
ThunderX units in the netperf cluster.
16:37:25 - r317376
( 24 minutes ago)
by emaste
Affects:  /head/release/scripts/pkg-stage.sh
Add sysutils/tmux to the DVD package set

The zsh + tmux combination is commonly wanted.

Approved by: gjb
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation
16:31:28 - r317375
( 30 minutes ago)
by smh
Affects: 
(7 files)
/stable/10/cddl/lib/libdtrace/ip.d
/stable/10/sys/netinet/*
Partial MFC r316676 and the required r313045

MFC r316676:

Use estimated RTT for receive buffer auto resizing instead of timestamps.
This is a partial MFC as stable/10 doesn't include the TCP stack
modularisation.

MFC r313045:

Add an mbuf to ipinfo_t translator to finish cleanup of mbuf passing to TCP
probes. This is a partial MFC (missing debug__output & debug__drop changes)
due to the massive amount of additional dtrace changes that would be
required for a full MFC.

Relnotes: Yes
Sponsored by: Multiplay
16:07:30 - r317374
( 54 minutes ago)
by asomers
Affects: 
(5 files)
/stable/11/sbin/camcontrol/*
MFC r312558:

Misc Coverity fixes in camcontrol(8)

CID 1229913 Fix output of "camcontrol persist -i report_capabilities".
  The reported Persistent Reservation Types were wrong in all
  cases.
CID 1356029 Annotate the code so Coverity will know that this is a false
  positive.
CID 1366830 Fix a memory leak in "camcontrol timestamp -s"
CID 1366832 Fix a segfault that could be caused by bad drive firmware

Also, fix the man page entry for the "camcontrol epc state" command to match
what the code does.

Reviewed by: ken, wblock
MFC after: 4 weeks
Sponsored by: Spectra Logic Corp
Differential Revision: https://reviews.freebsd.org/D9239
15:29:17 - r317373
(1 hour 32 minutes ago)
by asomers
Affects: 
(5 files)
/stable/11/etc/*
/stable/11/share/man/man5/periodic.conf.5
/stable/11/usr.sbin/periodic/periodic.sh
MFC r316342, r316358

r316342:
Consolidate random sleeps in periodic scripts

Multiple periodic scripts sleep for a random amount of time in order to
mitigate the thundering herd problem. This is bad, because the sum of
multiple uniformly distributed random variables approaches a normal
distribution, so the problem isn't mitigated as effectively as it would be
with a single sleep.

This change creates a single configurable anticongestion sleep. periodic
will only sleep if at least one script requires it, and it will never sleep
more than once per invocation. It also won't sleep if periodic was run
interactively, fixing an unrelated longstanding bug.

PR: 217055
PR: 210188
Reviewed by: cy
MFC after: 3 weeks
Differential Revision: https://reviews.freebsd.org/D10211

r316358:
Fix man page typo from r316342

Reported by: rgrimes
MFC after: 20 days
X-MFC-With: 316342
14:56:41 - r317372
(2 hours 5 minutes ago)
by pfg
Affects:  /head/lib/libc/gen/scandir.c
scandir(3): promote arraysz to size_t to match numitems.

The internal array size goes through a loop and is compared with numitems
which at its limits makes can be unreachably higher than arraysz.
Prevent an hypothetical overflow by matching the types.

MFC after: 1 week
14:51:53 - r317371
(2 hours 9 minutes ago)
by emaste
Affects:  /head/contrib/elftoolchain/elfcopy/main.c
elfcopy: allow empty symbol list files

Reported by: bz
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D10441
12:52:42 - r317370
(4 hours 9 minutes ago)
by mav
Affects:  /head/sys/cam/ctl/ctl.c
Change ctl_free_lun() locking.

This fixes potential callout_drain() sleep under non-sleepable lock.

PR: 218167
MFC after: 2 weeks
12:44:04 - r317369
(4 hours 17 minutes ago)
by mav
Affects:  /head/sys/cam/ctl/ctl_backend_block.c
/head/sys/cam/ctl/ctl_backend_ramdisk.c
Slightly compact the code.

MFC after: 2 weeks
11:34:02 - r317368
(5 hours 27 minutes ago)
by smh
Affects: 
(7 files)
/stable/11/sys/netinet/*
MFC r316676:

Use estimated RTT for receive buffer auto resizing instead of timestamps

Relnotes: Yes
Sponsored by: Multiplay
11:22:07 - r317367
(5 hours 39 minutes ago)
by mav
Affects: 
(2 files)
/stable/10/sys/dev/isp/ispmbox.h
MFC r315913: Add brackets to fix incorrect macro expansion.
11:21:32 - r317366
(5 hours 40 minutes ago)
by mav
Affects: 
(8 files)
/stable/10/sys/dev/isp/*
MFC r315908: Unify initiator and target DMA setup and command sending.

The code is so alike that it is pointless to keep it separate.
11:20:56 - r317365
(5 hours 40 minutes ago)
by mav
Affects: 
(2 files)
/stable/10/sys/dev/isp/isp_freebsd.h
MFC r315870: isp field in struct isp_pcmd is also unused.
11:20:21 - r317364
(5 hours 41 minutes ago)
by mav
Affects: 
(3 files)
/stable/10/sys/dev/isp/isp_freebsd.c
/stable/10/sys/dev/isp/isp_freebsd.h
MFC r315869: Remove write-only crn field from struct isp_pcmd.
11:19:47 - r317363
(5 hours 42 minutes ago)
by mav
Affects: 
(5 files)
/stable/10/sys/dev/isp/*
MFC r315708: Cleanup response queue processing.
11:12:03 - r317362
(5 hours 49 minutes ago)
by mav
Affects: 
(2 files)
/stable/11/sys/dev/isp/ispmbox.h
MFC r315913: Add brackets to fix incorrect macro expansion.
11:06:10 - r317361
(5 hours 55 minutes ago)
by andrew
Affects: 
(4 files)
/head/sys/arm64/arm64/vm_machdep.c
/head/sys/conf/options.arm64
/head/sys/dev/psci/*
Call the PSCI reset from cpu_reset on arm64. When rebooting from DDB the
kernel calls this directly so the event handler is not called, meaning
the computer fails to reboot.

Tested by: cognet
MFC after: 1 week
Sponsored by: DARPA, AFRL
10:21:13 - r317360
(6 hours 40 minutes ago)
by mav
Affects: 
(8 files)
/stable/11/sys/dev/isp/*
MFC r315908: Unify initiator and target DMA setup and command sending.

The code is so alike that it is pointless to keep it separate.
10:20:36 - r317359
(6 hours 41 minutes ago)
by mav
Affects: 
(2 files)
/stable/11/sys/dev/isp/isp_freebsd.h
MFC r315870: isp field in struct isp_pcmd is also unused.
10:19:59 - r317358
(6 hours 41 minutes ago)
by mav
Affects: 
(3 files)
/stable/11/sys/dev/isp/isp_freebsd.c
/stable/11/sys/dev/isp/isp_freebsd.h
MFC r315869: Remove write-only crn field from struct isp_pcmd.
10:19:26 - r317357
(6 hours 42 minutes ago)
by mav
Affects: 
(5 files)
/stable/11/sys/dev/isp/*
MFC r315708: Cleanup response queue processing.
10:16:12 - r317356
(6 hours 45 minutes ago)
by mav
Affects:  /head/sys/dev/isp/isp.c
Switch isp_reset to scratchpad not requiring ISP_MBOXDMASETUP.

MFC after: 1 week
08:44:51 - r317355
(8 hours 17 minutes ago)
by mav
Affects:  /head/sys/dev/cxgbe/cxgbei/icl_cxgbei.c
Use proper alignment constant for uma_zcreate().

Previous code panicked on KASSERT with INVARIANTS enabled.

MFC after: 2 weeks
07:52:44 - r317354
(9 hours 9 minutes ago)
by kib
Affects: 
(2 files)
/stable/11/sys/arm64/arm64/pmap.c
MFC r316679:
Do not lose dirty bits for removing PROT_WRITE on arm64.
07:52:27 - r317353
(9 hours 9 minutes ago)
by sephe
Affects:  /head/sys/dev/hyperv/netvsc/if_hn.c
hyperv/hn: Use channel0, i.e. TX ring0, for TCP SYN/SYN|ACK.

Hyper-V hot channel effect:
Operation latency on hot channel is only _half_ of the operation
latency on cold channels.

This commit takes the advantage of the above Hyper-V host channel
effect, and can reduce more than 75% latency and more than 50%
latency stdev, i.e. lower and more stable/predictable latency,
for various types of web server workloads.

MFC after: 3 days
Sponsored by: Microsoft
06:33:08 - r317352
(10 hours 28 minutes ago)
by mav
Affects: 
(3 files)
/stable/10/usr.sbin/ctld/ctld.c
/stable/10/usr.sbin/ctld/ctld.h
MFC r316677: Do not register in CTL portal groups without portals.

From config synthax point of view such portal groups are not incorrect,
but they are useless since can not receive any connection. And since
CTL port resource is very limited, it is good to save it.
06:32:35 - r317351
(10 hours 29 minutes ago)
by mav
Affects: 
(3 files)
/stable/11/usr.sbin/ctld/ctld.c
/stable/11/usr.sbin/ctld/ctld.h
MFC r316677: Do not register in CTL portal groups without portals.

From config synthax point of view such portal groups are not incorrect,
but they are useless since can not receive any connection. And since
CTL port resource is very limited, it is good to save it.
2017 - 04 - 23   (yesterday)
23:09:02 - r317350
(17 hours 52 minutes ago)
by rmacklem
Affects:  /head/usr.sbin/nfsuserd/nfsuserd.c
Fix the default uid/gid values in nfsuserd.c

This patch sets the default uid/gid values for "nobody" and "nogroup"
to the values in the password and group databases. Normally nfsuserd(8)
will override these with whatever is in the password/group databases,
so these values are only used when the databases entries aren't available.
It would be nice to use the definitions in sys/conf.h, but those are
in the _KERNEL section of the file.

Reported by: tez@pkgsrc.org
Submitted by: tez@pkgsrc.org
MFC after: 2 weeks
22:31:12 - r317349
(18 hours 30 minutes ago)
by pfg
Affects:  /head/lib/msun/src/e_asin.c
msun: Remove trailing space in Sunsoft copyright statement.

Submittedby: kargl
22:20:25 - r317348
(18 hours 41 minutes ago)
by trasz
Affects:  /head/sys/kern/vfs_bio.c
Make it possible to terminate "show lockedbufs" by pressing "q".

MFC after: 2 weeks
21:58:17 - r317347
(19 hours 3 minutes ago)
by jilles
Affects:  /head/bin/sh/tests/expansion/Makefile
/head/bin/sh/tests/expansion/cmdsubst24.0
sh: Add tests for NUL byte in command substitution output.
21:51:29 - r317346
(19 hours 10 minutes ago)
by pfg
Affects: 
(6 files)
/head/lib/libc/regex/*
regex: unsign and constify some variables.

Taking some hints from the regex variant in nvi(1) and higher-level
compiler warnings, update some types in our regex(3) implementation.

Joint work with: Kyle Evans
MFC after: 2 weeks
21:51:28 - r317345
(19 hours 10 minutes ago)
by rmacklem
Affects:  /head/sys/fs/nfs/nfsport.h
/head/sys/fs/nfsclient/nfs_clrpcops.c
/head/sys/fs/nfsclient/nfs_clstate.c
Make the NFSv4 client to use a write open for reading if allowed by the server.

An NFSv4 server has the option of allowing a Read to be done using a Write
Open. If this is not allowed, the server will return NFSERR_OPENMODE.
This patch attempts the read with a write open and then disables this
if the server replies NFSERR_OPENMODE.
This change will avoid some uses of the special stateids. This will be
useful for pNFS/DS Reads, since they cannot use special stateids.
It will also be useful for any NFSv4 server that does not support reading
via the special stateids. It has been tested against both types of NFSv4 server.

MFC after: 2 weeks
21:36:32 - r317344
(19 hours 25 minutes ago)
by rmacklem
Affects:  /head/sys/fs/nfsclient/nfs_clrpcops.c
Don't set the connection-back-channel flag for DS sessions.

The NFSv4.1/pNFS client does not use/need a backchannel for the Data Server (DS)
sessions, so the flag should only be set for MetaData Server (MDS) sessions.
This patch should have been a part of r317275.

MFC after: 2 weeks
21:17:59 - r317343
(19 hours 43 minutes ago)
by marius
Affects:  /head/sbin/ipfw/ipv6.c
In fill_ip6(), the value of the pointer av changes before it is
free(3)ed. Thus, introduce a new variable to track the original
value.

Submitted by: Tom Rix
Differential Revision: https://reviews.freebsd.org/D9962
20:32:46 - r317342
(20 hours 29 minutes ago)
by kib
Affects: 
(18 files)
/stable/11/include/*
/stable/11/lib/libc/*
/stable/11/sys/sys/*
MFC r316213:
Implement the memset_s(3) function as specified by the C11 ISO/IEC
9899:2011 Appendix K 3.7.4.1.

MFC r316258:
Only activate __EXT1_VISIBLE block when using sys/errno.h in userspace.
17:39:31 - r317341
(23 hours 22 minutes ago)
by trasz
Affects:  /head/sys/kern/vfs_bio.c
Improve BUF_TRACKING by not displaying NULL entries.

Reviewed by: cem
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D10443
14:25:51 - r317340
(1 day 2 hours ago)
by mav
Affects: 
(5 files)
/head/sys/dev/ntb/*
Report NTB link speed to console and interface.

MFC after: 2 weeks
10:29:09 - r317339
(1 day 6 hours ago)
by bcr
Affects: 
(2 files)
/stable/11/sbin/setkey/setkey.8
MFC r316657:

Make setkey(8) more clear about anti-replay window size option semantics.

PR: 172913
Submitted by: john@saltant.com
Reviewed by: ae@
Differential Revision: https://reviews.freebsd.org/D10304
09:01:40 - r317338
(1 day 8 hours ago)
by mav
Affects: 
(2 files)
/stable/11/sys/dev/usb/storage/cfumass.c
MFC r314290: Implement use of multiple transfers per I/O.

This change removes limitation of single S/G list entry and limitation on
maximal I/O size, using multiple data transfers per I/O if needed. Also
it removes code duplication between send and receive paths, which are now
completely equal.
09:01:01 - r317337
(1 day 8 hours ago)
by mav
Affects: 
(2 files)
/stable/11/sys/dev/usb/storage/cfumass.c
MFC r314256: Use ctl_queue_sense() to implement sense data reporting.

USB MS BBB transport does not support autosense, so we have to queue any
sense data back to CTL for later fetching via REQUEST SENSE.
09:00:26 - r317336
(1 day 8 hours ago)
by mav
Affects: 
(2 files)
/stable/11/sys/dev/usb/storage/cfumass.c
MFC r314254: Update kern_data_resid according to r312291.

This now mandatory for correct operation.
08:59:57 - r317335
(1 day 8 hours ago)
by kp
Affects: 
(3 files)
/stable/10/sys/netinet6/ip6_output.c
/stable/10/sys/netpfil/pf/pf_norm.c
MFC r317186

pf: Fix possible incorrect IPv6 fragmentation

When forwarding pf tracks the size of the largest fragment in a fragmented
packet, and refragments based on this size.
It failed to ensure that this size was a multiple of 8 (as is required for all
but the last fragment), so it could end up generating incorrect fragments.

For example, if we received an 8 byte and 12 byte fragment pf would emit a first
fragment with 12 bytes of payload and the final fragment would claim to be at
offset 8 (not 12).

We now assert that the fragment size is a multiple of 8 in ip6_fragment(), so
other users won't make the same mistake.

Reported by: Antonios Atlasis <aatlasis at secfu net>
08:59:35 - r317334
(1 day 8 hours ago)
by bde
Affects:  /head/sys/dev/syscons/scvgarndr.c
Change the drawing method for the mouse cursor in planar mode to support
colors.

Colors are still hard-coded as 15 (normally lightwhite) for the interior
and 0 (normally black) for the border, but these are now values used in
2 expressions instead of built in to the algorithm. The algorithm used
a fancy and/or method, but this gives no control over the colors except
and'ing all color planes off gives black and or'ing all color planes on
gives lightwhite. Just draw the border and interior in separate colors
using the same method as for characters, including its complications to
optimize for VGA adaptors. Optimization is not really needed here, but
for the VGA case it avoids being slower than the and/or method. The
optimization is worth about 30%.
08:58:50 - r317333
(1 day 8 hours ago)
by kp
Affects: 
(3 files)
/stable/11/sys/netinet6/ip6_output.c
/stable/11/sys/netpfil/pf/pf_norm.c
MFC r317186

pf: Fix possible incorrect IPv6 fragmentation

When forwarding pf tracks the size of the largest fragment in a fragmented
packet, and refragments based on this size.
It failed to ensure that this size was a multiple of 8 (as is required for all
but the last fragment), so it could end up generating incorrect fragments.

For example, if we received an 8 byte and 12 byte fragment pf would emit a first
fragment with 12 bytes of payload and the final fragment would claim to be at
offset 8 (not 12).

We now assert that the fragment size is a multiple of 8 in ip6_fragment(), so
other users won't make the same mistake.

Reported by: Antonios Atlasis <aatlasis at secfu net>
08:45:55 - r317332
(1 day 8 hours ago)
by trasz
Affects: 
(2 files)
/stable/11/share/man/man7/hier.7
MFC r316589:

Unify capitalization.
08:44:50 - r317331
(1 day 8 hours ago)
by trasz
Affects: 
(2 files)
/stable/11/share/man/man7/hier.7
MFC r316587:

Update hier(7) by removing files and directories that no longer
exist and doing a few random tweaks.
08:43:45 - r317330
(1 day 8 hours ago)
by trasz
Affects: 
(2 files)
/stable/11/share/man/man7/hier.7
MFC r316467:

Add basic description of kernel source layout.
08:41:58 - r317329
(1 day 8 hours ago)
by trasz
Affects: 
(2 files)
/stable/11/share/man/man7/hier.7
MFC r316466:

Remove excessive horizontal whitespace from hier(7) by correctly
using "-width". The http://mdocml.bsd.lv/mdoc/details/width.html
says: "Do not use macros in the argument specifying the width,
that's not portable. While GNU troff can handle it, mandoc cannot."
The same problem seems to exist in many other man pages.
08:40:34 - r317328
(1 day 8 hours ago)
by trasz
Affects: 
(2 files)
/stable/11/lib/libpmc/pmc.haswell.3
MFC r316468:

Fix typo.

Sponsored by: DARPA, AFRL
08:39:46 - r317327
(1 day 8 hours ago)
by trasz
Affects: 
(3 files)
/stable/11/share/man/man9/EVENTHANDLER.9
/stable/11/share/man/man9/Makefile
MFC r316057:

Document EVENTHANDLER_DEFINE(9).

Sponsored by: DARPA, AFRL
08:38:47 - r317326
(1 day 8 hours ago)
by trasz
Affects: 
(2 files)
/stable/11/share/man/man9/VOP_LOOKUP.9
MFC r316056:

The cn_consume was removed in r296716.

Sponsored by: DARPA, AFRL
08:36:29 - r317325
(1 day 8 hours ago)
by trasz
Affects: 
(2 files)
/stable/11/sbin/reboot/reboot.8
MFC r315560:

Document how to use reroot with NFS.

Sponsored by: DARPA, AFRL
07:57:30 - r317324
(1 day 9 hours ago)
by dchagin
Affects:  /head/sys/compat/linux/linux_time.c
Map Linux CLOCK_BOOTTIME to native CLOCK_UPTIME.

MFC after: 1 week
07:43:50 - r317323
(1 day 9 hours ago)
by dchagin
Affects:  /head/sys/compat/linux/linux_ioctl.c
/head/sys/compat/linux/linux_ioctl.h
Add Evdev ioctl handler to the Linuxulator.

PR: 218627
Submitted by: Jan Kokemüller
Reported by: Jan Kokemüller
MFC after: 1 week
07:37:14 - r317322
(1 day 9 hours ago)
by mav
Affects: 
(3 files)
/stable/10/sys/dev/isp/isp.c
/stable/10/sys/dev/isp/isp_freebsd.c
MFC r316652: Fix few minor issues found by Clang Analyzer.
07:36:44 - r317321
(1 day 9 hours ago)
by mav
Affects: 
(3 files)
/stable/11/sys/dev/isp/isp.c
/stable/11/sys/dev/isp/isp_freebsd.c
MFC r316652: Fix few minor issues found by Clang Analyzer.
07:35:51 - r317320
(1 day 9 hours ago)
by mav
Affects: 
(3 files)
/stable/10/sys/cam/ctl/ctl.c
/stable/10/sys/cam/ctl/ctl_frontend_iscsi.c
MFC r316653: Fix few minor issues found by Clang Analyzer.
07:35:10 - r317319
(1 day 9 hours ago)
by mav
Affects: 
(3 files)
/stable/11/sys/cam/ctl/ctl.c
/stable/11/sys/cam/ctl/ctl_frontend_iscsi.c
MFC r316653: Fix few minor issues found by Clang Analyzer.
06:45:21 - r317318
(1 day 10 hours ago)
by dchagin
Affects: 
(2 files)
/stable/11/sys/compat/linsysfs/linsysfs.c
MFC r315506:

Glibc get_nprocs() and get_nprocs_conf() uses the sysfs cpu infrastructure
to get number of processors. Implement /sys/devices/system/cpu/.
06:43:52 - r317317
(1 day 10 hours ago)
by dchagin
Affects: 
(6 files)
/stable/11/sys/amd64/*
/stable/11/sys/compat/linux/*
/stable/11/sys/i386/linux/linux_dummy.c
MFC r315505:

Implement getrandom() syscall.
Note. GRND_RANDOM option is not supported for now.
03:36:03 - r317316
(1 day 13 hours ago)
by ngie
Affects:  /head/lib/libgeom/geom_ctl.c
Minor style(9) fixups

Delete trailing whitespace and sort headers.

Leave libgeom.h's placement alone, per reasoning in r317289.

MFC after: 5 weeks
Sponsored by: Dell EMC Isilon
03:17:32 - r317315
(1 day 13 hours ago)
by ngie
Affects:  /head/lib/libc/gen/getpagesize.3
Note that getpagesize(3) can return -1 on failure

MFC after: 5 weeks
Sponsored by: Dell EMC Isilon
03:16:38 - r317314
(1 day 13 hours ago)
by cy
Affects: 
(6 files)
/stable/10/contrib/ipfilter/*
/stable/11/contrib/ipfilter/*
MFC r316993, r316994, r316997 as follows:

r316993:

Fix CID 1372601 in ipfilter/lib/parsefields.c, possible NULL pointer
dereference should reallocarray() fail.

  Reported by: Coverity CID 1372601

r316994:

Fix CID 1372600 in ipfilter/tools/ipf_y.y, possible NULL pointer
dereference should reallocarray() fail.

  Reported by: Coverity CID 1372600

r316997:

Use warnx() to issue error message.

  Reported by: cem
02:30:06 - r317313
(1 day 14 hours ago)
by ngie
Affects:  /head/tools/regression/geom_gpt/gctl_test.t
gctl_test.t: catch errors with the mdcfg directive

While here, add a note about certain testcases relying on `count=1024` in
the "create" portion.

MFC after: 5 weeks
Sponsored by: Dell EMC Isilon
01:50:47 - r317312
(1 day 15 hours ago)
by ngie
Affects:  /head/lib/libgeom/geom_stats.c
Fix type for `pagesize` to match the return type for getpagesize(3)
to fix the build

MFC after: 5 weeks
X-MFC with: r317311
Pointyhat to: ngie
Sponsored by: Dell EMC Isilon
01:47:52 - r317311
(1 day 15 hours ago)
by ngie
Affects:  /head/lib/libgeom/geom_stats.c
Check for failures from getpagesize(3)

Return errno on failure, similar to the open(2) call above it.

MFC after: 5 weeks
Reported by: Coverity
CID: 1193753
Sponsored by: Dell EMC Isilon
01:17:59 - r317310
(1 day 15 hours ago)
by ngie
Affects:  /head/lib/libgeom/geom_stats.c
Minor style(9) fixups

Delete trailing whitespace and sort headers.

Leave libgeom.h's placement alone, per reasoning in r317289.

MFC after: 5 weeks
Sponsored by: Dell EMC Isilon
2017 - 04 - 22   (2 days ago)
23:30:02 - r317309
(1 day 17 hours ago)
by ngie
Affects:  /head/tools/regression/geom_gpt/gctl_test.t
gctl_test.t: improve error reporting with mdcfg and mount directives

If the commands had failed previously, it would press on and result in a
series of cascading failures. Fail early and continue on to the next case
instead of executing additional commands after a previously failed series
of steps.

MFC after: 5 weeks
Sponsored by: Dell EMC Isilon
23:27:40 - r317308
(1 day 17 hours ago)
by ngie
Affects:  /head/tools/regression/geom_gpt/gctl_test.t
gctl_test.t: more tweaks to try and update the code and get it functional
(again?)

- Make the logfile for $out be built off the basename for $cmd, instead of $cmd.
  (r317292 broke this assumption).
- Rename $mntpt to $mntpt_prefix for clarity, as this variable is a prefix for
  mountpoints.
- Reindent the umount directive block while here to match the rest of the code.

MFC after: 5 weeks
Sponsored by: Dell EMC Isilon
23:06:53 - r317307
(1 day 17 hours ago)
by ngie
Affects:  /head/tools/regression/geom_gpt/gctl_test.t
Use verb=delete not verb=remove

The `remove` verb hasn't been present in geom_part*(4) for well
over a decade, if ever. I couldn't find any references to it in
^/stable/5 at least, which is around the timeframe that this test
was written.

MFC after: 5 weeks
Sponsored by: Dell EMC Isilon
22:40:39 - r317306
(1 day 18 hours ago)
by ngie
Affects:  /head/tools/regression/geom_gpt/gctl_test.t
gctl_test.t: minor tweaks

- Declare $count with the `my` scope operator to permit `use strict`.
- Add `use strict`.
- Use `use warnings` instead of using `-w` in the shebang.
- Don't unlink $cmd when done (prevents unnecessary rebuilding).
- Improve the error message when running with insufficient permissions, e.g.,
  non-root.

MFC after: 5 weeks
Sponsored by: Dell EMC Isilon
22:37:44 - r317305
(1 day 18 hours ago)
by rmacklem
Affects:  /head/sys/fs/nfsclient/nfs_clstate.c
Fix the NFSv4.1/pNFS client return layout on close.

The "return layout on close" case in the pNFS client was badly broken.
Fortunately, extant pNFS servers that I have tested against do not
do this. This patch fixes it. It also changes the way the layout stateid.seqid
is set for LayoutReturn. I think this change is correct w.r.t. the RFC,
but I am not 100% sure.
This was found during recent testing of the pNFS server under development.

MFC after: 2 weeks
22:34:45 - r317304
(1 day 18 hours ago)
by ngie
Affects:  /head/tools/regression/geom_gpt/gctl_test_helper.c
gctl_test_helper: add diagnostic output for parse_retval(..)

This will help end-users better diagnose issues with the function.

MFC after: 5 weeks
Sponsored by: Dell EMC Isilon
22:05:23 - r317303
(1 day 18 hours ago)
by rgrimes
Affects: 
(4 files)
/stable/10/share/examples/bhyve/vmrun.sh
/stable/11/share/examples/bhyve/vmrun.sh
MFC: r314694

  Make vmrun.sh passthrough -u and -w to bhybe

PR: 214273
Submitted by: Martin Birgmeier <la5lb...@aon.at>
Approved by: grehan (mentor)
21:57:26 - r317302
(1 day 19 hours ago)
by rgrimes
Affects: 
(2 files)
/stable/10/share/man/man7/hier.7
MFC: r314691

Document 3 more src/ directories

Approved by: grehan (mentor)
21:49:59 - r317301
(1 day 19 hours ago)
by rgrimes
Affects: 
(2 files)
/stable/11/share/man/man7/hier.7
MFC r314691:

Document 3 more src/ directories

Approved by: grehan (mentor)
21:40:31 - r317300
(1 day 19 hours ago)
by ngie
Affects:  /head/usr.bin/grep/tests/grep_freebsd_test.sh
Only expect :grep_r_implied to pass with bsdgrep(1)

The test fails with gnu grep from base and ports.

Sponsored by: Dell EMC Isilon
21:40:10 - r317299
(1 day 19 hours ago)
by ngie
Affects:  /head/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
Add more sanity tests for grep, egrep, and fgrep

The test suite currently lacks basic sanity checks to ensure that egrep,
fgrep, and grep are actually matching the right expression types, i.e. passing
the right flags to regcomp(3). Amend the test suite to make sure that not only
are the individual versions doing the right thing, but also that we don't have
some
kind of frankenregex situation happening where egrep is accepting a BRE or
grep an ERE.

I've chosen to not expand the 'basic' test but to add the 'grep_sanity' checks
to their own test case since this is testing for more than just 'grep matches
things',
but actual expression types.

Differential Revision: D10444
Reviewed by: emaste, ngie
Submitted by: Kyle Evans <kevans91@ksu.edu>
Tested with: bsdgrep, gnu grep (base, ports)
Sponsored by: Dell EMC Isilon
21:31:37 - r317298
(1 day 19 hours ago)
by jilles
Affects:  /head/bin/sh/options.c
/head/bin/sh/trap.c
/head/bin/sh/trap.h
sh: Simplify setinteractive().

setsignal() does nothing if the signal disposition is already set correctly.
21:26:15 - r317297
(1 day 19 hours ago)
by ngie
Affects:  /head/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
Remove the expected failures for :context and :context2 with bsdgrep(1)

They're no longer needed after recent fixes made to bsdgrep(1).

Submitted by: Kyle Evans <kevans91@ksu.edu> (via a previous diff in D10433)
Sponsored by: Dell EMC Isilon
20:55:39 - r317296
(1 day 20 hours ago)
by rmacklem
Affects:  /head/sys/fs/nfsclient/nfs_clrpcops.c
/head/sys/fs/nfsclient/nfs_clvfsops.c
Fix some krpc leaks for the NFSv4.1/pNFS client.

The NFSv4.1/pNFS client wasn't doing a newnfs_disconnect() call for the
connection to the Data Server (DS) under some circumstances. The main
effect of this was a leak of malloc'd structures in the krpc. This patch
adds the newnfs_disconnect() calls to fix this.
Detected during recent testing against the pNFS server under development.

MFC after: 2 weeks
20:51:54 - r317295
(1 day 20 hours ago)
by ngie
Affects:  /head/tools/regression/geom_gpt/gctl_test_helper.c
The GPT class no longer exists; use the PART class instead

MFC after: 5 weeks
Sponsored by: Dell EMC Isilon
20:29:56 - r317294
(1 day 20 hours ago)
by ngie
Affects:  /head/tools/regression/geom_gpt/Makefile
Bump WARNS to 6 per previous commits which fixed warnings

MFC after: 5 weeks
Tested with: clang (4.0), gcc (4.2.1, 6.3.0)
Sponsored by: Dell EMC Isilon
20:27:46 - r317293
(1 day 20 hours ago)
by ngie
Affects:  /head/tools/regression/geom_gpt/gctl_test_helper.c
gctl_test_helper: apply polish

- Staticize variables to fix warnings.
- Sprinkle asserts around for calls that can fail
- Apply style(9) for main(..) definition.
- ANSIify usage(..) definition.

MFC after: 5 weeks
Sponsored by: Dell EMC Isilon
20:15:47 - r317292
(1 day 20 hours ago)
by ngie
Affects:  /head/tools/regression/geom_gpt/Makefile
/head/tools/regression/geom_gpt/gctl_test.t
gctl_test.t: use make to compile gctl_test_helper instead of calling cc directly

MFC after: 5 weeks
Sponsored by: Dell EMC Isilon
20:06:11 - r317291
(1 day 20 hours ago)
by ngie
Affects: 
(4 files)
/head/tools/regression/geom_gpt/*
Rename gctl.t to gctl_test.t and test.c to gctl_test_helper.c

This is being done to reduce ambiguity and to make the tests more portable
in the future to other locations in the source tree.

MFC after: 5 weeks
Sponsored by: Dell EMC Isilon
20:00:52 - r317290
(1 day 21 hours ago)
by ngie
Affects:  /head/tools/regression/geom_gpt/test.c
Fix -Wimplicit-function-declaration compilation warning by moving libgeom.h
#include below the stdio.h #include.

gctl_dump(3) needs stdio.h, per reasoning noted in r317289.

MFC after: 5 weeks
PR: 218809
Submitted by: Chang-Hsien Tsai <luke.tw@gmail.com>
Sponsored by: Dell EMC Isilon
19:32:23 - r317289
(1 day 21 hours ago)
by ngie
Affects:  /head/lib/libgeom/libgeom.3
libgeom(3): note that stdio.h is required when referencing gctl_dump(3)

gctl_dump(3) is only exposed when stdio.h is #include'd first, per its
addition in r112510. The reasoning noted for the conditional "exposure"
of the function was to "limit #include pollution".

This addresses an issue I found with the documentation when looking at
bug 218809, which in turn addresses a -Wimplicit-function-declaration
compiler warning in `tools/regression/geom_gpt/test.c` (it uses
gctl_dump(3)).

MFC after: 5 weeks
Sponsored by: Dell EMC Isilon
19:11:37 - r317288
(1 day 21 hours ago)
by ngie
Affects:  /head/lib/libgeom/libgeom.3
libgeom(3): apply minor polish

- Use .Dv when mentioning NULL per mdoc(7).
- Reword `g_device_path`, `g_open_by_ident`, and `g_providername`'s descriptions
  so they're less wordy.
- Fix a typo in `g_device_path` (can not -> cannot).

MFC after: 5 weeks
Tested with: igor, make manlint
Sponsored by: Dell EMC Isilon
18:59:50 - r317287
(1 day 22 hours ago)
by dim
Affects: 
(92 files)
/projects/clang500-import/contrib/libc++/*
/projects/clang500-import/lib/libc++/Makefile
Merge libc++ trunk r300890, and update build glue.
18:55:25 - r317286
(1 day 22 hours ago)
by karels
Affects: 
(2 files)
/stable/11/sys/netinet/tcp_output.c
MFC r316065: Enable route and LLE (ndp) caching in TCP/IPv6

tcp_output.c was using a route on the stack for IPv6, which does not
allow route caching or LLE/ndp caching. Switch to using the route
(v6 flavor) in the in_pcb, which was already present, which caches
both L3 and L2 lookups.

Reviewed by: gnn hiren
18:43:15 - r317285
(1 day 22 hours ago)
by dim
Affects: 
(220 files)
/projects/clang500-import/contrib/compiler-rt/*
/projects/clang500-import/lib/libclang_rt/include/Makefile
/projects/clang500-import/lib/libcompiler_rt/Makefile.inc
Merge compiler-rt trunk r300890, and update build glue.
16:02:40 - r317284
(2 days ago)
by pfg
Affects:  /head/usr.sbin/pmcstat/pmcpl_calltree.c
/head/usr.sbin/pmcstat/pmcstat_log.c
pmcstat(8); unsign some allocation variables and use reallocarray(3).

Use unsigned values in some internal variables that will be used during
allocation. The variables are used in reduced scope and have no chance of
becoming negative.

Provide bounds checking through reallocarray(3).

MFC after: 2 weeks
14:50:11 - r317283
(2 days 2 hours ago)
by pfg
Affects: 
(4 files)
/head/sbin/fsck_ffs/*
fsck_ffs: Unsign some variables and make use of reallocarray(3).

Instead of casting listmax and numdirs to unsigned values just define
them as unsigned and avoid the casts. Use reallocarray(3).

While here, fs_ncg is already unsigned so the cast is unnecessary.

Reviewed by: mckusick
MFC after: 2 weeks
13:04:36 - r317282
(2 days 3 hours ago)
by kp
Affects:  /head/sys/netinet6/ip6_output.c
Rename variable for clarity

Rename the mtu variable in ip6_fragment(), because mtu is misleading. The
variable actually holds the fragment length.
No functional change.

Suggested by: ae
11:30:07 - r317281
(2 days 5 hours ago)
by dim
Affects: 
(75 files)
/projects/clang500-import/*
Merge ^/head r317216 through r317280.
09:38:43 - r317280
(2 days 7 hours ago)
by trasz
Affects:  /head/usr.bin/tip/tip/cu.1
Add basic example to the cu(1) man page. Srsly, folks, you don't
need to install minicom for this...

MFC after: 2 weeks
08:38:49 - r317279
(2 days 8 hours ago)
by mav
Affects:  /head/sys/net/if_lagg.c
Remove unneeded conditions.

MFC after: 2 weeks
02:12:08 - r317278
(2 days 14 hours ago)
by adrian
Affects:  /head/sys/net80211/ieee80211_proto.c
/head/sys/net80211/ieee80211_proto.h
[net80211] add methods to fetch the global and per-VAP WME parameters.

For now there isn't any per-VAP WME state. The eventual aim is to migrate
the driver direct use of WME parameters over to use these methods as
appropriate (global for most devices, per-VAP for firmware NICs that support
it) in preparation for actual per-VAP WME (and other thing) state change
support.
01:06:23 - r317277
(2 days 15 hours ago)
by des
Affects:  /head/sys/crypto/chacha20/chacha20.c
Fix counter increment in Salsa and ChaCha.

In my eagerness to eliminate a branch which is taken once per 2^38
bytes of keystream, I forgot that the state words are in host order.
Thus, the counter increment code worked fine on little-endian
machines, but not on big-endian ones. Switch to a simpler (branchful)
solution.
2017 - 04 - 21   (3 days ago)
23:01:32 - r317276
(2 days 18 hours ago)
by rmacklem
Affects:  /head/sys/fs/nfs/nfs_commonkrpc.c
Don't set ND_NOMOREDATA for a failed Setattr operation (NFSv4).

The NFSv4 Setattr operation always has reply data even when it fails,
so don't set the ND_NOMOREDATA for it. This would only affect unusual
cases where Setattr fails and the RPC code wants to parse the rest of
the compound. Detected during recent development related to the pNFS server.

MFC after: 2 weeks
22:38:26 - r317275
(2 days 18 hours ago)
by rmacklem
Affects:  /head/sys/fs/nfs/nfs_commonkrpc.c
Don't create a backchannel for a DS connection.

An NFSv4.1 client connection to a Data Server (DS) should not have a
backchannel. This patch fixes the NFSv4.1/pNFS client to not do a backchannel
for this case.
Found during recent testing with the pNFS server under development.

MFC after: 2 weeks
22:19:13 - r317274
(2 days 18 hours ago)
by sjg
Affects:  /head/contrib/bmake/str.c
/head/contrib/bmake/unit-tests/modmatch.exp
/head/contrib/bmake/unit-tests/modmatch.mk
Str_Match: fix closure tests for [^] and add unit-test.
22:00:22 - r317273
(2 days 19 hours ago)
by cem
Affects:  /head/sys/fs/fuse/fuse_node.c
fuse: Implement FOPEN_KEEP_CACHE flag

Implement FUSE open flag FOPEN_KEEP_CACHE. Without this flag, cached file
contents should be invalidated on open. Apparently, fusefs-encfs relies
upon this behavior.

PR: 218636
Submitted by: Ben RUBSON <ben.rubson at gmail.com>
21:43:00 - r317272
(2 days 19 hours ago)
by rmacklem
Affects:  /head/sys/fs/nfsclient/nfs_clcomsubs.c
Add checks for failed operations to the NFSv4 client function nfscl_mtofh().

The nfscl_mtofh() function didn't check for failed operations and, as such,
would have returned EBADRPC for these cases, due to parsing failure.
This patch adds checks, so that it returns with ND_NOMOREDATA set.
This is needed for future use in the pNFS server and acts as a safety
belt in the meantime.

MFC after: 2 weeks
21:06:11 - r317271
(2 days 19 hours ago)
by dim
Affects:  /projects/clang500-import/lib/clang/libclang/Makefile
/projects/clang500-import/lib/clang/liblldb/Makefile
/projects/clang500-import/usr.bin/clang/lld/Makefile
Strip out a few objects from libclang, liblldb and lldb, which are not
referenced due to the selection of tools that we build, and our compile
time options.
20:53:51 - r317270
(2 days 20 hours ago)
by rmacklem
Affects:  /head/usr.sbin/nfsuserd/nfsuserd.8
Get rid of bogus statement in the nfsuserd.8 man page.

The nfsuserd.8 man page stated that a usertimeout of 0 would disable
the cache timeout. This was simply not true, so this patch deletes
the sentence.

This is a content change.

PR: 217406
MFC after: 2 weeks
20:08:10 - r317269
(2 days 20 hours ago)
by rmacklem
Affects:  /head/sys/fs/nfs/nfs_commonsubs.c
/head/sys/sys/conf.h
Set default uid/gid to nobody/nogroup for NFSv4 mapping.

The default uid/gid for NFSv4 are set by the nfsuserd(8) daemon.
However, they were 0 until the nfsuserd(8) was run. Since it is
possible to use NFSv4 without running the nfsuserd(8) daemon, set them
to nobody/nogroup initially.
Without this patch, the values would be set by the nfsuserd(8) daemon
and left changed even if the nfsuserd(8) daemon was killed. The default
values of 0 meant that setting a group to "wheel" would fail even when
done by root.
It also adds a definition of GID_NOGROUP to sys/conf.h.

Discussed on: freebsd-current@
MFC after: 2 weeks
20:03:08 - r317268
(2 days 20 hours ago)
by pfg
Affects: 
(2 files)
/stable/11/usr.bin/mkimg/vmdk.c
MFC r302664:
mkimg(1): minor cleanups with argument order in calloc(3).

Generally the first argument in calloc is supposed to stand for a count
and the second for a size. Try to make that consistent. While here,
attempt to make some use of the overflow detection capability in
calloc(3).

Requested by: manu
19:53:52 - r317267
(2 days 21 hours ago)
by jpaetzel
Affects: 
(11 files)
/head/cddl/contrib/opensolaris/cmd/zfs/*
/head/cddl/contrib/opensolaris/lib/libzfs/common/*
/head/sys/cddl/contrib/opensolaris/common/zfs/*
MFV 316891

7386 zfs get does not work properly with bookmarks

illumos/illumos-gate@edb901aab9c738b5eb15aa55933e82b0f2f9d9a2
https://github.com/illumos/illumos-gate/commit/edb901aab9c738b5eb15aa55933e82b0f2f9d9a2

https://www.illumos.org/issues/7386
  The zfs get command does not work with the bookmark parameter while it works
  properly with both filesystem and snapshot:
  # zfs get -t all -r creation rpool/test
  NAME PROPERTY VALUE SOURCE
  rpool/test creation Fri Sep 16 15:00 2016 -
  rpool/test@snap creation Fri Sep 16 15:00 2016 -
  rpool/test#bkmark creation Fri Sep 16 15:00 2016 -
  # zfs get -t all -r creation rpool/test@snap
  NAME PROPERTY VALUE SOURCE
  rpool/test@snap creation Fri Sep 16 15:00 2016 -
  # zfs get -t all -r creation rpool/test#bkmark
  cannot open 'rpool/test#bkmark': invalid dataset name
  #
  The zfs get command should be modified to work properly with bookmarks too.

Reviewed by: Simon Klinkert <simon.klinkert@gmail.com>
Reviewed by: Paul Dagnelie <pcd@delphix.com>
Approved by: Matthew Ahrens <mahrens@delphix.com>
Author: Marcel Telka <marcel@telka.sk>
19:41:33 - r317266
(2 days 21 hours ago)
by gjb
Affects: 
(4 files)
/stable/10/release/doc/share/xml/*
/stable/11/release/doc/share/xml/*
Document EN-17:01 through EN-17:05, SA-16:39 through SA-17:03

Sponsored by: The FreeBSD Foundation
19:27:33 - r317265
(2 days 21 hours ago)
by pfg
Affects: 
(5 files)
/head/lib/libgssapi/gss_buffer_set.c
/head/lib/libiconv_modules/ISO2022/citrus_iso2022.c
/head/lib/libutil/*
lib: initial use of reallocarray(3).

Make some use of reallocarray, attempting to limit it to cases where the
parameters are unsigned and there is some theoretical chance of overflow.

MFC afer: 2 weeks
Differential Revision: https://reviews.freebsd.org/D9980
17:57:23 - r317264
(2 days 23 hours ago)
by bde
Affects:  /head/sys/dev/syscons/scvgarndr.c
Optimize setting of the foreground color in the main planar method much
like for the background color.

This is a about 5% faster for output that actually reaches the screen.
17:42:48 - r317263
(2 days 23 hours ago)
by gjb
Affects:  /user/gjb/thermite/10-armv6-CUBOX-HUMMINGBOARD-snap.conf
/user/gjb/thermite/10-armv6-WANDBOARD-snap.conf
Chase r316765, and add conv=sync to dd(1) for stable/10 IMX6 boards.

Sponsored by: The FreeBSD Foundation
17:09:37 - r317262
(2 days 23 hours ago)
by ae
Affects: 
(2 files)
/stable/11/sys/netpfil/ipfw/ip_fw_dynamic.c
MFC r316824:
  The rule field in the ipfw_dyn_rule structure is used as storage
  to pass rule number and rule set to userland. In r272840 the kernel
  internal rule representation was changed and the rulenum field of
  struct ip_fw_rule got the type uint32_t, but userlevel representation
  still have the type uint16_t. To not overflow the size of pointer
  on the systems with 32-bit pointer size use separate variable to
  copy rulenum and set.

  Reported by: PVS-Studio
17:03:48 - r317261
(2 days 23 hours ago)
by dim
Affects: 
(3 files)
/stable/11/contrib/llvm/lib/Target/X86/X86ISelLowering.cpp
/stable/11/contrib/llvm/lib/Target/X86/X86RegisterInfo.td
MFC r316989:

Pull in r300404 from upstream llvm trunk (by me):

  Use correct registers for "A" inline asm constraint

  Summary:
  In PR32594, inline assembly using the 'A' constraint on x86_64 causes
  llvm to crash with a "Cannot select" stack trace. This is because
  `X86TargetLowering::getRegForInlineAsmConstraint` hardcodes that 'A'
  means the EAX and EDX registers.

  However, on x86_64 it means the RAX and RDX registers, and on 16-bit
  x86 (ia16?) it means the old AX and DX registers.

  Add new register classes in `X86RegisterInfo.td` to support these
  cases, and amend the logic in `getRegForInlineAsmConstraint` to cope
  with different subtargets. Also add a test case, derived from
  PR32594.

  Reviewers: craig.topper, qcolombet, RKSimon, ab

  Reviewed By: ab

  Subscribers: ab, emaste, royger, llvm-commits

  Differential Revision: https://reviews.llvm.org/D31902

This should fix crashes when using the 'A' constraint on amd64, for
example as it is being used in Xen.

Reported by: royger

MFC r317079:

Pull in r300429 from upstream llvm trunk (by Benjamin Kramer):

  [X86] Remove special handling for 16 bit for A asm constraints.

  Our 16 bit support is assembler-only + the terrible hack that is
  .code16gcc. Simply using 32 bit registers does the right thing for
  the latter.

  Fixes PR32681.

This fixes some cases of assembling 16 bit code (i.e. SeaBIOS) that uses
the 'A' inline asm constraint, after r316989.
16:47:57 - r317260
(3 days ago)
by gjb
Affects: 
(2 files)
/stable/11/Makefile.inc1
MFC r317100:
 Use relative symlink for 'latest' to allow repo to work after being
 moved.

PR: 217197
Sponsored by: The FreeBSD Foundation
16:47:09 - r317259
(3 days ago)
by gjb
Affects: 
(4 files)
/stable/11/Makefile.inc1
/stable/11/release/scripts/make-pkg-package.sh
/stable/11/share/mk/bsd.own.mk
MFC r310181 (matthew) (originally r309314):
 Allow a user-overridable setting 'PKG_CMD' to control the command used
 to create a repo during 'make packages'.

Sponsored by: The FreeBSD Foundation
16:45:43 - r317258
(3 days ago)
by ae
Affects: 
(2 files)
/stable/11/sys/kern/uipc_sockbuf.c
MFC r316770:
  Clear h/w csum flags on mbuf handled by UDP.

  When checksums of received IP and UDP header already checked, UDP uses
  sbappendaddr_locked() to pass received data to the socket.
  sbappendaddr_locked() uses given mbuf as is, and if NIC supports checksum
  offloading, mbuf contains csum_data and csum_flags that were calculated
  for already stripped headers. Some NICs support only limited checksums
  offloading and do not use CSUM_PSEUDO_HDR flag, and csum_data contains
  some value that UDP/TCP should use for pseudo header checksum calculation.

  When L2TP is used for tunneling with mpd5, ng_ksocket receives mbuf with
  filled csum_flags and csum_data, that were calculated for outer headers.
  When L2TP header is stripped, a packet that was tunneled goes to the IP
  layer and due to presence of csum_flags (without CSUM_PSEUDO_HDR) and
  csum_data, the UDP/TCP checksum check fails for this packet.

  Reported by: Irina Liakh <spell at itl ua>
  Tested by: Irina Liakh <spell at itl ua>

MFC r316822,316823:
  Rework r316770 to make it protocol independent and general, like we
  do for streaming sockets.

  And do more cleanup in the sbappendaddr_locked_internal() to prevent
  leak information from existing mbuf to the one, that will be possible
  created later by netgraph.

  Suggested by: glebius
  Tested by: Irina Liakh <spell at itl ua>
15:59:58 - r317257
(3 days 1 hour ago)
by dim
Affects:  /projects/clang500-import/lib/clang/libclang/Makefile
/projects/clang500-import/lib/clang/libllvmminimal/Makefile
/projects/clang500-import/usr.bin/clang/llvm-xray/Makefile
Update some more build glue. All llvm extras, lld and lldb should link now.
15:12:43 - r317256
(3 days 1 hour ago)
by bde
Affects:  /head/sys/dev/syscons/scvgarndr.c
Merge the main ega drawing method into the main vga planar method and
remove the former.

All other EGA/VGA methods were already shared, with VGA-only features
mostly not used and no decisions in inner loops to optimize fof VGA,
but this method was split up because it is the only important one and
using VGA methods if possible is about twice as fast. The speed is
mostly not from splitting to reduce branches but from doing half as
many bus accesses, so make this easier to maintain by not splitting.
There is now 1 extra branch in an inner loop where it costs less than
1% of the bus access overhead on Haswell even if the compiler schedules
it poorly.
14:50:29 - r317255
(3 days 2 hours ago)
by emaste
Affects:  /head/share/man/man5/src.conf.5
/head/share/mk/src.opts.mk
/head/tools/build/options/WITH_GNU_GREP_COMPAT
bsdgrep: disable GNU_GREP_COMPAT by default

The GNU extension bits in the base system are old, no longer faithful
to upstream, and surprising in some regards. Switch to documenting
WITH_GNU_GREP_COMPAT and default GNU_GREP_COMPAT to OFF in the name of
good behavior.

According to http://www.regular-expressions.info, GNU extensions:

- Add missing quantifiers to BREs: \?, \+

- Add branching to BREs: \|

- Add backreferences (\1 through \9) to EREs

- Add \w, \W, \s, and \S corresponding to :alnum:, [^[:alnum:]],
  :space:, and [^[:space:]] respectively

- Add word boundaries and anchors:
  \b: word boundary
  \B: not word boundary
  \<: Strt of word
  \>: End of word
  \`: Start of subject string
  \': End of subject string

These extensions are still available in /usr/bin/grep by default today,
as it is still GNU grep. As part of the bsdgrep migration plan these
extensions may be added to bsdgrep's regex support if necessary.

Submitted by: Kyle Evans <kevans91 at ksu.edu>
Reviewed by: cem
Differential Revision: https://reviews.freebsd.org/D10114
14:36:09 - r317254
(3 days 2 hours ago)
by emaste
Affects: 
(7 files)
/head/share/*
/head/tools/build/options/WITHOUT_BSD_GREP_FASTMATCH
/head/usr.bin/grep/*
bsdgrep: add BSD_GREP_FASTMATCH knob for built-in fastmatch

Bugs have been found in the fastmatch implementation as used in bsdgrep.
Some have been fixed (r316495) while fixes for others are in review
(D10098).

In comparison with the fastmatch implementation, Kyle Evans found that:

- regex(3)'s performance with literal expressions offers a speed
  improvement over fastmatch

- regex(3)'s performance, both with simple BREs and EREs, seems to be
  comparable

The regex implementation was imported in r226035, and the commit message
reports:

  This is a temporary solution until the whole regex library is
  not replaced so that BSD grep development can continue and the
  backported code gets some review and testing. This change only
  improves scalability slightly, there is no big performance boost
  yet but several minor bugs have been found and fixed.

Introduce a WITH_/WITHOUT_BSD_GREP_FASTMATCH knob to support testing
of both approaches.

PR: 175314, 194823
Submitted by: Kyle Evans <kevans91 at ksu.edu>
Reviewed by: bdrewery (in part)
Differential Revision: https://reviews.freebsd.org/D10282
13:45:01 - r317253
(3 days 3 hours ago)
by mav
Affects:  /head/sys/net/if_lagg.c
Add interface reference counting to if_lagg.

Using plain ifunit() looks like request for troubles.

MFC after: 2 weeks
13:39:14 - r317252
(3 days 3 hours ago)
by emaste
Affects:  /head/gnu/usr.bin/Makefile
Simplify gnu/usr.bin Makefile conditions

After r307655 MK_GDB is forced to no if MK_BINUTILS is no, and similarly
MK_GROFF is forced to no if MK_CXX is no, so we can remove nested
conditionals.

Reviewed by: bapt, brooks
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D8287
11:48:12 - r317251
(3 days 5 hours ago)
by rmacklem
Affects:  /head/sys/fs/nfs/nfs_commonsubs.c
Revert r317240. I didn't realize there were defined constants for
uid/gid values in sys/conf.h. I will do another commit using those.
10:16:34 - r317250
(3 days 6 hours ago)
by kib
Affects: 
(2 files)
/stable/10/sbin/fsck_ffs/pass1.c
MFC r316852:
In fsck_ffs pass1, prevent the inosused variable from wrapping.

PR: 218592
10:13:07 - r317249
(3 days 6 hours ago)
by kib
Affects: 
(2 files)
/stable/11/sbin/fsck_ffs/pass1.c
MFC r316852:
In fsck_ffs pass1, prevent the inosused variable from wrapping.

PR: 218592
10:11:08 - r317248
(3 days 6 hours ago)
by kib
Affects: 
(2 files)
/stable/11/sys/x86/iommu/intel_gas.c
MFC r316851:
Correct calculation of the entry->free_down in the invariants-checking
code.
07:43:44 - r317247
(3 days 9 hours ago)
by mav
Affects:  /head/sys/geom/eli/g_eli.h
Dump md_iterations as signed, which it really is.

PR: 208305
PR: 196834
MFC after: 2 weeks
07:16:07 - r317246
(3 days 9 hours ago)
by mav
Affects:  /head/sbin/geom/class/eli/geom_eli.c
/head/sys/geom/eli/g_eli_ctl.c
Always allow setting number of iterations for the first time.

Before this change it was impossible to set number of PKCS#5v2 iterations,
required to set passphrase, if it has two keys and never had any passphrase.
Due to present metadata format limitations there are still cases when number
of iterations can not be changed, but now it works in cases when it can.

PR: 218512
MFC after: 2 weeks
Sponsored by: iXsystems, Inc.
Differential Revision: https://reviews.freebsd.org/D10338
06:55:17 - r317245
(3 days 10 hours ago)
by bde
Affects:  /head/sys/dev/syscons/scvgarndr.c
Oops, the previous commit swapped the main ega method with the main
vga planar method (for testing that was supposed to be local that the
former still works). The ega method works on vga but is about twice
as slow. The vga method doesn't work on ega.

Optimize the main vga planar method a little. For changing the
background color (which was otherwise optimized better than most
things), don't switch the write mode from 3 to 0 just to select
the pixel mask of 0xff obscurely by writing 0. Just write 0xff
directly.
06:05:34 - r317244
(3 days 10 hours ago)
by tuexen
Affects:  /head/sys/netinet/tcp_syncache.c
Represent "a syncache overflow hasn't happend yet" by using
-(SYNCOOKIE_LIFETIME + 1) instead of INT64_MIN, since it is
good enough and works when time_t is int32 or int64.
This fixes the issue reported by cy@ on i386.

Reported by: cy
MFC after: 1 week
Sponsored by: Netflix, Inc.
02:11:44 - r317243
(3 days 14 hours ago)
by cy
Affects: 
(2 files)
/stable/10/sys/contrib/ipfilter/netinet/radix_ipf.c
MFC r317139 for real.

Restore prototype accidently removed by r316811. Also remove $NetBSD$
accidentally added.

Reported by: hps, lwhsu
Pointy hat to: cy
02:02:52 - r317242
(3 days 14 hours ago)
by cy
Affects: 
(4 files)
/stable/10/sys/contrib/ipfilter/netinet/radix_ipf.c
/stable/11/sys/contrib/ipfilter/netinet/radix_ipf.c
MFC r316811, r317139:

Add missing free()'s after calls to randomize().

PR: NetBSD PR/50559
Obtained from: Netbsd radix_ipf.c r1.6
01:51:49 - r317241
(3 days 15 hours ago)
by cy
Affects: 
(4 files)
/stable/10/sys/contrib/ipfilter/netinet/ip_frag.c
/stable/11/sys/contrib/ipfilter/netinet/ip_frag.c
MFC r316809:

Fix a use after free panic in ipfilter's fragment processing.
Memory is malloc'd, then a search for a match in the fragment table
is made and if the fragment matches, the wrong fragment table is
freed, causing a use after free panic. This commit fixes this.

A symptom of the problem is a kernel page fault in bcopy() called by
ipf_frag_lookup() at line 715 in ip_frag.c. Another symptom is a
kernel page fault in ipf_frag_delete() when called by ipf_frag_expire()
via ipf_slowtimer().
01:50:41 - r317240
(3 days 15 hours ago)
by rmacklem
Affects:  /head/sys/fs/nfs/nfs_commonsubs.c
Set default uid/gid to nobody/nogroup for NFSv4 mapping.

The default uid/gid for NFSv4 are set by the nfsuserd(8) daemon.
However, they were 0 until the nfsuserd(8) was run. Since it is
possible to use NFSv4 without running the nfsuserd(8) daemon, set them
to nobody/nogroup initially.
Without this patch, the values would be set by the nfsuserd(8) daemon
and left changed even if the nfsuserd(8) daemon was killed. Also, the default
values of 0 meant that setting a group to "wheel" would fail even when
done by root and this patch fixes this issue.

MFC after: 2 weeks
00:45:44 - r317239
(3 days 16 hours ago)
by sjg
Affects: 
(18 files)
/head/contrib/bmake/*
/head/usr.bin/bmake/Makefile
Merge bmake-20170420
00:24:59 - r317238
(3 days 16 hours ago)
by jpaetzel
Affects: 
(2 files)
/head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zio_checksum.c
MFV 316871

7490 real checksum errors are silenced when zinject is on

illumos/illumos-gate@6cedfc397d92d64e442f0aae4445ac507beaf58f
https://github.com/illumos/illumos-gate/commit/6cedfc397d92d64e442f0aae4445ac507beaf58f

https://www.illumos.org/issues/7490
  When zinject is on, error codes from zfs_checksum_error() can be overwritten
  due to an incorrect and overly-complex if condition.

Reviewed by: George Wilson <george.wilson@delphix.com>
Reviewed by: Paul Dagnelie <pcd@delphix.com>
Reviewed by: Dan Kimmel <dan.kimmel@delphix.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Approved by: Robert Mustacchi <rm@joyent.com>
Author: Pavel Zakharov <pavel.zakharov@delphix.com>
00:17:54 - r317237
(3 days 16 hours ago)
by jpaetzel
Affects: 
(3 files)
/head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_disk.c
/head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zio.c
MFV 316870

7448 ZFS doesn't notice when disk vdevs have no write cache

illumos/illumos-gate@295438ba3230419314faaa889a2616f561658bd5
https://github.com/illumos/illumos-gate/commit/295438ba3230419314faaa889a2616f561658bd5

https://www.illumos.org/issues/7448
  I built a SmartOS image with all the NVMe commits including 7372
  (support NVMe volatile write cache) and repeated my dd testing:
  > #!/bin/bash
  > for i in `seq 1 1000`; do
  > dd if=/dev/zero of=file00 bs=1M count=102400 oflag=sync &
  > dd if=/dev/zero of=file01 bs=1M count=102400 oflag=sync &
  > wait
  > rm file00 file01
  > done
  >
  Previously each dd command took ~145 seconds to finish, now it takes
  ~400 seconds.
  Eventually I figured out it is 7372 that causes unnecessary
  nvme_bd_sync() executions which wasted CPU cycles.
  If a NVMe device doesn't support a write cache, the nvme_bd_sync function will
  return ENOTSUP to indicate this to upper layers.
  It seems this returned value is ignored by ZFS, and as such this bug is not
  really specific to NVMe. In vdev_disk_io_start() ZFS sends the flush to the
  disk driver (blkdev) with a callback to vdev_disk_ioctl_done(). As nvme filled
  in the bd_sync_cache function pointer, blkdev will not return ENOTSUP, as the
  nvme driver in general does support cache flush. Instead it will issue an
  asynchronous flush to nvme and immediately return 0, and hence ZFS will not
set
  vdev_nowritecache here. The nvme driver will at some point process the cache
  flush command, and if there is no write cache on the device it will return
  ENOTSUP, which will be delivered to the vdev_disk_ioctl_done() callback. This
  function will not check the error code and not set nowritecache.
  The right place to check the error code from the cache flush is in
  zio_vdev_io_assess(). This would catch both cases, synchronous and
asynchronous
  cache flushes. This would also be independent of the implementation detail
that
  some drivers can return ENOTSUP immediately.

Reviewed by: Dan Fields <dan.fields@nexenta.com>
Reviewed by: Alek Pinchuk <alek.pinchuk@nexenta.com>
Reviewed by: George Wilson <george.wilson@delphix.com>
Approved by: Dan McDonald <danmcd@omniti.com>
Author: Hans Rosenfeld <hans.rosenfeld@nexenta.com>
Obtained from: Illumos
00:17:47 - r317236
(3 days 16 hours ago)
by rmacklem
Affects:  /head/sys/fs/nfsserver/nfs_nfsdport.c
Fix the setting of atime for Linux client NFSv4 mounts.

The FreeBSD NFSv4 server did not set the attribute bit for TimeAccess in
the reply to an Open with exclusive_create, as required by the RFCs.
(This is required since the FreeBSD NFS server stores the create_verifier
 in the va_atime attribute.)
As such, the Linux NFSv4 client did not set the TimeAccess (atime) in
the Setattr done in an RPC after the one with the Open/exclusive_create.
This patch fixes the server to set the TimeAccess bit in the reply.

I believe that storing the create_verifier in an extended attribute for
file systems that support extended attributes might be a good idea,
but I will wait for a discussion of this on the freebsd-fs@ email list
before considering committing a patch to do this.

Reported by: jim@ks.uiuc.edu
Suggested by: dfr
MFC after: 2 weeks
00:12:47 - r317235
(3 days 16 hours ago)
by jpaetzel
Affects: 
(5 files)
/head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/*
MFV 316868

7430 Backfill metadnode more intelligently

illumos/illumos-gate@af346df58864e8fe897b1ff1a3a4c12f9294391b
https://github.com/illumos/illumos-gate/commit/af346df58864e8fe897b1ff1a3a4c12f9294391b

https://www.illumos.org/issues/7430
  Description and patch from brought over from the following ZoL commit:
https://
  github.com/zfsonlinux/zfs/commit/68cbd56e182ab949f58d004778d463aeb3f595c6
  Only attempt to backfill lower metadnode object numbers if at least
  4096 objects have been freed since the last rescan, and at most once
  per transaction group. This avoids a pathology in dmu_object_alloc()
  that caused O(N^2) behavior for create-heavy workloads and
  substantially improves object creation rates. As summarized by
  @mahrens in #4636:
  "Normally, the object allocator simply checks to see if the next
  object is available. The slow calls happened when dmu_object_alloc()
  checks to see if it can backfill lower object numbers. This happens
  every time we move on to a new L1 indirect block (i.e. every 32 *
  128 = 4096 objects). When re-checking lower object numbers, we use
  the on-disk fill count (blkptr_t:blk_fill) to quickly skip over
  indirect blocks that don?t have enough free dnodes (defined as an L2
  with at least 393,216 of 524,288 dnodes free). Therefore, we may
  find that a block of dnodes has a low (or zero) fill count, and yet
  we can?t allocate any of its dnodes, because they've been allocated
  in memory but not yet written to disk. In this case we have to hold
  each of the dnodes and then notice that it has been allocated in
  memory.
  The end result is that allocating N objects in the same TXG can
  require CPU usage proportional to N^2."
  Add a tunable dmu_rescan_dnode_threshold to define the number of
  objects that must be freed before a rescan is performed. Don't bother
  to export this as a module option because testing doesn't show a
  compelling reason to change it. The vast majority of the performance
  gain comes from limit the rescan to at most once per TXG.

Reviewed by: Alek Pinchuk <alek@nexenta.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Approved by: Gordon Ross <gordon.w.ross@gmail.com>
Author: Ned Bass <bass6@llnl.gov>

Obtained from: Illumos
00:00:23 - r317234
(3 days 17 hours ago)
by glebius
Affects:  /head/usr.bin/vmstat/vmstat.c
- When reading VM stats, provide proper size argument to sysctl.
- While here, remove unused arguments from mysysctl().
2017 - 04 - 20   (4 days ago)
23:12:50 - r317233
(3 days 17 hours ago)
by sjg
Affects:  /vendor/NetBSD/bmake/20170420
tag bmake-20170420
23:12:37 - r317232
(3 days 17 hours ago)
by sjg
Affects: 
(16 files)
/vendor/NetBSD/bmake/dist/*
Import bmake-20170420

Only use -C arg "as is" if it contains no relative component.
Fix Main_SetObjdir() for relative paths (eg obj).
Fix a number of coverity complaints.
22:30:39 - r317231
(3 days 18 hours ago)
by jkim
Affects:  /head/usr.bin/systat/vmstat.c
Fix systat(1) regression. It was broken by r317061.
21:48:54 - r317230
(3 days 19 hours ago)
by dim
Affects: 
(376 files)
/projects/clang500-import/contrib/llvm/*
/projects/clang500-import/lib/clang/include/*
Merge llvm, clang, lld and lldb trunk r300890, and update build glue.
21:21:35 - r317229
(3 days 19 hours ago)
by dim
Affects:  /vendor/lldb/lldb-trunk-r300890
Tag lldb trunk r300890.
21:21:28 - r317228
(3 days 19 hours ago)
by dim
Affects: 
(51 files)
/vendor/lldb/dist/*
Vendor import of lldb trunk r300890:
https://llvm.org/svn/llvm-project/lldb/trunk@300890
21:21:25 - r317227
(3 days 19 hours ago)
by dim
Affects:  /vendor/lld/lld-trunk-r300890
Tag lld trunk r300890.
21:21:19 - r317226
(3 days 19 hours ago)
by dim
Affects: 
(13 files)
/vendor/lld/dist/COFF/*
/vendor/lld/dist/ELF/*
/vendor/lld/dist/test/*
Vendor import of lld trunk r300890:
https://llvm.org/svn/llvm-project/lld/trunk@300890
21:21:16 - r317225
(3 days 19 hours ago)
by dim
Affects:  /vendor/libc++/libc++-trunk-r300890
Tag libc++ trunk r300890.
21:21:10 - r317224
(3 days 19 hours ago)
by dim
Affects: 
(357 files)
/vendor/libc++/dist/*
Vendor import of libc++ trunk r300890:
https://llvm.org/svn/llvm-project/libcxx/trunk@300890
21:21:04 - r317223
(3 days 19 hours ago)
by dim
Affects:  /vendor/compiler-rt/compiler-rt-trunk-r300890
Tag compiler-rt trunk r300890.
21:20:59 - r317222
(3 days 19 hours ago)
by dim
Affects: 
(90 files)
/vendor/compiler-rt/dist/include/sanitizer/coverage_interface.h
/vendor/compiler-rt/dist/lib/*
/vendor/compiler-rt/dist/test/*
Vendor import of compiler-rt trunk r300890:
https://llvm.org/svn/llvm-project/compiler-rt/trunk@300890
21:20:56 - r317221
(3 days 19 hours ago)
by dim
Affects:  /vendor/clang/clang-trunk-r300890
Tag clang trunk r300890.
21:20:51 - r317220
(3 days 19 hours ago)
by dim
Affects: 
(156 files)
/vendor/clang/dist/*
Vendor import of clang trunk r300890:
https://llvm.org/svn/llvm-project/cfe/trunk@300890
21:19:16 - r317219
(3 days 19 hours ago)
by dim
Affects:  /vendor/llvm/llvm-trunk-r300890
Tag llvm trunk r300890.
21:19:10 - r317218
(3 days 19 hours ago)
by dim
Affects: 
(438 files)
/vendor/llvm/dist/*
Vendor import of llvm trunk r300890:
https://llvm.org/svn/llvm-project/llvm/trunk@300890
21:04:21 - r317217
(3 days 19 hours ago)
by dim
Affects: 
(329 files)
/projects/clang500-import/*
Merge ^/head r316992 through r317215.
21:01:59 - r317216
(3 days 19 hours ago)
by pfg
Affects:  /head/lib/libthread_db/libpthread_db.c
libthread_db: unbreak build due to sign/unsigned comparison.

Reported by: lwshu
21:00:09 - r317215
(3 days 20 hours ago)
by dim
Affects:  /head/lib/clang/llvm.build.mk
Add function and data sections when building llvm, clang, lld and lldb,
and allow the linker to garbage collect them. This shaves off up to a
few MB from the final executables.

MFC after: 3 days
21:00:04 - r317214
(3 days 20 hours ago)
by dim
Affects:  /head/lib/clang/include/llvm/Config/config.h
Turn off llvm/clang's ENABLE_BACKTRACES setting, since it never worked
properly anyway. (Upstream has reorganized this somewhat in the mean
time, but for proper backtraces we would need llvm-symbolizer in base.)

MFC after: 3 days
20:46:34 - r317213
(3 days 20 hours ago)
by scottl
Affects:  /head/sys/cam/scsi/scsi_da.c
Reorder the minimum_cmd_size code to make it a little smaller and
easier to read.
20:06:51 - r317212
(3 days 20 hours ago)
by trasz
Affects:  /head/share/man/man4/geom.4
Mention GEOM_MOUNTVER.

MFC after: 2 weeks
19:33:00 - r317211
(3 days 21 hours ago)
by bapt
Affects:  /head/gnu/lib/Makefile
GNU diff is done and GNU diff3 is not using libgnuregex, so no need to
condition the build of libgnuregex anymore on WITHOUT_GNU_DIFF
19:29:35 - r317210
(3 days 21 hours ago)
by bapt
Affects:  /head/gnu/lib/Makefile
Only build libreadline for gdb, binutils actually does not need it
19:24:51 - r317209
(3 days 21 hours ago)
by bapt
Affects: 
(6 files)
/head/*
Replace again GNU diff with BSD diff

After a firts failed attempt, BSD diff is now good enough to replace
GNU diff.

Relnotes: yes
19:19:33 - r317208
(3 days 21 hours ago)
by tuexen
Affects:  /head/sys/netinet/tcp_syncache.c
/head/sys/netinet/tcp_syncache.h
Syncoockies can be used in combination with the syncache. If the cache
overflows, syncookies are used.
This patch restricts the usage of syncookies in this case: accept
syncookies only if there was an overflow of the syncache recently.
This mitigates a problem reported in PR217637, where is syncookie was
accepted without any recent drops.
Thanks to glebius@ for suggesting an improvement.

PR: 217637
Reviewed by: gnn, glebius
MFC after: 1 week
Sponsored by: Netflix, Inc.
Differential Revision: https://reviews.freebsd.org/D10272
19:14:52 - r317207
(3 days 21 hours ago)
by bapt
Affects:  /head/usr.bin/diff/diff.1
Cross reference pr(1) which diff might call with -l option
19:07:52 - r317206
(3 days 21 hours ago)
by bapt
Affects:  /head/usr.bin/diff/TODO
Update the TODO list to reflect what has been changed
19:05:43 - r317205
(3 days 21 hours ago)
by bapt
Affects:  /head/usr.bin/diff/diff.1
Document all long options
18:21:50 - r317204
(3 days 22 hours ago)
by bapt
Affects: 
(19 files)
/head/*
Readd Big5: some large databases setup are still requiring it.

Reported by: "張君天(Chun-Tien Chang)" <tcs@kitty.2y.idv.tw>
17:58:27 - r317203
(3 days 23 hours ago)
by pfg
Affects:  /head/lib/libthread_db/libpthread_db.c
libpthread_db: undo the memset size change.

I inadvertedly soubled the size of the memset without noticing the
start address had changed. The size for the memset in pt_map_thread()
shouldn't actually match the reallocarray() so undo that part of r317200.

This is a re-commit of r317201 to clarify the log.

X-MFC with: r317200
17:54:59 - r317202
(3 days 23 hours ago)
by pfg
Affects:  /head/lib/libthread_db/libpthread_db.c
Revert r317201 to fix the log.
17:49:37 - r317201
(3 days 23 hours ago)
by pfg
Affects:  /head/lib/libthread_db/libpthread_db.c
libpthread_db: leave the memset size from unchanged.

The size for the memset in pt_map_thread() shouldn't actually match the
reallocarray() so undo that part of r317200.

X-MFC with: r317200
17:43:25 - r317200
(3 days 23 hours ago)
by pfg
Affects:  /head/lib/libthread_db/libpthread_db.c
/head/lib/libthread_db/libpthread_db.h
libthread_db: unsign map_len and use reallocarray(3).

Lengths are not negative, so map_len should be unsigned. Unsign the
corresponding indexes too and bring a small use of reallocarray(3).

Reorder the memset to be consistent with the realloc: it appears we
were only clearing half the memory in pt_map_thread().

MFC after: 2 weeks
17:22:03 - r317199
(3 days 23 hours ago)
by bde
Affects:  /head/sys/dev/syscons/scvgarndr.c
Eliminate the ega renderer switch. It did nothing useful except hold
a pointer to the main ega drawing method which is misoptimized be in
a different function than the main vga planar mode drawing method.
Vga initialization handles everything with no extra code except for
selecting the different function.
16:34:09 - r317198
(4 days ago)
by bde
Affects:  /head/sys/dev/syscons/scvgarndr.c
/head/sys/dev/syscons/syscons.h
When the character width is 9, remove vertical lines in the mouse cursor
corresponding to the gaps between characters. This fixes distortion
of the cursor due to expanding it across the gaps.

Again for character width 9, when the cursor characters are not in the
graphics range (0xb0-0xdf), the gaps were always there (filled in the
background color for the previous char). They still look strange, but
don't cause distortion. When the cursor characters are in the graphics
range, the gaps are filled by repeating the previous line. This gives
distortion with cilia. Removing vertical lines reduces the distortion
to vertical cilia.

Move the default for the cursor characters out of the graphics range.
With character width 9, this gives gaps instead of distortion and
other problems. With character width 8, it just fixes a smaller set
of other problems. Some distortion and other problems can be recovered
using vidcontrol -M. Presumably the default was to fill the gaps
intentionally, but it is much better to leave gaps. The gaps can even
be considered as a feature for text processing -- they give sub-pointers
to character boundaries. The other problems are: (1) with character
width 9, characters near the cursor are moved into the graphics range
and thus distorted if any of their 8th bits is set; (2) conflicts with
national characters in the graphics range.

The default range for the graphics cursor characters is now 8-11. This
doesn't conflict with anything, since the glyphs for the characters in
this range are unreachable.

Use the 10x16 mouse cursor in text mode too (if the font size is >= 14).

When the character width is 9, removal of 1 or 2 vertical lines makes
10x16 cursor no wider than the 9x13 one usually was. We could even
handle cursors 1 pixel wider in 2 character cells and gaps without
more clipping than given by the gaps (the worst case is 1 pixel in the
left cell, 1 removed in the middle gap, 8 in the right cell and 1
removed in the right gap. The pixel in the right gap is removed so
it doesn't matter if it is in the font).

When the character width is 8, we now clip the 10-wide cursor by 1
pixel in the worst case. This clipping is usually invisible since it
is of the border and and the border usually merges with the background
so is invisible. There should be an option to use reverse video to
highlight the border and its tip instead of the interior (graphics
mode can do better using separate colors). This needs the 9x13 cursor
again.

Ideas from: ache (especially about the bad default character range)
15:53:20 - r317197
(4 days 1 hour ago)
by andrew
Affects:  /head/sys/arm64/arm64/trap.c
Restrict the arm64 supervisor all instructions to only allow a zero
immediate value for system calls. We may wish to use other values in the
future for other purposes.

MFC after: 1 week
Sponsored by: DARPA, AFRL
15:18:15 - r317196
(4 days 1 hour ago)
by kib
Affects:  /head/sys/dev/fb/vesa.c
Write-combine framebuffer writes through user-space mappings, if possible.

Note that KVA mapping of the framebuffer already uses write-combining
mode, so the change, besides improving speed of user mode writes, also
satisfies requirement of the IA32 architecture of using consistent
caching modes for multiple mappings of the same page.

Reported and tested by: bde
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
15:06:16 - r317195
(4 days 1 hour ago)
by cognet
Affects:  /head/sys/dev/ofw/ofw_cpu.c
Update comment ot reflect realilty, we know also take care of CPUs that
provide a enable-method.

Suggested by: jhibbits
14:22:33 - r317194
(4 days 2 hours ago)
by bapt
Affects: 
(7 files)
/head/usr.bin/diff/*
Implement a basic --changed-group-format

etcupdate(8) requires that option, while GNU diff supports many more variation
of that options, their behaviour beside the simple verion implemented here are
quite inconsistent as such I do not plan to implement those.

The only special keyword supported by this implementation are: %< and %>
%= is not implemented as the documentation of GNU diff says: common lines, but
it actually when tested print the changes from the first file
13:57:53 - r317193
(4 days 3 hours ago)
by emaste
Affects:  /head/contrib/elftoolchain/elfcopy/elfcopy.1
elfcopy: document --strip-symbols=filename in the man page

Reported by: bz
MFC after: 1 week
Sponsored by: The FreeBSD Foundation
13:56:30 - r317192
(4 days 3 hours ago)
by andrew
Affects:  /head/sys/arm64/arm64/exception.S
/head/sys/arm64/arm64/genassym.c
/head/sys/arm64/arm64/trap.c
Push loading curthread into assembly in the synchronous exception handlers.
This will help investigating the performance impact of moving parts of the
switch statement in do_el0_sync into assembly.

Sponsored by: DARPA, AFRL
13:56:06 - r317191
(4 days 3 hours ago)
by cognet
Affects:  /head/sys/dev/ofw/ofw_cpu.c
ePAPR states that any non-boot CPU will come in "disabled" state. So we should
not consider a "disabled" cpu as a CPU we have to ignore, and we should use
them if they provide a "enable-method".
While I'm there, support "ok" as well as "okay", while ePAPR only accepts
"okay", linux accepts "ok" too so we can expect it to be used.

Reviewed by: andrew (partially)
13:46:55 - r317190
(4 days 3 hours ago)
by bde
Affects:  /head/sys/dev/fb/vesa.c
/head/sys/dev/fb/vga.c
/head/sys/sys/fbio.h
Attempt to determine the modes in which 8-bit wide characters are actually
9 wide.

I only need this to improve the mouse cursor, but it has always been
needed to select and/or adjust fonts.

This is complicated because there are no standard parameter tables
giving this bit of information directly, and the device register bit
giving the information can't be trusted even if it is read from the
hardware. Use a heuristic to guess if the device register can be
trusted. (The device register is normally read from the BIOS mode
table, but on my system where the device register is wrong, the mode
table doesn't match the hardware and is not used; the device registers
are used in this case.)
12:48:01 - r317189
(4 days 4 hours ago)
by andrew
Affects: 
(2 files)
/stable/11/libexec/rtld-elf/aarch64/reloc.c
MFC r312764:
Pull the R_AARCH64_TLSDESC code out into a common function and use them in
both the plt and non-plt case.

This fixes an issue where libraries built with LLD can fail with
"Unhandled relocation 1031"
11:52:10 - r317188
(4 days 5 hours ago)
by skra
Affects: 
(2 files)
/stable/11/sys/arm/arm/pmap-v6.c
MFC r308569,r308570:

  r308569:
  Always call PHYS_TO_VM_PAGE() in is_managed(). Fast road for addresses
  under first_page cannot be taken as this variable is connected only to
  vm_page_array segment. There could be more segments in system like the ones
  for various fictitious page ranges. These can be situated under
  vm_page_array segment and so, they could be skipped before this fix.
  However, as far as I know, there is no report associated with it.
  r308570:
  The return type of is_managed() was changed from boolean_t to bool type in
  r308569. Now, propagate this change further for consistency sake.
11:32:18 - r317187
(4 days 5 hours ago)
by bapt
Affects:  /head/usr.bin/diff/tests/Makefile
/head/usr.bin/diff/tests/diff_test.sh
/head/usr.bin/diff/tests/ifdef.out
Add a regression test for diff -D
09:05:53 - r317186
(4 days 7 hours ago)
by kp
Affects:  /head/sys/netinet6/ip6_output.c
/head/sys/netpfil/pf/pf_norm.c
pf: Fix possible incorrect IPv6 fragmentation

When forwarding pf tracks the size of the largest fragment in a fragmented
packet, and refragments based on this size.
It failed to ensure that this size was a multiple of 8 (as is required for all
but the last fragment), so it could end up generating incorrect fragments.

For example, if we received an 8 byte and 12 byte fragment pf would emit a first
fragment with 12 bytes of payload and the final fragment would claim to be at
offset 8 (not 12).

We now assert that the fragment size is a multiple of 8 in ip6_fragment(), so
other users won't make the same mistake.

Reported by: Antonios Atlasis <aatlasis at secfu net>
MFC after: 3 days
09:01:31 - r317185
(4 days 8 hours ago)
by mav
Affects:  /head/sys/dev/watchdog/watchdog.c
Some cosmetic polishing for pre-timeouts.

MFC after: 1 week
04:36:49 - r317184
(4 days 12 hours ago)
by davidcs
Affects: 
(6 files)
/stable/9/sys/dev/qlxgbe/*
MFC r316183
Upgrade firmware and other related files to version 5.4.64
04:33:47 - r317183
(4 days 12 hours ago)
by davidcs
Affects: 
(5 files)
/stable/10/sys/dev/qlxgbe/*
MFC r316183
Upgrade firmware and other related files to version 5.4.64
04:26:47 - r317182
(4 days 12 hours ago)
by davidcs
Affects: 
(5 files)
/stable/11/sys/dev/qlxgbe/*
MFC r316183
Upgrade firmware and other related files to version 5.4.64
03:43:37 - r317181
(4 days 13 hours ago)
by ngie
Affects:  /head/share/man/man5/src.conf.5
Regenerate src.conf(5) after recent additions/clarifications

Sponsored by: Dell EMC Isilon
03:41:42 - r317180
(4 days 13 hours ago)
by davidcs
Affects: 
(4 files)
/head/sys/dev/qlxgbe/*
Cleanup QLA_LOCK/QLA_UNLOCK macros
remove unused QLA_TX_LOCK/QLA_TX_UNLOCK macros
format qla_error_recovery()

MFC after:3 days
03:36:09 - r317179
(4 days 13 hours ago)
by ngie
Affects:  /head/tools/build/options/WITHOUT_PROFILE
/head/tools/build/options/WITH_PROFILE
Clean up WITH*_PROFILE

- Clarify that profiled libraries are usable with gprof(8).
- Add WITH_PROFILE to complement WITHOUT_PROFILE and placate makeman.

MFC after: 7 weeks
Sponsored by: Dell EMC Isilon
03:32:30 - r317178
(4 days 13 hours ago)
by ngie
Affects:  /head/tools/build/options/WITH_GROFF
Add WITH_GROFF to complement WITHOUT_GROFF and placate complaints from makeman

MFC after: 7 weeks
Sponsored by: Dell EMC Isilon
2017 - 04 - 19   (5 days ago)
23:06:07 - r317177
(4 days 17 hours ago)
by np
Affects:  /head/sys/netinet/tcp_lro.c
Free lro_hash unconditionally, just like lro_mbuf_data a few lines
later. Fix whitespace nit while here.
22:50:19 - r317176
(4 days 18 hours ago)
by glebius
Affects:  /head/sys/sys/param.h
Bump __FreeBSD_version due to r317061, struct vmmeter changes.
22:48:27 - r317175
(4 days 18 hours ago)
by glebius
Affects:  /head/sys/dev/syscons/scvgarndr.c
Fix build without SC_PIXEL_MODE defined.
22:43:11 - r317174
(4 days 18 hours ago)
by jkim
Affects:  /head/sys/dev/vt/vt_cpulogos.c
Revert r316796. It is not necessary since r317173.
22:41:24 - r317173
(4 days 18 hours ago)
by jkim
Affects:  /head/sys/dev/vt/vt_core.c
Always clear borders when the terminal is flushed.

PR: 202288
22:27:26 - r317172
(4 days 18 hours ago)
by np
Affects:  /head/sys/netinet/tcp_lro.c
Do not leak lro_hash on failure to allocate lro_mbuf_data.

MFC after: 1 week
22:21:15 - r317171
(4 days 18 hours ago)
by jkim
Affects:  /head/sys/dev/vt/vt_core.c
Micro-optimize vt_set_border().
22:20:41 - r317170
(4 days 18 hours ago)
by np
Affects:  /head/sys/netinet/tcp_lro.c
Remove redundant assignment.
21:18:06 - r317169
(4 days 19 hours ago)
by gjb
Affects:  /head/release/tools/vmimage.subr
Trim trailing '/release/..' when setting _OBJDIR so arm64/aarch64
boot1.efifat is properly located when creating virtual machine images.

Sponsored by: The FreeBSD Foundation
20:45:46 - r317168
(4 days 20 hours ago)
by ngie
Affects:  /head/share/mk/src.opts.mk
/head/tools/build/options/WITH_RPCBIND_WARMSTART_SUPPORT
/head/usr.sbin/rpcbind/Makefile
Add a knob, WITH*_RPCBIND_WARMSTART_SUPPORT, to allow the end-user to build
rpcbind(8) with/without warmstart support.

The knob defaults to off to preserve POLA for the feature.

See rpcbind(8) for more details about the warmstart feature.

MFC after: 7 weeks
Relnotes: yes
Sponsored by: Dell EMC Isilon
20:35:47 - r317167
(4 days 20 hours ago)
by ngie
Affects:  /head/tools/build/options/WITH_CXX
Add WITH_CXX to complement WITHOUT_CXX and placate makeman's complaints

MFC after: 7 weeks
Sponsored by: Dell EMC Isilon
20:35:04 - r317166
(4 days 20 hours ago)
by manu
Affects:  /head/usr.bin/pom/pom.c
pom: Remove useless cap_rights_init

Pointy-Hat: manu

Reported by: bapt
20:27:48 - r317165
(4 days 20 hours ago)
by manu
Affects:  /head/usr.bin/pom/pom.c
Capsicumize pom

Since pom is the only binary that can save lives, capsicumize it to be
sure that it's safe to run it.

Reviewed by: bapt
20:27:13 - r317164
(4 days 20 hours ago)
by ngie
Affects:  /head/usr.sbin/rpcbind/Makefile
Fix indentation per style.Makefile(5)

MFC after: 7 weeks
Sponsored by: Dell EMC Isilon
20:23:27 - r317163
(4 days 20 hours ago)
by ngie
Affects:  /head/usr.sbin/rpcbind/rpcbind.8
rpcbind(8): post-humously document -w (warmstart) support added in r74462

warmstart support saves portmap/rpcbind(8) registration state on exit and
restores the saved registration state on restart.

MFC after: 7 weeks
Sponsored by: Dell EMC Isilon
20:04:45 - r317162
(4 days 20 hours ago)
by ngie
Affects:  /head/usr.sbin/rpcbind/rpcbind.8
rpcbind(8): add a description for /var/run/rpcbind.sock under the FILES section

MFC after: 7 weeks
Sponsored by: Dell EMC Isilon
19:55:38 - r317161
(4 days 21 hours ago)
by ngie
Affects:  /head/usr.bin/which/which.c
which(1): sort #includes

No functional change [intended].

MFC after: 7 weeks
Sponsored by: Dell EMC Isilon
19:52:40 - r317160
(4 days 21 hours ago)
by ngie
Affects:  /head/usr.bin/which/which.c
Clean up trailing whitespace

No functional changes

MFC after: 1 week
Sponsored by: Dell EMC Isilon
19:06:47 - r317159
(4 days 21 hours ago)
by emaste
Affects:  /head/contrib/libstdc++/config/abi/pre/gnu.ver
libstdc++: fix symbol version script for LLD

LLD is less tolerant of inconsistencies in the symbol version script.

- Add a ; on the last entry in a version block
- Remove duplicated symbols, retaining those in the earliest block

Reviewed by: bdrewery
MFC after: 1 month
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D10428
18:59:38 - r317158
(4 days 22 hours ago)
by emaste
Affects: 
(4 files)
/head/share/man/man5/src.conf.5
/head/share/mk/src.opts.mk
/head/tools/build/options/*
Remove WITHOUT_GNU and WITHOUT_GNU_SUPPORT src.conf.knobs

These have no effect (and WITHOUT_GNU is documented as having no
effect). I intend to later introduce a WITHOUT_GPL knob to serve a
similar purpose as WITHOUT_GNU's previously documented intent, but with
a more accurate name. To avoid confusion over the transition though just
remove the existing, nonfunctional ones.
18:35:34 - r317157
(4 days 22 hours ago)
by bde
Affects:  /head/sys/dev/syscons/scvgarndr.c
Fix missing support for drawing the mouse cursor in depth 24 of direct
mode.

Use the general DRAWPIXEL() macro with its bigger case statement
(twice) instead of our big case statement (once). DRAWPIXEL() is more
complicated since it is not missing support for depth 24 or
complications for colors in depth 16 (we currently hard-code black and
white so the complications for colors are not needed). DRAWPIXEL()
also does the bpp calculation in the inner loop. Compilers optimize
DRAWPIXEL() well enough, and the main text drawing method always
depended on this. In direct mode, mouse cursor drawing is now similar
to normal text drawing except it draws in 2 hard-coded colors instead
of 1 variable color.

This also fixes a nested hard-coding of colors. DRAWPIXEL() uses the
palette in all cases, but the direct code didn't use the palette for
its hard-coded black. This only had an effect in depth 8, since
changing the palette is not supported in other depths.
18:11:08 - r317156
(4 days 22 hours ago)
by emaste
Affects:  /head/tools/build/options/makeman
makeman: add a comment describing purpose and invocation

Reviewed by: jhb, ngie
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D10389
18:01:53 - r317155
(4 days 22 hours ago)
by ngie
Affects:  /head/usr.sbin/rpcbind/rpcbind.8
rpcbind(8): wordsmith -h description and mention -W in the SYNOPSIS section

-W was already documented in the OPTIONS section.

MFC after: 7 weeks
Reported by: igor (-h wordsmith'ing)
Sponsored by: Dell EMC Isilon
17:51:32 - r317154
(4 days 23 hours ago)
by ngie
Affects:  /head/usr.sbin/rpcbind/rpcbind.c
Print out the signal number on exit in terminate(..) if WARMSTART is compiled
into rpcbind.

The signal number can provide helpful diagnostic info.

MFC after: 1 week
Obtained from: Isilon OneFS
Sponsored by: Dell EMC Isilon
17:32:32 - r317153
(4 days 23 hours ago)
by bdrewery
Affects: 
(2 files)
/stable/11/sys/conf/kmod.mk
MFC r316533:

  Support assym.s in DPSRCS to depend on it but not link it in.
17:29:54 - r317152
(4 days 23 hours ago)
by bdrewery
Affects: 
(2 files)
/stable/11/sys/modules/dtrace/dtrace/Makefile
MFC r316534:

  Stop building assym.o into the module.
17:06:32 - r317151
(4 days 23 hours ago)
by br
Affects: 
(4 files)
/head/sys/riscv/include/*
/head/sys/riscv/riscv/*
Follow r317061 "Remove struct vmmeter from struct pcpu"
with MD changes for RISC-V.

This unbreaks RISC-V build.

Sponsored by: DARPA, AFRL
16:24:51 - r317150
(5 days ago)
by bde
Affects:  /head/sys/dev/syscons/scvgarndr.c
Stop using a saveunder method for mouse cursor drawing in the vga
direct mode renderer. I thought that reads were not much slower than
writes, so that the method only tripled the time for the whole function,
but I recently measured that video memory reads can be up to 53 times
slower than writes in tighter loops than here. Loop overheap here
reduces the multiplier to only 16-20 on Haswell.

Start cleaning up and fixing larger bugs in this function. Only replace
the 22-line removal loop by a 3-line one for now, since adjusting the
old loop would have required many palette calculations which are better
done in the DRAW_PIXEL() macro. This also fixes missing support for
depth 24, but only for removal.

Removal is currently sloppy at the right bottom corner. It sometimes
leaks border color into the text window. This is soon cleaned up by the
caller. The planar renderer has complications to clip at the corner.
16:16:41 - r317149
(5 days ago)
by markj
Affects: 
(9 files)
/stable/11/sys/*
/stable/11/tests/sys/kern/*
MFC r313006 (by cem), r315983 (by bde):
Add an SSE4.2 implementation of crc32 for x86.
16:12:02 - r317148
(5 days ago)
by markj
Affects:  /head/sys/compat/linuxkpi/common/src/linux_compat.c
Drop Giant before sleeping in linux_wait_for_{timeout_,}common().

Reported and tested by: Pete Wright <pete@nomadlogic.org>
Reviewed by: hselasky (previous version)
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D10414
15:59:16 - r317147
(5 days 1 hour ago)
by andrew
Affects: 
(2 files)
/stable/11/sys/arm64/arm64/swtch.S
MFC 313772:

Load the new sp_el0 with interrupts disabled in fork_trampoline. If an
interrupt arrives in fork_trampoline after sp_el0 was written we may then
switch to a new thread, enter userland so change this stack pointer, then
return to this code with the wrong value. This fixes this case by moving
the load of sp_el0 until after interrupts have been disabled.
15:46:34 - r317146
(5 days 1 hour ago)
by andrew
Affects: 
(2 files)
/stable/11/sys/conf/ldscript.arm64
MFC 305355:

Explicitly include all .rodata.* sections in the kernel .rodata. This
helps link the kernel with lld as it will then put all these into a single
.rodata section.
15:33:24 - r317145
(5 days 1 hour ago)
by emaste
Affects: 
(14 files)
/stable/11/sys/boot/mips/uboot/ldscript.mips
/stable/11/sys/conf/*
MFC r303442, r305343: remove CONSTRUCTORS from linker scripts

r303442: remove CONSTRUCTORS from kernel linker scripts

r305343: remove CONSTRUCTORS from MIPS uboot linker script

The linker script CONSTRUCTORS keyword is only meaningful "when linking
object file formats which do not support arbitrary sections, such as
ECOFF and XCOFF"[1] and is ignored for other object file formats.

LLVM's lld does not yet accept (and ignore) CONSTRUCTORS, so just remove
CONSTRUCTORS from the linker script as it has no effect.

[1] https://sourceware.org/binutils/docs/ld/Output-Section-Keywords.html

Reported by: andrew
Sponsored by: The FreeBSD Foundation
15:24:33 - r317144
(5 days 1 hour ago)
by br
Affects:  /head/contrib/zstd/lib/common/xxhash.c
Don't use __builtin_bswap for RISC-V due to undefined reference
in compiler.

This unbreaks RISC-V world build.

Sponsored by: DARPA, AFRL
15:04:52 - r317143
(5 days 1 hour ago)
by scottl
Affects: 
(15 files)
/head/sys/cam/*
Add infrastructure to the ATA and SCSI transports that supports
using a driver-supplied sbuf for printing device discovery
announcements. This helps ensure that messages to the console
will be properly serialized (through sbuf_putbuf) and not be
truncated and interleaved with other messages. The
infrastructure mirrors the existing xpt_announce_periph()
entry point and is opt-in for now. No content or formatting
changes are visible to the operator other than the new coherency.

While here, eliminate the stack usage of the temporary
announcement buffer in some of the drivers. It's moved to the
softc for now, but future work will eliminate it entirely by
making the code flow more linear. Future work will also address
locking so that the sbufs can be dynamically sized.

The scsi_da, scs_cd, scsi_ses, and ata_da drivers are converted
at this point, other drivers can be converted at a later date.
A tunable+sysctl, kern.cam.announce_nosbuf, exists for testing
purposes but will be removed later.

TODO:
Eliminate all of the code duplication and temporary buffers. The
old printf-based methods will be retired, and xpt_announce_periph()
will just be a wrapper that uses a dynamically sized sbuf. This
requires that the register and deregister paths be made malloc-safe,
which they aren't currently.

Sponsored by: Netflix
14:49:18 - r317142
(5 days 2 hours ago)
by bde
Affects:  /head/sys/dev/fb/vga.c
When we don't use the parameter table in the BIOS, also don't use most
of our tweaked modes based on it. In practice, this means limiting the
tweaked modes to at most 80x50 based on 80x25, so there are no 90-column,
80x30 or 80x60 modes.

This happens when the the initial mode is is not in the parameter
table. We always detected this case, but assumed that the (necessarily
nonstandard) parameters of the initial mode could be tweaked just as
blindly as the probably-standard parameters of initial modes in the
table.

On 1 laptop system with near-VGA where the initial mode is nonstandard,
this is because the hardware apparently doesn't support 9-bit mode,
but otherwise has standard timing. The initial mode has 8-bit mode
CRTC horizontal parameters similar to those in syscons' 90-column modes
and in EGA modes. Tweaking these values for the 90-column modes has
little effect except to print the extra 10 columns off the screen.
Tweaking from 80x25 to 80x30 requires changing from 400 scan lines to
480. This can probably be made to work, but syscons blindly applies
values based on standard timing. This gives blank output. Tweaking
from 80x25 to 80x50 doesn't change the CRTC timing and works.
14:43:51 - r317141
(5 days 2 hours ago)
by emaste
Affects:  /head/contrib/elftoolchain/readelf/readelf.c
readelf: dump MIPS abiflags section

This is not fully fleshed out but is sufficient to dump the
SHT_MIPS_ABIFLAGS used in FreeBSD.

Reviewed by: imp
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D8241
14:07:35 - r317140
(5 days 2 hours ago)
by andrew
Affects: 
(4 files)
/stable/11/share/mk/bsd.stand.mk
/stable/11/sys/boot/efi/Makefile.inc
/stable/11/sys/boot/efi/loader/arch/arm64/start.S
Fix the arm64 userland building with lld:

MFC 308124:
 On arm64 build the efi loader with -fPIC. Without this clang 3.9 will
 generate relocation in the self relocation code.

MFC 316608:
 Add -fPIC to the standalone build flags on arm64. This is needed as
 loader.efi is position independend, however we were not building it as
 such causing a build failure when building with lld.

MFC 315452:
 Mark the EFI PE header as allocated. While ld.bfd doesn't seem to care
 about not having this flag ld.lld fails to link without it.
13:24:32 - r317139
(5 days 3 hours ago)
by cy
Affects:  /head/sys/contrib/ipfilter/netinet/radix_ipf.c
Restore prototype accidently removed by r316811. Also remove $NetBSD$
accidentally added.

Reported by: hps, lwhsu
13:04:34 - r317138
(5 days 3 hours ago)
by hselasky
Affects:  /head/sys/compat/linuxkpi/common/include/linux/rcupdate.h
Use __typeof() instead of typeof() in some RCU related macros in the LinuxKPI.

MFC after: 1 week
Sponsored by: Mellanox Technologies
13:03:29 - r317137
(5 days 3 hours ago)
by hselasky
Affects:  /head/sys/compat/linuxkpi/common/include/linux/sched.h
/head/sys/compat/linuxkpi/common/include/linux/srcu.h
/head/sys/compat/linuxkpi/common/src/linux_rcu.c
Fix problem regarding priority inversion when using the concurrency
kit, CK, in the LinuxKPI.

When threads are pinned to a CPU core or when there is only one CPU,
it can happen that a higher priority thread can call the CK
synchronize function while a lower priority thread holds the read
lock. Because the CK's synchronize is a simple wait loop this can lead
to a deadlock situation. To solve this problem use the recently
introduced CK's wait callback function.

When detecting a CK blocking condition figure out the lowest priority
among the blockers and update the calling thread's priority and
yield. If another CPU core is holding the read lock, pin the thread to
the blocked CPU core and update the priority. The calling threads
priority and CPU bindings are restored before return.

If a thread holding a CK read lock is detected to be sleeping, pause()
will be used instead of yield().

MFC after: 1 week
Sponsored by: Mellanox Technologies
12:39:45 - r317136
(5 days 4 hours ago)
by n_hibma
Affects:  /head/tools/tools/nanobsd/embedded/common
A test was moved but without the definition of $d.

The test however always succeeds because 'test -d' always returns true.

Also some speling fixes.
11:38:07 - r317135
(5 days 5 hours ago)
by hselasky
Affects:  /head/sys/compat/linuxkpi/common/src/linux_work.c
Zero number of CPUs should be translated into the default number of
CPUs when allocating a LinuxKPI workqueue. This also ensures that the
created taskqueue always have a non-zero number of worker threads.

MFC after: 1 week
Sponsored by: Mellanox Technologies
11:13:32 - r317134
(5 days 5 hours ago)
by kib
Affects: 
(2 files)
/stable/11/sys/fs/nfsclient/nfs_clbio.c
MFC r316532:
Make nfs pageout coherent with the dirty state of the buffers.
11:11:51 - r317133
(5 days 5 hours ago)
by kib
Affects: 
(2 files)
/stable/11/sys/fs/nfsclient/nfs_clbio.c
MFC r316531:
Handle nfs IO_ASYNC write requests asynchronously.
11:10:02 - r317132
(5 days 5 hours ago)
by kib
Affects: 
(3 files)
/stable/11/sys/fs/nfsclient/nfs_clbio.c
/stable/11/sys/fs/nfsclient/nfs_clvnops.c
MFC r316529:
Handle possible vnode reclamation after ncl_vinvalbuf() call.
10:57:57 - r317131
(5 days 6 hours ago)
by kib
Affects: 
(2 files)
/stable/10/lib/libc/gen/sysconf.c
MFC r316739:
Fix reporting of _SC_SEM_NSEMS_MAX and _SC_SEM_VALUE_MAX.
10:54:08 - r317130
(5 days 6 hours ago)
by kib
Affects: 
(2 files)
/stable/11/lib/libc/gen/sysconf.c
MFC r316739:
Fix reporting of _SC_SEM_NSEMS_MAX and _SC_SEM_VALUE_MAX.
09:07:04 - r317129
(5 days 7 hours ago)
by pho
Affects:  /user/pho/stress2/misc/mmap18.sh
Use calculated max wire for test.

Sponsored by: Dell EMC Isilon
09:05:30 - r317128
(5 days 7 hours ago)
by pho
Affects:  /user/pho/stress2/misc/mmap14.sh
Limit RLIMIT_MEMLOCK so test does not deadlock.
Cleanup code while here.
09:01:04 - r317127
(5 days 8 hours ago)
by pho
Affects:  /user/pho/stress2/misc/nfsdelegation.sh
Added a regression test.

Sponsored by: Dell EMC Isilon
05:59:00 - r317126
(5 days 11 hours ago)
by ganbold
Affects:  /head/sys/arm/allwinner/aw_cir.c
Use hwreset_get_by_ofw_idx() function instead, since there is
no reset-names dts property defined for IR in case of H3 SoC.
That way IR works on H3 SoC based board.
Tested on Orangepi mini 2 board.
05:28:21 - r317125
(5 days 11 hours ago)
by sephe
Affects: 
(3 files)
/stable/10/sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c
/stable/10/sys/dev/hyperv/utilities/hv_kvp.c
MFC 316813,316815

316813
  hyperv/storvsc: Use ULL for 64bits value shift.

  Reported by: PVS
  Sponsored by: Microsoft

316815
  hyperv/kvp: Remove always false condition.

  Reported by: PVS
  Sponsored by: Microsoft
05:19:33 - r317124
(5 days 11 hours ago)
by sephe
Affects: 
(4 files)
/stable/10/sys/conf/files.amd64
/stable/10/sys/dev/hyperv/input/hv_kbdc.c
MFC 316515,316812

316515
  hyperv/kbd: Add support for synthetic keyboard.

  Synthetic keyboard is the only supported keyboard on GEN2 Hyper-V.

  Submitted by: Hongjiang Zhang <honzhan microsoft com>
  Sponsored by: Microsoft
  Differential Revision: https://reviews.freebsd.org/D10196

316812
  hyperv/kbd: Remove unnecessary assignment.

  Reported by: PVS
  Sponsored by: Microsoft
03:43:24 - r317123
(5 days 13 hours ago)
by davidcs
Affects: 
(2 files)
/stable/10/sys/dev/qlnx/qlnxe/qlnx_os.c
MFC r316747
  Fix rss_ind_table entry for num_funcs > 1
03:41:19 - r317122
(5 days 13 hours ago)
by davidcs
Affects: 
(3 files)
/stable/10/sys/dev/qlnx/qlnxe/bcm_osal.h
/stable/10/sys/dev/qlnx/qlnxe/qlnx_os.c
MFC r316720
  Fix defects reported by Coverity
  1. Deadcode in ecore_init_cache_line_size(), qlnx_ioctl() and
  qlnx_clean_filters()
  2. ARRAY_VS_SINGLETON issue in qlnx_remove_all_mcast_mac() and
  qlnx_update_rx_prod()
03:39:50 - r317121
(5 days 13 hours ago)
by sephe
Affects: 
(3 files)
/stable/11/sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c
/stable/11/sys/dev/hyperv/utilities/hv_kvp.c
MFC 316813,316815

316813
  hyperv/storvsc: Use ULL for 64bits value shift.

  Reported by: PVS
  Sponsored by: Microsoft

316815
  hyperv/kvp: Remove always false condition.

  Reported by: PVS
  Sponsored by: Microsoft
03:37:11 - r317120
(5 days 13 hours ago)
by davidcs
Affects: 
(7 files)
/stable/10/share/man/man4/*
/stable/10/sys/*
MFC r316485
  Add 25/40/100Gigabit Ethernet Driver version v1.3.0 for Cavium Inc's.
  Qlogic 45000 Series Adapters
03:30:37 - r317119
(5 days 13 hours ago)
by sephe
Affects: 
(4 files)
/stable/11/sys/conf/files.amd64
/stable/11/sys/dev/hyperv/input/hv_kbdc.c
MFC 316515,316812

316515
  hyperv/kbd: Add support for synthetic keyboard.

  Synthetic keyboard is the only supported keyboard on GEN2 Hyper-V.

  Submitted by: Hongjiang Zhang <honzhan microsoft com>
  Sponsored by: Microsoft
  Differential Revision: https://reviews.freebsd.org/D10196

316812
  hyperv/kbd: Remove unnecessary assignment.

  Reported by: PVS
  Sponsored by: Microsoft
03:18:11 - r317118
(5 days 13 hours ago)
by davidcs
Affects: 
(2 files)
/stable/11/sys/dev/qlnx/qlnxe/qlnx_os.c
MFC r316747
Fix rss_ind_table entry for num_funcs > 1
03:13:58 - r317117
(5 days 13 hours ago)
by davidcs
Affects: 
(3 files)
/stable/11/sys/dev/qlnx/qlnxe/bcm_osal.h
/stable/11/sys/dev/qlnx/qlnxe/qlnx_os.c
MFC r316720
Fix defects reported by Coverity
  1. Deadcode in ecore_init_cache_line_size(), qlnx_ioctl() and
  qlnx_clean_filters()
  2. ARRAY_VS_SINGLETON issue in qlnx_remove_all_mcast_mac() and
  qlnx_update_rx_prod()
03:09:20 - r317116
(5 days 13 hours ago)
by davidcs
Affects: 
(7 files)
/stable/11/share/man/man4/*
/stable/11/sys/*
MFC r316485
  Add 25/40/100Gigabit Ethernet Driver version v1.3.0 for Cavium Inc's.
  Qlogic 45000 Series Adapters
03:06:27 - r317115
(5 days 13 hours ago)
by sephe
Affects: 
(2 files)
/stable/10/sys/dev/hyperv/vmbus/hyperv.c
MFC 317107
  hyperv: Use kmem_malloc for hypercall memory due to NX bit change.

  Reported by: dexuan@
  Sponsored by: Microsoft
03:03:46 - r317114
(5 days 13 hours ago)
by davidcs
Affects: 
(5 files)
/stable/9/share/man/man4/qlxgbe.4
MFC r316310
  Update man page for commit r316309 "Add support for optional Soft LRO".
  The driver provides the ability to select either HW or Software LRO, when
  LRO is enabled (default HW LRO).
03:02:23 - r317113
(5 days 13 hours ago)
by davidcs
Affects: 
(6 files)
/stable/9/sys/dev/qlxgbe/*
MFC r316309
Add support for optional Soft LRO
02:59:26 - r317112
(5 days 14 hours ago)
by davidcs
Affects: 
(2 files)
/stable/10/share/man/man4/qlxgbe.4
MFC r316310
Update man page for commit r316309 "Add support for optional Soft LRO".
The driver provides the ability to select either HW or Software LRO, when
LRO is enabled (default HW LRO).
02:58:14 - r317111
(5 days 14 hours ago)
by davidcs
Affects: 
(5 files)
/stable/10/sys/dev/qlxgbe/*
MFC r316309
Add support for optional Soft LRO
02:54:59 - r317110
(5 days 14 hours ago)
by davidcs
Affects: 
(2 files)
/stable/11/share/man/man4/qlxgbe.4
MFC r316310
Update man page for commit r316309 "Add support for optional Soft LRO".
The driver provides the ability to select either HW or Software LRO, when
LRO is enabled (default HW LRO).
02:52:55 - r317109
(5 days 14 hours ago)
by davidcs
Affects: 
(5 files)
/stable/11/sys/dev/qlxgbe/*
MFC r316309
Add support for optional Soft LRO
02:48:38 - r317108
(5 days 14 hours ago)
by sephe
Affects: 
(2 files)
/stable/11/sys/dev/hyperv/vmbus/hyperv.c
MFC 317107
  hyperv: Use kmem_malloc for hypercall memory due to NX bit change.

  Reported by: dexuan@
  Sponsored by: Microsoft
02:39:48 - r317107
(5 days 14 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/vmbus/hyperv.c
hyperv: Use kmem_malloc for hypercall memory due to NX bit change.

Reported by: dexuan@
MFC after: now
Sponsored by: Microsoft
2017 - 04 - 18   (6 days ago)
23:59:15 - r317106
(5 days 17 hours ago)
by sjg
Affects:  /head/share/mk/auto.obj.mk
If MAKEOBJDIRPREFIX is a prefix match for .CURDIR, then __objdir is .CURDIR

Reviewed by: bdrewery
21:21:31 - r317105
(5 days 19 hours ago)
by dim
Affects:  /projects/clang500-import/lib/clang/liblldb/Makefile
Update objects in liblldb for the MK_LLDB=yes case.
21:05:05 - r317104
(5 days 19 hours ago)
by cem
Affects:  /head/sys/cam/scsi/scsi_da.c
da(4): Fix a TRIM regression introduced in r308155

According to Warner, multiple TRIM BIOs are collapsed into a single CCB with
NULL bp. It is invalid to biotrack() NULL, and results in a fault. So,
don't do that.

Reported by: asomers@
Sponsored by: Dell EMC Isilon
20:31:02 - r317103
(5 days 20 hours ago)
by dim
Affects: 
(4 files)
/projects/clang500-import/contrib/llvm/tools/lldb/include/lldb/Host/Config.h
/projects/clang500-import/lib/clang/include/lldb/Host/Config.h
For lldb, delete the custom Xcode-only Host/Config.h, and provide a
pre-generated version in lib/clang/include/lldb/Host instead, similar to
what we do for clang, llvm and lld.
20:07:21 - r317102
(5 days 20 hours ago)
by kp
Affects:  /head/sys/netpfil/pf/pf_ioctl.c
pf: Also clear limit counters

The "pfctl -F info" command didn't clear the limit counters ( as shown in the
"pfctl -vsi" output).

Submitted by: Max <maximos@als.nnov.ru>
19:54:04 - r317101
(5 days 21 hours ago)
by jhb
Affects:  /head/share/man/man5/src.conf.5
Regenerate to note that GDB is now off by default on most platforms.

Note that this commit also adds the default riscv settings for all
options since riscv was added to 'make targets' since the last time
this was generated.

Reminded by: emaste
19:44:34 - r317100
(5 days 21 hours ago)
by gjb
Affects:  /head/Makefile.inc1
Use relative symlink for 'latest' to allow repo to work after being
moved.

Submitted by: woodsb02
MFC after: 3 days
PR: 217197
Sponsored by: The FreeBSD Foundation
19:36:58 - r317099
(5 days 21 hours ago)
by tsoome
Affects:  /head/sys/boot/uboot/lib/disk.c
loader: uboot disk ioctl should call disk_ioctl

As the uboot disk interface is using common/disk.c API, we also
should use disk_ioctl() call, this will give us chance to read partition
sizes and have feature parity with UEFI and BIOS implementations.

This does also fix arm boot issue on some systems, reported/tested by Ian,
thanks.

Reported by: ian
Reviewed by: ian
Differential Revision: https://reviews.freebsd.org/D10421
19:15:06 - r317098
(5 days 21 hours ago)
by dim
Affects:  /projects/clang500-import/usr.bin/clang/lld/Makefile
Add new objects to usr.bin/clang/lld for the MK_LLD=yes case.
18:07:54 - r317097
(5 days 22 hours ago)
by tsoome
Affects: 
(11 files)
/head/sys/boot/*
loader: F_READ/F_WRITE should be checked against masked flag

The work to make it possible to avoid bcache via using F_NORA modifier did
miss the fact that not all loader platforms are using the bcache, and so
it is possible the modifier is not cleared, as bcache strategy function is
not used.

For fix, we make sure the checks are dont with masked flag.

This patch does fix boot for platforms which do not use bcache.

Reported by: emaste
Reviewed by: emaste
Differential Revision: https://reviews.freebsd.org/D10422
17:39:20 - r317096
(5 days 23 hours ago)
by dim
Affects:  /projects/clang500-import/lib/clang/libclang/Makefile
/projects/clang500-import/lib/clang/libllvm/Makefile
/projects/clang500-import/usr.bin/clang/llvm-pdbdump/Makefile
Add new objects to lib/clang/lib{llvm,clang} and usr.bin/clang for the
MK_CLANG_EXTRAS=yes case.
17:20:03 - r317095
(5 days 23 hours ago)
by br
Affects: 
(9 files)
/head/sys/boot/fdt/dts/mips/*
/head/sys/mips/beri/*
/head/sys/mips/conf/std.BERI
Switch BERI Programmable Interrupt Controller to INTRNG.

Sponsored by: DARPA, AFRL
16:27:48 - r317094
(6 days ago)
by jhb
Affects:  /head/share/mk/src.opts.mk
Disable in-tree GDB by default on x86, mips, and powerpc.

GDB in ports contains all of the functionality as GDB in base
(including kgdb) for these platforms along with additional
functionality. In-tree GDB remains enabled on ARM and sparc64.
GDB in ports does not currently support kernel debugging on arm,
and ports GDB for sparc64 has not been tested (though it does
include sparc64 support).

Reviewed by: bdrewery, emaste, imp
Relnotes: yes
Sponsored by: DARPA / AFRL
Differential Revision: https://reviews.freebsd.org/D10399
16:17:38 - r317093
(6 days ago)
by asomers
Affects: 
(2 files)
/stable/10/tests/sys/netinet/fibs_test.sh
MFC r285117

Make cleanup routines idempotent

cleanup routines can be executed at any point during the execution of the
body, including even before the body has done any real work. In those
cases, cleanup routines should be careful to not raise spurious errors so
as to not "override" the actual result of the test case.

This is just general good coding style but is not a problem in practice
for these specific tests. (The way I discovered the issue, though, was
due to a regression I introduced in Kyua itself while refactoring some
internals.)

MFC after: 1 week
15:43:47 - r317092
(6 days 1 hour ago)
by tsoome
Affects:  /head/sys/boot/zfs/zfsimpl.c
loader: zfs reader vdev_probe should check for minimum device size

The smallest device we can have in the pool is 64MB, since we are trying to
walk all four labels to find the most up to date uberblock, this limit will
also give us good method to check if we even should attempt to probe.

Enforcing the check also will make sure we are not getting wrapped while
calculating the label offset.

Also, after label check, we should verify if we actually got any UB or not.

PR: 218473
Reported by: Masachika ISHIZUKA
Reviewed by: allanjude
Differential Revision: https://reviews.freebsd.org/D10381
15:36:13 - r317091
(6 days 1 hour ago)
by pluknet
Affects:  /head/lib/libc/sys/kqueue.2
Document kevent EVFILT_EMPTY.

Reviewed by: hiren
X-MFC with: r312277
10:39:14 - r317090
(6 days 6 hours ago)
by zbb
Affects:  /head/sys/arm/mv/armada38x/armada38x.c
/head/sys/arm/mv/mv_machdep.c
/head/sys/arm/mv/mvreg.h
Optimize Armada38x low-level MBUS settings

Add early init handler, which comprises various internal
bus optimisations for Armada 38x SoC's. Magic values used
due to undocumented registers.

Submitted by: Marcin Wojtas <mw@semihalf.com>,
  Arnaud Ysmal <arnaud.ysmal@stormshield.eu>
Obtained from: Semihalf, Stormshield
Sponsored by: Stormshield
Differential revision: https://reviews.freebsd.org/D10219
10:37:08 - r317089
(6 days 6 hours ago)
by zbb
Affects:  /head/sys/arm/include/pl310.h
Fix bit assignment in PL310_POWER_CTRL

Align to ARM specification:
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0246f/BEIEHICF.html

Submitted by: Marcin Wojtas <mw@semihalf.com>
Obtained from: Semihalf
Sponsored by: Stormshield
Reviewed by: meloun-miracle-cz
Differential revision: https://reviews.freebsd.org/D10223
10:35:30 - r317088
(6 days 6 hours ago)
by zbb
Affects:  /head/sys/arm/conf/ARMADA38X
Add PL310 device in ARMADA38X config

Submitted by: Arnaud Ysmal <arnaud.ysmal@stormshield.eu>
Obtained from: Stormshield
Sponsored by: Stormshield
Differential revision: https://reviews.freebsd.org/D10222
10:34:10 - r317087
(6 days 6 hours ago)
by zbb
Affects:  /head/sys/arm/arm/pl310.c
Execute PL310_ERRATA_727915 only for related revisions

Part of PL310 erratum 727915 in pl310_wbinv_range() was
executed uncoditionally for all possible controllers'
revisions. This patch adds appropriate condition, since
extra operations are required only for revisions between
r2p0 and r3p0.

Submitted by: Marcin Wojtas <mw@semihalf.com>
Obtained from: Semihalf
Sponsored by: Stormshield
Reviewed by: meloun-miracle-cz
Differential revision: https://reviews.freebsd.org/D10221
10:32:21 - r317086
(6 days 6 hours ago)
by zbb
Affects:  /head/sys/arm/mv/armada38x/armada38x_pl310.c
/head/sys/arm/mv/armada38x/files.armada38x
Add PL310 platform initialization for Armada 38x

Introduce machine-dependent part of the arm/pl310 driver for
Armada 38x SoCs. Add prefetch and power savings configuration.

Submitted by: <arnaud.ysmal@stormshield.eu>
Obtained from: Stormshield
Sponsored by: Stormshield
Differential revision: https://reviews.freebsd.org/D10220
10:25:59 - r317085
(6 days 6 hours ago)
by zbb
Affects:  /head/sys/arm/arm/machdep.c
Increase number of L2 tables required for kernel bootstrap

Memory space reserved for pmap_kernel_l2dtable_kva and
pmap_kernel_l2ptp_kva has not been taken into account in
original code. All the memory reserved from kernel space by
pmap_alloc_specials() function called in pmap_bootstrap()
should be mapped initially by initarm(). To create initial
mapping initarm() function reserves proper number of l2 page
tables. However the number of the l2 page tables does not take
into account memory for: pmap_kernel_l2ptp_kva,
pmap_kernel_l2dtable_kva, crashdumpmap, etc.

Submitted by: Grzegorz Bernacki <gjb@semihalf.com>
Obtained from: Semihalf
Sponsored by: Stormshield
Reviewed by: meloun-miracle-cz
Differential revision: https://reviews.freebsd.org/D10217
10:20:42 - r317084
(6 days 6 hours ago)
by zbb
Affects:  /head/sys/arm/conf/ARMADA38X
Reduce kmem_arena maximum size for Armada38x

VM_KMEM_SIZE_MAX allows to limit kmem arena size. In our case this was
necessary, as decreasing size of kmem_arena leaves more space for
kernel_arena.

kernel_arena is pool used for contigmalloc (in effect, DMA) allocations,
which failed on Armada38x. This resulted in 'no memory errors'
(e.g. USB_ERR_NOMEM errors) and failure of whole system. The need for
greater size of kernel_arena probably comes from more peripherals making
use of busdma.

Value used as upper limit is half of the default value
(0x1399a000).

Submitted by: Wojciech Macek <wma@semihalf.com>
Obtained from: Semihalf
Sponsored by: Stormshield
Differential revision: https://reviews.freebsd.org/D10216
09:27:26 - r317083
(6 days 7 hours ago)
by ae
Affects: 
(3 files)
/stable/11/sys/netinet/in.h
/stable/11/sys/netinet/ip_input.c
MFC r316715:
  Make sysctl identifiers for direct netisr queue unique.
  Introduce IPCTL_INTRDQMAXLEN and IPCTL_INTRDQDROPS macros for this purpose.

  Reviewed by: gnn
  Differential Revision: https://reviews.freebsd.org/D10358
09:22:06 - r317082
(6 days 7 hours ago)
by ae
Affects: 
(2 files)
/stable/10/sys/net/if_vlan.c
MFC r316716:
  Inherit IPv6 checksum offloading flags to vlan interfaces.

  if_vlan(4) interfaces inherit IPv4 checksum offloading flags from the
  parent when VLAN_HWCSUM and VLAN_HWTAGGING flags are present on the
  parent interface. Do the same for IPv6 checksum offloading flags.

  Reported by: Harry Schmalzbauer
  Reviewed by: np, gnn
  Differential Revision: https://reviews.freebsd.org/D10356
09:17:20 - r317081
(6 days 7 hours ago)
by ae
Affects: 
(2 files)
/stable/11/sys/net/if_vlan.c
MFC r316716:
  Inherit IPv6 checksum offloading flags to vlan interfaces.

  if_vlan(4) interfaces inherit IPv4 checksum offloading flags from the
  parent when VLAN_HWCSUM and VLAN_HWTAGGING flags are present on the
  parent interface. Do the same for IPv6 checksum offloading flags.

  Reported by: Harry Schmalzbauer
  Reviewed by: np, gnn
  Differential Revision: https://reviews.freebsd.org/D10356
08:04:15 - r317080
(6 days 8 hours ago)
by mav
Affects:  /head/sys/dev/ahci/ahci.c
/head/sys/dev/ahci/ahci.h
/head/sys/dev/ahci/ahci_pci.c
Block FPDMA TRIM for ASMedia HBAs.

Experiments show FPDMA TRIM command timeouts on ASMedia HBAs, while the
same SSDs working fine on Intel HBAs.

MFC after: 2 weeks
07:02:12 - r317079
(6 days 9 hours ago)
by dim
Affects:  /head/contrib/llvm/lib/Target/X86/X86ISelLowering.cpp
/head/contrib/llvm/lib/Target/X86/X86RegisterInfo.td
Pull in r300429 from upstream llvm trunk (by Benjamin Kramer):

  [X86] Remove special handling for 16 bit for A asm constraints.

  Our 16 bit support is assembler-only + the terrible hack that is
  .code16gcc. Simply using 32 bit registers does the right thing for
  the latter.

  Fixes PR32681.

This fixes some cases of assembling 16 bit code (i.e. SeaBIOS) that uses
the 'A' inline asm constraint, after r316989.

MFC after: 3 days
X-MFC-With: r316989
06:58:04 - r317078
(6 days 10 hours ago)
by ganbold
Affects:  /head/sys/arm/allwinner/a10_gpio.h
Remove function declaration that doesn't exist.
03:40:36 - r317077
(6 days 13 hours ago)
by jhibbits
Affects:  /head/etc/rc.d/ldconfig
Add 32-bit caching to ldconfig script for powerpc64

Reported by: ian@

 


Powered by Python FreeBSD support by secnetix GmbH & Co. KG

Page generated in 30 ms, 302 revisions printed. Current time is 2017-04-24 17:01:51. All times are in UTC/GMT.