SVNews

NOTE: This service is experimental and subject to change! Use at your own risk!

Year:   Month: - or - Filter committers: - or -
Filter paths:
Include diffs if smaller than lines.

2016 - 07 - 30   (today)
20:31:12 - r303559
( 3 minutes ago)
by bz
Affects:  /head/sys/dev/pci/pci_pci.c
Try to declare _hw_pci for all sysctl cases needed after r303497.

MFC after: 5 days
X-MFC with: r303497
20:02:08 - r303558
( 32 minutes ago)
by cperciva
Affects: 
(2 files)
/stable/11/release/tools/ec2.conf
MFC r302929: Now that potentially buggy versions of Xen are automatically
detected (see r302635, MFCed as r302895), there is no need to force msix
interrupt migration off via loader.conf.

Reverts: r302184
Approved by: re (gjb)
19:03:32 - r303557
(1 hour 31 minutes ago)
by ivadasz
Affects:  /head/sys/dev/iwm/if_iwm.c
[iwm] Fix iwm_poll_bit() usage in iwm_stop_device(), fixup r303418.

* iwm_poll_bit() returns 1 on success and 0 on failure, whereas
  iwl_poll_bit() in Linux's iwlwifi returns >= 0 on success and < 0 on
  failure.

* Because of the wrong iwm_poll_bit return code check, no warning was
  printed if tx DMA stopping failed.

Approved by: adrian (mentor)
Differential Revision: https://reviews.freebsd.org/D7371
17:53:37 - r303556
(2 hours 41 minutes ago)
by allanjude
Affects:  /head/sys/boot/common/interp_parse.c
Improve boot loader quote parsing

parse() is the boot loader's interp_parse.c is too naive about quotes

both single and double quotes were allowed to be mixed, and single
quotes did not follow the usual semantics (re variable expansion).

The old code did not check for terminating quotes

This update implements:
 * distinguishing single and double quote
 * variable expansion will not be done inside single quote protected area
 * will preserve inner quote for values like "value 'some list'"
 * ending quote check.

this diff does not implement ending quote order check, it shouldn't
be too hard, needs some improvements on parser state machine.

PR: 204602
Submitted by: Toomas Soome <tsoome@me.com>
Relnotes: yes
Differential Revision: https://reviews.freebsd.org/D6000
17:45:56 - r303555
(2 hours 48 minutes ago)
by allanjude
Affects:  /head/sys/boot/common/bcache.c
bcache should support reads shorter than sector size

dosfs (fat file systems) can perform reads of partial sectors
bcache should support such reads.

Submitted by: Toomas Soome <tsoome@me.com>
Reviewed by: cem
Differential Revision: https://reviews.freebsd.org/D6475
15:56:36 - r303554
(4 hours 38 minutes ago)
by mav
Affects:  /head/sys/dev/ntb/ntb_hw/ntb_hw.c
Block MSIX negotiation until SMP started and IRQ reshuffled.
15:51:16 - r303553
(4 hours 43 minutes ago)
by mav
Affects:  /head/sys/dev/ntb/if_ntb/if_ntb.c
Make MAC address generation more random.

'ticks' approach does not work at boot time.
14:47:04 - r303552
(5 hours 47 minutes ago)
by kib
Affects: 
(5 files)
/stable/10/share/man/man9/*
/stable/10/sys/kern/kern_mutex.c
/stable/10/sys/sys/mutex.h
MFC r303211:
Implement mtx_trylock_spin(9).
10:32:28 - r303551
(10 hours 2 minutes ago)
by mav
Affects:  /head/sys/dev/ntb/ntb.c
Fix infinite loops introduced at r303429.
09:46:29 - r303550
(10 hours 48 minutes ago)
by kib
Affects: 
(2 files)
/stable/11/bin/ps/ps.c
MFC r303213:
Add missed required call to xo_finish() when only header is printed.

Approved by: re (gjb)
09:28:13 - r303549
(11 hours 6 minutes ago)
by kib
Affects: 
(5 files)
/stable/11/share/man/man9/*
/stable/11/sys/kern/kern_mutex.c
/stable/11/sys/sys/mutex.h
MFC r303211:
Implement mtx_trylock_spin(9).

Approved by: re (gjb)
09:25:57 - r303548
(11 hours 8 minutes ago)
by kib
Affects:  /head/sys/kern/kern_tc.c
Cache getbintime(9) answer in timehands, similarly to getnanotime(9)
and getmicrotime(9).

Suggested and reviewed by: bde (previous version)
Sponsored by: The FreeBSD Foundation
MFC after: 1 month
07:28:15 - r303547
(13 hours 6 minutes ago)
by araujo
Affects:  /head/usr.bin/indent/indent.c
Use nitems() from sys/param.h.

MFC after: 2 weeks.
Sponsored by: gandi.net (BSD Day Taiwan)
07:15:54 - r303546
(13 hours 19 minutes ago)
by araujo
Affects:  /head/usr.bin/procstat/procstat_files.c
Use nitems() from sys/param.h.

MFC after: 2 weeks.
Sponsored by: gandi.net (BSD Day Taiwan)
07:06:23 - r303545
(13 hours 28 minutes ago)
by araujo
Affects:  /head/usr.bin/netstat/pfkey.c
Use nitems() from sys/param.h.

MFC after: 2 weeks.
Sponsored by: gandi.net (BSD Day Taiwan)
07:05:33 - r303544
(13 hours 29 minutes ago)
by markj
Affects:  /head/sys/cddl/contrib/opensolaris/uts/intel/dtrace/fasttrap_isa.c
Restore an ifdef that should not have been removed in r303535.

X-MFC-With: r303535
07:04:46 - r303543
(13 hours 30 minutes ago)
by araujo
Affects:  /head/usr.bin/locale/locale.c
Use nitems() from sys/param.h.

MFC after: 2 weeks.
Sponsored by: gandi.net (BSD Day Taiwan)
07:02:33 - r303542
(13 hours 32 minutes ago)
by araujo
Affects:  /head/usr.bin/gzip/gzip.c
Use nitems() from sys/param.h.

MFC after: 2 weeks.
Sponsored by: gandi.net (BSD Day Taiwan)
06:35:49 - r303541
(13 hours 59 minutes ago)
by araujo
Affects:  /head/usr.bin/calendar/io.c
Use nitems() from sys/param.h.

Sponsored by: gandi.net (BSD Day Taiwan)
MFC after: 2 weeks.
06:32:18 - r303540
(14 hours 2 minutes ago)
by araujo
Affects:  /head/usr.bin/at/at.c
Use nitems() from sys/param.h

Sponsored by: gandi.net (BSD Day Taiwan)
06:19:34 - r303539
(14 hours 15 minutes ago)
by araujo
Affects:  /head/sbin/fsdb/fsdb.c
Use nitems() from sys/param.h.

Sponsored by: gandi.net (BSD Day Taiwan)
04:40:44 - r303538
(15 hours 54 minutes ago)
by ngie
Affects:  /head/usr.bin/sed/compile.c
Explicitly test for cu_fgets returning NULL or !NULL

MFC after: 3 weeks
Sponsored by: EMC / Isilon Storage Division
03:43:55 - r303537
(16 hours 51 minutes ago)
by markj
Affects:  /head/Makefile.inc1
Add libprocstat prebuild library dependencies.

X-MFC-With: r303531
03:11:54 - r303536
(17 hours 23 minutes ago)
by ache
Affects:  /head/lib/libc/gen/glob.c
Rework r303074 case 4. Don't immediatelly skip directory entries which
cause MAXPATHLEN exceeded. Process them first through gl_errfunc() and
GLOB_ERR.
03:11:53 - r303535
(17 hours 23 minutes ago)
by markj
Affects:  /head/sys/cddl/contrib/opensolaris/uts/common/dtrace/fasttrap.c
/head/sys/cddl/contrib/opensolaris/uts/intel/dtrace/fasttrap_isa.c
Include fasttrap handling for DATAMODEL_ILP32 when compiling for amd64.

MFC after: 1 month
03:09:57 - r303534
(17 hours 24 minutes ago)
by markj
Affects:  /head/cddl/contrib/opensolaris/lib/libdtrace/arm/dt_isadep.c
/head/cddl/contrib/opensolaris/lib/libdtrace/i386/dt_isadep.c
libdtrace: Don't hard-code the native data model.

MFC after: 1 month
03:09:23 - r303533
(17 hours 25 minutes ago)
by markj
Affects: 
(7 files)
/head/lib/libproc/*
/head/share/mk/src.libnames.mk
libproc: Add proc_getmodel().

This is used by libdtrace to determine the data model of target processes.
This allows for the creation of pid provider probes in 32-bit processes on
amd64.

MFC after: 1 month
03:07:14 - r303532
(17 hours 27 minutes ago)
by markj
Affects:  /head/lib/libproc/_libproc.h
Add descriptions for fields in struct proc_handle.

Remove the unused kq field and some unnecessary includes.

MFC after: 1 month
03:05:23 - r303531
(17 hours 29 minutes ago)
by markj
Affects: 
(5 files)
/head/Makefile.inc1
/head/lib/librtld_db/*
/head/share/mk/src.libnames.mk
librtld_db: Use the auxv to figure out where to look up loader symbols.

Previously, librtld_db just hardcoded /libexec/ld-elf.so, which isn't
correct for processes that aren't using the native ABI. With this change,
librtld_db can be used to inspect non-native processes; in particular,
dtrace -c now works for 32-bit executables on amd64.

MFC after: 1 month
02:09:11 - r303530
(18 hours 25 minutes ago)
by ache
Affects:  /head/lib/libc/gen/glob.c
Reset errno for readdirfunc() before contunue.
01:16:06 - r303529
(19 hours 18 minutes ago)
by bapt
Affects:  /head/contrib/libexecinfo/backtrace.c
/head/lib/libc/stdio/dprintf.c
/head/sys/contrib/libnv/nvlist.c
Remove usage of _WITH_DPRINTF
01:13:54 - r303528
(19 hours 21 minutes ago)
by bapt
Affects:  /head/contrib/ofed/usr.lib/libibverbs/config.h
/head/lib/libc/stdio/getline.c
/head/lib/libc/tests/stdio/getdelim_test.c
Remove last traces of _WITH_GETLINE
01:10:05 - r303527
(19 hours 24 minutes ago)
by bapt
Affects: 
(5 files)
/head/usr.sbin/*
Remove usage of _WITH_GETLINE from usr.sbin
01:07:47 - r303526
(19 hours 27 minutes ago)
by bapt
Affects: 
(9 files)
/head/usr.bin/*
Remove usage of _WITH_GETLINE from usr.bin
01:04:18 - r303525
(19 hours 30 minutes ago)
by pfg
Affects:  /head/usr.bin/indent/indent.c
/head/usr.bin/indent/io.c
/head/usr.bin/indent/lexi.c
indent(1): Yet more style issues.

strchr(3) returns a pointer not a boolean.
Attempt to make the style somewhat more ocnsistent with what indent
had before recent changes.

Pointed out by: bde
01:00:16 - r303524
(19 hours 34 minutes ago)
by bapt
Affects:  /head/include/stdio.h
/head/lib/libc/stdio/getline.3
/head/lib/libc/stdio/printf.3
Remove _WITH_GETLINE and _WITH_DPRINTF guards

When adding getline(3) and dprintf(3) into libc, those guards were added
to prevent breaking too many ports.

7 years later the ports tree have been fixed, it is time to remove this
FreeBSDism

While here remove the extra parenthesis surrounding dprintf(3)
2016 - 07 - 29   (yesterday)
23:30:33 - r303523
(21 hours 4 minutes ago)
by pfg
Affects:  /head/usr.bin/indent/indent.c
indent(1): Attempt to preserve some consistent style.

Remove the excessive braces from r303485 and align the comments to the
right as done in the rest of the code. This is not nice but there is no
clear way to make it nice (and KNF).

Pointed out by: bde
22:11:29 - r303522
(22 hours 23 minutes ago)
by jhb
Affects:  /head/sys/dev/cxgbe/t4_main.c
Various fixes to the t4/5nex character device.

- Remove null open/close methods.
- Don't set d_flags to 0 explicitly.
- Remove t5_cdevsw as the .d_name member isn't really used and doesn't
  warrant a separate cdevsw just for the name.
- Use ENOTTY as the error value for an unknown ioctl request.
- Use make_dev_s() to close race with setting si_drv1.

Sponsored by: Chelsio Communications
21:37:00 - r303521
(22 hours 57 minutes ago)
by emaste
Affects:  /head/contrib/llvm/projects/libunwind/src/Unwind-EHABI.cpp
libunwind: correct return code in unwinding trace log message

Obtained from: LLVM r277215
MFC after: 3 days
Sponsored by: The FreeBSD Foundation
21:18:20 - r303520
(23 hours 16 minutes ago)
by vangyzen
Affects:  /head/usr.bin/cpuset/cpuset.1
Fix markup for -j in cpuset(1) synopsis

MFC after: 3 days
Sponsored by: Dell Inc.
21:12:48 - r303519
(23 hours 22 minutes ago)
by vangyzen
Affects:  /head/share/man/man9/bitset.9
/head/share/man/man9/cpuset.9
Fix two return types in the cpuset(9) and bitset(9) man pages

The *_FFS() and *_COUNT() functions return int, not size_t.

MFC after: 3 days
Sponsored by: Dell Inc.
21:11:32 - r303518
(23 hours 23 minutes ago)
by lidl
Affects:  /head/contrib/blacklist/lib/bl.c
libblacklist: Do not use %m for logging, use strerror(errno)

The blacklist library can accept a function to use for logging,
defaulting to vsyslog(), if no function is specified. Make the
blacklist library use strerror(errno) explicitly, instead of %m,
so that the passed in function does not need to support the
syslog specific placeholder.

This matches a change already submitted and accepted upstream.

MFC after: 1 week
Sponsored by: The FreeBSD Foundation
21:07:17 - r303517
(23 hours 27 minutes ago)
by markj
Affects: 
(26 files)
/user/alc/PQ_LAUNDRY/*
MFH r303516
21:05:37 - r303516
(23 hours 29 minutes ago)
by markj
Affects:  /head/sys/vm/vm_page.c
Use vm_page_undirty() instead of manually setting a page field.

Reviewed by: alc
MFC after: 3 days
21:05:17 - r303515
(23 hours 29 minutes ago)
by lidl
Affects:  /head/usr.bin/resizewin/resizewin.1
Make resizewin.1 manpage use .Fx macro

Fix capitalization of "PuTTY" also.

MFC after: 1 week
21:03:30 - r303514
(23 hours 31 minutes ago)
by mav
Affects:  /head/sys/dev/ntb/ntb_transport.c
Fix NTBT_QP_LINKS negotiation.

I believe it never worked correctly for more the one queue even in Linux.
This fixes case when one of consumer drivers is not loaded on one side,
but its queues still announced as ready if something else brought link up.

While there, remove some pointless NULL checks.
21:03:02 - r303513
(23 hours 31 minutes ago)
by markj
Affects:  /head/sys/ofed/drivers/infiniband/ulp/sdp/sdp_main.c
sdp: Destroy the RDMA ID after destroying the connection's queue pair.

This is the ordering documented by rdma_destroy_qp(). Also add a useful
KASSERT to sdp_pcbfree().

Sponsored by: EMC / Isilon Storage Division
21:01:04 - r303512
(23 hours 33 minutes ago)
by markj
Affects: 
(4 files)
/head/sys/ofed/drivers/infiniband/ulp/sdp/*
sdp: Use malloc(9) instead of the Linux compat layer.

SDP transmit and receive rings are always created in a sleepable context,
so we can use M_WAITOK and remove error checks.

Sponsored by: EMC / Isilon Storage Division
20:54:43 - r303511
(23 hours 40 minutes ago)
by markj
Affects:  /head/sys/ofed/drivers/infiniband/ulp/sdp/sdp_rx.c
sdp: Use the correct socket buffer in sdp_post_recvs_needed().

Sponsored by: EMC / Isilon Storage Division
20:52:18 - r303510
(23 hours 42 minutes ago)
by mav
Affects:  /head/sys/dev/ntb/ntb_hw/ntb_hw.c
Clear scratchpad after MSIX negotiation to not leak garbage.
20:51:52 - r303509
(23 hours 43 minutes ago)
by markj
Affects:  /head/sys/ofed/drivers/infiniband/ulp/sdp/sdp_rx.c
sdp: Always free received control packets after they're handled.

Sponsored by: EMC / Isilon Storage Division
20:48:42 - r303508
(23 hours 46 minutes ago)
by markj
Affects:  /head/sys/ofed/drivers/infiniband/ulp/sdp/sdp_rx.c
Fix the KASSERT format string arguments after r303507.
20:39:32 - r303507
(23 hours 55 minutes ago)
by markj
Affects:  /head/sys/ofed/drivers/infiniband/ulp/sdp/sdp_rx.c
sdp: Use the PCB as the rx completion handler argument.

The generic socket may be detached from the PCB before the completion
queue is drained and destroyed, so this change closes a race condition
in connection teardown.

Sponsored by: EMC / Isilon Storage Division
20:36:01 - r303506
(23 hours 58 minutes ago)
by markj
Affects:  /head/sys/ofed/drivers/infiniband/ulp/sdp/sdp_main.c
sdp: Destroy the PCB lock before freeing to the zone.

Sponsored by: EMC / Isilon Storage Division
20:35:04 - r303505
(23 hours 59 minutes ago)
by markj
Affects:  /head/sys/ofed/drivers/infiniband/ulp/sdp/sdp.h
/head/sys/ofed/drivers/infiniband/ulp/sdp/sdp_main.c
/head/sys/ofed/drivers/infiniband/ulp/sdp/sdp_rx.c
sdp: Use an mbufq for received control packets.

This is simpler than the hand-rolled queue, and fixes a use-after-free.

Sponsored by: EMC / Isilon Storage Division
20:33:43 - r303504
(1 day ago)
by markj
Affects:  /head/sys/ofed/drivers/infiniband/ulp/sdp/Kconfig
/head/sys/ofed/drivers/infiniband/ulp/sdp/Makefile
sdp: Remove Linux build files.

They aren't useful here, and Linux seems to have largely abandoned SDP
anyway.

Sponsored by: EMC / Isilon Storage Division
20:19:14 - r303503
(1 day ago)
by jhb
Affects:  /head/sys/kern/sched_4bsd.c
Don't treat NOCPU as a valid CPU to CPU_ISSET.

If a thread is created bound to a cpuset it might already be bound before
it's very first timeslice, and td_lastcpu will be NOCPU in that case.

MFC after: 1 week
19:36:10 - r303502
(1 day ago)
by pfg
Affects: 
(5 files)
/head/usr.bin/indent/*
indent(1): Use NULL instead of zero for pointers.
18:26:15 - r303501
(1 day 2 hours ago)
by jhb
Affects:  /head/sys/kern/vfs_aio.c
/head/tests/sys/aio/aio_test.c
Fix locking issues with aio_fsync().

- Use correct lock in aio_cancel_sync when dequeueing job.
- Add _locked variants of aio_set/clear_cancel_function and use those
  to avoid lock recursion when adding and removing fsync jobs to the
  per-process sync queue.
- While here, add a basic test for aio_fsync().

PR: 211390
Reported by: Randy Westlund <rwestlun@gmail.com>
MFC after: 1 week
Sponsored by: Chelsio Communications
Differential Revision: https://reviews.freebsd.org/D7339
18:12:56 - r303500
(1 day 2 hours ago)
by markj
Affects: 
(9009 files)
/user/alc/PG_CACHED/*
Merge from PQ_LAUNDRY at r303496
18:00:10 - r303499
(1 day 2 hours ago)
by pfg
Affects:  /head/usr.bin/indent/lexi.c
indent(1): Support "f" and "F" floating constant suffixes.

Actually this just brings back r303487 with the correct commit log.

Differential Revision: https://reviews.freebsd.org/D6966 (Partial)
Obtained from: Piotr Stefaniak
17:55:38 - r303498
(1 day 2 hours ago)
by pfg
Affects:  /head/usr.bin/indent/lexi.c
Revert r303487: Wrong commit log.

Will be brought back with the correct log.
17:54:21 - r303497
(1 day 2 hours ago)
by jhb
Affects:  /head/sys/dev/pci/pci_pci.c
Add a loader tunable (hw.pci.enable_pcie_hp) to disable PCI-e HotPlug.

Some systems and/or devices (such as riser cards) do not include a
non-compliant implementation of PCI-e HotPlug that can result in devices
not being attached (e.g. the HotPlug code might assume that a card is
being unplugged and will power the slot off and detach it). This
tunable can be set to 0 to disable support for PCI-e HotPlug ignoring
the incorrect HotPlug state on these slots.

PR: 211081
Reported by: Sergey Renkas <serg_ic@mail.ru> (SuperMicro X7 riser card)
Reported by: Jeffrey E Pieper <jeffrey.e.pieper@intel.com>
  (Intel X520 adapter)
MFC after: 1 week
Relnotes: yes
17:28:14 - r303496
(1 day 3 hours ago)
by markj
Affects:  /user/alc/PQ_LAUNDRY/sys/vm/vm_pageout.c
Remove a redundant variable for the target number of laundry cycles.

Suggested by: alc
17:18:47 - r303495
(1 day 3 hours ago)
by ed
Affects:  /head/include/xlocale/_locale.h
/head/lib/libc/locale/freelocale.3
/head/lib/libc/locale/xlocale.c
Change the return type of freelocale(3) to void.

Our version of this function currently returns an integer indicating
failure or success, whereas POSIX specifies that this function has no
return value. It returns void. Patch up the header, sources and man page
to use the right type. While there, use the opportunity to simplify the
body of this function.

Theoretically speaking, this change breaks the ABI of this function.
That said, I have yet to find any code that makes use of freelocale()'s
return value. I couldn't find any of it in the base system, nor did an
exp-run reveal any breakage caused by this change.

PR: 211394 (exp-run)
17:15:41 - r303494
(1 day 3 hours ago)
by mav
Affects: 
(5 files)
/head/share/man/man4/*
/head/sys/dev/ntb/*
Once more refactor KPI between ntb_transport(4) and if_ntb(4)..

New design allows to attach multiple consumers to ntb_transport(4) instance.
Previous design obtained from Linux theoretically allowed that, but was not
practically usable (Linux also has only one consumer driver now).
17:12:31 - r303493
(1 day 3 hours ago)
by alc
Affects: 
(143 files)
/user/alc/PQ_LAUNDRY/*
MFH r303468
16:43:51 - r303492
(1 day 3 hours ago)
by alc
Affects:  /head/sys/vm/vm_pageout.c
Remove a probe declaration that has been unused since r292469, when
vm_pageout_grow_cache() was replaced.

MFC after: 3 days
16:35:58 - r303491
(1 day 3 hours ago)
by royger
Affects:  /head/sys/x86/x86/intr_machdep.c
Revert r291022: x86/intr: allow mutex recursion in intr_remove_handler

This was only needed for Xen, and a better way to deal with this issue has
been found, so this commit can be reverted.

Sponsored by: Citrix Systems R&D
MFC after: 5 days
Reviewed by: kib
Differential revision: https://reviews.freebsd.org/D7363
16:34:54 - r303490
(1 day 4 hours ago)
by royger
Affects:  /head/sys/x86/xen/xen_intr.c
xen-intr: fix removal of event channels during resume

Event channel handlers cannot be removed during resume because there might
be an interrupt thread running on a CPU currently blocked in the
cpususpend_handler, which prevents the call to intr_remove_handler from
finishing and completely freezes the system during resume. r291022 tried to
fix this by allowing recursion in intr_remove_handler, but that's clearly
not enough.

Instead don't remove the handlers at the interrupt resume phase, and let
each driver remove the handler by itself during resume. In order to do this,
change the opaque event channel handler cookie to use the global interrupt
vector instead of the event channel port. The event channel port cannot be
used because after resume all event channels are reset, and the port numbers
can change.

Sponsored by: Citrix Systems R&D
MFC after: 5 days
16:34:16 - r303489
(1 day 4 hours ago)
by pfg
Affects:  /head/usr.bin/indent/io.c
indent(1): Removed whitespace shouldn't be considered in column calculations.

This piece of code removed tabs and space characters from after colons
that follow labels by decrementing the e_lab (end of label) "pointer"
which is later used to calculate the width of the string that fprintf()
puts into "output". But pad_output() gets the length from the actual
string, so it miscalculated what the current column is.

Fixed by putting a string terminator at the e_lab "pointer".

Differential Revision: https://reviews.freebsd.org/D6966
(Partial)
Obtained from: Piotr Stefaniak
16:33:45 - r303488
(1 day 4 hours ago)
by royger
Affects:  /head/sys/dev/xen/netfront/netfront.c
xen-netfront: fix trying to send packets with disconnected netfront

In certain circumstances xn_txq_mq_start might be called with num_queues ==
0 during the resume phase after a migration, which can trigger a KASSERT.
Fix this by making sure the carrier is on before trying to transmit, or else
return that the queues are full.

Just as a note, I haven't been able to reproduce this crash on my test
systems, but I still think it's possible and worth fixing.

Reported by: Karl Pielorz <kpielorz_lst@tdx.co.uk>
Sponsored by: Citrix Systems R&D
MFC after: 5 days
Reviewed by: Wei Liu <wei.liu2@citrix.com>
Differential revision: https://reviews.freebsd.org/D7349
16:28:51 - r303487
(1 day 4 hours ago)
by pfg
Affects:  /head/usr.bin/indent/lexi.c
indent(1): fix struct termination detection.

Small style cleanup while here.

Differential Revision: https://reviews.freebsd.org/D6966 (Partial)
Obtained from: Piotr Stefaniak
16:25:09 - r303486
(1 day 4 hours ago)
by ed
Affects:  /head/lib/libc/gen/basename.3
/head/lib/libc/gen/dirname.3
Mention that basename(3) and dirname(3) will change in the future.

Update the existing manual pages for basename(3) and dirname(3) to
mention that in future versions of FreeBSD, these functions will no
longer use internal buffers for storing the results.

MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D7356
16:23:00 - r303485
(1 day 4 hours ago)
by pfg
Affects:  /head/usr.bin/indent/indent.c
indent(1): fix struct termination detection.

Semicolons inside struct declarations don't end the declarations.

Differential Revision: https://reviews.freebsd.org/D6966 (Partial)
Obtained from: Piotr Stefaniak
16:17:54 - r303484
(1 day 4 hours ago)
by pfg
Affects:  /head/usr.bin/indent/indent.c
indent(1): Fix breakage caused by single comment following "else".

indent(1) simply wasn't taught that "else" may be followed by a comment
without any opening brace anywhere on the line, so it was very confused
in such cases.

Differential Revision: https://reviews.freebsd.org/D6966 (Partial)
Obtained from: Piotr Stefaniak
16:14:03 - r303483
(1 day 4 hours ago)
by pfg
Affects:  /head/usr.bin/indent/indent_globs.h
indent(1): Avoid potential use-after-free.

last_bl is a char pointer that tracks the last blank character in a
comment, which is used for wrapping long comment lines. Since the
underlying array may be reallocated, make sure last_bl is up to date when
that happens.

Differential Revision: https://reviews.freebsd.org/D6966 (Partial)
Obtained from: Piotr Stefaniak
16:09:05 - r303482
(1 day 4 hours ago)
by pfg
Affects:  /head/usr.bin/indent/indent.c
indent(1): Avoid out of bound access of array codebuf.

dump_line() requires s_code to be a string, because it will call count_spaces().

Differential Revision: https://reviews.freebsd.org/D6966 (Partial)
Obtained from: Piotr Stefaniak
15:24:50 - r303481
(1 day 5 hours ago)
by imp
Affects:  /head/sys/conf/files
Fix typo.
12:30:33 - r303480
(1 day 8 hours ago)
by br
Affects:  /head/sys/modules/dtrace/Makefile
/head/sys/modules/dtrace/dtraceall/dtraceall.c
Include FBT to modules build on RISC-V.
12:29:17 - r303479
(1 day 8 hours ago)
by br
Affects:  /head/sys/cddl/dev/fbt/riscv/fbt_isa.c
Remove unused variables.
12:15:55 - r303478
(1 day 8 hours ago)
by trasz
Affects:  /head/sys/fs/autofs/autofs_vnops.c
Remove write-only variable.

MFC after: 1 month
11:33:23 - r303477
(1 day 9 hours ago)
by trasz
Affects:  /head/sys/dev/usb/usb_device.c
Improve error message.

MFC after: 1 month
11:33:01 - r303476
(1 day 9 hours ago)
by trasz
Affects:  /head/sys/dev/usb/template/usb_template_mtp.c
Fix MTP description in the comment.

MFC after: 1 month
08:50:36 - r303475
(1 day 11 hours ago)
by andrew
Affects:  /head/sys/arm64/conf/GENERIC
/head/sys/conf/files.arm64
/head/sys/dev/usb/controller/generic_ehci.c
Add a generic EHCI USB driver based on the Allwinner A10 driver. It is ACPI
only for now, but wouldn't be too difficult to add support for FDT.

Reviewed by: hselasky
Obtained from: ABT Systems Ltd
MFC after: 1 month
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D7352
06:22:11 - r303474
(1 day 14 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c
hyperv/storvsc: Use busdma(9) and enable PIM_UNMAPPED by default.

The UNMAPPED I/O greatly improves userland direct disk I/O performance
by 35% ~ 135%.

Submitted by: Hongjiang Zhang <honzhan microsoft com>
MFC after: 1 week
Sponsored by: Microsoft
Differential Revision: https://reviews.freebsd.org/D7195
06:10:27 - r303473
(1 day 14 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/vmbus/vmbus.c
/head/sys/dev/hyperv/vmbus/vmbus_var.h
hyperv/vmbus: Revoke unnecessary exposure of vmbus softc

MFC after: 1 week
Sponsored by: Microsoft
Differential Revision: https://reviews.freebsd.org/D7348
05:58:24 - r303472
(1 day 14 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/vmbus/vmbus.c
/head/sys/dev/hyperv/vmbus/vmbus_et.c
hyperv/vmbus: Move driver glue to the beginning of the files

Just as most of other drivers do. And move sysinit function close
to its SYSINIT.

MFC after: 1 week
Sponsored by: Microsoft
Differential Revision: https://reviews.freebsd.org/D7347
05:49:12 - r303471
(1 day 14 hours ago)
by sephe
Affects: 
(5 files)
/head/sys/dev/hyperv/vmbus/*
hyperv/vmbus: Forward declare static functions

MFC after: 1 week
Sponsored by: Microsoft
Differential Revision: https://reviews.freebsd.org/D7346
03:16:51 - r303470
(1 day 17 hours ago)
by sephe
Affects: 
(5 files)
/head/sys/dev/hyperv/include/*
/head/sys/dev/hyperv/vmbus/*
hyperv/vmbus: Reindent function declarations.

MFC after: 1 week
Sponsored by: Microsoft
Differential Revision: https://reviews.freebsd.org/D7344
00:00:54 - r303469
(1 day 20 hours ago)
by gjb
Affects:  /stable/11/sys/conf/newvers.sh
Update stable/11 to BETA3 as part of the 11.0-RELEASE cycle.

Approved by: re (implicit)
Sponsored by: The FreeBSD Foundation
2016 - 07 - 28   (2 days ago)
22:55:21 - r303468
(1 day 21 hours ago)
by imp
Affects: 
(6 files)
/head/sys/cam/*
/head/sys/conf/files
Move protocol specific stuff into a linker set object that's
per-protocol. This reduces the number scsi symbols references by
cam_xpt significantly, and eliminates all ata / nvme symbols. There's
still some NVME / ATA specific code for dealing with XPT_NVME_IO and
XPT_ATA_IO respectively, and a bunch of scsi-specific code, but this
is progress.

Differential Revision: https://reviews.freebsd.org/D7289
22:55:14 - r303467
(1 day 21 hours ago)
by imp
Affects: 
(5 files)
/head/sys/cam/*
Switch to linker sets to find the xport callback object. This
eliminates the need to special case everything in cam_xpt for new
transports. It is now a failure to not have a transport object when
registering the bus as well. You can still, however, create a
transport that's unspecified (XPT_)

Differential Revision: https://reviews.freebsd.org/D7289
22:40:31 - r303466
(1 day 21 hours ago)
by imp
Affects:  /head/sys/dev/nvme/nvme_sim.c
Kill a few stray debug printfs.
22:30:48 - r303465
(1 day 22 hours ago)
by alc
Affects:  /head/sys/vm/vm_pageout.c
Remove any mention of cache (PG_CACHE) pages from the comments in
vm_pageout_scan(). That function has not cached pages since r284376.

MFC after: 3 days
21:29:04 - r303464
(1 day 23 hours ago)
by brooks
Affects: 
(7 files)
/head/sys/*
Don't create pointless backups of generated files in "make sysent".

Any sensible workflow will include a revision control system from which
to restore the old files if required. In normal usage, developers just
have to clean up the mess.

Reviewed by: jhb
Sponsored by: DARPA, AFRL
Differential Revision: https://reviews.freebsd.org/D7353
21:27:47 - r303463
(1 day 23 hours ago)
by brooks
Affects:  /head/sys/modules/Makefile
cxgbe's firmware module fails to build on mips64 as well as mips32 so
disable for all mips.

Sponsored by: DARPA, AFRL
21:16:18 - r303462
(1 day 23 hours ago)
by jhb
Affects: 
(2 files)
/stable/11/share/man/man4/aio.4
MFC 303202: Update to note that operations on local files are safe.

Approved by: re (gjb)
20:51:29 - r303461
(1 day 23 hours ago)
by jhb
Affects:  /head/lib/libc/sys/ptrace.2
Note that not all optional ptrace events use SIGTRAP.

New child processes attached due to PTRACE_FORK use SIGSTOP instead of
SIGTRAP. All other ptrace events use SIGTRAP.
20:31:30 - r303460
(2 days ago)
by jhb
Affects: 
(7 files)
/stable/11/lib/libc/sys/*
/stable/11/share/man/man4/aio.4
/stable/11/sys/kern/vfs_aio.c
MFC 303164: Add more documentation regarding unsafe AIO requests.

The asynchronous I/O changes made previously result in different
behavior out of the box. Previously all AIO requests failed with
ENOSYS / SIGSYS unless aio.ko was explicitly loaded. Now, some AIO
requests complete and others ("unsafe" requests) fail with EOPNOTSUPP.

Reword the introductory paragraph in aio(4) to add a general
description of AIO before describing the vfs.aio.enable_unsafe sysctl.

Remove the ENOSYS error description from aio_fsync(2), aio_read(2),
and aio_write(2) and replace it with a description of EOPNOTSUPP.

Remove the ENOSYS error description from aio_mlock(2).

Log a message to the system log the first time a process requests an
"unsafe" AIO request that fails with EOPNOTSUPP. This is modeled on
the log message used for processes using the legacy pty devices.

Approved by: re (gjb)
20:11:34 - r303459
(2 days ago)
by sbruno
Affects: 
(2 files)
/stable/10/sys/netinet6/icmp6.c
MFC r299829
Use Node Information flag names instead of hard-coding their values.
20:08:01 - r303458
(2 days ago)
by sbruno
Affects: 
(6 files)
/stable/10/sys/netinet6/*
MFC r296063 r297397 r299213

296063:
Lock the NDP default router list and count defrouter references.

This addresses a number of race conditions that can cause crashes as a
result of unsynchronized access to the list.

297397
Modify nd6_llinfo_timer() to acquire the nd6 lock before the LLE lock.

When expiring a neighbour cache entry we may need to look up the associated
default router, which requires the nd6 read lock. To avoid an LOR, the nd6
lock should be acquired first.

299213
Clean up callers of nd6_prelist_add().

nd6_prelist_add() sets *newp if and only if it is successful, so there's no
need for code that handles the case where the return value is 0 and
*newp == NULL. Fix some style bugs in nd6_prelist_add() while here.

Submitted by: Jason Wolfe <j@nitrology.com>
19:32:25 - r303457
(2 days 1 hour ago)
by gallatin
Affects:  /head/sys/netinet/tcp_subr.c
Call tcp_notify() directly to shoot down routes, rather than
calling in_pcbnotifyall().

This avoids lock contention on tcbinfo due to in_pcbnotifyall()
holding the tcbinfo write lock while walking all connections.

Reviewed by: rrs, karels
MFC after: 2 weeks
Sponsored by: Netflix, Inc.
Differential Revision: https://reviews.freebsd.org/D7251
18:40:43 - r303456
(2 days 1 hour ago)
by dim
Affects:  /head/ObsoleteFiles.inc
Add tblgen to ObsoleteFiles.inc, as it was renamed to llvm-tblgen.

Noticed by: pluknet
MFC after: 3 days
18:39:30 - r303455
(2 days 1 hour ago)
by stevek
Affects:  /head/sys/netinet/in_prot.c
/head/sys/sys/proc.h
/head/sys/sys/systm.h
Remove BSD and USL copyright and update license block in in_prot.c, as the
code in this file was written by Robert N. M. Waston.

Move cr_can* prototypes from sys/systm.h to sys/proc.h

Reported by: rwatson
Reviewed by: rwatson
Approved by: sjg (mentor)
Differential Revision: https://reviews.freebsd.org/D7345
17:37:12 - r303454
(2 days 2 hours ago)
by jhb
Affects:  /head/sys/dev/cxgbe/t4_sge.c
Mark spg_len and fl_pktshift static.

These variables are no longer exported to t4_netmap.c after r296478.
17:18:02 - r303453
(2 days 3 hours ago)
by br
Affects:  /head/share/mk/bsd.sys.mk
/head/sys/conf/kern.mk
Normalise the CWARNFLAGS inter-word spacing: remove all leading
and trailing space, and convert multiple consecutive spaces to
single space.

This helps to keep build output looking good.
16:54:12 - r303452
(2 days 3 hours ago)
by pfg
Affects:  /head/usr.bin/indent/indent.c
indent: avoid calling write(2) with a negative second parameter.

negative_returns: n is passed to a parameter that cannot be negative.
Fix a style issue while here.

CID: 1008107
16:20:27 - r303451
(2 days 4 hours ago)
by ed
Affects: 
(5 files)
/head/include/libgen.h
/head/lib/libc/gen/*
Fix up prototypes of basename(3) and dirname(3) to comply to POSIX.

POSIX allows these functions to be implemented in a way that the
resulting string is stored in the input buffer. Though some may find
this annoying, this has the advantage that it makes it possible to
implement this function in a thread-safe way. It also means that they
can be implemented in a way that they work for paths of arbitrary
length, as the output string of these functions is never longer than
max(1, len(input)).

Portable code already needs to be written with this in mind, so in my
opinion it makes very little sense to allow the existing behaviour.
Prevent the base system from falling back to this by switching over to
POSIX prototypes.

I'm not going to bump the __FreeBSD_version for this. The reason is that
it's possible to account for this change in a portable way, without
depending on a specific version of FreeBSD. An exp-run was done some
time ago. As far as I know, all regressions as a result of this have
already been fixed.

I'll give this change some time to settle. In the long run I want to
replace our copies by ones that are thread-safe and don't depend on
PATH_MAX/MAXPATHLEN.
16:06:37 - r303450
(2 days 4 hours ago)
by ed
Affects:  /head/usr.bin/xinstall/xinstall.c
Pull a copy of the input string before calling basename() and dirname().

POSIX allows implementations of these functions to modify their input.
16:02:30 - r303449
(2 days 4 hours ago)
by ed
Affects:  /head/usr.sbin/newsyslog/newsyslog.c
Clean up use of basename() and dirname().

Pull copies of the input pathname string before calling basename() and
dirname() to make this comply to POSIX. Free these copies at the end of
this function. While there, remove the duplication of the 's' ->
'logfname' string. There is no need for this.
15:57:01 - r303448
(2 days 4 hours ago)
by kib
Affects:  /head/sys/vm/swap_pager.c
Do not delegate a work to geom event thread which can be done inline.

In particular, swapongeom_ev() needed event thread context when swap
pager configuration was performed under Giant and geom asserted that
Giant is not owned. Now both of the reason went away.

On the other hand, note that swpageom_release() is called from the
bio_done context, and possible close cannot be performed inline.

Also fix some minor issues. The swapgeom() function does not use the
td argument, remove it. Recheck that the vnode passed is still VCHR
and not reclaimed after the lock.

Reviewed by: mav
Tested by: pho
Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks
15:54:17 - r303447
(2 days 4 hours ago)
by robak
Affects: 
(5 files)
/stable/11/usr.sbin/bsdinstall/scripts/*
MFC r302897:

Add new System Hardening menu and options to bsdinstall.

This patch add new 'hardening' file responsible for new bsdinstall
'System Hardening' menu allowing users to set some sane and carefully
picked system security options (like random process id's, hiding
other users/groups processes and others).

All options are OFF by default in this patch due to POLA principle
with intention to turn change some of them to ON by default in future.

Reviewed by: adrian, allanjude, bdrewery, nwhitehorn
Approved by: re@, adrian, allanjude
15:49:51 - r303446
(2 days 4 hours ago)
by kib
Affects:  /head/sys/vm/swap_pager.c
Fix style and typo.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week
15:33:19 - r303445
(2 days 5 hours ago)
by ed
Affects:  /head/usr.sbin/uathload/uathload.c
Call basename() and dirname() in the POSIXly correct way.

Pull copies of the input string, as these functions are allowed to
modify them. Free the copies after creating the new pathname string.
15:19:47 - r303444
(2 days 5 hours ago)
by ed
Affects:  /head/usr.bin/grep/util.c
Call basename() in a portable way.

Pull a copy of the filename string before calling basename(). Change the
loop to not return on its own, so we can put a free() statement at the
bottom.
15:17:12 - r303443
(2 days 5 hours ago)
by ed
Affects:  /head/usr.bin/sed/main.c
Don't call basename() and dirname() in an unportable way.

POSIX allows these functions to modify their input buffer, so that they
have storage for the return value. Pull copies of the filename before
calling these utility functions.
13:54:46 - r303442
(2 days 6 hours ago)
by emaste
Affects: 
(12 files)
/head/sys/conf/*
remove CONSTRUCTORS from kernel linker scripts

The linker script CONSTRUCTORS keyword is only meaningful "when linking
object file formats which do not support arbitrary sections, such as
ECOFF and XCOFF"[1] and is ignored for other object file formats.

LLVM's lld does not yet accept (and ignore) CONSTRUCTORS, so just remove
CONSTRUCTORS from the linker scripts as it has no effect.

[1] https://sourceware.org/binutils/docs/ld/Output-Section-Keywords.html

Reviewed by: kib
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D7343
13:35:46 - r303441
(2 days 6 hours ago)
by emaste
Affects:  /head/share/man/man5/src.conf.5
Regenerate src.conf.5 after r303394
13:21:45 - r303440
(2 days 7 hours ago)
by br
Affects:  /head/sys/modules/i2c/iicbb/Makefile
/head/sys/modules/uart/Makefile
Build ofw_bus_if.h for modules for RISC-V.
13:18:10 - r303439
(2 days 7 hours ago)
by br
Affects:  /head/sys/modules/dtrace/dtrace/Makefile
Build DTrace assym.o with -msoft-float flag for RISC-V so we have
correct flag in ELF file.

Sponsored by: DARPA, AFRL
Sponsored by: HEIF5
13:15:23 - r303438
(2 days 7 hours ago)
by br
Affects:  /head/sys/conf/kern.mk
o Add warn flags required to build modules with GCC 6.1;
o Sort GCC 4.8 warn flags.

Sponsored by: DARPA, AFRL
Sponsored by: HEIF5
12:25:58 - r303437
(2 days 8 hours ago)
by mav
Affects:  /head/sys/dev/ntb/ntb.c
Fix r303429 build with invariants.
12:22:34 - r303436
(2 days 8 hours ago)
by ed
Affects: 
(6 files)
/head/sys/kern/*
/head/sys/sys/*
Regenerate system call table for r303435.
12:22:01 - r303435
(2 days 8 hours ago)
by ed
Affects:  /head/lib/libc/sys/msgrcv.2
/head/sys/kern/syscalls.master
/head/sys/sys/msg.h
Change the return type of msgrcv() to ssize_t as required by POSIX.

It looks like the msgrcv() system call is already written in such a way
that the size is internally computed as a size_t and written into all of
td_retval[0]. This means that it is effectively already returning
ssize_t. It's just that the userspace prototype doesn't match up.
12:06:40 - r303434
(2 days 8 hours ago)
by kib
Affects: 
(2 files)
/stable/11/sys/kern/vfs_aio.c
MFC r303154:
Declare aio requests on files from local filesystems safe.

Approved by: re (gjb)
11:51:20 - r303433
(2 days 8 hours ago)
by kib
Affects: 
(4 files)
/stable/10/sys/dev/pty/pty.c
/stable/10/sys/kern/subr_prf.c
/stable/10/sys/sys/systm.h
MFC r303151:
Provide counter_warning(9) KPI.

MFC r303155:
Hide counted_warning(9) under #ifdef _KERNEL braces.
11:43:25 - r303432
(2 days 8 hours ago)
by kib
Affects: 
(4 files)
/stable/11/sys/dev/pty/pty.c
/stable/11/sys/kern/subr_prf.c
/stable/11/sys/sys/systm.h
MFC r303151:
Provide counter_warning(9) KPI.

MFC r303155:
Hide counted_warning(9) under #ifdef _KERNEL braces.

Approved by: re (gjb)
11:10:13 - r303431
(2 days 9 hours ago)
by pho
Affects:  /user/pho/stress2/misc/ptrace5.sh
/user/pho/stress2/misc/ptrace6.sh
/user/pho/stress2/misc/ptrace7.sh
Added regression tests.

Sponsored by: EMC / Isilon Storage Division
11:05:26 - r303430
(2 days 9 hours ago)
by pho
Affects:  /user/pho/stress2/misc/ptrace10.sh
/user/pho/stress2/misc/ptrace9.sh
Added two regression tests.

Submitted by: markj
Sponsored by: EMC / Isilon Storage Division
10:48:20 - r303429
(2 days 9 hours ago)
by mav
Affects: 
(6 files)
/head/share/man/man4/ntb_hw.4
/head/sys/dev/ntb/*
Once more refactor KPI between NTB hardware and consumers.

New design allows hardware resources to be split between several consumers.
For example, one BAR can be dedicated for remote memory access, while other
resources can be used for packet transport for virtual Ethernet interface.
And even without resource split, this code allows to specify which consumer
driver should attach the hardware.

From some points this makes the code even closer to Linux one, even though
Linux does not provide the described flexibility.
10:05:41 - r303428
(2 days 10 hours ago)
by ed
Affects:  /head/include/netdb.h
/head/lib/libc/net/getnameinfo.3
/head/lib/libc/net/getnameinfo.c
Add NI_NUMERICSCOPE.

POSIX also declares NI_NUMERICSCOPE, which makes getnameinfo() return a
numerical scope identifier. The interesting thing is that support for
this is already present in code, but #ifdef disabled. Expose this
functionality by placing a definition for it in <netdb.h>.

While there, remove references to NI_WITHSCOPEID, as that got removed 11
years ago.
09:50:19 - r303427
(2 days 10 hours ago)
by ed
Affects:  /head/include/stdlib.h
/head/include/xlocale/_stdlib.h
Change type of MB_CUR_MAX and MB_CUR_MAX_L() to size_t.

POSIX requires that MB_CUR_MAX expands to an expression of type size_t.
It currently expands to an int. As these are already macros, don't
change the underlying type of these functions. There is no ned to touch
those.

Differential Revision: https://reviews.freebsd.org/D6645
09:09:55 - r303426
(2 days 11 hours ago)
by kib
Affects: 
(4 files)
/head/sys/ddb/db_ps.c
/head/sys/kern/*
/head/sys/sys/proc.h
Rewrite subr_sleepqueue.c use of callouts to not depend on the
specifics of callout KPI. Esp., do not depend on the exact interface
of callout_stop(9) return values.

The main change is that instead of requiring precise callouts, code
maintains absolute time to wake up. Callouts now should ensure that a
wake occurs at the requested moment, but we can tolerate both run-away
callout, and callout_stop(9) lying about running callout either way.

As consequence, it removes the constant source of the bugs where
sleepq_check_timeout() causes uninterruptible thread state where the
thread is detached from CPU, see e.g. r234952 and r296320.

Patch also removes dual meaning of the TDF_TIMEOUT flag, making code
(IMO much) simpler to reason about.

Tested by: pho
Reviewed by: jhb
Sponsored by: The FreeBSD Foundation
MFC after: 1 month
Differential revision: https://reviews.freebsd.org/D7137
08:57:01 - r303425
(2 days 11 hours ago)
by kib
Affects: 
(4 files)
/head/share/man/man9/*
/head/sys/kern/kern_timeout.c
/head/sys/sys/callout.h
Extract the calculation of the callout fire time into the new function
callout_when(9). See the man page update for the description of the
intended use.

Tested by: pho
Reviewed by: jhb, bjk (man page updates)
Sponsored by: The FreeBSD Foundation
MFC after: 1 month
X-Differential revision: https://reviews.freebsd.org/D7137
08:53:38 - r303424
(2 days 11 hours ago)
by kib
Affects:  /head/sys/sys/proc.h
Fix typo in comment.

MFC after: 3 days
08:41:13 - r303423
(2 days 11 hours ago)
by kib
Affects: 
(6 files)
/head/bin/ps/ps.1
/head/sys/kern/*
/head/sys/sys/proc.h
When a debugger attaches to the process, SIGSTOP is sent to the
target. Due to a way issignal() selects the next signal to deliver
and report, if the simultaneous or already pending another signal
exists, that signal might be reported by the next waitpid(2) call.
This causes minor annoyance for debuggers, which must be prepared to
take any signal as the first event, then filter SIGSTOP later.

More importantly, for tools like gcore(1), which attach and then
detach without processing events, SIGSTOP might leak to be delivered
after PT_DETACH. This results in the process being unintentionally
stopped after detach, which is fatal for automatic tools.

The solution is to force SIGSTOP to be the first signal reported after
the attach. Attach code is modified to set P2_PTRACE_FSTP to indicate
that the attaching ritual was not yet finished, and issignal() prefers
SIGSTOP in that condition. Also, the thread which handles
P2_PTRACE_FSTP is made to guarantee to own p_xthread during the first
waitpid(2). All that ensures that SIGSTOP is consumed first.

Additionally, if P2_PTRACE_FSTP is still set on detach, which means
that waitpid(2) was not called at all, SIGSTOP is removed from the
queue, ensuring that the process is resumed on detach.

In issignal(), when acting on STOPing signals, remove the signal from
queue before suspending. Otherwise parallel attach could result in
ptracestop() acting on that STOP as if it was the STOP signal from the
attach. Then SIGSTOP from attach leaks again.

As a minor refactoring, some bits of the common attach code is moved
to new helper proc_set_traced().

Reported by: markj
Reviewed by: jhb, markj
Tested by: pho
Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks
Differential revision: https://reviews.freebsd.org/D7256
06:46:10 - r303422
(2 days 13 hours ago)
by sephe
Affects: 
(13 files)
/head/sys/dev/hyperv/*
hyperv/vmbus: Inclusion cleanup

MFC after: 1 week
Sponsored by: Microsoft
Differential Revision: https://reviews.freebsd.org/D7334
06:30:29 - r303421
(2 days 14 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/vmbus/vmbus_br.c
hyperv/vmbus: Avoid unnecessary mb()

MFC after: 1 week
Sponsored by: Microsoft
Differential Revision: https://reviews.freebsd.org/D7333
05:59:56 - r303420
(2 days 14 hours ago)
by loos
Affects:  /head/sys/arm/altera/socfpga/files.socfpga
/head/sys/arm/ti/files.ti
/head/sys/conf/files
Enable the build of micphy as part of generic miibus build, but only for
FDT enabled systems.

Sponsored by: Rubicon Communications (Netgate)
2016 - 07 - 27   (3 days ago)
21:45:11 - r303419
(2 days 22 hours ago)
by bdrewery
Affects:  /head/usr.sbin/pmcstudy/pmcstudy.c
Fix non-amd64 build from r292043 after reconnecting in r303410.

MFC after: 3 days
X-MFC-With: r303410
Sponsored by: EMC / Isilon Storage Division
20:51:31 - r303418
(2 days 23 hours ago)
by ivadasz
Affects:  /head/sys/dev/iwm/if_iwm.c
[iwm] When stopping TX DMA, wait for all channels at once.

  * Makes the TX DMA stopping more similar to Linux code, and potentially
  a bit faster. Also, output an error message when TX DMA idling fails.

  Taken-From: Linux iwlwifi

Tested:

* AC3165, STA mode

Approved by: adrian (mentor)
Obtained from: DragonFlyBSD git 2ee486ddff973ac552ff787c17e8d83e8ae0f24c
Differential Revision: https://reviews.freebsd.org/D7325
20:48:15 - r303417
(2 days 23 hours ago)
by bdrewery
Affects:  /head/sys/modules/ixl/Makefile
/head/sys/modules/ixlv/Makefile
opt_bdg.h was removed in r150636.

MFC after: 3 days
Sponsored by: EMC / Isilon Storage Division
20:46:51 - r303416
(2 days 23 hours ago)
by ivadasz
Affects:  /head/sys/dev/iwm/if_iwm.c
/head/sys/dev/iwm/if_iwmreg.h
[iwm] Set different pm_timeout for action frames.

  When building a Tx Command for management frames, we are lacking
  a check for action frames, for which we should set a different
  pm_timeout. This cause the fw to stay awake for 100TU after each
  such frame is transmitted, resulting an excessive power consumption.

  Taken-From: Linux iwlwifi (git b084a35663c3f1f7)

Approved by: adrian (mentor)
Obtained from: Linux git b084a35663c3f1f7de1c45c4ae3006864c940fe7
Obtained from: DragonFlyBSD git ba00f0e3ae873d6f0d5743e22c3ebc49c44dfdac
Differential Revision: https://reviews.freebsd.org/D7324
20:45:00 - r303415
(2 days 23 hours ago)
by bdrewery
Affects:  /head/sys/modules/hyperv/vmbus/Makefile
/head/sys/modules/linux64/Makefile
opt_apic.h is only used on i386.

MFC after: 3 days
Sponsored by: EMC / Isilon Storage Division
20:44:53 - r303414
(2 days 23 hours ago)
by bdrewery
Affects:  /head/sys/modules/mlx5/Makefile
opt_random.h was removed in r287558 for opt_global.h

MFC after: 3 days
Sponsored by: EMC / Isilon Storage Division
20:43:08 - r303413
(2 days 23 hours ago)
by ivadasz
Affects:  /head/sys/dev/iwm/if_iwm.c
[iwm] Fix inverted logic in iwm_tx().

  The PROT_REQUIRE flag in should be set for data frames above a certain
  length, but we were setting it for !data frames above a certain length,
  which makes no sense at all.

  Taken-From: OpenBSD, Linux iwlwifi

Approved by: adrian (mentor)
Obtained from: DragonFlyBSD git 8cc03924a36c572c2908e659e624f44636dc2b33
Differential Revision: https://reviews.freebsd.org/D7323
20:37:32 - r303412
(2 days 23 hours ago)
by rrs
Affects:  /head/MAINTAINERS
Remove myself from kern_timeout.c yeah!
20:34:09 - r303411
(3 days ago)
by stevek
Affects: 
(6 files)
/head/sys/*
Prepare for network stack as a module

 - Move cr_canseeinpcb to sys/netinet/in_prot.c in order to separate the
  INET and INET6-specific code from the rest of the prot code (It is only
  used by the network stack, so it makes sense for it to live with the
  other network stack code.)
 - Move cr_canseeinpcb prototype from sys/systm.h to netinet/in_systm.h
 - Rename cr_seeotheruids to cr_canseeotheruids and cr_seeothergids to
  cr_canseeothergids, make them non-static, and add prototypes (so they
  can be seen/called by in_prot.c functions.)
 - Remove sw_csum variable from ip6_forward in ip6_forward.c, as it is an
  unused variable.

Reviewed by: gnn, jtl
Approved by: sjg (mentor)
Sponsored by: Juniper Networks, Inc.
Differential Revision: https://reviews.freebsd.org/D2901
20:28:28 - r303410
(3 days ago)
by bdrewery
Affects:  /head/usr.sbin/Makefile
Reconnect pmcstudy, lost in r291021

Reported by: pluknet
MFC after: 3 days
Sponsored by: EMC / Isilon Storage Division
19:41:07 - r303409
(3 days ago)
by cy
Affects: 
(2 files)
/stable/9/etc/ntp/leap-seconds
MFC r303160.

Update leap-seconds to leap-seconds.3676752000.

As per https://datacenter.iers.org/web/guest/eop/-/somos/5Rgv/latest/16:

  UTC TIME STEP
  on the 1st of January 2017

 A positive leap second will be introduced at the end of December 2016.
 The sequence of dates of the UTC second markers will be:

  2016 December 31, 23h 59m 59s
  2016 December 31, 23h 59m 60s
  2017 January 1, 0h 0m 0s

 The difference between UTC and the International Atomic Time TAI is:

  from 2015 July 1, 0h UTC, to 2017 January 1 0h UTC : UTC-TAI = - 36s
  from 2017 January 1, 0h UTC, until further notice : UTC-TAI = - 37s

Obtained from: ftp://tycho.usno.navy.mil/pub/ntp/leap-seconds.3676752000
See also: https://www.iers.org/SharedDocs/News/EN/BulletinC.html
  https://datacenter.iers.org/web/guest/eop/-/somos/5Rgv/latest/16

Relnotes: yes
19:40:25 - r303408
(3 days ago)
by cy
Affects: 
(2 files)
/stable/10/etc/ntp/leap-seconds
MFC r303160.

Update leap-seconds to leap-seconds.3676752000.

As per https://datacenter.iers.org/web/guest/eop/-/somos/5Rgv/latest/16:

  UTC TIME STEP
  on the 1st of January 2017

 A positive leap second will be introduced at the end of December 2016.
 The sequence of dates of the UTC second markers will be:

  2016 December 31, 23h 59m 59s
  2016 December 31, 23h 59m 60s
  2017 January 1, 0h 0m 0s

 The difference between UTC and the International Atomic Time TAI is:

  from 2015 July 1, 0h UTC, to 2017 January 1 0h UTC : UTC-TAI = - 36s
  from 2017 January 1, 0h UTC, until further notice : UTC-TAI = - 37s

Obtained from: ftp://tycho.usno.navy.mil/pub/ntp/leap-seconds.3676752000
See also: https://www.iers.org/SharedDocs/News/EN/BulletinC.html
  https://datacenter.iers.org/web/guest/eop/-/somos/5Rgv/latest/16

Relnotes: yes
19:39:25 - r303407
(3 days ago)
by cy
Affects: 
(2 files)
/stable/11/etc/ntp/leap-seconds
MFC r303160.

Update leap-seconds to leap-seconds.3676752000.

As per https://datacenter.iers.org/web/guest/eop/-/somos/5Rgv/latest/16:

  UTC TIME STEP
  on the 1st of January 2017

 A positive leap second will be introduced at the end of December 2016.
 The sequence of dates of the UTC second markers will be:

  2016 December 31, 23h 59m 59s
  2016 December 31, 23h 59m 60s
  2017 January 1, 0h 0m 0s

 The difference between UTC and the International Atomic Time TAI is:

  from 2015 July 1, 0h UTC, to 2017 January 1 0h UTC : UTC-TAI = - 36s
  from 2017 January 1, 0h UTC, until further notice : UTC-TAI = - 37s

Obtained from: ftp://tycho.usno.navy.mil/pub/ntp/leap-seconds.3676752000
See also: https://www.iers.org/SharedDocs/News/EN/BulletinC.html
  https://datacenter.iers.org/web/guest/eop/-/somos/5Rgv/latest/16

Relnotes: yes

Approved by: re@ (delphij@)
19:31:25 - r303406
(3 days 1 hour ago)
by jhb
Affects:  /head/sys/kern/vfs_aio.c
Adjust tests in fsync job scheduling loop to reduce indentation.
18:29:35 - r303405
(3 days 2 hours ago)
by jhb
Affects: 
(5 files)
/head/sys/dev/cxgbe/offload.h
/head/sys/dev/cxgbe/t4_main.c
/head/sys/dev/cxgbe/tom/*
Add support for zero-copy aio_write() on TOE sockets.

AIO write requests for a TOE socket on a Chelsio T4+ adapter can now
DMA directly from the user-supplied buffer. This is implemented by
wiring the pages backing the user-supplied buffer and queueing special
mbufs backed by raw VM pages to the socket buffer. The TOE code
recognizes these special mbufs and builds a sglist from the VM page
array associated with the mbuf when queueing a work request to the TOE.

Because these mbufs do not have an associated virtual address, m_data
is not valid. Thus, the AIO handler does not invoke sosend() directly
for these mbufs but instead inlines portions of sosend_generic() and
tcp_usr_send().

An aiotx_buffer structure is used to describe the user buffer (e.g.
it holds the array of VM pages and a reference to the AIO job). The
special mbufs reference this structure via m_ext. Note that a single
job might be split across multiple mbufs (e.g. if it is larger than
the socket buffer size). The 'ext_arg2' member of each mbuf gives an
offset relative to the backing aiotx_buffer. The AIO job associated
with an aiotx_buffer structure is completed when the last reference to
the structure is released.

Zero-copy aio_write()'s for connections associated with a given
adapter can be enabled/disabled at runtime via the
'dev.t[45]nex.N.toe.tx_zcopy' sysctl.

MFC after: 1 month
Relnotes: yes
Sponsored by: Chelsio Communications
18:12:36 - r303404
(3 days 2 hours ago)
by jkim
Affects:  /head/share/timedef/ko_KR.UTF-8.src
/head/share/timedef/ko_KR.eucKR.src
/head/tools/tools/locale/tools/cldr2def.pl
Add a hack to add weekday to date format for ko_KR locale.
17:55:40 - r303403
(3 days 2 hours ago)
by jhb
Affects: 
(4 files)
/stable/10/usr.sbin/crashinfo/crashinfo.sh
/stable/9/usr.sbin/crashinfo/crashinfo.sh
MFC 303109: Update crashinfo to work with newer gdb from ports.

If gdb from ports is installed, use it instead of the base system gdb
to extract variables from a kernel. Note that base gdb and ports gdb
do not support the same options for invoking a single command in batch
mode, so a wrapper shell function is used. In addition, prefer kgdb
from ports when generating a backtrace if present.

PR: 193335
17:55:14 - r303402
(3 days 2 hours ago)
by jhb
Affects: 
(2 files)
/stable/11/usr.sbin/crashinfo/crashinfo.sh
MFC 303109: Update crashinfo to work with newer gdb from ports.

If gdb from ports is installed, use it instead of the base system gdb
to extract variables from a kernel. Note that base gdb and ports gdb
do not support the same options for invoking a single command in batch
mode, so a wrapper shell function is used. In addition, prefer kgdb
from ports when generating a backtrace if present.

PR: 193335
Approved by: re (gjb)
17:21:24 - r303401
(3 days 3 hours ago)
by markj
Affects: 
(48 files)
/user/alc/PQ_LAUNDRY/*
MFH r303397
17:18:08 - r303400
(3 days 3 hours ago)
by emaste
Affects:  /head/contrib/libcxxrt/libelftc_dem_gnu3.c
libcxxrt: fix demangling of wchar_t

'wchar_t' is 7 characters long, not 6. r303297 fixed this in libelftc,
but not the second copy of this file that we have in libcxxrt.

PR: 208661
Submitted by: Daniel McRobb
Obtained from: ELF Tool Chain r3480
MFC after: 3 days
17:11:03 - r303399
(3 days 3 hours ago)
by markj
Affects:  /head/sys/vm/vm_pageout.c
De-pluralize "queues" where appropriate in the pagedaemon code.

MFC after: 1 week
17:10:09 - r303398
(3 days 3 hours ago)
by emaste
Affects: 
(2 files)
/stable/11/contrib/elftoolchain/libelftc/libelftc_dem_gnu3.c
MFC r303279: libelftc: fix demangling of wchar_t

"wchar_t" is 7 characters long, not 6.

PR: 208661
Submitted by: Daniel McRobb
Approved by: re (kib)
Obtained from: ELF Tool Chain r3480
16:46:48 - r303397
(3 days 3 hours ago)
by alc
Affects:  /user/alc/PQ_LAUNDRY/sys/vm/vm_pageout.c
Reactivation is still the best way of handling VM_PAGER_{ERROR,FAIL} in
vm_pageout_flush().

Reviewed by: markj
Sponsored by: EMC / Isilon Storage Division
16:34:19 - r303396
(3 days 4 hours ago)
by emaste
Affects:  /head/contrib/gcc/config/arm/libunwind-arm.S
/head/contrib/gcc/config/arm/libunwind.S
/head/gnu/lib/libgcc/Makefile
rename ARM's libunwind.S to to avoid conflict with llvm libunwind

llvm libunwind includes a libunwind.cpp, but on ARM libunwind.S is found
first in .PATH. Rename the latter one, since it is not going to be
updated again.

Reviewed by: andrew
MFC after: 3 days
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D7162
16:27:41 - r303395
(3 days 4 hours ago)
by julian
Affects: 
(2 files)
/stable/10/sys/sys/sysent.h
MFH: r303287

Split MAKE_SYSENT into two parts so that the initializer part can be
used separately if one wants to embed the sysent into a larger structure.
16:01:44 - r303394
(3 days 4 hours ago)
by emaste
Affects:  /head/share/mk/src.opts.mk
Enable LLVM libunwind by default on amd64 and i386

It is a maintained and updated runtime exception stack unwinder that
should be a drop-in replacement.

It can be disabled by setting WITHOUT_LLVM_LIBUNWIND in src.conf.

PR: 206039 [exp-run]
Sponsored by: The FreeBSD Foundation
15:14:11 - r303393
(3 days 5 hours ago)
by kib
Affects:  /head/lib/libthr/thread/thr_init.c
/head/lib/libthr/thread/thr_once.c
/head/lib/libthr/thread/thr_private.h
Remove empty initializer for the once facility. It was not needed
since r179417.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week
14:58:15 - r303392
(3 days 5 hours ago)
by emaste
Affects:  /head/Makefile.inc1
/head/share/mk/local.meta.sys.mk
/head/share/mk/sys.mk
Remove ${OBJDUMP} as it is not used by the base system

It was added to sys.mk relatively recently (r274503) for EFI builds
but is no longer used by the base system. The in-tree binutils are
outdated, will not be updated, and will be removed in the future.
Remove it from the toolchain build now to slightly simplify the build
and make sure we don't grow an accidental dependency.

Note that this affects only the toolchain build, and does not affect
/usr/bin/objdump in the built world.

Reviewed by: bdrewery
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D6460
14:27:08 - r303391
(3 days 6 hours ago)
by emaste
Affects:  /head/sys/kern/kern_proc.c
ANSIfy kern_proc.c and delete register keyword

Reviewed by: kib
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D6478
14:12:04 - r303390
(3 days 6 hours ago)
by emaste
Affects:  /head/share/man/man4/syscons.4
/head/share/man/man4/vt.4
syscons,vt: improve phrasing in kern.vty man page description

Submitted by: wblock
13:53:15 - r303389
(3 days 6 hours ago)
by jch
Affects: 
(2 files)
/stable/10/sys/netinet/tcp_timer.c
MFC r286873:

Make clear that TIME_WAIT timeout expiration is managed solely by
tcp_tw_2msl_scan().

Sponsored by: Verisign, Inc.
11:54:24 - r303388
(3 days 8 hours ago)
by kib
Affects:  /head/sys/kern/kern_time.c
Remove Giant from settime(), tc_setclock_mtx guards tc_windup() calls,
and there is no other issues with parallel settime(). Remove spl()
vestiges there as well.

Tested by: pho (as part of the whole patch)
Reviewed by: jhb (same)
Discussed wit: bde
Sponsored by: The FreeBSD Foundation
MFC after: 1 month
Differential revision: https://reviews.freebsd.org/D7302
11:49:41 - r303387
(3 days 8 hours ago)
by kib
Affects:  /head/sys/kern/kern_clock.c
/head/sys/kern/kern_tc.c
Prevent parallel tc_windup() calls, both parallel top-level calls from
setclock() and from simultaneous top-level and interrupt. For this,
tc_windup() is protected with a tc_setclock_mtx spinlock, in the try
mode when called from hardclock interrupt. If spinlock cannot be
obtained without spinning from the interrupt context, this means that
top-level executes tc_windup() on other core and our try may be
avoided.

The boottimebin and boottime variables should be adjusted from
tc_windup(). To be correct, they must be part of the timehands and
read using lockless protocol. Remove the globals and reimplement the
getboottime(9)/getboottimebin(9) KPI using the timehands read
protocol.

Tested by: pho (as part of the whole patch)
Reviewed by: jhb (same)
Discussed wit: bde
Sponsored by: The FreeBSD Foundation
MFC after: 1 month
X-Differential revision: https://reviews.freebsd.org/D7302
11:40:06 - r303386
(3 days 8 hours ago)
by kib
Affects:  /head/sys/kern/kern_ntptime.c
Fix a bug in r302252.

Change ntpadj_lock to spinlock always, and rename stuff removing
ADJ/adj from the names. ntp_update_second() requires ntp_lock and is
called from the tc_windup(), so ntp_lock must be a spinlock. Add
missed lock to ntp_update_second().

Tested by: pho (as part of the whole patch)
Reviewed by: jhb (same)
Noted by: bde
Sponsored by: The FreeBSD Foundation
MFC after: 1 month
X-Differential revision: https://reviews.freebsd.org/D7302
11:34:25 - r303385
(3 days 9 hours ago)
by kib
Affects:  /head/sys/kern/subr_rtc.c
Reduce the resettodr_lock scope to only CLOCK_SETTIME() call.

Tested by: pho (as part of the whole patch)
Reviewed by: jhb (same)
Discussed with: bde
Sponsored by: The FreeBSD Foundation
MFC after: 1 month
X-Differential revision: https://reviews.freebsd.org/D7302
11:33:33 - r303384
(3 days 9 hours ago)
by kib
Affects:  /head/sys/kern/kern_tc.c
Style.

Sponsored by: The FreeBSD Foundation
MFC after: 1 month
X-Differential revision: https://reviews.freebsd.org/D7302
11:27:52 - r303383
(3 days 9 hours ago)
by kib
Affects:  /head/sys/kern/kern_tc.c
Reduce number of timehands to just two. This is useful because
consumers can now be only one tc_windup() call late.

Use C99 initialization.

Tested by: pho (as part of the whole patch)
Reviewed by: jhb (same)
Discussed with: bde
Sponsored by: The FreeBSD Foundation
MFC after: 1 month
X-Differential revision: https://reviews.freebsd.org/D7302
11:08:59 - r303382
(3 days 9 hours ago)
by kib
Affects: 
(15 files)
/head/sys/*
Hide the boottime and bootimebin globals, provide the getboottime(9)
and getboottimebin(9) KPI. Change consumers of boottime to use the
KPI. The variables were renamed to avoid shadowing issues with local
variables of the same name.

Issue is that boottime* should be adjusted from tc_windup(), which
requires them to be members of the timehands structure. As a
preparation, this commit only introduces the interface.

Some uses of boottime were found doubtful, e.g. NLM uses boottime to
identify the system boot instance. Arguably the identity should not
change on the leap second adjustment, but the commit is about the
timekeeping code and the consumers were kept bug-to-bug compatible.

Tested by: pho (as part of the bigger patch)
Reviewed by: jhb (same)
Discussed with: bde
Sponsored by: The FreeBSD Foundation
MFC after: 1 month
X-Differential revision: https://reviews.freebsd.org/D7302
10:43:36 - r303381
(3 days 9 hours ago)
by andrew
Affects:  /vendor/device-tree/devicetree-965f3718
Tag the devicetree source import
10:33:45 - r303380
(3 days 10 hours ago)
by andrew
Affects: 
(1354 files)
/vendor/device-tree/dist/Bindings/*
/vendor/device-tree/dist/include/dt-bindings/*
/vendor/device-tree/dist/src/*
Import the updated devicetree files from
https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git
09:27:08 - r303379
(3 days 11 hours ago)
by sephe
Affects: 
(5 files)
/head/sys/conf/*
/head/sys/dev/hyperv/vmbus/*
/head/sys/modules/hyperv/vmbus/Makefile
hyperv/vmbus: Rename cleaned up bufring code

MFC after: 1 week
Sponsored by: Microsoft
Differential Revision: https://reviews.freebsd.org/D7318
09:26:46 - r303378
(3 days 11 hours ago)
by glebius
Affects:  /user/cperciva/freebsd-update-build/scripts/build.subr
Starting with FreeBSD 11 we will use dvd1 disk instead of disc1, since we
need kernel-dbg distribution. For 11.0-BETA1 and 11.0-BETA2 this was done
as override, but we should use it as default.

In case if 10.4-RELEASE will use disc1, we will create override for 10.4
build only.

Discussed with: delphij, gjb
09:23:04 - r303377
(3 days 11 hours ago)
by glebius
Affects: 
(29 files)
/user/cperciva/freebsd-update-build/patches/*
/user/cperciva/freebsd-update-build/scripts/*
- Check in 11.0-BETA1, 11.0-BETA2 configuration.
- Check in SA-16:24, SA-16:25.
- Check in EN-16:09.
08:53:11 - r303376
(3 days 11 hours ago)
by kib
Affects: 
(3 files)
/stable/10/sys/ufs/ufs/ufs_lookup.c
/stable/10/sys/ufs/ufs/ufs_vnops.c
MFC r303090:
Ensure that the UFS directory vnode' vm_object is properly sized
before UFS_BALLOC() is called.
08:47:24 - r303375
(3 days 11 hours ago)
by kib
Affects: 
(3 files)
/stable/11/sys/ufs/ufs/ufs_lookup.c
/stable/11/sys/ufs/ufs/ufs_vnops.c
MFC r303090:
Ensure that the UFS directory vnode' vm_object is properly sized
before UFS_BALLOC() is called.

Approved by: re (delphij)
08:26:35 - r303374
(3 days 12 hours ago)
by ae
Affects:  /head/sbin/route/route.c
Due to dropped mbuf in netisr queue route(8) can fall into infinity
loop of reading the rtsock's feed. When it used by some scripts,
this leads to growing number of not finished route(8) instances and
thus growing number of rtsock consumers. Add SIGALRM handler to prevent this.

Reviewed by: melifaro
Obtained from: Yandex LLC
MFC after: 2 weeks
Sponsored by: Yandex LLC
08:11:08 - r303373
(3 days 12 hours ago)
by kevlo
Affects:  /head/share/timedef/zh_TW.Big5.src
/head/share/timedef/zh_TW.UTF-8.src
Regenerate timedef for zh_TW.

Reviewed by: bapt
08:08:46 - r303372
(3 days 12 hours ago)
by kevlo
Affects:  /head/tools/tools/locale/README
/head/tools/tools/locale/tools/cldr2def.pl
Fix cldr2def.pl script to add weekday to the date format of zh_TW locales.
While here, mention dependency on textproc/p5-XML-Parser in README.

Reviewed by: bapt
07:51:58 - r303371
(3 days 12 hours ago)
by jch
Affects: 
(4 files)
/stable/10/sys/netinet/tcp_input.c
/stable/10/sys/netinet/tcp_syncache.c
/stable/10/sys/netinet/toecore.c
MFC r271119, r272081:

r271119:

In tcp_input(), don't acquire the pcbinfo global write lock for SYN
packets targeting a listening socket. Permit to reduce TCP input
processing starvation in context of high SYN load (e.g. short-lived TCP
connections or SYN flood).

Submitted by: Julien Charbon <jcharbon@verisign.com>
Reviewed by: adrian, hiren, jhb, Mike Bentkofsky

r272081:

Catch up with r271119.
07:36:54 - r303370
(3 days 12 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/vmbus/hv_ring_buffer.c
/head/sys/dev/hyperv/vmbus/vmbus_brvar.h
hyperv/vmbus: Cleanup RX bufring read process.

MFC after: 1 week
Sponsored by: Microsoft
Differential Revision: https://reviews.freebsd.org/D7317
07:19:06 - r303369
(3 days 13 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/vmbus/hv_ring_buffer.c
hyperv/vmbus: Stringent RX bufring data length checks.

MFC after: 1 week
Sponsored by: Microsoft
Differential Revision: https://reviews.freebsd.org/D7316
06:52:43 - r303368
(3 days 13 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/vmbus/hv_ring_buffer.c
hyperv/vmbus: Cleanup TX bufring write process.

MFC after: 1 week
Sponsored by: Microsoft
Differential Revision: https://reviews.freebsd.org/D7315
06:49:16 - r303367
(3 days 13 hours ago)
by ngie
Affects:  /head/usr.bin/sed/tests/multi_test.sh
Testcase 7.8 no longer needs to be marked TODO

It passes out of the box today

MFC after: 2 months
Sponsored by: EMC / Isilon Storage Division
06:36:57 - r303366
(3 days 13 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/vmbus/hv_ring_buffer.c
hyperv/vmbus: Update comment for bufring

MFC after: 1 week
Sponsored by: Microsoft
Differential Revision: https://reviews.freebsd.org/D7314
06:31:40 - r303365
(3 days 14 hours ago)
by jch
Affects: 
(2 files)
/stable/10/sys/netinet/tcp_usrreq.c
MFC r273014:

A connection in TIME_WAIT state before calling close() actually did not
received any RST packet. Do not set error to ECONNRESET in this case.

Differential Revision: https://reviews.freebsd.org/D879
Reviewed by: rpaulo, adrian
Approved by: jhb (mentor)
Sponsored by: Verisign, Inc.
06:29:41 - r303364
(3 days 14 hours ago)
by ngie
Affects:  /stable/11/ObsoleteFiles.inc
MFC r302842:

Don't delete usr/share/local/kk_KZ.UTF-8 with "make delete-old" after r302329

kk_KZ.UTF-8 was originally removed in r290494, but restored as an alias to
en_US.UTF-8 in r302329

Approved by: re (kib)
PR: 211046
06:29:26 - r303363
(3 days 14 hours ago)
by ngie
Affects:  /stable/11
MFC r302842:

Don't delete usr/share/local/kk_KZ.UTF-8 with "make delete-old" after r302329

kk_KZ.UTF-8 was originally removed in r290494, but restored as an alias to
en_US.UTF-8 in r302329

Approved by: re (kib)
PR: 211046
06:17:20 - r303362
(3 days 14 hours ago)
by sephe
Affects: 
(4 files)
/head/sys/dev/hyperv/vmbus/*
hyperv/vmbus: Use different struct for RX/TX bufring.

So that they can use suitable MP synchronization mechanism.

While I'm here change the bufring init/read/write function names.

MFC after: 1 week
Sponsored by: Microsoft
Differential Revision: https://reviews.freebsd.org/D7313
05:47:32 - r303361
(3 days 14 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/vmbus/hv_ring_buffer.c
/head/sys/dev/hyperv/vmbus/vmbus_brvar.h
/head/sys/dev/hyperv/vmbus/vmbus_chan.c
hyperv/vmbus: Initialize RX/TX bufring mutex at channel creation time

MFC after: 1 week
Sponsored by: Microsoft OSTC
Differential Revision: https://reviews.freebsd.org/D7312
05:38:09 - r303360
(3 days 14 hours ago)
by bdrewery
Affects: 
(3 files)
/stable/11/Makefile.inc1
/stable/11/Makefile.libcompat
MFC r303274:

  Don't disable binutils/elftoolchain bootstrapping with external compiler.

Approved by: re (kib)
05:17:55 - r303359
(3 days 15 hours ago)
by bdrewery
Affects: 
(3 files)
/stable/11/Makefile
/stable/11/Makefile.inc1
MFC r303272,r303273:

  r303272:
  SYSTEM_COMPILER: Rework the logic to allow a 'make test-system-compiler'.
  r303273:
  Fix empty WANT_COMPILER_TYPE when neither compiler is bootstrapped.

Approved by: re (kib)
05:03:58 - r303358
(3 days 15 hours ago)
by alc
Affects:  /user/alc/PQ_LAUNDRY/sys/vm/vm_pageout.c
Update a comment.
04:00:22 - r303357
(3 days 16 hours ago)
by alc
Affects: 
(116 files)
/user/alc/PQ_LAUNDRY/*
MFH r303356
03:49:00 - r303356
(3 days 16 hours ago)
by alc
Affects:  /head/sys/vm/vm_pageout.c
Update a comment to reflect r284376.

MFC after: 3 days
03:21:02 - r303355
(3 days 17 hours ago)
by stevek
Affects:  /head/sys/conf/NOTES
/head/sys/conf/options
/head/sys/kern/kern_sig.c
Add the NUM_CORE_FILES kernel config option which specifies the limit for the
number of core files allowed by a particular process when using the %I core
file name pattern.

Sanity check at compile time to ensure the value is within the valid range of
0-10.

Reviewed by: jtl, sjg
Approved by: sjg (mentor)
Sponsored by: Juniper Networks, Inc.
Differential Revision: https://reviews.freebsd.org/D6812
00:46:48 - r303354
(3 days 19 hours ago)
by kevlo
Affects:  /head/share/timedef/zh_TW.UTF-8.src
Add weekday to the date format.
00:08:01 - r303353
(3 days 20 hours ago)
by ian
Affects: 
(7 files)
/head/sys/dev/usb/serial/*
Annotate the usb-serial drivers which always return 0 for line status,
so that it'll be easier to find and fix them in the future.
00:03:29 - r303352
(3 days 20 hours ago)
by grehan
Affects:  /head/usr.sbin/bhyve/pci_fbuf.c
- Change the fbuf "vga" parameter to "vga=on|io|off".
  "io" is the default, and allows VGA i/o registers to be
  accessed. This is required by Win7/2k8 graphics guests that
  use a combination of BIOS int10 and UEFI.
  "off" disables all VGA i/o and mem accesses.
  "on" is not yet hooked up, but will enable full VGA rendering.

  OpenBSD/UEFI >= 5.9 graphics guests can be booted using "vga=off"

- Allow "rfb" to be used instead of "tcp" for the fbuf VNC
  description. "tcp" will be removed at a future point and is
  kept as an alias.

Discussed with: Leon Dang
MFC after: 3 days
00:03:18 - r303351
(3 days 20 hours ago)
by ian
Affects:  /head/sys/dev/usb/serial/ubsa.c
Translate modem status reg bits from ns16550 to SER_* values used by the
tty layer.

Also annotate a switch case fall-through per style(9).
2016 - 07 - 26   (4 days ago)
23:42:42 - r303350
(3 days 20 hours ago)
by ian
Affects:  /head/sys/dev/usb/serial/umct.c
Translate modem status reg bits from ns16550 to SER_* values used by the
tty layer.

Also annotate a switch case fall-through per style(9).
23:40:25 - r303349
(3 days 20 hours ago)
by grehan
Affects:  /head/usr.sbin/bhyve/pci_xhci.c
Catch another case where an XHCI interrupt was being
injected without state being set up.

This fixes a core dump when dropping to the UEFI prompt
with graphics enabled and moving the mouse around.

Discussed with: Leon Dang
MFC after: 3 days
23:29:37 - r303348
(3 days 21 hours ago)
by np
Affects:  /head/sys/dev/cxgbe/t4_main.c
cxgbe(4): Initialize the adapter queues (fwq and mgmtq) instead of
returning EAGAIN if they aren't available when the user tries to program
a filter. Do this after validating the filter so that the driver
doesn't bring up the queues if it doesn't have to.
23:27:28 - r303347
(3 days 21 hours ago)
by ian
Affects:  /head/sys/dev/usb/serial/umcs.c
Translate modem status reg bits from ns16550 to SER_* values used by the
tty layer. Also, the line status reg bits are already ns16550 as expected
by the ucom layer, so no need for translation or a local var to hold them.
22:26:49 - r303346
(3 days 22 hours ago)
by ian
Affects:  /head/sys/dev/usb/serial/umoscom.c
Actually return line status register values from umoscom_cfg_get_status().

The hardware delivers ns16550-compatible status bits, which is what the
usb_serial code expects, so no need for translation, no need for a local
variable to hold a temporary lsr result.
21:27:02 - r303345
(3 days 23 hours ago)
by ivadasz
Affects:  /head/share/man/man4/iwm.4
/head/share/man/man4/iwmfw.4
Mention AC3165 and AC8260 chipsets in iwm(4) and mention AC3165 in iwmfw(4)

- Support for the AC3165 and AC8260 chipsets was added by r303322 and r303327.

Approved by: adrian (mentor)
Differential Revision: https://reviews.freebsd.org/D7322
20:26:03 - r303344
(4 days ago)
by avos
Affects: 
(3 files)
/stable/11/sys/dev/urtwn/if_urtwn.c
/stable/11/sys/dev/urtwn/if_urtwnreg.h
MFC r303115:

urtwn: fix A-MSDU tx aggregation when encryption is used.

Clear unused (undocumented) CAM bytes while setting a key;
without that, hardware does weird things when A-MSDU bit in QoS header
is set.

Tested with RTL8188CUS (AP) -> RTL8188EU (STA) (A-MSDU transmit).

Reported by: many
Approved by: re (gjb)
Obtained from: https://github.com/s3erios/urtwm
20:20:09 - r303343
(4 days ago)
by brd
Affects:  /head/sys/netinet/cc/cc.c
Fix the case for some sysctl descriptions.

Reviewed by: gnn
20:11:29 - r303342
(4 days ago)
by ed
Affects:  /head/include/stdlib.h
/head/lib/libc/stdlib/random.3
/head/lib/libc/stdlib/random.c
Fix typing of srandom() and initstate().

POSIX requires that these functions have an unsigned int for their first
argument; not an unsigned long.

My reasoning is that we can safely change these functions without
breaking the ABI. As far as I know, our supported architectures either
use registers for passing function arguments that are at least as big as
long (e.g., amd64), or int and long are of the same size (e.g., i386).

Reviewed by: ache
Differential Revision: https://reviews.freebsd.org/D6644
18:27:48 - r303341
(4 days 2 hours ago)
by phil
Affects:  /head/share/misc/committers-src.dot
Fix start date to not be in the future.

Submitted by: phil
Reviewed by: sjg (mentor)
Approved by: sjg
17:23:49 - r303340
(4 days 3 hours ago)
by ed
Affects:  /head/sys/compat/freebsd32/freebsd32_ipc.h
/head/sys/kern/sysv_shm.c
/head/sys/sys/shm.h
Add shmatt_t.

It looks like our "struct shmid_ds::shm_nattch" deviates from the
standard in the sense that it is a signed integer, whereas POSIX
requires that it is unsigned, having a special type shmatt_t.

Patch up our native and 32-bit copies to use a new shmatt_t that is an
unsigned integer. As it's unsigned, we can relax the comparisons that
are performed on it. Leave the Linux, iBCS2, etc. copies of the
structure alone.

Reviewed by: ngie
Differential Revision: https://reviews.freebsd.org/D6655
16:40:03 - r303339
(4 days 3 hours ago)
by adrian
Affects:  /head/sys/dev/etherswitch/arswitch/arswitch_7240.c
/head/sys/dev/etherswitch/arswitch/arswitch_8316.c
Update my TODO items.
15:34:26 - r303338
(4 days 5 hours ago)
by emaste
Affects:  /head/sys/dev/vt/vt_core.c
vt: lock Giant around kbd calls in CONS_GETINFO

Note that keyboards are stored in an array and are not freed (just
"unregistered" by clearing some fields) so a race would be limited to
obtaining stale information about an unregistered keyboard.

Reported by: CTurt
MFC after: 3 days
15:22:21 - r303337
(4 days 5 hours ago)
by emaste
Affects: 
(2 files)
/stable/11/Makefile.inc1
MFC r303034: Include makewhatis in ITOOLS when MK_MAN_UTILS is true

Previously it was conditional on MK_MAN. It's possible to build
FreeBSD with man pages but without man page tools. MK_MAN_UTILS
is the conditional used in share/man/Makefile for determining whether
makewhatis is executed at install time, so it is the proper one for
ITOOLS as well.

PR: 210142
Approved by: re (gjb)
14:12:11 - r303336
(4 days 6 hours ago)
by pfg
Affects: 
(2 files)
/stable/11/lib/libc/locale/mblocal.h
MFC r303046:
libc: tag the rune initialization function prototypes visibility as hidden.

It is good practice to export as few symbols as possible from your shared
libraries, so use the GCC visibility attribute in this case, matching what
Apple's libc does.

Reference:
https://developer.apple.com/library/mac/documentation/DeveloperTools/Conceptual/CppRuntimeEnv/Articles/SymbolVisibility.html

Hinted by: Apple's libc 1082.20.4
Approved by: re (gjb)
13:36:28 - r303335
(4 days 6 hours ago)
by emaste
Affects:  /head/sys/dev/kbd/kbd.c
apply some style(9) to kbd: make function name start in column 1

Sponsored by: The FreeBSD Foundation
08:58:44 - r303334
(4 days 11 hours ago)
by pho
Affects:  /user/pho/stress2/misc/callout_reset_on.sh
/user/pho/stress2/misc/vfork.sh
Added findings.

Sponsored by: EMC / Isilon Storage Division
05:52:53 - r303333
(4 days 14 hours ago)
by manu
Affects:  /stable/11/sys/boot/efi/libefi/Makefile
MFC: r303039

Do not use TERM_EMU on arm and arm64 as it doesn't behave
well with serial console.

Approved by: re (gjb)
05:27:26 - r303332
(4 days 15 hours ago)
by allanjude
Affects: 
(2 files)
/stable/11/usr.sbin/bsdinstall/scripts/time
MFC: r302790, r302795

Add new menu to bsdinstall to allow user to set date and time after
selecting timezone. The 'skip' button is the default selection.

Submitted by: des
Approved by: re (gjb)
05:26:53 - r303331
(4 days 15 hours ago)
by allanjude
Affects: 
(2 files)
/stable/11/usr.sbin/bsdinstall/scripts/zfsboot
MFC: r302940

Fix error in bsdinstall triggered when doing a GELI encrypted install to
an MBR formatted disk

Approved by: re (gjb)
Sponsored by: ScaleEngine Inc.
05:26:07 - r303330
(4 days 15 hours ago)
by allanjude
Affects: 
(2 files)
/stable/11/usr.sbin/bsdinstall/scripts/zfsboot
MFC: r302941

At the start of the installation process, all ZFS pools are exported and
all GELI instances are detached, to allow a restarted install to proceed.

PR: 210814
Approved by: re (gjb)
05:06:00 - r303329
(4 days 15 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/vmbus/hv_ring_buffer.c
hyperv/vmbus: Nuke unnecessary accessor functions.

MFC after: 1 week
Sponsored by: Microsoft OSTC
Differential Revision: https://reviews.freebsd.org/D7303
03:47:16 - r303328
(4 days 16 hours ago)
by bdrewery
Affects:  /head/share/man/man3/Makefile
Add links for bit_ffc_at(3) and bit_ffs_at(3).

MFC after: 3 days
00:02:17 - r303327
(4 days 20 hours ago)
by sbruno
Affects: 
(15 files)
/head/sys/dev/iwm/*
iwm(4) synchronize driver to DragonFlyBSD version and recent f/w update.

Submitted by: Kevin Bowling (kevin.bowling@kev009.com)
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D6967
2016 - 07 - 25   (5 days ago)
23:44:44 - r303326
(4 days 20 hours ago)
by sbruno
Affects:  /head/sys/dev/iwm/if_iwm.c
/head/sys/dev/iwm/if_iwmvar.h
iwm(4): switch to ieee80211_runtask()

Submitted by: Andiry Voskoboinyk (s3erios@gmail.com)
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D5054
23:38:14 - r303325
(4 days 20 hours ago)
by jhb
Affects: 
(24 files)
/stable/10/*
/stable/9/*
MFC 302899: Add documentation for the sigevent structure.

- Add a sigevent(3) manpage to give a general overview of the sigevent
  structure and the available notification mechanisms.
- Document that AIO requests contain a nested sigevent structure that can
  be used to request completion notification.
- Expand the sigevent details in other manuals to note details such as
  the extra values stored in a queued signal's information or in a posted
  kevent.
23:37:47 - r303324
(4 days 20 hours ago)
by jhb
Affects: 
(11 files)
/stable/11/lib/libc/sys/*
/stable/11/share/man/man3/*
/stable/11/share/man/man4/aio.4
MFC 302899: Add documentation for the sigevent structure.

- Add a sigevent(3) manpage to give a general overview of the sigevent
  structure and the available notification mechanisms.
- Document that AIO requests contain a nested sigevent structure that can
  be used to request completion notification.
- Expand the sigevent details in other manuals to note details such as
  the extra values stored in a queued signal's information or in a posted
  kevent.

Approved by: re (gjb)
23:06:37 - r303323
(4 days 21 hours ago)
by sbruno
Affects:  /svnadmin/conf/sizelimit.conf
Restore my previous limit.
23:05:25 - r303322
(4 days 21 hours ago)
by sbruno
Affects: 
(15 files)
/head/share/man/man4/iwmfw.4
/head/sys/*
Update iwmfw(4) to include support for 8260 series units and update
f/w for the other devices supported by this driver.

Patch linked in https://reviews.freebsd.org/D6967 but not actually
a part of the review.

Obtained from DragonflyBSD.

Submitted by: Kevin Bowling <kev009@kev009.com>
MFC after: 2 weeks
Relnotes: yes
23:04:21 - r303321
(4 days 21 hours ago)
by sbruno
Affects:  /svnadmin/conf/sizelimit.conf
Temp raise of my limit as I thwack a bunch of firmware files into base.
20:49:16 - r303320
(4 days 23 hours ago)
by rene
Affects:  /head/share/misc/organization.dot
miwi resigned from FreeBSD, update the graph
20:02:11 - r303319
(5 days ago)
by asomers
Affects: 
(2 files)
/stable/11/usr.sbin/camdd/camdd.c
MFC r303091

Fix camdd for host-aware and host-managed SMR disks.
This should've gone in as part of r300207

Approved by: re (gjb)
19:37:10 - r303318
(5 days ago)
by emaste
Affects: 
(4 files)
/stable/11/contrib/llvm/projects/libunwind/include/__libunwind_config.h
/stable/11/contrib/llvm/projects/libunwind/include/unwind.h
/stable/11/contrib/llvm/projects/libunwind/src/DwarfParser.hpp
Merge LLVM libunwind fixes

r302475: libunwind: limit stack usage in unwind cursor

This may be reworked upstream but in the interim should address the
stack usage issue reported in the PR.

r303061: libunwind: Properly align _Unwind_Exception.

_Unwind_Exception is required to be double word aligned. GCC has
interpreted this to mean "use the maximum useful alignment for the
target" so follow that lead.

PR: 206384 (r302475)
Obtained from: LLVM review D22543 (r303061)
Approved by: re (gjb)
19:18:42 - r303317
(5 days 1 hour ago)
by jhb
Affects: 
(4 files)
/stable/10/share/man/man3/siginfo.3
/stable/9/share/man/man3/siginfo.3
MFC 302861: Fix rendering issues.

- Use Ta to separate column headers.
- Correct width of the 'Code' column in the last table.
19:16:49 - r303316
(5 days 1 hour ago)
by jhb
Affects: 
(2 files)
/stable/11/share/man/man3/siginfo.3
MFC 302861: Fix rendering issues.

- Use Ta to separate column headers.
- Correct width of the 'Code' column in the last table.

Approved by: re (gjb)
19:16:30 - r303315
(5 days 1 hour ago)
by imp
Affects:  /head/sys/cam/nvme/nvme_xpt.c
Remove some extraneous printfs.
18:25:19 - r303314
(5 days 2 hours ago)
by bdrewery
Affects: 
(3 files)
/stable/11/sys/conf/config.mk
/stable/11/sys/conf/kern.pre.mk
MFC r303195:

  Don't run find(1) for __MPATH with NO_MODULES set.

Approved by: re (gjb)
18:24:54 - r303313
(5 days 2 hours ago)
by nwhitehorn
Affects:  /projects/powernv/powerpc/powernv/opal.h
/projects/powernv/powerpc/powernv/opal_pci.c
Add some stub code for resetting the PCI host bridge that currently hoses
everything.
17:37:02 - r303312
(5 days 2 hours ago)
by bdrewery
Affects: 
(5 files)
/stable/11/share/man/man4/vt.4
/stable/11/sys/dev/vt/*
MFC r303043:

  Increase vt(4) framebuffer maximum size

PR: 210382
Approved by: re (gjb)
17:17:59 - r303311
(5 days 3 hours ago)
by np
Affects: 
(2 files)
/stable/11/usr.sbin/ctld/login.c
MFC r303199:

ctld(8): Fix MaxBurstLength negotiation.

The target must reply with the selected value of MaxBurstSize instead of
just echoing back the initiator's offered value.

Reviewed by: mav@
Approved by: re@ (gjb@)
Sponsored by: Chelsio Communications
Differential Revision: https://reviews.freebsd.org/D7278
16:28:02 - r303310
(5 days 4 hours ago)
by cem
Affects:  /head/sys/fs/devfs/devfs_vnops.c
/head/sys/kern/vfs_vnops.c
devfs: Move most ioctl logic down to vnode layer

Devfs' file layer ioctl is now just a thin shim around the vnode layer.

Reviewed by: kib
Sponsored by: EMC / Isilon Storage Division
Differential Revision: https://reviews.freebsd.org/D7286
16:18:20 - r303309
(5 days 4 hours ago)
by andrew
Affects:  /head/sys/arm64/arm64/mp_machdep.c
Remove an unused variable.

Obtained from: ABT Systems Ltd
MFC after: 1 month
Sponsored by: The FreeBSD Foundation
15:59:31 - r303308
(5 days 4 hours ago)
by andrew
Affects:  /head/sys/arm64/arm64/mp_machdep.c
Fix a typo in a string in a KASSERT to sanity check the CPU IDs.

Obtained from: ABT Systems Ltd
MFC after: 1 month
Sponsored by: The FreeBSD Foundation
15:57:13 - r303307
(5 days 4 hours ago)
by andrew
Affects:  /head/sys/arm64/arm64/mp_machdep.c
Rework how we number CPUs on arm64 to try and keep clusters together.

Obtained from: ABT Systems Ltd
MFC after: 1 month
Sponsored by: The FreeBSD Foundation
15:56:37 - r303306
(5 days 4 hours ago)
by jhb
Affects: 
(2 files)
/stable/11/lib/librt/aio.c
MFC 302860: Fix aio system call wrappers in librt.

- Update aio_return/waitcomplete wrappers for the ssize_t return type.
- Fix the aio_return() wrapper to fail with EINVAL on a pending job.
  This matches the semantics of the in-kernel system call. Also,
  aio_return() returns errors via errno, not via the return value.

Approved by: re (gjb)
Sponsored by: Chelsio Communications
15:05:01 - r303305
(5 days 5 hours ago)
by pfg
Affects: 
(3 files)
/stable/9/usr.bin/mail/quit.c
/stable/9/usr.bin/mail/v7.local.c
MFC r302911:
mail(1): Avoid closing negative file descriptors.

CID: 1008105, 1008106
15:04:17 - r303304
(5 days 5 hours ago)
by delphij
Affects: 
(16 files)
/releng/*
Fix bspatch heap overflow vulnerability. [SA-16:25]

Fix freebsd-update(8) support of FreeBSD 11.0 release
distribution. [EN-16:09]

Approved by: so
15:04:15 - r303303
(5 days 5 hours ago)
by pfg
Affects: 
(3 files)
/stable/10/usr.bin/mail/quit.c
/stable/10/usr.bin/mail/v7.local.c
MFC r302911:
mail(1): Avoid closing negative file descriptors.

CID: 1008105, 1008106
15:03:14 - r303302
(5 days 5 hours ago)
by pfg
Affects: 
(3 files)
/stable/11/usr.bin/mail/quit.c
/stable/11/usr.bin/mail/v7.local.c
MFC r302911:
mail(1): Avoid closing negative file descriptors.

CID: 1008105, 1008106
Approved by: re (gjb)
14:53:04 - r303301
(5 days 5 hours ago)
by delphij
Affects:  /stable/10/usr.bin/bsdiff/bspatch/bspatch.c
/stable/9/usr.bin/bsdiff/bspatch/bspatch.c
Fix bspatch heap overflow vulnerability.

Obtained from: Chromium
Reported by: Lu Tung-Pin
Security: FreeBSD-SA-16:25.bspatch
14:52:12 - r303300
(5 days 5 hours ago)
by delphij
Affects:  /stable/11/usr.bin/bsdiff/bspatch/bspatch.c
Fix bspatch heap overflow vulnerability.

Obtained from: Chromium
Reported by: Lu Tung-Pin
Security: FreeBSD-SA-16:25.bspatch
Approved by: re (so@ blanket)
14:49:15 - r303299
(5 days 5 hours ago)
by andrew
Affects:  /head/sys/arm64/conf/GENERIC
Enable the generic OHCI driver on arm64

Obtained from: ABT Systems Ltd
MFC after: 1 month
Relnotes: yes
Sponsored by: The FreeBSD Foundation
14:45:48 - r303298
(5 days 5 hours ago)
by delphij
Affects:  /head/usr.bin/bsdiff/bspatch/bspatch.c
Fix bspatch heap overflow vulnerability.

Obtained from: Chromium
Reported by: Lu Tung-Pin
Security: FreeBSD-SA-16:25.bspatch
14:36:55 - r303297
(5 days 5 hours ago)
by emaste
Affects: 
(2 files)
/stable/10/sys/boot/efi/boot1/generate-fat.sh
MFC r297871: boot1.efifat: provide a fallback startup.nsh

In case the firmware falls through to executing startup.sh, populate it
with the name of our boot loader. In normal operation this should not be
necessary but may allow the system to boot if it would otherwise just
remain at a shell prompt.

Sponsored by: The FreeBSD Foundation
14:35:48 - r303296
(5 days 5 hours ago)
by delphij
Affects: 
(2 files)
/stable/11/usr.bin/mail/collect.c
MFC r302542:

Use _PATH_DEVNULL instead of hardcoding.

Approved by: re (kib)
14:35:14 - r303295
(5 days 5 hours ago)
by emaste
Affects: 
(3 files)
/stable/10/usr.bin/ar/ar.1
/stable/10/usr.bin/ar/ar.c
MFC r301974: ar: enable reproducible output by default when invoked as 'ar -s'

ar output is already deterministic by default for ar -q and ar -r, and
when invoked as ranlib. Make ar -s equivalent to ranlib and enable
deterministic output by default in that case too.

PR: 210330
Sponsored by: The FreeBSD Foundation
14:28:50 - r303294
(5 days 6 hours ago)
by emaste
Affects: 
(2 files)
/stable/10/sys/boot/efi/boot1/boot1.c
MFC r302335: boot1.efi: fix assignment / comparison expression

PR: 210706
Submitted by: David Binderman <dcb314@hotmail.com>
14:26:33 - r303293
(5 days 6 hours ago)
by emaste
Affects: 
(2 files)
/stable/10/lib/libcxxrt/Version.map
MFC r302278: libcxxrt: correct mangled "typeinfo name" symbols in Version.map

r261644 (MFC of r260553) added missing C++ typinfos to libcxxrt's
version script. It appears that a number of duplicate mangled symbols
were added due to a cut and paste error. Switch the second instances to
_ZTS*, typeinfo name for *.

Found by lld, which produces an error or warning for duplicate symbols.

Sponsored by: The FreeBSD Foundation
14:16:28 - r303292
(5 days 6 hours ago)
by emaste
Affects: 
(2 files)
/stable/11/contrib/libcxxrt/exception.cc
MFC r303157: libcxxrt: add padding in __cxa_allocate_* to fix alignment

The addition of the referenceCount to __cxa_allocate_exception put the
unwindHeader at offset 0x58 in __cxa_exception, but it requires 16-byte
alignment. In order to avoid changing the current __cxa_exception ABI
(and thus breaking its consumers), add explicit padding in the
allocation routines (and account for it when freeing).

This is intended as a lower-risk change for FreeBSD 11. A "more correct"
fix should be prepared for upstream and -CURRENT.

Approved by: re (gjb)
Sponsored by: The FreeBSD Foundation
13:31:18 - r303291
(5 days 7 hours ago)
by kib
Affects: 
(3 files)
/stable/10/sys/kern/vfs_subr.c
/stable/10/sys/vm/vm_object.c
MFC r302567:
In vgonel(), postpone setting BO_DEAD until VOP_RECLAIM() is called,
if vnode is VMIO. For VMIO vnodes, set BO_DEAD in vm_object_terminate().

MFC r302580:
Fix grammar.
13:28:59 - r303290
(5 days 7 hours ago)
by kib
Affects: 
(3 files)
/stable/11/sys/kern/vfs_subr.c
/stable/11/sys/vm/vm_object.c
MFC r302567:
In vgonel(), postpone setting BO_DEAD until VOP_RECLAIM() is called,
if vnode is VMIO. For VMIO vnodes, set BO_DEAD in vm_object_terminate().

MFC r302580:
Fix grammar.

Approved by: re (gjb)
11:25:33 - r303289
(5 days 9 hours ago)
by des
Affects:  /head/sbin/geom/class/part/gpart.8
Rewrite the GPT and MBR examples. For GPT, ensure that the boot partition
is large enough for gptzfsboot, which has doubled in size since 10.

PR: 211361
MFC after: 3 days
09:12:08 - r303288
(5 days 11 hours ago)
by ae
Affects:  /head/sys/geom/geom_subr.c
Do not invoke resize method if geom is being withered.

PR: 211028
MFC after: 2 weeks
08:13:50 - r303287
(5 days 12 hours ago)
by julian
Affects:  /head/sys/sys/sysent.h
Split MAKE_SYSENT into two parts so that the initializer part can be
used separately if one wants to embed the sysent into a larger structure.

MFC after: 1 week
05:33:19 - r303286
(5 days 15 hours ago)
by delphij
Affects: 
(32 files)
/stable/9/contrib/file/*
/stable/9/lib/libmagic/*
MFC r302221,302222:

MFV r302218: file 5.28.

Relnotes: yes
03:58:19 - r303285
(5 days 16 hours ago)
by delphij
Affects: 
(14 files)
/head/contrib/libdivsufsort/*
/head/usr.bin/bsdiff/bsdiff/*
Change bsdiff to use divsufsort suffix sort library instead of qsufsort,
which is more efficient.

Note that for now we do not create a separate library for libdivsufsort
because it's not used anywhere else.

Obtained from: Chromium
MFC after: 2 months
03:30:26 - r303284
(5 days 17 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/vmbus/vmbus_brvar.h
/head/sys/dev/hyperv/vmbus/vmbus_chanvar.h
hyperv/vmbus: Move bufring info definition to vmbus_brvar.h

MFC after: 1 week
Sponsored by: Microsoft OSTC
Differential Revision: https://reviews.freebsd.org/D7282
03:12:40 - r303283
(5 days 17 hours ago)
by sephe
Affects: 
(8 files)
/head/sys/dev/hyperv/netvsc/hv_rndis_filter.c
/head/sys/dev/hyperv/vmbus/*
hyperv/vmbus: Rename hv_vmbus_priv.h to vmbus_brvar.h

It only contains bufring related bits for a while.

MFC after: 1 week
Sponsored by: Microsoft OSTC
Differential Revision: https://reviews.freebsd.org/D7281
00:49:27 - r303282
(5 days 19 hours ago)
by emaste
Affects:  /head/sys/modules/Makefile
avoid building otusfw when WITHOUT_SOURCELESS_UCODE set

PR: 204748
Submitted by: Fabian Keil
Obtained from: ElectroBSD
MFC after: 1 week
00:46:45 - r303281
(5 days 19 hours ago)
by delphij
Affects: 
(2 files)
/stable/9/usr.bin/mail/collect.c
MFC r302542:

Use _PATH_DEVNULL instead of hardcoding.
00:46:01 - r303280
(5 days 19 hours ago)
by delphij
Affects: 
(2 files)
/stable/10/usr.bin/mail/collect.c
MFC r302542:

Use _PATH_DEVNULL instead of hardcoding.
2016 - 07 - 24   (6 days ago)
23:40:33 - r303279
(5 days 20 hours ago)
by emaste
Affects:  /head/contrib/elftoolchain/libelftc/libelftc_dem_gnu3.c
libelftc: fix demangling of wchar_t

"wchar_t" is 7 characters long, not 6.

PR: 208661
Submitted by: Daniel McRobb
Obtained from: ELF Tool Chain r3480
MFC after: 3 days
20:54:30 - r303278
(5 days 23 hours ago)
by sbruno
Affects: 
(3044 files)
/projects/mips64-clang/*
MFC to r303274
20:47:57 - r303277
(5 days 23 hours ago)
by glebius
Affects:  /head/usr.bin/calendar/calendars/ru_RU.UTF-8/calendar.orthodox
/head/usr.bin/calendar/calendars/ru_RU.UTF-8/calendar.pagan
Fix failures of scripted conversion.

Noticed by: ache
Pointy hat to: glebius
20:43:02 - r303276
(5 days 23 hours ago)
by delphij
Affects:  /vendor/libdivsufsort/0.0.2015.10.27
Tag libdivsufsort snapshot of 2015/10/27.

Git revision: 5f60d6f026c30fb4ac296f696b3c8b0eb71bd428
20:39:43 - r303275
(5 days 23 hours ago)
by delphij
Affects: 
(36 files)
/vendor/libdivsufsort/dist/*
Vendor import of libdivsufsort, a software library that implements
a lightweight suffix array construction algorithm.

Obtained from: https://github.com/y-256/libdivsufsort
18:50:11 - r303274
(6 days 1 hour ago)
by bdrewery
Affects:  /head/Makefile.inc1
/head/Makefile.libcompat
Don't disable binutils/elftoolchain bootstrapping with external compiler.

This was a regression from r300349.

Setting MK_CROSS_COMPILER=no forces the compiler bootstraping *and* the
binutils/elftoolchain bootstrapping to be disabled in share/mk/src.opts.mk.
The only intent with using an external compiler is to disable bootstrapping of
the compiler. The binutils/elftoolchain bootstrapping must still occur unless
XAS is set. This did not affect WITH_SYSTEM_COMPILER.

Now that setting an external compiler sets both MK_CLANG_BOOTSTRAP and
MK_GCC_BOOTSTRAP to no, and MK_CROSS_COMPILER does the same via
share/mk/src/opts.mk, remove redundant logic that checks for
MK_CROSS_COMPILER. It will not always be true now that MK_CROSS_COMPILER==no
when an external compiler is used and --sysroot/-target is needed.

Reported by: sbruno
Pointyhat to: bdrewery
MFC after: 3 days
Sponsored by: EMC / Isilon Storage Division
18:28:14 - r303273
(6 days 2 hours ago)
by bdrewery
Affects:  /head/Makefile.inc1
Fix empty WANT_COMPILER_TYPE when neither compiler is bootstrapped.

Bug in r303272.

MFC after: 3 days
X-MFC-With: r303272
Sponsored by: EMC / Isilon Storage Division
18:05:05 - r303272
(6 days 2 hours ago)
by bdrewery
Affects:  /head/Makefile
/head/Makefile.inc1
SYSTEM_COMPILER: Rework the logic to allow a 'make test-system-compiler'.

1. Always calculate what the expected values are.
2. Add 'make test-system-compiler' to show all of the computed values
  vs the wanted values.
3. Extend the .info line to buildkernel/kernel-toolchain/toolchain/_cross-tools.
4. Consolidate all of the logic to one condition.

MFC after: 3 days
Sponsored by: EMC / Isilon Storage Division
18:04:12 - r303271
(6 days 2 hours ago)
by br
Affects:  /head/share/mk/bsd.sys.mk
/head/sys/conf/kern.mk
Fix style.
17:07:39 - r303270
(6 days 3 hours ago)
by adrian
Affects:  /svnadmin/conf/access
/svnadmin/conf/mentors
oops - correct username!

Approved by: core
16:33:48 - r303269
(6 days 4 hours ago)
by sbruno
Affects:  /stable/10/sys/dev/ixgbe/ixgbe_phy.c
MFC r303032
Fixup DA cable detection routines to not set the cable type to
unknown if they do not match one of two cable types.

PR: 150249
16:32:34 - r303268
(6 days 4 hours ago)
by sbruno
Affects: 
(2 files)
/stable/11/sys/dev/ixgbe/ixgbe_phy.c
MFC r303032
Fixup DA cable detection routines to not set the cable type to
unknown if they do not match one of two cable types.

PR: 150249
Approved by: re (gjb)
14:50:16 - r303267
(6 days 5 hours ago)
by tuexen
Affects: 
(10 files)
/stable/11/sys/netinet/*
/stable/11/usr.bin/netstat/*
MFC r302904:
Fix a bug which results in a core dump when running netstat with
the -W option and having a listening SCTP socket.
The bug was introduced in r279122 when adding support for libxo.

MFC r302907:
When calling netstat -Laptcp the local address values are not aligned
with the corresponding entry in the table header. r295136
increased the value width from 14 to 32 without the corresponding
change to the table header. This commit adds the change to the table
header width.

MFC r302917:
Ensure that the -a, -W, -L options for SCTP behave similar
as for TCP.

MFC r302928:
Address a potential memory leak found a the clang static code analyzer
running on the userland stack.

MFC r302930:
Don't free a data chunk twice.
Found by the clang static code analyzer running for the userland stack.

MFC r302935:
Deal with a portential memory allocation failure, which was reported
by the clang static code analyzer.
Joint work with rrs@.

MFC r302942:
Add missing sctps_reasmusrmsgs counter.
Joint work with rrs@.

MFC r302945:
Don't duplicate code for SCTP, just use the ones used for UDP and TCP.
This fixes a bug with link local addresses. This will require and
upcoming change in the kernel to bring SCTP to the same behaviour
as UDP and TCP.

MFC r302949:
Fix the PR-SCTP behaviour.
This is done by rrs@.

MFC r302950:
Add a constant required by RFC 7496.

MFC r303024:
netstat and sockstat expect the IPv6 link local addresses to
have an embedded scope. So don't recover.

MFC r303025:
Use correct order of conditions to avoid NULL deref.

MFC r303073:
Fix a bug in deferred stream reset processing which results
in using a length field before it is set.
Thanks to Taylor Brandstetter for reporting the issue and
providing a fix.

Approved by: re (kib)
14:42:11 - r303266
(6 days 5 hours ago)
by mav
Affects:  /head/sys/dev/ntb/ntb_hw/ntb_hw.c
Postpone ntb_get_msix_info() till we need to negotiate MSIX.

Calling it earlier increases the window when MSIX info may change.
This change does not solve the problem completely, but seems logical.
Complete solution should probably include link reset in case of MSIX
remap to trigger new negotiation, but we have no way to get notified
about that now.
11:05:23 - r303265
(6 days 9 hours ago)
by bapt
Affects:  /head/usr.bin/calendar/calendar.1
Remove reference cpp(1) which is not used anymore
10:35:44 - r303264
(6 days 9 hours ago)
by glebius
Affects: 
(5 files)
/head/usr.bin/calendar/calendars/ru_RU.UTF-8/*
The date format for ru_RU.UTF-8 locale has changed some time ago, adjust
the ru_RU.UTF-8 calendar files.
10:10:09 - r303263
(6 days 10 hours ago)
by glebius
Affects:  /head/sys/compat/svr4/svr4_sockio.c
/head/sys/net/if.c
Partially revert r257696/r257713, which have an issue with writing to user
controlled address. Restore the old code that emulated OSIOCGIFCONF in if.c.

Noticed by: C Turt
10:00:29 - r303262
(6 days 10 hours ago)
by trasz
Affects: 
(3 files)
/stable/11/usr.sbin/ctld/ctl.conf.5
/stable/11/usr.sbin/ctld/ctld.8
MFC r303132:

Add documentation for "ctld -u", the UCL configuration file format.

Submitted by: jceel@
Approved by: re (kib)
MFC after: 1 month
Differential Revision: https://reviews.freebsd.org/D7222
09:15:11 - r303261
(6 days 11 hours ago)
by mav
Affects: 
(6 files)
/head/sys/*
Add more UEFI/e820 memory types from latest specifications.

This is only cosmetics.

MFC after: 2 weeks
09:00:16 - r303260
(6 days 11 hours ago)
by bapt
Affects: 
(23 files)
/stable/11/share/timedef/*
MFC: r303219

Add weekday to the date format of more locales
Approved by: re (kib)
08:52:49 - r303259
(6 days 11 hours ago)
by andrew
Affects:  /head/sys/dev/uart/uart_cpu_fdt.c
Remove now unused functions from the FDT uart cpu driver.

Obtained from: ABT Systems Ltd
MFC after: 1 month
X-MFC with: r303100
Sponsored by: The FreeBSD Foundation
08:35:45 - r303258
(6 days 11 hours ago)
by mizhka
Affects: 
(4 files)
/head/sys/conf/files.mips
/head/sys/dev/nvram2env/*
[nvram2env] split implementation into generic & MIPS-based code

Split implementation of nvram2env to generic (MI) & MIPS-based code:

 - removed includes like "*siba*", because they are unused
 - added nvram2env_mips.c file with MIPS-specific code, code moved from
nvram2env.c
 - added header file to shared defines/structures/function prototypes between
MI and MIPS code

Also this fix allows to implement own nvram2env drivers.

Reviewed by: ray, adrian (mentor)
Approved by: adrian (mentor)
Differential Revision: https://reviews.freebsd.org/D6513
08:21:21 - r303257
(6 days 12 hours ago)
by bapt
Affects: 
(3 files)
/stable/10/usr.sbin/pw/rm_r.c
/stable/10/usr.sbin/pw/tests/pw_userdel.sh
Do not try to delete the home of the user if is is not a directory for example
"/dev/null"

PR: 211195
Submitted by: rday <ryan@ryanday.net>
Reported by: eniorm <eniorm@gmail.com>
08:12:23 - r303256
(6 days 12 hours ago)
by bapt
Affects: 
(3 files)
/stable/11/usr.sbin/pw/rm_r.c
/stable/11/usr.sbin/pw/tests/pw_userdel.sh
iDo not try to delete the home of the user if is is not a directory for example
"/dev/null"

PR: 211195
Submitted by: rday <ryan@ryanday.net>
Reported by: eniorm <eniorm@gmail.com>
Approved by: re (kib)
05:24:10 - r303255
(6 days 15 hours ago)
by jhb
Affects: 
(10 files)
/stable/10/*
/stable/9/*
MFC 302175:
Add pci_get_max_payload() to fetch the PCI-express maximum payload size.
04:38:50 - r303254
(6 days 15 hours ago)
by jhb
Affects: 
(13 files)
/stable/10/*
/stable/9/*
MFC 300253: Remove dangling references to rman_await_resource().

This function was removed when RF_TIMESHARE was removed a couple of years
ago.
01:31:41 - r303253
(6 days 19 hours ago)
by loos
Affects:  /head/sys/arm/ti/files.ti
Allow the use of micphy on am335x devices.

The Micrel PHYs reads the optional external delays from DTB.

Tested and used by uBMC and uFW.

Sponsored by: Rubicon Communications (Netgate)

 


Powered by Python FreeBSD support by secnetix GmbH & Co. KG

Page generated in 53 ms, 307 revisions printed. Current time is 2016-07-30 20:34:55. All times are in UTC/GMT.