SVNews

NOTE: This service is experimental and subject to change! Use at your own risk!

Year:   Month: - or - Filter committers: - or -
Filter paths:
Include diffs if smaller than lines.

2016 - 04 - 30   (today)
18:07:13 - r298855
( 38 minutes ago)
by manu
Affects:  /head/sys/arm/allwinner/aw_nmi.c
ACK the interrupt after disabling it, this avoid an interrupt storm.

Approved by: andrew (mentor)
17:27:33 - r298854
(1 hour 17 minutes ago)
by andrew
Affects: 
(18 files)
/head/sys/arm/*
/head/sys/conf/options.arm
Add a MULTIDELAY option to allow the ARM kernel to have multiple DELAY
implementations. Early in the boot the kernel will use an approximate,
however after the timer has been probed it will switch to a more accurate
implementation.

Reviewed by: manu
Sponsored by: ABT Systems Ltd
Differential Revision: https://reviews.freebsd.org/D5762
16:01:38 - r298853
(2 hours 43 minutes ago)
by emaste
Affects:  /head/sys/fs/fdescfs/fdesc.h
/head/sys/fs/fdescfs/fdesc_vfsops.c
/head/sys/fs/fdescfs/fdesc_vnops.c
Rationalize license numbering in fdescfs(5)
15:06:18 - r298852
(3 hours 39 minutes ago)
by jamie
Affects: 
(4 files)
/stable/10/etc/defaults/rc.conf
/stable/10/etc/rc.d/jail
/stable/10/share/man/man5/rc.conf.5
MFC r295471:

  Add new rc.conf parameter "jail_reverse_stop"

  When a user defines "jail_list" in rc.conf the jails are started in the
  order defined. Currently the jails are not are stopped in reverse order
  which may break dependencies between jails/services and prevent a clean
  shutdown. The new parameter "jail_reverse_stop" will shutdown jails in
  "jail_list" in reverse order when set to "YES".

  Please note that this does not affect manual invocation of the jail rc
  script. If a user runs the command

  # service jail stop jail1 jail2 jail3

  the jails will be stopped in exactly the order specified regardless of
  jail_reverse_stop being defined in rc.conf.

MFC r295568:

  Document the new jail_reverse_stop parameter

  While here clean up the documentation for jail_list

PR: 196152
Submitted by: feld
14:48:30 - r298851
(3 hours 56 minutes ago)
by bapt
Affects:  /head/usr.bin/sdiff/sdiff.c
When checking for binary file, check if ch is not EOF only ch actually got
a value assigned

Reported by: pfg
14:47:45 - r298850
(3 hours 57 minutes ago)
by wblock
Affects: 
(2 files)
/stable/10/usr.sbin/pw/pw.8
MFC r298525:

Add a single example of adding a user that roughly corresponds with the
adduser example in the Handbook.
14:43:42 - r298849
(4 hours 1 minute ago)
by pfg
Affects:  /head/include/arpa/nameser.h
/head/include/rpcsvc/klm_prot.x
include: minor spelling fixes.

No functional change.
14:41:18 - r298848
(4 hours 4 minutes ago)
by pfg
Affects: 
(21 files)
/head/sys/*
sys: Make use of our rounddown() macro when sys/param.h is available.

No functional change.
14:25:00 - r298847
(4 hours 20 minutes ago)
by tuexen
Affects: 
(6 files)
/head/sys/netinet/*
Add the UDP encaps port as a parameter to sctp_add_remote_addr().

This is currently only a code change without any functional
change. But this allows to set the remote encapsulation port
in a more detailed way, which will be provided in a follow-up
commit.

MFC after: 1 week
12:44:03 - r298846
(6 hours 1 minute ago)
by emaste
Affects:  /head/sys/fs/fdescfs/fdesc_vfsops.c
/head/sys/fs/fdescfs/fdesc_vnops.c
ANSIfy fdescfs(5)
10:35:42 - r298845
(8 hours 9 minutes ago)
by dim
Affects: 
(66 files)
/head/contrib/subversion/*
/head/usr.bin/svn/*
Update from subversion 1.9.2 to 1.9.4.

This contains only bug fixes, no new features. The repository format is
also unchanged from 1.9.2. Full list of changes between 1.9.4 and
earlier versions:

  https://svn.apache.org/repos/asf/subversion/tags/1.9.4/CHANGES

Note that the two security issues fixed in 1.9.4 (CVE-2016-2167 and
CVE-2016-2168) do not affect the version of Subversion in the FreeBSD
base system, since neither SASL nor Apache modules are enabled.

Relnotes: yes
MFC after: 2 weeks
09:50:08 - r298844
(8 hours 55 minutes ago)
by ngie
Affects:  /head/etc/rc.d/SERVERS
/head/etc/rc.d/kdc
Make SERVERS REQUIRE clean when MK_KERBEROS==no

Make kdc run BEFORE SERVERS instead of being REQUIREd by SERVERS,
so systems that pedantically check REQUIREs function after r270782

MFC after: 1 week
X-MFC with: r270782
Sponsored by: EMC / Isilon Storage Division
09:43:01 - r298843
(9 hours 2 minutes ago)
by ngie
Affects: 
(4 files)
/stable/9/sbin/ping6/ping6.c
MFstable/10 r272871:
r272871 (by hrs):

MFC r271909:
  Revert changes in r269180. It could cause -c N option to enter an
  infinite loop if no reply packet is received.
09:32:19 - r298842
(9 hours 13 minutes ago)
by ngie
Affects:  /head/lib/libkvm/kvm_amd64.c
Don't leak PML4 in _amd64_initvtop(..) if kvm_read2(..) fails

MFC after: 1 week
Reported by: Coverity
CID: 1341474
Sponsored by: EMC / Isilon Storage Division
09:31:01 - r298841
(9 hours 14 minutes ago)
by ngie
Affects:  /head/lib/libkvm/kvm_sparc64.c
Remove a -Wunused-but-set-variable variable -- `pa`

Reported by: gcc 5.x
Sponsored by: EMC / Isilon Storage Division
09:21:13 - r298840
(9 hours 24 minutes ago)
by ngie
Affects: 
(6 files)
/head/ObsoleteFiles.inc
/head/lib/libkvm/*
Remove kvm_getfiles(3)

This libcall has been broken since (at least) r174989/8.0-RELEASE.

Bump SHLIB_MAJOR for the change

Differential Revision: https://reviews.freebsd.org/D6052
Relnotes: yes
Reviewed by: jhb, markj
Sponsored by: EMC / Isilon Storage Division
09:13:26 - r298839
(9 hours 31 minutes ago)
by ngie
Affects:  /head/lib/libkvm/kvm_proc.c
Fix memory allocation edgecases in kvm_argv(..)

- Don't leak nbufp on realloc failure in kvm_argv
- Catch malloc errors with bufp
- Set buflen last in the "buflen == 0" case to ensure that
  bufp/nbufp is properly reallocated on the next go around

Differential Revision: https://reviews.freebsd.org/D6051
MFC after: 1 week
Reviewed by: jhb, markj
Reported by: cppcheck
Sponsored by: EMC / Isilon Storage Division
06:48:48 - r298838
(11 hours 56 minutes ago)
by jkim
Affects:  /head/sys/contrib/dev/acpica/components/hardware/hwregs.c
Revert AccessWidth/BitOffset support for AcpiHwWrite() and AcpiHwRead() for
now. The following upstream commits are reverted from hwregs.c:

https://github.com/acpica/acpica/commit/96ece05
https://github.com/acpica/acpica/commit/3d8583a
https://github.com/acpica/acpica/commit/48eea5e
https://github.com/acpica/acpica/commit/0a212c3
https://github.com/acpica/acpica/commit/41f6aef
https://github.com/acpica/acpica/commit/26434b9
https://github.com/acpica/acpica/commit/c23034a
https://github.com/acpica/acpica/commit/c49a751

Note this commit will be reverted when the upstream fixes the code properly.
06:37:32 - r298837
(12 hours 7 minutes ago)
by bapt
Affects:  /head/etc/mtree/BSD.tests.dist
Add sdiff test directory to the tests mtree
06:35:20 - r298836
(12 hours 10 minutes ago)
by arybchik
Affects: 
(3 files)
/stable/10/sys/dev/sfxge/sfxge_ev.c
/stable/10/sys/dev/sfxge/sfxge_rx.c
MFC r298735

sfxge(4): do not use RxQ index as label

Labels are limitted by 32 on EF10. It is not sufficient on powerful hosts.
Since only one RxQ is running over each EvQ, zero label may be used.

Reviewed by: gnn
Sponsored by: Solarflare Communications, Inc.
PR: 208267
Differential Revision: https://reviews.freebsd.org/D6121
04:02:32 - r298835
(14 hours 42 minutes ago)
by jamie
Affects: 
(5 files)
/stable/10/sys/kern/*
/stable/10/usr.sbin/jail/jail.8
MFC r298584:

  Note the existence of module-specific jail paramters, starting with the
  linux.* parameters when linux emulation is loaded.

MFC r298585:

  Encapsulate SYSV IPC objects in jails. Define per-module parameters
  sysvmsg, sysvsem, and sysvshm, with the following bahavior:

  inherit: allow full access to the IPC primitives. This is the same as
  the current setup with allow.sysvipc is on. Jails and the base system
  can see (and moduly) each other's objects, which is generally considered
  a bad thing (though may be useful in some circumstances).

  disable: all no access, same as the current setup with allow.sysvipc off.

  new: A jail may see use the IPC objects that it has created. It also
  gets its own IPC key namespace, so different jails may have their own
  objects using the same key value. The parent jail (or base system) can
  see the jail's IPC objects, but not its keys.

PR: 48471
04:01:22 - r298834
(14 hours 44 minutes ago)
by jamie
Affects: 
(4 files)
/stable/10/share/man/man9/osd.9
/stable/10/sys/kern/kern_osd.c
/stable/10/sys/sys/osd.h
MFC r297367:

  Move the various per-type arrays of OSD data into a single structure array.

MFC r297422:

  Add osd_reserve() and osd_set_reserved(), which allow M_WAITOK allocation
  of an OSD array.
03:19:07 - r298833
(15 hours 26 minutes ago)
by jamie
Affects: 
(3 files)
/stable/10/sys/kern/kern_jail.c
/stable/10/sys/sys/jail.h
MFC r298565:

  Add a new jail OSD method, PR_METHOD_REMOVE. It's called when a jail is
  removed from the user perspective, i.e. when the last pr_uref goes away,
  even though the jail mail still exist in the dying state. It will also
  be called if either PR_METHOD_CREATE or PR_METHOD_SET fail.

MFC r298683:

  Delay removing the last jail reference in prison_proc_free, and instead
  put it off into the pr_task. This is similar to prison_free, and in fact
  uses the same task even though they do something slightly different.

MFC r298566:

  Pass the current/new jail to PR_METHOD_CHECK, which pushes the call
  until after the jail is found or created. This requires unlocking the
  jail for the call and re-locking it afterward, but that works because
  nothing in the jail has been changed yet, and other processes won't
  change the important fields as long as allprison_lock remains held.

  Keep better track of name vs namelc in kern_jail_set. Name should
  always be the hierarchical name (relative to the caller), and namelc
  the last component.

MFC r298668:

  Use crcopysafe in jail_attach.

PR: 48471
03:05:36 - r298832
(15 hours 39 minutes ago)
by jamie
Affects: 
(3 files)
/stable/10/sys/kern/kern_jail.c
/stable/10/sys/sys/jail.h
MFC r298564:

  Remove the PR_REMOVE flag, which was meant as a temporary marker for
  a jail that might be seen mid-removal. It hasn't been doing the right
  thing since at least the ability to resurrect dying jails, and such
  resurrection also makes it unnecessary.
02:47:41 - r298831
(15 hours 57 minutes ago)
by pfg
Affects: 
(5 files)
/head/sys/boot/forth/*
boot/forth: spelling fixes.

Reviewed by: dteske
MFC after: 2 weeks
01:24:24 - r298830
(17 hours 20 minutes ago)
by pfg
Affects: 
(34 files)
/head/lib/libc/*
libc: spelling fixes.

Mostly on comments.
00:53:10 - r298829
(17 hours 52 minutes ago)
by pfg
Affects: 
(9 files)
/head/sys/compat/linux/*
/head/sys/compat/linuxkpi/common/*
sys/compat/linux*: spelling fixes.

Mostly on comments but there are some user-visible messages as well.

MFC after: 2 weeks
00:35:46 - r298828
(18 hours 9 minutes ago)
by pfg
Affects: 
(6 files)
/head/sys/compat/ndis/*
ndis: spelling fixes in comments.

No functional change.
00:34:04 - r298827
(18 hours 11 minutes ago)
by pfg
Affects:  /head/sys/compat/x86bios/x86bios.h
x86bios: spelling fix in a comment.

No functional change.
00:26:38 - r298826
(18 hours 18 minutes ago)
by pfg
Affects: 
(22 files)
/head/sys/boot/*
sys/boot: spelling fixes in comments.

No functional change.
2016 - 04 - 29   (yesterday)
23:55:22 - r298825
(18 hours 50 minutes ago)
by jhb
Affects:  /head/sys/conf/NOTES
Add PCI_IOV to NOTES.
23:53:55 - r298824
(18 hours 51 minutes ago)
by jhb
Affects: 
(7 files)
/head/sys/*
Move 'device pci' for the PCI bus driver to the MI NOTES file.

The PCI bus was already listed in all of the MD NOTES files and the
driver should at least compile on all platforms.
23:27:15 - r298823
(19 hours 18 minutes ago)
by bapt
Affects: 
(40 files)
/head/gnu/usr.bin/*
/head/usr.bin/Makefile
/head/usr.bin/sdiff/*
import sdiff(1) from GSoC 2012

Import sdiff(1) from the diff version written by Raymond Lai,
improved during GSoC 2012 by Jesse Hagewood.

Compared to the version done in during that summer of code:
- Remove the zlib frontend: zsdiff
- Compatible output (column size and separators) with GNU sdiff

Compared to GNU sdiff in ports:
- The only difference is padding using spaces vs tabs

Compared to OpenBSD and NetBSD import:
- Implement missing options (including long options) from GNU sdiff
- Improved support for the edition mode (signal handling)
- Output visually compatible with GNU sdiff: size of columns

While here import regression tests from NetBSD adapted to fit the output as
expected by GNU sdiff

Reviewed by: emaste (in part)
Obtained from: OpenBSD, NetBSD, GSoC 2012
Relnotes: yes
Differential Revision: https://reviews.freebsd.org/D5981
Differential Revision: https://reviews.freebsd.org/D6032 (diff with NetBSD
version)
Differential Revision: https://reviews.freebsd.org/D6033 (diff with OpenBSD
version)
22:43:11 - r298822
(20 hours 2 minutes ago)
by avos
Affects:  /head/sys/dev/wpi/if_wpi.c
wpi: convert to ieee80211_add_channel() (mostly noop).

Tested with Intel 3945BG, STA / HOSTAP modes.
22:42:59 - r298821
(20 hours 2 minutes ago)
by gonzo
Affects: 
(6 files)
/head/sys/boot/fdt/*
/head/sys/boot/uboot/fdt/uboot_fdt.c
Add FDT overlays support to ubldr

FDT overlays is de-facto standard for describing expansion boards like
Beaglebone capes or Raspberry Pi shields. The ides is to have basic
DTB for base board and overlays DTB for shields/capes and to construct
final DTB either using human-readable configuration or some
self-discovery mechanism. I believe this approach can also be expanded
to support dynamically loadable FPGA bitstreams on systems like
Zedboard/Zybo.

Overlaying process is simmilar to executable link process for
binaries: each DTB has "exported" symbols and "undefined" symbols, the
latter are resolved using information for the former obtained from
base DTB or one of the overlays applied earlier (more rare case).

This symbols information is not generated by standard dtc that FreeBSD
has in base system, patched[1] version required to produces
overlay-compatible blobs. So although DTB files generated by
buildkernel do not support overlays there are enough
vendor/community-provided DTB blobs ciruclating around to justify
committing this change to ubldr.

This commit introduces handler for "fdt_overlays" variable that can be
defined either as a loader env variable or U-Boot env variable.
fdt_overlays is comma-separated list of .dtbo files located in
/boot/dtb/ directory along with base .dtb. ubldr loads files and
applies them one-by-one to base .dtb and then passes result blob to
the kernel.

[1]
https://github.com/RobertCNelson/dtc/commit/dd6a0533e846e8d5e690a618fa35cc15a6103efb

Differential Revision: https://reviews.freebsd.org/D3180
22:29:33 - r298820
(20 hours 15 minutes ago)
by jhb
Affects:  /head/sys/arm/conf/NOTES
/head/sys/powerpc/conf/NOTES
Remove vestiges of IEEE-488/GPIB drivers removed in r276214.
22:15:33 - r298819
(20 hours 29 minutes ago)
by pfg
Affects: 
(44 files)
/head/sys/kern/*
sys/kern: spelling fixes in comments.

No functional change.
22:14:11 - r298818
(20 hours 31 minutes ago)
by avos
Affects: 
(19 files)
/head/sys/dev/*
/head/sys/net80211/_ieee80211.h
net80211 + drivers: hide size of 'bands' array behind a macro.

Auto-replace 'howmany(IEEE80211_MODE_MAX, 8)' with 'IEEE80211_MODE_BYTES'.
No functional changes.
21:54:28 - r298817
(20 hours 50 minutes ago)
by pfg
Affects:  /head/sys/kern/vfs_bio.c
/head/sys/kern/vfs_vnops.c
sys/kern: spelling fixes.

Mostly on comments but affects some debug messages.

MFC after: 2 weeks
21:46:43 - r298816
(20 hours 58 minutes ago)
by jmcneill
Affects:  /head/sys/dev/dwc/if_dwcvar.h
Set txbuf_map array size to TX_DESC_COUNT instead of RX_DESC_COUNT.
21:38:36 - r298815
(21 hours 6 minutes ago)
by avos
Affects:  /head/sys/dev/wpi/if_wpi.c
wpi: remove unused variable.
21:29:37 - r298814
(21 hours 15 minutes ago)
by asomers
Affects:  /head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c
Fix a use-after-free when "zpool import" fails

clear vd->vdev_tsd in vdev_geom_close_locked instead of vdev_geom_detach.
In the latter function, it would fail to happen in certain circumstances
where cp->private was unset. Ideally, the latter should never happen, but
it can happen when vdev open fails, or where spares are involved.

MFC after: 4 weeks
X-MFC-With: 298786
Sponsored by: Spectra Logic Corp
21:25:05 - r298813
(21 hours 20 minutes ago)
by pfg
Affects: 
(38 files)
/head/sys/netgraph/*
sys/netgraph: spelling fixes in comments.

No functional change.
21:18:14 - r298812
(21 hours 27 minutes ago)
by avos
Affects:  /head/sys/net80211/ieee80211.c
/head/sys/net80211/ieee80211_regdomain.c
/head/sys/net80211/ieee80211_var.h
net80211: provide a set of ieee80211_add_channel*() functions

This change adds few methods for net80211 channel table setup:

- ieee80211_add_channel()
- ieee80211_add_channel_ht40()
(primarily for drivers, that parse EEPROM to get channel list -
they will allow to hide implementation details).

- ieee80211_add_channel_list_2ghz()
- ieee80211_add_channel_list_5ghz()
(mostly as a replacement for ieee80211_init_channels() - they will allow
to specify non-default channel list; may be used in ic_getradiocaps()).

Tested with wpi(4) (add_channel) and rum(4) (add_channel_list_2ghz).

Reviewed by: adrian
Differential Revision: https://reviews.freebsd.org/D6124
21:11:31 - r298811
(21 hours 33 minutes ago)
by asomers
Affects:  /head/sys/kern/subr_unit.c
/head/tests/sys/kern/Makefile
Automate the subr_unit test.

Build and install the subr_unit test program originally written by phk, and
run it with the other ATF tests.

tests/sys/kern/Makefile
  * Build and install the subr_unit test as a plain test

sys/kern/subr_unit.c
  * Reduce the default number of repetitions from 100 to 1, and add a
  command-line parser to override it.
  * Don't be so noisy by default
  * Fix an include problem for the test build

Reviewed by: ngie
MFC after: 4 weeks
Sponsored by: Spectra Logic Corp
Differential Revision: https://reviews.freebsd.org/D6038
21:05:48 - r298810
(21 hours 39 minutes ago)
by pfg
Affects: 
(15 files)
/head/sys/cam/*
sys/cam: spelling fixes in comments.

No functional change.
21:04:06 - r298809
(21 hours 41 minutes ago)
by pfg
Affects:  /head/sys/cam/cam_queue.c
sys/cam: spelling fixes.

Affects a debug message.

MFC after: 2 weeks
20:56:58 - r298808
(21 hours 48 minutes ago)
by pfg
Affects: 
(18 files)
/head/sys/geom/*
sys/geom: spelling fixes in comments.

No functional change.
20:53:39 - r298807
(21 hours 51 minutes ago)
by pfg
Affects:  /head/sys/ddb/db_textdump.c
sys/ddb: spelling fixes in comments.

No functional change.
20:51:24 - r298806
(21 hours 53 minutes ago)
by pfg
Affects: 
(15 files)
/head/sys/fs/*
sys/fs: spelling fixes in comments.

No functional change.
20:45:50 - r298805
(21 hours 59 minutes ago)
by pfg
Affects:  /head/sys/fs/ext2fs/ext2_inode.c
fs/ext2fs: spelling fixes on comment.

No functional change.
20:43:51 - r298804
(22 hours 1 minute ago)
by pfg
Affects: 
(6 files)
/head/sys/ufs/ffs/*
/head/sys/ufs/ufs/*
UFS: spelling fixes on comments.

No functional change.
20:33:20 - r298803
(22 hours 12 minutes ago)
by tuexen
Affects:  /head/sys/netinet/sctputil.c
Don't assign, just compare...
20:31:49 - r298802
(22 hours 13 minutes ago)
by gonzo
Affects:  /head/sys/arm/ti/ti_adc.c
/head/sys/arm/ti/ti_adcreg.h
/head/sys/arm/ti/ti_adcvar.h
Add driver for AM33xx SoC touchscreen

Split ADC driver in two halves: ADC(analog ot digital) and
TSC(touchscreen). Touchscreen driver is fully functional
up to the point of reporting samples. This part will be added
once FreeBSD has API for touchscreen.

Tested on: Beaglebone Black + 4DCAPE-43T
Reviewed by: loos
Differential Revision: https://reviews.freebsd.org/D5847
20:22:10 - r298801
(22 hours 23 minutes ago)
by pfg
Affects:  /head/sys/compat/x86bios/x86bios.c
x86bios_alloc(): Unsign a counter.

The value can't even be signed so we can avoid the signed vs. unsigned
comparison.

Reviewed by: jkim
20:22:01 - r298800
(22 hours 23 minutes ago)
by tuexen
Affects:  /head/sys/netinet/ip_icmp.h
/head/sys/netinet/sctputil.c
Add support for handling ICMP and ICMP6 messages sent in response
to SCTP/UDP/IP and SCTP/UDP/IPv6 packets.
20:19:41 - r298799
(22 hours 25 minutes ago)
by kp
Affects: 
(3 files)
/stable/10/sys/fs/msdosfs/direntry.h
/stable/10/sys/fs/msdosfs/msdosfs_conv.c
MFC r298664

msdosfs: Prevent buffer overflow when expanding win95 names

In win2unixfn() we expand Windows 95 style long names. In some cases that
requires moving the data in the nbp->nb_buf buffer backwards to make room. That
code failed to check for overflows, leading to a stack overflow in win2unixfn().

We now check for this event, and mark the entire conversion as failed in that
case. This means we present the 8 character, dos style, name instead.

PR: 204643
Differential Revision: https://reviews.freebsd.org/D6015
20:13:35 - r298798
(22 hours 31 minutes ago)
by tuexen
Affects:  /head/sys/netinet6/udp6_usrreq.c
Use correct order of source and destination address and port.
20:12:45 - r298797
(22 hours 32 minutes ago)
by jhb
Affects:  /head/sys/kern/sys_socket.c
/head/sys/sys/socketvar.h
Expose soaio_enqueue().

This can be used by protocol-specific AIO handlers to queue work to the
socket AIO daemon pool.

Sponsored by: Chelsio Communications
20:11:09 - r298796
(22 hours 34 minutes ago)
by jhb
Affects: 
(4 files)
/head/sys/kern/*
/head/sys/sys/protosw.h
Introduce a new protocol hook pru_aio_queue.

This allows a protocol to claim individual AIO requests instead of using
the default socket AIO handling.

Sponsored by: Chelsio Communications
19:17:31 - r298795
(23 hours 27 minutes ago)
by dim
Affects:  /vendor/subversion/subversion-1.9.4
Tag subversion-1.9.4 import.
19:16:59 - r298794
(23 hours 28 minutes ago)
by dim
Affects: 
(63 files)
/vendor/subversion/dist/*
Vendor import of subversion-1.9.4.
19:10:22 - r298793
(23 hours 35 minutes ago)
by dchagin
Affects:  /head/sys/dev/iwm/if_iwm.c
The iwm_nic_error() defined if IWM_DEBUG is defined.
18:53:16 - r298792
(23 hours 52 minutes ago)
by adrian
Affects:  /head/sys/dev/ath/if_ath_tx_ht.c
[ath] initialise do_ldpc to 0.

I .. can't believe I missed this.

This showed up because the AP was TX'ing LDPC to an iwm(4) chipset,
which didn't advertise LDPC and doesn't /accept/ LDPC. Amusingly, all
the two other FreeBSD 11n parts I had tested with (AR9380, Intel 7260)
and I completely forgot to test on ye olde hardware.

That'll teach me.

Tested:

* AR9580 (AP) - Intel 7260 (STA), AR9380 (STA), Intel 6205 (STA)
17:56:16 - r298791
(1 day ago)
by cem
Affects:  /head/sys/sys/buf.h
PRINT_BUF_FLAGS: Remove removed DIRTY/PERSIST flags

This is a follow-up to r298789, which removed the B_DIRTY and B_PERSISTENT
flags. This changeset removes them from the associated %b bit description
string as well.

Reviewed by: pfg
Sponsored by: EMC / Isilon Storage Division
17:35:28 - r298790
(1 day 1 hour ago)
by jhb
Affects:  /head/sys/vm/vm_page.c
Don't require write locks on the VM object for vm_page_prev/next.

Reviewed by: kib
Sponsored by: Chelsio Communications
16:32:28 - r298789
(1 day 2 hours ago)
by pfg
Affects:  /head/sys/kern/vfs_bio.c
/head/sys/sys/buf.h
bufs: make B_DIRTY and B_PERSISTENT flags available

It appears these flags were related to ext2fs but are completely
unused nowadays. Retire them.

Suggested by: mckusick
16:07:25 - r298788
(1 day 2 hours ago)
by pfg
Affects: 
(13 files)
/head/sys/fs/*
/head/sys/nfs/*
NFS: spelling fixes on comments.

No funcional change.
15:45:22 - r298787
(1 day 3 hours ago)
by avg
Affects:  /head/sys/cddl/dev/dtrace/x86/dis_tables.c
add invpcid instruction to i386 dtrace disassembler tables

MFC after: 2 weeks
15:23:51 - r298786
(1 day 3 hours ago)
by asomers
Affects:  /head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c
Refactor vdev_geom_attach and friends to reduce code duplication

sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c
  Move checks for provider's sectorsize and mediasize into a single
  location in vdev_geom_attach. Remove the zfs::vdev::taste class;
  it's ok to use the regular vdev class for tasting. Consolidate guid
  checks into a single location in vdev_attach_ok. Consolidate some
  error handling code from vdev_geom_attach into vdev_geom_detach,
  closing a resource leak of geom consumers in the process.

Reviewed by: avg
MFC after: 4 weeks
Sponsored by: Spectra Logic Corp
Differential Revision: https://reviews.freebsd.org/D5974
13:58:01 - r298785
(1 day 4 hours ago)
by danfe
Affects: 
(2 files)
/stable/8/bin/ed/cbc.c
MFC r270256, r298640:

  ed(1): switch two statements so we check the index before dereferencing.

Approved by: pfg
12:23:56 - r298784
(1 day 6 hours ago)
by bapt
Affects:  /head/etc/defaults/rc.conf
/head/etc/rc.d/savecore
/head/share/man/man5/rc.conf.5
Add a savecore_enable variable support for the savecore rc script

By default set to 'YES' so it does not change the current behaviour for users,
this variable allows to decide to not extract crach dumps from the dump
device at boot time by setting it to "NO" in rc.conf.

Sponsored by: Gandi.net
12:00:36 - r298783
(1 day 6 hours ago)
by hselasky
Affects:  /head/etc/devd/usb.conf
Regenerate usb.conf .

MFC after: 1 week
11:38:45 - r298782
(1 day 7 hours ago)
by hselasky
Affects: 
(4 files)
/stable/9/sys/dev/usb/quirk/usb_quirk.c
/stable/9/sys/dev/usb/usbdevs
MFC r297696 and r298424:
Add new USB quirks.

Submitted by: AJ <aleksanderlothe@live.com>
PR: 208623
Submitted by: Naram Qashat <cyberbotx@cyberbotx.com>
PR: 208642
11:37:06 - r298781
(1 day 7 hours ago)
by hselasky
Affects: 
(3 files)
/stable/10/sys/dev/usb/quirk/usb_quirk.c
/stable/10/sys/dev/usb/usbdevs
MFC r297696 and r298424:
Add new USB quirks.

Submitted by: AJ <aleksanderlothe@live.com>
PR: 208623
Submitted by: Naram Qashat <cyberbotx@cyberbotx.com>
PR: 208642
11:31:27 - r298780
(1 day 7 hours ago)
by hselasky
Affects: 
(2 files)
/stable/9/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_cm.c
MFC r298458:
Add missing set of the current VNET when inputting IP packets in IPoIB.

This fixes a kernel panic when using IPoIB with VIMAGE and infiniband.

PR: 208957
Sponsored by: Mellanox Technologies
Tested by: Justin Clift <justin@postgresql.org>
11:29:52 - r298779
(1 day 7 hours ago)
by hselasky
Affects: 
(2 files)
/stable/10/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_cm.c
MFC r298458:
Add missing set of the current VNET when inputting IP packets in IPoIB.

This fixes a kernel panic when using IPoIB with VIMAGE and infiniband.

PR: 208957
Sponsored by: Mellanox Technologies
Tested by: Justin Clift <justin@postgresql.org>
11:18:48 - r298778
(1 day 7 hours ago)
by hselasky
Affects: 
(4 files)
/stable/10/sys/ofed/drivers/net/mlx4/en_netdev.c
/stable/10/sys/ofed/drivers/net/mlx4/en_rx.c
/stable/10/sys/ofed/drivers/net/mlx4/mlx4_en.h
MFC r297968:
Remove some unused fields.

Sponsored by: Mellanox Technologies
11:17:25 - r298777
(1 day 7 hours ago)
by hselasky
Affects: 
(4 files)
/stable/9/sys/ofed/drivers/net/mlx4/en_netdev.c
/stable/9/sys/ofed/drivers/net/mlx4/en_rx.c
/stable/9/sys/ofed/drivers/net/mlx4/mlx4_en.h
MFC r297968:
Remove some unused fields.

Sponsored by: Mellanox Technologies
11:15:48 - r298776
(1 day 7 hours ago)
by hselasky
Affects: 
(3 files)
/stable/9/sys/ofed/drivers/net/mlx4/en_rx.c
/stable/9/sys/ofed/drivers/net/mlx4/mlx4_en.h
MFC r297967:
Ensure the received IP header gets 32-bits aligned.

The FreeBSD's TCP/IP stack assumes that the IP-header is 32-bits aligned
when decoding it. Else unaligned 32-bit memory access can happen, which
not all processor architectures support.

Sponsored by: Mellanox Technologies
11:14:02 - r298775
(1 day 7 hours ago)
by hselasky
Affects: 
(3 files)
/stable/10/sys/ofed/drivers/net/mlx4/en_rx.c
/stable/10/sys/ofed/drivers/net/mlx4/mlx4_en.h
MFC r297967:
Ensure the received IP header gets 32-bits aligned.

The FreeBSD's TCP/IP stack assumes that the IP-header is 32-bits aligned
when decoding it. Else unaligned 32-bit memory access can happen, which
not all processor architectures support.

Sponsored by: Mellanox Technologies
11:10:43 - r298774
(1 day 7 hours ago)
by hselasky
Affects: 
(2 files)
/stable/9/sys/ofed/drivers/net/mlx4/en_tx.c
MFC r297966:
Add missing port_up checks.

When downing a mlxen network adapter we need to check the port_up variable
to ensure we don't continue to transmit data or restart timers which can
reside in freed memory.

Sponsored by: Mellanox Technologies
11:06:24 - r298773
(1 day 7 hours ago)
by hselasky
Affects: 
(2 files)
/stable/10/sys/ofed/drivers/net/mlx4/en_tx.c
MFC r297966:
Add missing port_up checks.

When downing a mlxen network adapter we need to check the port_up variable
to ensure we don't continue to transmit data or restart timers which can
reside in freed memory.

Sponsored by: Mellanox Technologies
11:01:06 - r298772
(1 day 7 hours ago)
by hselasky
Affects:  /head/sys/dev/mlx5/mlx5_en/mlx5_en_main.c
Correct some error codes to native FreeBSD ones.

Sponsored by: Mellanox Technologies
Tested by: Netflix
MFC after: 1 week
11:00:12 - r298771
(1 day 7 hours ago)
by hselasky
Affects:  /head/sys/dev/mlx5/driver.h
/head/sys/dev/mlx5/mlx5_core/mlx5_eq.c
/head/sys/dev/mlx5/mlx5_en/mlx5_en_main.c
Add function to detect the presence of a port module and use this
function to error out early when no port module is present and doing
eeprom access. This also prevents error codes from filling up in
dmesg.

Sponsored by: Mellanox Technologies
Tested by: Netflix
MFC after: 1 week
08:02:31 - r298770
(1 day 10 hours ago)
by delphij
Affects: 
(748 files)
/releng/*
Fix ntp multiple vulnerabilities.

Approved by: so
07:23:08 - r298769
(1 day 11 hours ago)
by sephe
Affects:  /head/sys/netinet/tcp_syncache.c
tcp/syncache: Set flowid and hash type properly for SYN|ACK

So the underlying drivers can use it to select the sending queue
properly for SYN|ACK instead of rolling their own hash.

Sponsored by: Microsoft OSTC
Differential Revision: https://reviews.freebsd.org/D6120
05:28:40 - r298768
(1 day 13 hours ago)
by gjb
Affects: 
(31 files)
/head/*
Fix including Kyuafile in packaged base system.

Fix a related typo while here.

Note, this change results in the Kyuafile inclusion in the runtime
package, which needs to be fixed, however addresses the PR as far
as I can tell in my tests.

PR: 209114
Submitted by: ngie
Sponsored by: The FreeBSD Foundation
03:13:18 - r298767
(1 day 15 hours ago)
by pfg
Affects: 
(2 files)
/stable/9/bin/ed/cbc.c
MFC r298640:
ed(1): switch two statements so we check the index before dereferencing.
03:12:14 - r298766
(1 day 15 hours ago)
by pfg
Affects: 
(2 files)
/stable/10/bin/ed/cbc.c
MFC r298640:
ed(1): switch two statements so we check the index before dereferencing.
03:06:42 - r298765
(1 day 15 hours ago)
by pfg
Affects: 
(2 files)
/stable/9/sbin/fsck_ffs/suj.c
MFC r298551, r298679, r298680:
fsck_ffs: use uint32_t for closedisk().

fs_ncg is of type uint32_t, and we were indexing it with an int.
Fixed this using an unsigned type.

Reviewed by: mckusick
03:04:56 - r298764
(1 day 15 hours ago)
by pfg
Affects: 
(2 files)
/stable/10/sbin/fsck_ffs/suj.c
MFC r298551, r298679, r298680:
fsck_ffs: use uint32_t for closedisk().

fs_ncg is of type uint32_t, and we were indexing it with an int.
Fixed this using an unsigned type.

Reviewed by: mckusick
02:56:03 - r298763
(1 day 15 hours ago)
by pfg
Affects: 
(2 files)
/stable/10/usr.bin/patch/pch.c
MFC r298530:
patch(1): avoid signed integer overflow when debugging.

Integer i is used to index p_end of type LINENUM (actually long).
Match the types.
01:53:45 - r298762
(1 day 16 hours ago)
by adrian
Affects:  /head/sys/dev/ath/if_ath_tx_ht.c
[ath] Add LDPC transmit support.

LDPC adds better transmit reliability if both ends support it.

You in theory can do both STBC and LDPC at the same time.
If I see issues I'll disable it.

* Only enable it if both ends of a connection negotiate it.
* Disable it if any rate is non-11n.
* Count both LDPC TX and STBC TX.

Tested:

* AR9380, STA mode
01:52:06 - r298761
(1 day 16 hours ago)
by adrian
Affects:  /head/sys/dev/ath/if_ath_tx.c
[ath] turn the BA hardware bug back into a printf().

I saw this happen a couple of times and all I saw was a dump of the
transmit descriptors. Log the message for now so I can see whta happened.
01:51:27 - r298760
(1 day 16 hours ago)
by adrian
Affects:  /head/sys/dev/ath/if_ath_sysctl.c
/head/sys/dev/ath/if_athioctl.h
[ath] Add counters for STBC TX and LDPC TX.

This is a big no-op until the TX path changes to enable LDPC TX are
added.
2016 - 04 - 28   (2 days ago)
22:14:09 - r298759
(1 day 20 hours ago)
by wblock
Affects:  /head/share/man/man7/build.7
Clarify build(7) instructions for alternate object directory.

PR: 209062
Submitted by: Shawn Debnath <sd@beastie.io>
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D6106
21:17:23 - r298758
(1 day 21 hours ago)
by ngie
Affects:  /head/sbin/camcontrol/camcontrol.c
Remove logically impossible test in scsidoinquiry(..)

It was already done 4 lines prior and the value of error didn't change

MFC after: 3 days
Reported by: Coverity
CID: 1011236
Sponsored by: EMC / Isilon Storage Division
20:30:49 - r298757
(1 day 22 hours ago)
by adrian
Affects:  /head/sys/net80211/ieee80211_adhoc.c
[net80211] fix indenting.

Sponsored by: Eva Automation, Inc.
20:29:50 - r298756
(1 day 22 hours ago)
by adrian
Affects:  /head/sys/net80211/ieee80211_adhoc.c
[net80211] handle action frames in adhoc mode from the node that created the
BSS.

We don't have a separate bss node; instead we dup the first node we saw
and turn that into the BSS node. This means that action frames from
that node would be rejected.

So, check that the node is the bss node /and/ the MAC doesn't match ni_macaddr.
That's the "right" way for now to verify it's an unknown node.

This fixes handling action frames in adhoc mode, which includes negotiating
11n aggregation via ADDBA/DELBA.

This by itself isn't enough to correctly create 11n adhoc networks; but
it is required for aggregation to be negotiated.

Tested:

* AR9380, 11n adhoc mode
* broadcom 11ac adhoc (vendor platform)

Sponsored by: Eva Automation, Inc.
19:26:46 - r298755
(1 day 23 hours ago)
by pfg
Affects:  /head/sys/geom/journal/g_journal.h
/head/sys/geom/raid/g_raid_ctl.c
/head/sys/geom/raid/md_ddf.c
sys/geom: spelling fixes.

These affect debugging messages.

MFC after: 2 weeks
18:53:14 - r298754
(1 day 23 hours ago)
by jhb
Affects:  /head/sys/dev/acpica/acpi_cpu.c
Only count CPU devices that are using the ACPI CPU driver.

Arguably we should only be doing the probe/attach to children of
these devices as well.

Tested by: Michal Stanek <mst_semihalf.com> (arm64)
Differential Revision: https://reviews.freebsd.org/D6133
18:41:55 - r298753
(2 days ago)
by ngie
Affects:  /head/lib/libcam/scsi_cmdparse.c
Fix va_list handling

- Add missing va_end's after corresponding va_start's to cleanup state
- Eliminate questionable bzero'ing of va_list passed in to
  do_buff_decode(..) and do_encode(..) from buff_{de,en}code_visit(..)
  and csio_{de,en}code_visit(..). Make va_list a pointer instead and
  pass NULL into the underlying functions to handler this in a portable
  way.
- Do some minor style(9) clean up in affected functions.

Differential Revision: https://reviews.freebsd.org/D6072
MFC after: 3 days
Reported by: cppcheck, Coverity
CID: 1018500-1018503
Reviewed by: cem
Sponsored by: EMC / Isilon Storage Division
18:23:18 - r298752
(2 days ago)
by jhb
Affects:  /head/share/man/man9/bus_activate_resource.9
Add some notes about the implicit resource mapping for activated resources.

Specifically, mention that rman_get_bustag/handle/virtual are valid after
a resource is activated. Also, mention the wrapper API that accepts a
struct resource instead of a bus tag and handle.
18:01:25 - r298751
(2 days ago)
by jhb
Affects:  /head/share/man/man9/bus_alloc_resource.9
Document RF_PREFETCHABLE.
17:57:17 - r298750
(2 days ago)
by ngie
Affects:  /head/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptc.c
Use a better idiom for finding UTC prefixed timezones

Instead of copy-pasting the string literal for "UTC" 3 times and using
strlen, use a static char[3] buffer and sizeof(..).

MFC after: 3 days
X-MFC with: r298507
Submitted by: kib
Sponsored by: EMC / Isilon Storage Division
17:50:16 - r298749
(2 days ago)
by jhb
Affects:  /head/share/man/man9/bus_activate_resource.9
/head/share/man/man9/bus_alloc_resource.9
Document PCI_RES_BUS as a possible resource type.
17:48:52 - r298748
(2 days ago)
by jhb
Affects:  /head/share/man/man9/bus_alloc_resource.9
Remove a stale reference to the removed RF_TIMESHARE flag.
15:53:10 - r298747
(2 days 2 hours ago)
by rrs
Affects: 
(5 files)
/head/sys/net/if_vxlan.c
/head/sys/netinet/*
/head/sys/netinet6/udp6_usrreq.c
Complete the UDP tunneling of ICMP msgs to those protocols
interested in having tunneled UDP and finding out about the
ICMP (tested by Michael Tuexen with SCTP.. soon to be using
this feature).

Differential Revision: http://reviews.freebsd.org/D5875
15:20:08 - r298746
(2 days 3 hours ago)
by pfg
Affects:  /head/usr.bin/localedef/wide.c
Small typo.
15:18:28 - r298745
(2 days 3 hours ago)
by pfg
Affects:  /head/sys/cam/scsi/scsi_all.c
Small typos.
15:13:50 - r298744
(2 days 3 hours ago)
by asomers
Affects:  /head/usr.sbin/extattr/tests/Makefile
Add PACKAGE fields to usr.sbin/extattr/tests/Makefile

usr.sbin/extattr/tests/Makefile
  Add boiler plate required by 298107 but omitted by 298483. These
  two changes passed through CR in parallel. I think this should get
  the full test suite running in Jenkins again.

MFC after: 22 days
X-MFC-with: 298483
Sponsored by: Spectra Logic Corp
13:27:12 - r298743
(2 days 5 hours ago)
by rrs
Affects: 
(5 files)
/head/sys/netinet/*
This cleans up the timers code in TCP to start using the new
async_drain functionality. This as been tested in NF as well as
by Verisign. Still to do in here is to remove all the old flags. They
are currently left being maintained but probably are no longer needed.

Sponsored by: Netflix Inc.
Differential Revision: http://reviews.freebsd.org/D5924
13:00:40 - r298742
(2 days 5 hours ago)
by mmel
Affects:  /head/sys/arm/nvidia/tegra_gpio.c
TEGRA: Add interrupt support for Tegra GPIO controller.
12:24:58 - r298741
(2 days 6 hours ago)
by andrew
Affects:  /head/contrib/jemalloc/include/jemalloc/jemalloc_FreeBSD.h
Stop using sbrk(2) with malloc. This helps reduce the number of places
within the tree where we call this legacy interface.

Reviewed by: jasone
Obtained from: brooks
Sponsored by: ABT Systems Ltd
12:05:07 - r298740
(2 days 6 hours ago)
by mmel
Affects:  /head/sys/arm/arm/swtch-v6.S
ARM: Use kernel pmap as intermediate mapping in context switch.
On ARM, we can directly switch between translation tables only when
the size of the mapping for any given virtual address is the same in
the old and new translation tables. The load of new TTB and subsequent
TLB flush is not atomic operation. So speculative page table walk can
load TLB entry from new mapping while rest of TLB entries are still the
old ones. In worst case, this can lead to situation when TLB cache can
contain multiple matching TLB entries. One (from old mapping) L2 entry
for VA + 4k and one (from new mapping) L1 entry for VA.

Thus, we must switch to kernel pmap translation table as intermediate
mapping because all sizes of these (old pmap and kernel pmap) mappings
are same (or unmapped). The same is true for switch from kernel pmap
translation table to new pmap one.
12:04:12 - r298739
(2 days 6 hours ago)
by mmel
Affects:  /head/sys/dev/gpio/gpiobus.c
/head/sys/kern/subr_intr.c
/head/sys/sys/intr.h
INTRNG: Define 'INTR_IRQ_INVALID' constant and use it consistently
as error indicator.
12:03:22 - r298738
(2 days 6 hours ago)
by mmel
Affects: 
(5 files)
/head/sys/dev/gpio/*
/head/sys/kern/subr_intr.c
/head/sys/sys/*
GPIO: Add support for gpio pin interrupts.
Add new function gpio_alloc_intr_resource(), which allows an allocation
of interrupt resource associated to given gpio pin. It also allows to
specify interrupt configuration.

Note: This functionality is dependent on INTRNG, and must be
implemented in each GPIO controller.
09:40:24 - r298737
(2 days 9 hours ago)
by avg
Affects:  /head/sys/amd64/amd64/initcpu.c
fix missing variable in r298736

Pointyhat to: avg
Reported by: Ivan Klymenko <fidaj@ukr.net>
MFC after: 2 weeks
X-MFC with: r298736
08:29:57 - r298736
(2 days 10 hours ago)
by avg
Affects:  /head/sys/amd64/amd64/initcpu.c
ensure that initial local apic id is sane on AMD 10h systems

Summary:
The Initial Local APIC ID is returned by CPUID function 1 (in EBX).
On AMD Family 10h systems the way that ID is built is controlled by
an MSR bit (InitApicIdCpuIdLo). BKDG instructs BIOS to set it in a
certain way, but a BIOS can be buggy. In that case the ID can confuse
tools that use it, e.g. hwloc.
For example, on a system that I own real Local APIC IDs are configured
as 0, 1, 2, 3, but IDs reported via CPUID.1 are 0, 0x40, 0x80, 0xc0.
See: https://github.com/open-mpi/hwloc/issues/183

Reviewed by: kib
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D6060
06:20:43 - r298735
(2 days 12 hours ago)
by arybchik
Affects:  /head/sys/dev/sfxge/sfxge_ev.c
/head/sys/dev/sfxge/sfxge_rx.c
sfxge(4): do not use RxQ index as label

Labels are limitted by 32 on EF10. It is not sufficient on powerful hosts.
Since only one RxQ is running over each EvQ, zero label may be used.

Reviewed by: gnn
Sponsored by: Solarflare Communications, Inc.
MFC after: 2 days
PR: 208267
Differential Revision: https://reviews.freebsd.org/D6121
03:19:53 - r298734
(2 days 15 hours ago)
by pfg
Affects:  /head/sys/compat/ndis/subr_ndis.c
ndis(4): it's rather unrealistic to expect a size_t here.

int was actually OK, and u_int is more than enough.
02:46:08 - r298733
(2 days 15 hours ago)
by pfg
Affects:  /head/sys/netinet/ip_divert.c
ipdivert: Remove unnecessary and incorrectly typed variable.

In principle n is only used to carry a copy of ipi_count, which is
unsigned, in the non-VIMAGE case, however ipi_count can be used
directly so it is not needed at all. Removing it makes things look
cleaner.
02:39:43 - r298732
(2 days 16 hours ago)
by pfg
Affects:  /head/sys/fs/devfs/devfs_vnops.c
sys/devfs: unsign an index to prevent signed integer overflow.

cdp_maxdirent in struct:cdev_priv is of type u_int. Use the same
type for the corresponding index in devfs_revoke().

MFC after: 1 week
01:58:56 - r298731
(2 days 16 hours ago)
by pfg
Affects:  /head/sys/compat/ndis/subr_ndis.c
ndis(4): unsign some indexes to prevent overflows.

The "len" parameter is uint32_t, indexing it with an int may
end up in a signed integer overflow.

strlen(3) returns an integer of size_t so the corresponding index should
have that size.

MFC after: 1 week
01:43:18 - r298730
(2 days 17 hours ago)
by sephe
Affects:  /head/sys/netinet/tcp_lro.c
tcp/lro: Fix more typo

Noticed by: hiren
MFC after: 1 week
Sponsored by: Microsoft OSTC
01:40:47 - r298729
(2 days 17 hours ago)
by jamie
Affects: 
(2 files)
/stable/10/usr.sbin/jail/command.c
MFC r298562:

  Make jail(8) interpret escape codes in fstab the same as getfsent(3).

PR: 208663
01:31:07 - r298728
(2 days 17 hours ago)
by jamie
Affects: 
(2 files)
/stable/10/etc/rc.d/jail
MFC r298516:

  Don't remove the /var/run/jail_name.id file if a jail fails to start.
  This messes up ezjail (and possibly others), when attempting to start
  a jail that already exists.

PR: 208806
Reviewed by: tj
01:12:38 - r298727
(2 days 17 hours ago)
by pfg
Affects: 
(2 files)
/stable/9/lib/libc/regex/engine.c
MFC r298521;
regex: prevent two improbable signed integer overflows.

In matcher() we used an integer to index nsub of type size_t.
In print() we used an integer to index nstates of type sopno,
typedef'd long.
In both cases the indexes never take negative values.

Match the types to avoid any error.
01:11:25 - r298726
(2 days 17 hours ago)
by pfg
Affects: 
(2 files)
/stable/10/lib/libc/regex/engine.c
MFC r298521;
regex: prevent two improbable signed integer overflows.

In matcher() we used an integer to index nsub of type size_t.
In print() we used an integer to index nstates of type sopno,
typedef'd long.
In both cases the indexes never take negative values.

Match the types to avoid any error.
01:05:40 - r298725
(2 days 17 hours ago)
by pfg
Affects: 
(2 files)
/stable/10/sys/fs/ext2fs/ext2_htree.c
MFC r298518:
ext2_htree_release(): prevent signed integer overflow in a loop.

h_levels_num, as most data structs in ext2fs, is unsigned so
the index that addresses it has to be unsigned as well.

To get to overflow here we would probably be considering a
degenerate case though.

MFC after: 5 days
2016 - 04 - 27   (3 days ago)
23:04:42 - r298724
(2 days 19 hours ago)
by jhb
Affects: 
(3 files)
/stable/10/usr.sbin/bhyve/pci_emul.h
/stable/10/usr.sbin/bhyve/pci_passthru.c
MFC 297932,298295:
Improvements for PCI passthru devices.

297932:
Handle PBA that shares a page with MSI-X table for passthrough devices.

If the PBA shares a page with the MSI-X table, map the shared page via
/dev/mem and emulate accesses to the portion of the PBA in the shared
page by accessing the mapped page.

298295:
Always emit an error message on passthru configuration errors.

Previously, many errors (such as the PCI device not being attached
to the ppt(4) driver) resulted in bhyve silently exiting without
starting the virtual machine. Now any errors encountered when
configuring a virtual slot for a PCI passthru device should be noted
on stderr.
21:51:24 - r298723
(2 days 20 hours ago)
by jhb
Affects:  /head/sys/vm/vm_map.c
Trim redundant message.

WITNESS_WARN() appends "with non-sleepable lock" to the caller's message.

Sponsored by: Chelsio Communications
21:12:05 - r298722
(2 days 21 hours ago)
by jhb
Affects:  /head/sys/dev/acpica/acpivar.h
Adjust prototypes for NUMA-related functions to match the style of the
rest of this file.
20:49:57 - r298721
(2 days 21 hours ago)
by manu
Affects:  /head/sys/arm/allwinner/aw_nmi.c
/head/sys/arm/allwinner/files.allwinner
Add support for the Non-maskable interrupt driver found in the Allwinner A20
and A31 SoCs.
This is normally used for the PMU.

Reviewed by: andrew
Approved by: andrew (mentor)
Differential Revision: https://reviews.freebsd.org/D5663
20:24:48 - r298720
(2 days 22 hours ago)
by jkim
Affects:  /head/sys/contrib/dev/acpica/include/acoutput.h
Fix build without ACPI_DEBUG.
20:12:16 - r298719
(2 days 22 hours ago)
by asomers
Affects:  /projects/zfsd/head/cddl/sbin/zfsd/case_file.cc
zfsd should attempt to activate a hotspare whenever a vdev becomes UNAVAIL.

This is rare, but sometimes happens when you would expect the REMOVED state
instead. I think it happens if vdev_reopen fails before vdev_geom_orphan
gets called.

Sponsored by: Spectra Logic Corp
20:09:02 - r298718
(2 days 22 hours ago)
by asomers
Affects:  /projects/zfsd/head/cddl/sbin/zfsd/Makefile.common
s/MK_MAN=no/MAN=

Reported by: bapt, et al
Sponsored by: Spectra Logic Corp
19:54:56 - r298717
(2 days 22 hours ago)
by jhb
Affects:  /head/sys/dev/pci/pci.c
Fix build for systems without PCI_RES_BUS.

Submitted by: vangyzen
19:38:24 - r298716
(2 days 23 hours ago)
by jkim
Affects:  /head/sys/modules/acpi/Makefile
Sort SUBDIR.
19:12:49 - r298715
(2 days 23 hours ago)
by jhb
Affects: 
(2 files)
/stable/10/sys/x86/x86/local_apic.c
MFC 297039,297374,297398,297484:
Poll the IPI status while waiting constantly instead of delaying
5 microseconds between checks. This avoids inserting a minimum
latency of 5 microseconds on each IPI.

297039:
Check IPI status more frequently when waiting.

An IPI cannot be sent via the local APIC if a previous IPI is still
being delivered. Attempts to send an IPI will wait for a pending IPI
to clear. Prior to r278325 these checks used a spin loop with a
hardcoded maximum count which broke AP startup on some systems.
However, r278325 also enforced a minimum latency of 5 microseconds if an
IPI was still pending which resulted in a measurable performance hit.
This change reduces that minimum latency to 1 microsecond.

297374:
Calibrate the frequency of the of the native_lapic_ipi_wait() loop,
and avoid a delay while waiting for IPI delivery acknowledgement in
xAPIC mode. This makes the loop exit immediately after the delivery
bit in APIC_ICR register is set, instead of waiting for some
microseconds.

We only need to ensure that some amount of time is allowed for the
LAPIC to react to the command, and we need that the wait time is
finite and reasonable. For that reasons, it is irrelevant if the CPU
frequency or throttling decrease the speed and make the loop,
calibrated for full CPU speed at boot time, execute somewhat slower.

297398:
Fix several bugs in r297374:
- fix UP build [1]
- do not obliterate initial reading of rdtsc by the loop counter [2]
- restore the meaning of the argument -1 to native_lapic_ipi_wait()
  as wait until LAPIC acknowledge without timeout
- correct formula for calculating loop iteration count for 1us, it was
  inverted, and ensure that even on unlikely slow CPUs at least one
  check for ack is performed.

297484:
Style(9), use tabs for the #define LOOPS line.
Print unsigned values with %u.
Make code slightly more compact by inlining loop limit.
19:09:21 - r298714
(2 days 23 hours ago)
by jkim
Affects: 
(342 files)
/head/sys/*
/head/usr.sbin/acpi/*
Merge ACPICA 20160422.
18:58:47 - r298713
(2 days 23 hours ago)
by tuexen
Affects:  /head/sys/netinet/sctp_indata.c
Don't use the control argument after calling sctp_add_to_readq().
This breaks the userland stack. There should be no functional change
for the FreeBSD kernel stack.
While there, use consistent variable nameing.
17:49:42 - r298712
(3 days ago)
by jhb
Affects: 
(6 files)
/head/sys/*
Add a bus_null_rescan() method that always fails with an error.

Use this in place of kobj_error_method to disable BUS_RESCAN() on
PCI drivers that do not use the "standard" scanning algorithm.
16:39:05 - r298711
(3 days 2 hours ago)
by jhb
Affects: 
(8 files)
/head/sys/dev/*
/head/sys/powerpc/ofw/ofw_pcib_pci.c
/head/sys/sparc64/pci/ofw_pcib.c
Add a pcib_attach_child() method to manage adding the child "pci" device.

This allows the PCI-PCI bridge driver to save a reference to the child
device in its softc.

Note that this required moving the "pci" device creation out of
acpi_pcib_attach(). Instead, acpi_pcib_attach() is renamed to
acpi_pcib_fetch_prt() as it's sole action now is to fetch the PCI
interrupt routing table.

Differential Revision: https://reviews.freebsd.org/D6021
16:34:29 - r298710
(3 days 2 hours ago)
by jhb
Affects:  /head/sys/dev/pci/pci.c
Fix PCI bus detach to delete child devices.

Differential Revision: https://reviews.freebsd.org/D6020
16:33:17 - r298709
(3 days 2 hours ago)
by jhb
Affects: 
(7 files)
/head/lib/libdevctl/*
/head/sys/*
/head/usr.sbin/devctl/*
Add 'devctl delete' that calls device_delete_child().

'devctl delete' can be used to delete a device that is no longer present.
As an anti-foot-shooting measure, 'delete' will not delete a device
unless it's parent bus says it is no longer present. This can be
overridden by passing the force ('-f') flag.

Note that this command should be used with care. If a device is deleted
that is actually present it can't be resurrected unless the parent bus
device's driver supports rescans.

Differential Revision: https://reviews.freebsd.org/D6019
16:31:12 - r298708
(3 days 2 hours ago)
by jhb
Affects: 
(6 files)
/head/sys/*
Implement a PCI bus rescan method.

Rescanning a PCI bus uses the following steps:
- Fetch the current set of child devices and save it in the 'devlist'
  array.
- Allocate a parallel array 'unchanged' initalized with NULL pointers.
- Scan the bus checking each slot (and each function on slots with a
  multifunction device).
- If a valid function is found, look for a matching device in the 'devlist'
  array. If a device is found, save the pointer in the 'unchanged' array.
  If a device is not found, add a new device.
- After the scan has finished, walk the 'devlist' array deleting any
  devices that do not have a matching pointer in the 'unchanged' array.
- Finally, fetch an updated set of child devices and explicitly attach any
  devices that are not present in the 'unchanged' array.

This builds on the previous changes to move subclass data management into
pci_alloc_devinfo(), pci_child_added(), and bus_child_deleted().

Subclasses of the PCI bus use custom rescan logic explicitly override the
rescan method to disable rescans.

Differential Revision: https://reviews.freebsd.org/D6018
16:29:03 - r298707
(3 days 2 hours ago)
by jhb
Affects: 
(10 files)
/head/*
Add a new rescan method to the bus interface.

The BUS_RESCAN() method rescans a single bus device checking for devices
that have been added or removed from the bus. A new 'rescan' command is
added to devctl(8) to trigger a rescan.

Differential Revision: https://reviews.freebsd.org/D6016
16:23:16 - r298706
(3 days 2 hours ago)
by bcr
Affects: 
(2 files)
/stable/10/usr.sbin/jexec/jexec.8
MFC r298524:

Define which of the username options (-u/-U) to jexec(8) is the default.
Bump Dd.

PR: 207587
Submitted by: dewayne@heuristicsystems.com.au
Sponsored by: Essen Hackathon 2016
15:48:47 - r298705
(3 days 2 hours ago)
by bcr
Affects: 
(2 files)
/stable/10/share/man/man5/fs.5
MFC r298522:

The default value of MINFREE is defined to be 8% in
ufs/ffs/fs.h and not 10%. The newfs(8) and tunefs(8)
man pages had this change already, but fs(5) did not.
This change makes it consistent again.

Bump Dd.

PR: 204929
Submitted by: amutu@amutu.com
Sponsored by: Essen Linuxhotel Hackathon 2016
15:38:56 - r298704
(3 days 3 hours ago)
by asomers
Affects: 
(6 files)
/projects/zfsd/head/cddl/sbin/zfsd/*
/projects/zfsd/head/lib/libdevdctl/*
Make zfsd(8) listen to GEOM::physpath events

zfsd should use a newly arrived device for autoreplace by physical path
operations, even if that device's physical path isn't known when zfsd first
becomes aware of the device.

Background: When a new device arrives, devfs emits a CREATE event to devctl(4).
In parallel, enc(4) assigns a physical path to it, then geom(4) emits a
GEOM::physpath event. It's possible that zfsd will see the CREATE event before
the physical path has been assigned. Previously, we would ignore such a
device. Now, zfsd(8) will listen to the GEOM::physpath event so it can use the
device for autoreplace-by-physical-path actions.

lib/libdevctl/event.cc:
lib/libdevctl/event.h:
lib/libdevctl/tests/libdevctl_unittest.cc
  Provide GeomEvent objects.

  Move
  DevfsEvent::{Devname,IsDiskDev,PhysicalPath,DevPath}
  into the base Event class. Only DevName needs to be
  specialized in the derived classes.

cddl/sbin/zfsd/zfsd.cc
cddl/sbin/zfsd/zfsd_event.cc
cddl/sbin/zfsd/zfsd_event.h
  Listen for GEOM::physpath events. When one arrives,
  ReEvaluate any matching caseFiles.

Sponsored by: Spectra Logic Corp
15:35:05 - r298703
(3 days 3 hours ago)
by pfg
Affects:  /head/sys/cam/cam_xpt.c
/head/sys/cam/ctl/ctl.c
cam: unsign some types to match their definitions and avoid overflows.

numpatterns is u_int.

ctl:
CTL_NUM_MODE_PAGES comes from sizeof().
In struct:ctl_scsiio, kern_sg_entries is uint32_t.

MFC after: 2 weeks
15:28:25 - r298702
(3 days 3 hours ago)
by ae
Affects:  /head/sys/netpfil/ipfw/ip_fw_eaction.c
/head/sys/netpfil/ipfw/ip_fw_sockopt.c
Make create_object callback optional and return EOPNOTSUPP when it isn't
defined. Remove eaction_create_compat() and use designated initializers to
initialize eaction_opcodes structure.

Obtained from: Yandex LLC
15:27:23 - r298701
(3 days 3 hours ago)
by asomers
Affects:  /projects/zfsd/head/cddl/sbin/zfsd/Makefile.common
/projects/zfsd/head/share/mk/src.libnames.mk
Replace LDADD with LIBADD and NO_MAN with MK_MAN

Sponsored by: Spectra Logic Corp
15:25:18 - r298700
(3 days 3 hours ago)
by delphij
Affects: 
(187 files)
/stable/9/contrib/ntp/*
/stable/9/usr.sbin/ntp/*
MFC r298695: MFV r298691: ntp 4.2.8p7.

Security: CVE-2016-1547, CVE-2016-1548, CVE-2016-1549, CVE-2016-1550
Security: CVE-2016-1551, CVE-2016-2516, CVE-2016-2517, CVE-2016-2518
Security: CVE-2016-2519
Security: FreeBSD-SA-16:16.ntp
With hat: so
15:24:33 - r298699
(3 days 3 hours ago)
by delphij
Affects: 
(186 files)
/stable/10/contrib/ntp/*
/stable/10/usr.sbin/ntp/*
MFC r298695: MFV r298691: ntp 4.2.8p7.

Security: CVE-2016-1547, CVE-2016-1548, CVE-2016-1549, CVE-2016-1550
Security: CVE-2016-1551, CVE-2016-2516, CVE-2016-2517, CVE-2016-2518
Security: CVE-2016-2519
Security: FreeBSD-SA-16:16.ntp
With hat: so
15:10:40 - r298698
(3 days 3 hours ago)
by pfg
Affects: 
(5 files)
/head/sys/geom/*
geom: unsign some types to match their definitions and avoid overflows.

In struct:gctl_req, nargs is unsigned.

In mirror:
g_mirror_syncreqs is unsigned.

In raid:
in struct:g_raid_volume, v_disks_count is unsigned.

In virstor:
in struct:g_virstor_softc, n_components is unsigned.

MFC after: 2 weeks
13:10:43 - r298697
(3 days 5 hours ago)
by marius
Affects:  /svnadmin/conf/approvers
- Require re@ approval for release.
- Hand releng/10.3 over to so@.

Approved by: re (implicit)
09:40:55 - r298696
(3 days 9 hours ago)
by sephe
Affects:  /head/sys/netinet/tcp_lro.c
tcp/lro: Fix typo.

MFC after: 1 week
Sponsored by: Microsoft OSTC
07:46:38 - r298695
(3 days 10 hours ago)
by delphij
Affects: 
(186 files)
/head/contrib/ntp/*
/head/usr.sbin/ntp/*
MFV r298691:

ntp 4.2.8p7.

Security: CVE-2016-1547, CVE-2016-1548, CVE-2016-1549, CVE-2016-1550
Security: CVE-2016-1551, CVE-2016-2516, CVE-2016-2517, CVE-2016-2518
Security: CVE-2016-2519
Security: FreeBSD-SA-16:16.ntp
With hat: so
06:49:16 - r298694
(3 days 11 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/netvsc/hv_net_vsc.h
/head/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c
hyperv/hn: Add stat for # of chimney sending tries

MFC after: 1 week
Sponsored by: Microsoft OSTC
05:45:14 - r298693
(3 days 13 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/vmbus/hv_channel.c
/head/sys/dev/hyperv/vmbus/hv_ring_buffer.c
hyperv/vmbus: Mark sysctls MPSAFE

MFC after: 1 week
Sponsored by: Microsoft OSTC
05:38:47 - r298692
(3 days 13 hours ago)
by delphij
Affects:  /vendor/ntp/4.2.8p7
Tag ntp 4.2.8p7.
05:37:54 - r298691
(3 days 13 hours ago)
by delphij
Affects: 
(193 files)
/vendor/ntp/dist/*
Vendor import of ntp-4.2.8p7.
05:18:04 - r298690
(3 days 13 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c
hyperv/hn: Mark sysctls MPSAFE

MFC after: 1 week
Sponsored by: Microsoft OSTC
05:05:54 - r298689
(3 days 13 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c
hyperv/hn: Remove unapplied comment.

Chimney sending buffers are shared across channels.

MFC after: 1 week
Sponsored by: Microsoft OSTC
04:51:28 - r298688
(3 days 13 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/netvsc/hv_net_vsc.h
/head/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c
hyperv/hn: Restart sending earlier once we gathered some free TX descs

This greatly reduces the oqdrops under heavy workload.

For TCP send/recv test (10K concurrent connections):
oqdrops is reduced by 17% on sending side, and 57% on receiving side.

For nginx-1.8/wrk-4 1KB object test (10K concurrent connections,
4 requests/connection):
oqdrops is reduced by 44% on nginx side, and 10% on wrk side.

MFC after: 1 week
Sponsored by: Microsoft OSTC
03:06:53 - r298687
(3 days 15 hours ago)
by araujo
Affects:  /head/usr.sbin/config/mkmakefile.c
/head/usr.sbin/config/mkoptions.c
For pointers use NULL instead of 0.

Reviewed by: rpaulo
MFC after: 2 weeks.
Differential Revision: https://reviews.freebsd.org/D5946
02:44:10 - r298686
(3 days 16 hours ago)
by araujo
Affects:  /head/usr.bin/top/machine.c
Use MIN() macro from sys/param.h.

MFC after: 2 weeks.
02:34:25 - r298685
(3 days 16 hours ago)
by araujo
Affects:  /head/usr.bin/tftp/main.c
Use MIN() macro from sys/param.h.

MFC after: 2 weeks.
02:26:31 - r298684
(3 days 16 hours ago)
by araujo
Affects:  /head/usr.bin/systat/main.c
Use macro MIN() from sys/param.h.

MFC after: 2 weeks.
02:25:21 - r298683
(3 days 16 hours ago)
by jamie
Affects:  /head/sys/kern/kern_jail.c
/head/sys/sys/jail.h
Delay revmoing the last jail reference in prison_proc_free, and instead
put it off into the pr_task. This is similar to prison_free, and in fact
uses the same task even though they do something slightly different.

This resolves a LOR between the process lock and allprison_lock, which
came about in r298565.

PR: 48471
02:13:57 - r298682
(3 days 16 hours ago)
by araujo
Affects:  /head/usr.bin/quota/quota.c
Use MIN() macro from sys/param.h.

MFC after: 2 weeks.
02:02:44 - r298681
(3 days 16 hours ago)
by araujo
Affects:  /head/sbin/ifconfig/sfp.c
Use macro MIN() from sys/param.h.

MFC after: 2 weeks.
01:36:25 - r298680
(3 days 17 hours ago)
by pfg
Affects:  /head/sbin/fsck_ffs/suj.c
fsck_ffs: Revert partially the unsigned changes.

Any value of uint16_t will be internally promoted to int so
changing them to an unsigned value doesn't help.

Missing revert value in suj_read().

X-MFC with: r298551
01:32:11 - r298679
(3 days 17 hours ago)
by pfg
Affects:  /head/sbin/fsck_ffs/suj.c
fsck_ffs: Revert partially the unsigned changes.

Any value of uint16_t will be internally promoted to int so
changing them to an unsigned value doesn't help.

Make clear we want to use uint32_t for closedisk()

X-MFC with: r298551
00:10:32 - r298678
(3 days 18 hours ago)
by cem
Affects:  /head/sys/kern/posix4_mib.c
posix4_mib: Don't overrun facility_initialized array

The facility_initialized and facility arrays are the same size and were
intended to be indexed the same. I believe this mismatch was just a
typo/braino in r208731.

Reported by: Coverity
CID: 1017430
Sponsored by: EMC / Isilon Storage Division
2016 - 04 - 26   (4 days ago)
23:58:55 - r298677
(3 days 18 hours ago)
by cem
Affects:  /head/sys/kern/subr_mbpool.c
subr_mbpool: Don't free bogus pointer in error paths

An mbpool is allocated with a contiguous array of mbpages. Freeing an
individual mbpage has never been valid. Don't do it.

This bug has been present since this code was introduced in r117624 (2003).

Reported by: Coverity
CID: 1009687
Sponsored by: EMC / Isilon Storage Division
23:23:44 - r298676
(3 days 19 hours ago)
by cem
Affects:  /head/sys/netipsec/ipsec.c
netipsec: Don't leak memory when deep copy fails

Reported by: Coverity
CID: 1331693
Sponsored by: EMC / Isilon Storage Division
23:13:48 - r298675
(3 days 19 hours ago)
by cem
Affects:  /head/sys/netinet/in.c
/head/sys/netinet6/in6.c
in_lltable_alloc and in6 copy: Don't leak LLE in error path

Fix a memory leak in error conditions introduced in r292978.

Reported by: Coverity
CIDs: 1347009, 1347010
Sponsored by: EMC / Isilon Storage Division
23:09:47 - r298674
(3 days 19 hours ago)
by gonzo
Affects: 
(4 files)
/head/sys/boot/fdt/dts/arm/*
/head/sys/dev/cadence/if_cgem.c
Refactor DTS files for Zynq-based SoCs

- Factor out common part to zynq-7000.dtsi
- Fix problem with Zynq interrupts by using interrupt "triples"
  in .dtsi file to differentiate between edge-triggered and
  level-triggered interrupts
- cgem driver now recognizes "status" property

Submitted by: Thomas Skibo <thomasskibo@yahoo.com>
Differential Revision: https://reviews.freebsd.org/D6095
23:02:18 - r298673
(3 days 19 hours ago)
by cem
Affects:  /head/sys/netinet/tcp_usrreq.c
tcp_usrreq: Free allocated buffer in relock case

The disgusting macro INP_WLOCK_RECHECK may early-return. In
tcp_default_ctloutput() the TCP_CCALGOOPT case allocates memory before invoking
this macro, which may leak memory.

Add a _CLEANUP variant that takes a code argument to perform variable cleanup
in the early return path. Use it to free the 'pbuf' allocated in
tcp_default_ctloutput().

I am not especially happy with this macro, but I reckon it's not any worse than
INP_WLOCK_RECHECK already was.

Reported by: Coverity
CID: 1350286
Sponsored by: EMC / Isilon Storage Division
22:32:33 - r298672
(3 days 20 hours ago)
by cem
Affects:  /head/sys/geom/part/g_part_bsd64.c
g_part_bsd64: Delete duplicate/dead code

RAW_PART is handled earlier in the loop.

Reported by: Coverity
CID: 1223201
Sponsored by: EMC / Isilon Storage Division
22:30:54 - r298671
(3 days 20 hours ago)
by cem
Affects:  /head/sys/geom/part/g_part_bsd64.c
g_part_bsd64: Check for valid on-disk npartitions value

This value is u32 on disk, but assigned to an int in memory. After we do the
implicit conversion via assignment, check that the result is at least one[1]
(non-negative[2]).

1. The subsequent for-loop iterates from gpt_entries minus one, down, until
  reaching zero. A negative or zero initial index results in undefined signed
  integer overflow.
2. It is also used to index into arrays later.

In practice, we expected non-malicious disks to contain small positive values.

Reported by: Coverity
CID: 1223202
Sponsored by: EMC / Isilon Storage Division
22:01:07 - r298670
(3 days 20 hours ago)
by cem
Affects:  /head/sys/dev/ciss/ciss.c
ciss(4): Fix overrun of array

The softc member 'ciss_logical' is an array of 'ciss_max_logical_bus' members.
Most of the time it is iterated correctly. This patch fixes the two instances
where the driver iterated off the end of the array.

Reported by: Coverity
CID: 1305492
Sponsored by: EMC / Isilon Storage Division
21:44:09 - r298669
(3 days 21 hours ago)
by cem
Affects:  /head/sys/dev/iscsi_initiator/iscsi.c
iscsi_initiator(4): Fix use-after-free, double-free

ism_stop() already destroys and frees 'sp', including a call to ic_destroy().
Don't dereference 'sp' after ism_stop() and don't invoke ic_destroy() on the
freed memory either.

Reported by: Coverity
CIDs: 1006109, 1304861
Sponsored by: EMC / Isilon Storage Division
21:19:12 - r298668
(3 days 21 hours ago)
by jamie
Affects:  /head/sys/kern/kern_jail.c
Use crcopysafe in jail_attach.
21:11:52 - r298667
(3 days 21 hours ago)
by gonzo
Affects:  /head/sys/arm/conf/ZEDBOARD
Add dtb/zynq to the list of extra modules required by Zedboard
21:11:01 - r298666
(3 days 21 hours ago)
by gonzo
Affects: 
(2 files)
/head/sys/modules/dtb/zynq/Makefile
Add dtb/zynq to generate dtb files for Zynq-based boards

It seems that the only way to supply dtb to loader on Zynq-based
SoCs is to manually generate dtb and place it to pre-defined location
on SD card or TFTP server where loader can pick it up. More modern
approach is to add modules/dtb/%soc% module and let installworld
target generate dtb and copy them to /boot/dtb/ where they can be
loaded by ubldr
20:59:21 - r298665
(3 days 21 hours ago)
by cem
Affects:  /head/sys/dev/aacraid/aacraid_cam.c
aacraid(4): Fix some mostly trivial buffer overruns

strcpy(3) emits a trailing nul byte, trampling fields after the intended
destination. Instead, use strncpy(3), intentionally leaving these fields
not nul-terminated.

Reported by: Coverity
CIDs: 1031024, 1305463, 1305494, 1305545
Sponsored by: EMC / Isilon Storage Division
20:36:32 - r298664
(3 days 22 hours ago)
by kp
Affects:  /head/sys/fs/msdosfs/direntry.h
/head/sys/fs/msdosfs/msdosfs_conv.c
msdosfs: Prevent buffer overflow when expanding win95 names

In win2unixfn() we expand Windows 95 style long names. In some cases that
requires moving the data in the nbp->nb_buf buffer backwards to make room. That
code failed to check for overflows, leading to a stack overflow in win2unixfn().

We now check for this event, and mark the entire conversion as failed in that
case. This means we present the 8 character, dos style, name instead.

PR: 204643
Differential Revision: https://reviews.freebsd.org/D6015
20:27:17 - r298663
(3 days 22 hours ago)
by cem
Affects:  /head/sys/net/radix_mpath.c
radix_mpath: Don't derefence a NULL pointer in for loop iteration

It seems rn_dupedkey may be NULL, because of the NULL check inside the loop.
(Also, the rt gets assigned from rn_dupedkey and NULL checked at top of loop.)
However, the for-loop update condition happens before the top-of-loop check and
dereferences 'rt' unconditionally.

Instead, NULL-check before dereferencing.

If rn_dupedkey cannot in fact be NULL, or something else protects this, feel
free to revert this and add an ASSERT of some kind instead.

This was introduced in r191080 (2009) and moved around slightly in r293657.

Reported by: Coverity
CID: 1348482
Sponsored by: EMC / Isilon Storage Division
20:06:35 - r298662
(3 days 22 hours ago)
by cem
Affects:  /head/sys/dev/pci/pci.c
PCI Enhanced Allocation: Annotate an intentional switch fallthrough

This is a trivial follow-up to r296308. Annotate the intentional fallthrough
to make it clear for future readers and linters.

Reported by: Coverity
CID: 1352716
Discussed with: jhb
Sponsored by: EMC / Isilon Storage Division
19:57:35 - r298661
(3 days 22 hours ago)
by cem
Affects: 
(7 files)
/head/share/man/man9/osd.9
/head/sys/*
osd(9): Change array pointer to array pointer type from void*

This is a minor follow-up to r297422, prompted by a Coverity warning. (It's
not a real defect, just a code smell.) OSD slot array reservations are an
array of pointers (void **) but were cast to void* and back unnecessarily.
Keep the correct type from reservation to use.

osd.9 is updated to match, along with a few trivial igor fixes.

Reported by: Coverity
CID: 1353811
Sponsored by: EMC / Isilon Storage Division
19:21:35 - r298660
(3 days 23 hours ago)
by ngie
Affects:  /head/contrib/netbsd-tests/lib/libc/ssp/h_read.c
Fix up r298368

Remove the semicolon accidentally added after the new conditional that tests
that /dev/zero is opened successfully.

MFC after: 1 week
X-MFC with: r298368
Pointhat to: ngie
Reported by: Coverity
CID: 1354980
Sponsored by: EMC / Isilon Storage Division
19:06:28 - r298659
(3 days 23 hours ago)
by cem
Affects:  /head/sys/dev/iwm/if_iwm.c
iwm(4): Don't dereference potentially NULL pointer before NULL check

Introduced in r298594. There is no path before the 'vap == NULL' check where
vap is not already dereferenced.

Reported by: Coverity
CID: 1354979
Sponsored by: EMC / Isilon Storage Division
18:54:44 - r298658
(3 days 23 hours ago)
by bhd
Affects:  /head/usr.sbin/etcupdate/etcupdate.8
Remove redundant word.

Reviewed by: bjk, bcr
Differential Revision: https://reviews.freebsd.org/D6064
18:20:41 - r298657
(4 days ago)
by cem
Affects:  /head/sys/dev/sound/pci/emu10kx.c
emu10kx: Don't iterate beyond array bounds

Reported by: Coverity
CID: 1354978
Sponsored by: EMC / Isilon Storage Division
18:17:44 - r298656
(4 days ago)
by jamie
Affects:  /head/sys/kern/sysv_msg.c
/head/sys/kern/sysv_sem.c
/head/sys/kern/sysv_shm.c
Redo the changes to the SYSV IPC sysctl functions from r298585, so they
don't (mis)use sbufs.

PR: 48471
18:11:45 - r298655
(4 days ago)
by cem
Affects:  /head/sys/kgssapi/gssd_prot.c
kgssapi: Don't leak memory in error cases

Reported by: Coverity
CIDs: 1007046, 1007047, 1007048
Sponsored by: EMC / Isilon Storage Division
18:08:51 - r298654
(4 days ago)
by bdrewery
Affects:  /head/Makefile.inc1
WITH_META_MODE: Allow buildkernel to create .meta files with curdir==objdir.

Without this the incremental build was broken since .depend.* are not
generated with .MAKE.MODE=meta and .meta files were not created to
track dependencies. Typically meta mode does not create .meta files
when building with curdir==objdir but the kernel build is special.

Reported by: Nikolai Lifanov <lifanov@mail.lifanov.com>
Sponsored by: EMC / Isilon Storage Division
17:39:54 - r298653
(4 days 1 hour ago)
by pfg
Affects: 
(8 files)
/stable/10/sys/*
MFC r298482:
Cleanup redundant parenthesis from existing howmany()/roundup() macro uses.

Requested by: dchagin
16:40:04 - r298652
(4 days 2 hours ago)
by adrian
Affects:  /head/sys/mips/mips/nexus.c
[mips] correctly represent memory region allocations >> 2^^31

Without this, it'd get promoted incorrectly and fail allocation.

Submitted by: Mori Hiroki <yamori813@yahoo.co.jp>
Reviewed by: imp
16:02:13 - r298651
(4 days 2 hours ago)
by br
Affects:  /head/sys/dev/spibus/spibus.c
Fix the parameter type according to method declaration.
This fixes compilation on riscv with GCC 5.2.0
15:41:31 - r298650
(4 days 3 hours ago)
by hselasky
Affects:  /head/sys/boot/kshim/bsd_kernel.h
Build fix. Add howmany() and nitems() macros to bootloader kernel shim.
15:38:17 - r298649
(4 days 3 hours ago)
by pfg
Affects: 
(21 files)
/head/sys/*
sys: extend use of the howmany() macro when available.

We have a howmany() macro in the <sys/param.h> header that is
convenient to re-use as it makes things easier to read.
15:34:00 - r298648
(4 days 3 hours ago)
by bz
Affects:  /head/sys/arm/arm/generic_timer.c
Mark the unused period argument __unused.

Reviewed by: andrew
MFC after: 2 weeks
Sponsored by: DARPA/AFRL
15:33:53 - r298647
(4 days 3 hours ago)
by hselasky
Affects:  /head/sys/boot/usb/bsd_usbloader_test.c
Add function needed for linking USB test application.
15:03:15 - r298646
(4 days 3 hours ago)
by pfg
Affects: 
(30 files)
/head/sys/dev/*
sys/dev: extend use of the howmany() macro when available.

We have a howmany() macro in the <sys/param.h> header that is
convenient to re-use as it makes things easier to read.
14:51:58 - r298645
(4 days 3 hours ago)
by pfg
Affects:  /head/sys/boot/common/part.c
/head/sys/boot/powerpc/ps3/main.c
/head/sys/boot/sparc64/boot1/boot1.c
sys/boot: make use of the howmany() macro when available.

We have a howmany() macro in the <sys/param.h> header that is
convenient to re-use as it makes things easier to read.
14:48:58 - r298644
(4 days 3 hours ago)
by asomers
Affects:  /head/sbin/devd/devd.conf.5
Add GEOM::physpath documentation to devd.conf(5)

Suggested by: trasz
Reviewed by: trasz
MFC after: 4 weeks
Sponsored by: Spectra Logic Corp
Differential Revision: https://reviews.freebsd.org/D6063
14:47:52 - r298643
(4 days 3 hours ago)
by pfg
Affects: 
(4 files)
/head/sys/arm/*
sys/arm: make use of the howmany() macro when available.

We have a howmany() macro in the <sys/param.h> header that is
convenient to re-use as it makes things easier to read.
14:44:49 - r298642
(4 days 4 hours ago)
by pfg
Affects:  /head/sys/powerpc/booke/pmap.c
/head/sys/powerpc/mpc85xx/fsl_sdhc.c
/head/sys/powerpc/powerpc/clock.c
sys/powerpc: make use of the howmany() macro when available.

We have a howmany() macro in the <sys/param.h> header that is
convenient to re-use as it makes things easier to read.
14:38:18 - r298641
(4 days 4 hours ago)
by br
Affects:  /head/sys/riscv/include/pmap.h
/head/sys/riscv/riscv/pmap.c
Rework the list of all pmaps: embed the list link into pmap.
14:31:48 - r298640
(4 days 4 hours ago)
by pfg
Affects:  /head/bin/ed/cbc.c
ed(1): switch two statements so we check the index before dereferencing.

This is related to r270256 but was missed in that occasion.

MFC after: 3 days
14:21:39 - r298639
(4 days 4 hours ago)
by andrew
Affects:  /head/sys/arm64/conf/GENERIC
Disable ACPI on arm64 ad it has only had minimal testing and is causing
boot issues when booting with FDT. It is planned to re-enable this at a
later date.

Obtained from: ABT Systems Ltd
Sponsored by: The FreeBSD Foundation
13:22:08 - r298638
(4 days 5 hours ago)
by br
Affects: 
(9 files)
/head/sys/boot/fdt/dts/riscv/*
/head/sys/conf/files.riscv
/head/sys/riscv/conf/*
o Add device tree files and kernel configuration files
  for RISC-V cpus synthesized on FPGA hardware.
o Include new files to the build.
13:16:45 - r298637
(4 days 5 hours ago)
by andrew
Affects:  /head/sys/dev/uart/uart_cpu_fdt.c
Stop including machine/fdt.h from the fdt uart code, it's unneeded.

Sponsored by: ABT Systems Ltd
12:56:44 - r298636
(4 days 5 hours ago)
by br
Affects: 
(4 files)
/head/sys/riscv/include/*
/head/sys/riscv/riscv/*
Add the non-standard "IO interrupt" vector used by lowRISC.
For now they provide UART irq only.

Sponsored by: DARPA, AFRL
Sponsored by: HEIF5
12:45:01 - r298635
(4 days 6 hours ago)
by br
Affects:  /head/sys/riscv/riscv/bus_machdep.c
/head/sys/riscv/riscv/bus_space_asm.S
Add the implementation of basic bus_space_read/write functions.

Sponsored by: DARPA, AFRL
Sponsored by: HEIF5
12:36:12 - r298634
(4 days 6 hours ago)
by jmcneill
Affects:  /head/sys/arm/allwinner/clk/aw_lcdclk.c
Fix calculation of LCD CH1 SCLK1 output frequency when SCLK2 /2 is used
as source.

PR: 208680
Reported by: David Binderman <dcb314@hotmail.com>
12:33:25 - r298633
(4 days 6 hours ago)
by br
Affects:  /head/sys/riscv/riscv/ofw_machdep.c
Add the implementation of OF_decode_addr().
12:31:23 - r298632
(4 days 6 hours ago)
by br
Affects:  /head/sys/dev/uart/uart_cpu_fdt.c
Do not include fdt.h on RISC-V.
12:29:47 - r298631
(4 days 6 hours ago)
by br
Affects:  /head/sys/kern/subr_devmap.c
Add support for RISC-V.
12:02:36 - r298630
(4 days 6 hours ago)
by jmcneill
Affects:  /head/sys/arm/allwinner/a10_mmc.c
Add support for 8-bit eMMC.

Set MMC_CAP_4_BIT_DATA and MMC_CAP_8_BIT_DATA based on the "bus-width"
DT property and reduce maximum bus frequency from 52MHz to 50MHz to match
the capabilities of the clock provider.

Tested on a BananaPi BPI-M3 (A83T).
12:00:04 - r298629
(4 days 6 hours ago)
by ae
Affects: 
(2 files)
/stable/9/sbin/geom/class/part/geom_part.c
MFC r297820:
  Fix the problem, when gpart(8) can't write both bootcode and partcode
  in one command due to wrong file size limit. Do not use bootcode size
  to calculate partsize limit.
  Also add report message about successful partcode writing.
11:55:28 - r298628
(4 days 6 hours ago)
by ae
Affects: 
(2 files)
/stable/10/sbin/geom/class/part/geom_part.c
MFC r297820:
  Fix the problem, when gpart(8) can't write both bootcode and partcode
  in one command due to wrong file size limit. Do not use bootcode size
  to calculate partsize limit.
  Also add report message about successful partcode writing.
11:53:37 - r298627
(4 days 6 hours ago)
by br
Affects: 
(48 files)
/head/sys/*
Move arm's devmap to some generic place, so it can be used
by other architectures.

Reviewed by: imp
Differential Revision: https://reviews.freebsd.org/D6091
Sponsored by: DARPA, AFRL
Sponsored by: HEIF5
11:39:32 - r298626
(4 days 7 hours ago)
by andrew
Affects:  /head/bin/csh/config.h
Stop using sbrk in csh. This is a legacy interface and its use within csh
is invalid. It is used to find the size of allocated memory. As malloc may
allocate memory with mmap it will fail to take this memory into account.

Obtained from: brooks
11:15:48 - r298625
(4 days 7 hours ago)
by manu
Affects: 
(5 files)
/head/sys/arm/allwinner/*
/head/sys/arm/conf/A10
Convert A10 interrupt controller to INTRNG

Reviewed by: skra
Approved by: cognet (mentor)
Differential Revision: https://reviews.freebsd.org/D5573
10:04:06 - r298624
(4 days 8 hours ago)
by ed
Affects:  /head/usr.sbin/bsdinstall/partedit/partedit.c
Remove unportable calls to basename().

The POSIX version of basename() doesn't use a 'const char *' argument;
the function may overwrite its input buffer. Instead of copying the
input string, let's just simplify this code by using our getprogname()
function that already returns the name of the application in the right
format.

Reviewed by: allanjude
Differential Revision: https://reviews.freebsd.org/D6094
07:47:01 - r298623
(4 days 10 hours ago)
by avg
Affects:  /stable/10
MFC r297846: [amd64] dtrace_invop handler is to be called only for
kernel exceptions

Fix up r298621.
07:40:56 - r298622
(4 days 11 hours ago)
by avg
Affects: 
(2 files)
/stable/9/sys/amd64/amd64/exception.S
MFC r297846: [amd64] dtrace_invop handler is to be called only for
kernel exceptions
07:40:07 - r298621
(4 days 11 hours ago)
by avg
Affects:  /stable/10/sys/amd64/amd64/exception.S
MFC r297846: [amd64] dtrace_invop handler is to be called only for
kernel exceptions
06:50:41 - r298620
(4 days 11 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c
hyperv/hn: Change description to "Hyper-V Network Interface"

This is consistent w/ other Hyper-V devices.

MFC after: 1 week
Sponsored by: Microsoft OSTC
06:50:38 - r298619
(4 days 11 hours ago)
by sobomax
Affects:  /head/sys/geom/uzip/g_uzip.c
Relax TOC offsets checking somewhat, allowing offset pointing to
the next byte past EOF to denote zero-block(s) at the very end of
the file.
06:41:36 - r298618
(4 days 12 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c
hyperv/stor: Set description properly in probe devmethod

MFC after: 1 week
Sponsored by: Microsoft OSTC
05:21:27 - r298617
(4 days 13 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/include/hyperv.h
/head/sys/dev/hyperv/vmbus/hv_channel.c
/head/sys/dev/hyperv/vmbus/hv_channel_mgmt.c
hyperv/channel: Git rid of the sub-channel creation callback

It is no longer used.

MFC after: 1 week
Sponsored by: Microsoft OSTC
05:15:15 - r298616
(4 days 13 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c
hyperv/stor: Avoid sub-channel creation callback.

Since the sub-channel offers are synchronized, we can do our own
channel setup without using the sub-channel creation callback.

This paves the way to whack the sub-channel creation callback.

MFC after: 1 week
Sponsored by: Microsoft OSTC
05:08:55 - r298615
(4 days 13 hours ago)
by sephe
Affects: 
(4 files)
/head/sys/dev/hyperv/netvsc/*
hyperv/hn: Avoid sub-channel creation callback.

Since the sub-channel offers are synchronized, we can do our own
channel setup without using the sub-channel creation callback.

This paves the way to whack the sub-channel creation callback.

MFC after: 1 week
Sponsored by: Microsoft OSTC
05:00:40 - r298614
(4 days 13 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c
hyperv/stor: Synchronize sub-channel offers

MFC after: 1 week
Sponsored by: Microsoft OSTC
04:48:57 - r298613
(4 days 13 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c
hyperv/stor: Remove the useless hs_open_multi_channel

This fixes the sub-channel offer race after Hyper-V device probe/attach
is moved to vmbus SYSINIT/attach.

MFC after: 1 week
Sponsored by: Microsoft OSTC
04:40:59 - r298612
(4 days 14 hours ago)
by adrian
Affects:  /head/sys/dev/iwm/if_iwm.c
/head/sys/dev/iwm/if_iwmvar.h
[iwm] implement suspend/resume through ieee80211_{suspend,resume}_all

This allows wifi to associate correctly after a suspend/resume cycle.

Yes, I'm using this now day to day.

Tested:

* Intel 7260AC, STA mode
03:24:28 - r298611
(4 days 15 hours ago)
by adrian
Affects:  /head/sys/dev/iwm/if_iwm.c
[iwm] add extra transmit setup/completion logging so I can see what's going on.

I'm seeing 5GHz association work but data not work until the rate drops,
so I need way more information about what's being programmed into the
transmit descriptors.

Tested:

* 7260AC, STA mode
01:52:35 - r298610
(4 days 16 hours ago)
by pfg
Affects:  /head/sys/ddb/db_expr.c
ddb: Make use of our roundup() macro when available.
01:41:15 - r298609
(4 days 17 hours ago)
by pfg
Affects:  /head/sys/fs/ext2fs/ext2_vfsops.c
ext2fs: make use of the howmany() macro when available.

We have a howmany() macro in the <sys/param.h> header that is
convenient to re-use as it makes things easier to read.

MFC after: 2 weeks
01:37:03 - r298608
(4 days 17 hours ago)
by adrian
Affects:  /head/sys/dev/ath/if_ath.c
/head/sys/dev/ath/if_athvar.h
[ath] add LDPC capability support and LDPC RX support.

This enables LDPC receive support for the AR9300 chips that support it.
It'll announce LDPC support via net80211.

Tested:

* AR9380, STA mode
* AR9331, (to verify the HAL didn't attach it to a chip which
  doesn't support LDPC.)

TODO:

* Add in net80211 machinery to make this configurable at runtime.
01:34:21 - r298607
(4 days 17 hours ago)
by adrian
Affects:  /head/sys/dev/ath/if_ath_tx_ht.c
[ath] obey the STBC flag setting in iv_flags_ht

Add support for the FHT_STBC_TX flag in iv_flags_ht, so it'll now obey
the per-vap ifconfig stbctx flag.

This means that we can do STBC TX on one vap and not another VAP.
(As well as STBC RX on said vap; that changes the HTCAP announcement.)
01:30:29 - r298606
(4 days 17 hours ago)
by adrian
Affects:  /head/sbin/ifconfig/ifieee80211.c
[ifconfig] add STBC TX/RX configuration

This adds the ability to view and configure the STBC parameter for
both transmit and receive.

Whilst here, fix a typo for AMSDU.

TODO:

* manpage update
01:29:26 - r298605
(4 days 17 hours ago)
by adrian
Affects:  /head/sys/net80211/ieee80211_ioctl.c
[net80211] add the STBC ioctl support.

This adds configurable STBC TX and RX support.
01:29:03 - r298604
(4 days 17 hours ago)
by adrian
Affects:  /head/sys/net80211/ieee80211_ht.c
[net80211] add STBC capability flags to iv_flags_ht.

This is in preparation for exposing configuring STBC flags up to ifconfig
so STBC TX/RX can be configured at runtime.

* Set the FHT_STBC flags for TX/RX if the HT capabilitiex exist
* Clear the RX STBC HT capability flag when creating a HTCAP IE, so
  we only announce it if it's configured in the FHT flags.

Tested:

* AR9331 (carambola2), AP/STA modes
01:26:11 - r298603
(4 days 17 hours ago)
by adrian
Affects:  /head/sys/net80211/ieee80211_ioctl.h
[net80211] add an ioctl for LDPC configuration.
01:20:16 - r298602
(4 days 17 hours ago)
by pfg
Affects:  /head/lib/libcuse/cuse_lib.c
libcuse: make more use of the howmany() macro when available.

We have a howmany() macro in the <sys/param.h> header that is
convenient to re-use as it makes things easier to read.
01:19:36 - r298601
(4 days 17 hours ago)
by pfg
Affects:  /head/lib/libstand/nandfs.c
libstand: make more use of the howmany() macro when available.

We have a howmany() macro in the <sys/param.h> header that is
convenient to re-use as it makes things easier to read.
01:17:05 - r298600
(4 days 17 hours ago)
by pfg
Affects:  /head/lib/libc/db/btree/bt_open.c
/head/lib/libc/db/hash/hash.c
libc: make more use of the howmany() macro when available.

We have a howmany() macro in the <sys/param.h> header that is
convenient to re-use as it makes things easier to read.
00:29:00 - r298599
(4 days 18 hours ago)
by araujo
Affects:  /head/usr.bin/stat/stat.c
Use MIN() instead of MAX() as the previous syntax was wrote in a weird and
confused way: "prec > 9 ? 9 : prec".

Submitted by: pfg, ngie and luke <luke.tw@gmail.com>
MFC after: 2 weeks.
2016 - 04 - 25   (5 days ago)
23:12:39 - r298598
(4 days 19 hours ago)
by loos
Affects:  /head/sys/netinet6/nd6.c
Fixes the comment to reflect the code.

Sponsored by: Rubicon Communications (Netgate)
22:30:10 - r298597
(4 days 20 hours ago)
by jamie
Affects:  /head/sys/kern/sysv_shm.c
Fix the logic in r298585: shm_prison_cansee returns an errno, so is
the opposite of a boolean.

PR: 48471
22:25:57 - r298596
(4 days 20 hours ago)
by jkim
Affects:  /vendor-sys/acpica/20160422
Tag ACPICA 20160422.
22:24:53 - r298595
(4 days 20 hours ago)
by jkim
Affects: 
(74 files)
/vendor-sys/acpica/dist/changes.txt
/vendor-sys/acpica/dist/generate/unix/*
/vendor-sys/acpica/dist/source/*
Import ACPICA 20160422.
22:00:05 - r298594
(4 days 20 hours ago)
by adrian
Affects:  /head/sys/dev/iwm/if_iwm.c
[iwm] restart the VAP if there's a firmware panic.

Always print out the firmware panic info before restarting; don't
put it behind IWM_DEBUG.

Submitted by: bapt
Differential Revision: https://reviews.freebsd.org/D6081
21:14:32 - r298593
(4 days 21 hours ago)
by pfg
Affects:  /head/sys/dev/random/fortuna.c
/head/sys/dev/random/randomdev.c
/head/sys/dev/random/yarrow.c
dev/random: use our roundup() macro instead of re-implementing it.

While here also use howmany() macro from sys/param.h
No functional change.

Reviewed by: markm (roundup replacement part)
Approved by: so
20:58:54 - r298592
(4 days 21 hours ago)
by gad
Affects:  /head/usr.sbin/lpr/lpd/lpd.c
Remove a variable and three lines of code which I should have removed as
part of revision 98776 back on June 24/2002. Noticed by pfg@ trying
coccinelle for checking code.

MFC after: 3 weeks
18:55:01 - r298591
(4 days 23 hours ago)
by davidcs
Affects:  /head/sys/dev/bxe/bxe_elink.c
/head/sys/modules/bxe/Makefile
1. Removed -Wno-shift-negative-value from Makefile
2. Fixed warning its absence caused in bxe_elink.c

MFC after:5 days
18:44:11 - r298590
(5 days ago)
by markj
Affects:  /head/sys/cddl/contrib/opensolaris/uts/common/sys/dtrace.h
Increase DTRACE_FUNCNAMELEN from 128 to 192.

This allows for the long function components encountered in www/firefox.
This constant is part of DTrace's userland ABI, so this change may not be
MFC'ed.

PR: 207735
18:40:57 - r298589
(5 days ago)
by markj
Affects:  /head/sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c
Allow DOF sections with excessively long probe function components.

Without this change, DTrace will refuse to load a DOF section if the
function component of any of its probes exceeds DTRACE_FUNCNAMELEN (128).
Probes in C++ programs can have very long function components. Rather than
rejecting all probes if a single probe exceeds the limit, simply skip the
invalid probe and emit a warning. This ensures that valid probes are
instantiated.

PR: 207735
MFC after: 2 weeks
18:13:21 - r298588
(5 days ago)
by markj
Affects: 
(2 files)
/stable/10/sys/kern/kern_proc.c
MFC r298173:
Use a loop instead of a goto in sysctl_kern_proc_kstack().
18:09:36 - r298587
(5 days ago)
by markj
Affects:  /head/sys/cddl/dev/dtrace/dtrace_sysctl.c
Add a kern.dtrace.err_verbose sysctl to control dtrace_err_verbose.

When this flag is turned on, DOF and DIF validation errors are printed to
the kernel message buffer. This is useful for debugging.

Also remove the debug.dtrace.debug sysctl, which has no effect.
17:32:08 - r298586
(5 days 1 hour ago)
by andrew
Affects:  /head/sys/arm64/include/cpu.h
Use the yield instruction in the arm64 cpu_spinwait. This instruction is
a hint to the hardware the software is not performing a task.

Sponsored by: ABT Systems Ltd
17:06:50 - r298585
(5 days 1 hour ago)
by jamie
Affects: 
(4 files)
/head/sys/kern/*
/head/usr.sbin/jail/jail.8
Encapsulate SYSV IPC objects in jails. Define per-module parameters
sysvmsg, sysvsem, and sysvshm, with the following bahavior:

inherit: allow full access to the IPC primitives. This is the same as
the current setup with allow.sysvipc is on. Jails and the base system
can see (and moduly) each other's objects, which is generally considered
a bad thing (though may be useful in some circumstances).

disable: all no access, same as the current setup with allow.sysvipc off.

new: A jail may see use the IPC objects that it has created. It also
gets its own IPC key namespace, so different jails may have their own
objects using the same key value. The parent jail (or base system) can
see the jail's IPC objects, but not its keys.

PR: 48471
Submitted by: based on work by kikuchan98@gmail.com
MFC after: 5 days
17:01:13 - r298584
(5 days 1 hour ago)
by jamie
Affects:  /head/usr.sbin/jail/jail.8
Note the existence of module-specific jail paramters, starting with the
linux.* parameters when linux emulation is loaded.

MFC after: 5 days
16:53:13 - r298583
(5 days 1 hour ago)
by adrian
Affects:  /head/sys/dev/bhnd/cores/chipc/chipc.c
[bhnd] Fix ChipCommon probing.

ChipCommon probing uses mapping table "chipc_devices". It calls
bhnd_device_lookup,
which iterate over mapping table with end condition:

entry->desc != NULL

So if mapping table contains row with description equals to NULL, it will
stop processing of mapping. I.e. description is mandatory field and should
be not NULL.

This patch corrects mapping table for ChipCommon.

Submitted by: Michael Zhilin <mizhka@gmail.com>
Differential Revision: https://reviews.freebsd.org/D6088
16:13:04 - r298582
(5 days 2 hours ago)
by adrian
Affects: 
(5 files)
/head/sys/dev/iwm/*
[iwn] fix firmware command use in iwm_auth().

The iwm firmware has separate commands for add, modify and delete for
various things (mac, phy context, etc.) The openbsd driver has a habit
of just completely resetting the NIC each time, which is technically
mostly okay (as long as the reset doesn't actually fail!) but it means
a lot of the code is doing ADD when it should do MODIFY.

The firmware responds in kind - it just asserts.

This fixes auth attempts that occur after the NIC has been already
configured.

(I'm sure there are more instances of this!)

Tested:

iwm0: <Intel Dual Band Wireless AC 7260> mem 0xf1400000-0xf1401fff irq 17 at
device 0.0 on pci2
iwm0: revision: 0x140, firmware 25.228 (API ver. 9)

.. STA mode.

Submitted by: Masachika ISHIZUKA <ish@amail.plala.or.jp>
15:46:42 - r298581
(5 days 2 hours ago)
by fanf
Affects:  /head/usr.bin/whois/whois.1
Example RIPE whois query with options and spaces.

Since it is used in the example, mention the -- option in the synopsis
even though it is a universal standard, and tweak to fit it on one line.
14:47:51 - r298580
(5 days 3 hours ago)
by br
Affects: 
(8 files)
/head/sys/riscv/include/*
/head/sys/riscv/riscv/*
o Implement shared pagetables and switch from 4 to 3 levels page
memory system.

RISC-V ISA has only single page table base register for both kernel
and user addresses translation. Before this commit we were using an
extra (4th) level of pagetables for switching between kernel and user
pagetables, but then realized FPGA hardware has 3-level page system
hardcoded. It is also become clear that the bitfile synthesized for
4-level system is untested/broken, so we can't use extra level for
switching.

We are now share level 1 of pagetables between kernel and user VA.
This requires to keep track of all the user pmaps created and once we
adding L1 page to kernel pmap we have to add it to all the user pmaps.

o Change the VM layout as we must have topmost bit to be 1 in the
  selected page system for kernel addresses and 0 for user addresses.
o Implement pmap_kenter_device().
o Create the l3 tables for the early devmap.

Sponsored by: DARPA, AFRL
Sponsored by: HEIF5
13:30:37 - r298579
(5 days 5 hours ago)
by br
Affects:  /head/sys/riscv/riscv/locore.S
Do not setup machine exception vector.

Sounds strange, but both RocketCore and lowRISC do not operate
if we set it.

All the known implementations (Spike, QEMU, RocketCore, lowRISC) uses
default machine trap vector address and operates fine with this.

Original Berkeley Boot Loader (bbl) does not set this as well.

Sponsored by: DARPA, AFRL
Sponsored by: HEIF5
13:20:57 - r298578
(5 days 5 hours ago)
by br
Affects:  /head/sys/conf/options.riscv
/head/sys/riscv/riscv/locore.S
Revert r298477 ("Clear the DDR memory").

There is no need to clear all the DDR memory (we only need to clear
BSS section).
I was playing with non-default version of hardware (the bitfile
synthesized for 4-level page memory system) and clearing was helpful,
but then realized support for 4-level page system is untested/broken
in both RocketCore and lowRISC.
13:20:35 - r298577
(5 days 5 hours ago)
by bz
Affects:  /head/usr.bin/mkuzip/mkuzip.c
Try to make gcc builds happy again by removing a redundant declaration.
12:25:30 - r298576
(5 days 6 hours ago)
by wblock
Affects: 
(2 files)
/stable/10/share/man/man4/vt.4
MFC r298176:

Add the kern.vt.enable_bell sysctl, which was not documented previously.
Minor additional punctuation and wording changes.
10:16:07 - r298575
(5 days 8 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c
hyperv/hn: Synchronize sub-channel offers

MFC after: 1 week
Sponsored by: Microsoft OSTC
09:00:06 - r298574
(5 days 9 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/include/hyperv.h
/head/sys/dev/hyperv/vmbus/hv_channel_mgmt.c
hyperv/channel: Add functions to synchronize sub-channel offers

MFC after: 1 week
Sponsored by: Microsoft OSTC
06:08:45 - r298573
(5 days 12 hours ago)
by jamie
Affects:  /head/sys/compat/linux/linux_mib.c
linux_map_osrel doesn't need to be checked in linux_prison_set,
since it already was in linux_prison_check.
05:58:32 - r298572
(5 days 12 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/vmbus/hv_channel_mgmt.c
hyperv/channel: Log a warning about duplicated primary channel offer

MFC after: 1 week
Sponsored by: Microsoft OSTC
05:46:44 - r298571
(5 days 12 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/vmbus/hv_channel_mgmt.c
hyperv/channel: Remove unapplied comment

MFC after: 1 week
Sponsored by: Microsoft OSTC
05:30:42 - r298570
(5 days 13 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/vmbus/hv_channel_mgmt.c
hyperv/channel: Minor style changes; no functional changes.

MFC after: 1 week
Sponsored by: Microsoft OSTC
05:22:35 - r298569
(5 days 13 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/vmbus/hv_channel_mgmt.c
hyperv/channel: Remove the unnecessary 'new' flag

MFC after: 1 week
Sponsored by: Microsoft OSTC
04:58:14 - r298568
(5 days 13 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/vmbus/hv_et.c
hyperv/et: Strip extra white space in function name

Reported by: Sascha Wildner <saw online de>
MFC after: 1 week
Sponsored by: Microsoft OSTC
04:36:54 - r298567
(5 days 14 hours ago)
by jamie
Affects:  /head/sys/kern/uipc_mqueue.c
Use the new PR_METHOD_REMOVE to clean up jail handling in POSIX
message queues.
04:27:58 - r298566
(5 days 14 hours ago)
by jamie
Affects:  /head/sys/kern/kern_jail.c
Pass the current/new jail to PR_METHOD_CHECK, which pushes the call
until after the jail is found or created. This requires unlocking the
jail for the call and re-locking it afterward, but that works because
nothing in the jail has been changed yet, and other processes won't
change the important fields as long as allprison_lock remains held.

Keep better track of name vs namelc in kern_jail_set. Name should
always be the hierarchical name (relative to the caller), and namelc
the last component.

PR: 48471
MFC after: 5 days
04:24:00 - r298565
(5 days 14 hours ago)
by jamie
Affects:  /head/sys/kern/kern_jail.c
/head/sys/sys/jail.h
Add a new jail OSD method, PR_METHOD_REMOVE. It's called when a jail is
removed from the user perspective, i.e. when the last pr_uref goes away,
even though the jail mail still exist in the dying state. It will also
be called if either PR_METHOD_CREATE or PR_METHOD_SET fail.

PR: 48471
MFC after: 5 days
03:58:08 - r298564
(5 days 14 hours ago)
by jamie
Affects:  /head/sys/kern/kern_jail.c
/head/sys/sys/jail.h
Remove the PR_REMOVE flag, which was meant as a temporary marker for
a jail that might be seen mid-removal. It hasn't been doing the right
thing since at least the ability to resurrect dying jails, and such
resurrection also makes it unnecessary.
03:48:28 - r298563
(5 days 14 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c
hyperv/hn: Allow users to configure ifq or bufring depth.

MFC after: 1 week
Sponsored by: Microsoft OSTC
03:24:48 - r298562
(5 days 15 hours ago)
by jamie
Affects:  /head/usr.sbin/jail/command.c
Make jail(8) interpret escape codes in fstab the same as getfsent(3).

PR: 208663
MFC after: 3 days
03:14:55 - r298561
(5 days 15 hours ago)
by sephe
Affects:  /head/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c
hn: Increase odrops for if_transmit method if drbr_enqueue fails.

MFC after: 1 week
Sponsored by: Microsoft OSTC
03:01:57 - r298560
(5 days 15 hours ago)
by jhibbits
Affects:  /head/sys/powerpc/powerpc/trap.c
OR in the unsigned form of the MCAR lower register.

When ORing in a register_t to a wider integer (vm_paddr_t), it gets sign
extended, so high addresses overwrite the upper word with all 0xf. Cast to the
unsigned form (u_register_t), to avoid this problem, and get correct addresses
printed.
00:55:51 - r298559
(5 days 17 hours ago)
by jhibbits
Affects:  /head/sys/powerpc/powerpc/machdep.c
Init static compiled-in env when no metadata present.

With this, a static environment can be compiled in via config(5). This allows,
among other things, the use of a compiled-in debug console (hw.uart.dbgport) for
kgdb.
00:52:37 - r298558
(5 days 17 hours ago)
by pfg
Affects: 
(3 files)
/stable/9/sys/fs/ext2fs/ext2_alloc.c
MFC r297796:
ext2fs: replace 0 with NULL for pointers.

While here do late initialization of ebap, similar as was
done in UFS.

Found with devel/coccinelle.
00:51:13 - r298557
(5 days 17 hours ago)
by pfg
Affects: 
(2 files)
/stable/10/sys/fs/ext2fs/ext2_alloc.c
MFC r297796:
ext2fs: replace 0 with NULL for pointers.

While here do late initialization of ebap, similar as was
done in UFS.

Found with devel/coccinelle.
00:41:23 - r298556
(5 days 18 hours ago)
by pfg
Affects:  /head/sbin/ifconfig/ifieee80211.c
ifconfig: prevent some improbable signed integer overflows.

ic_nchans, from struct:ieee80211req_chaninfo, is an unsigned int.
Use an unsigned index to prevent overflowing the index.

Adopt unsigned integers in other cases where it is useful
to be aware of the unsigned quantities and there is no
risk of the values being negative.

MFC after: 1 week
2016 - 04 - 24   (6 days ago)
22:13:55 - r298555
(5 days 20 hours ago)
by delphij
Affects:  /vendor/netcat/5.9
Tag netcat from OpenBSD 5.9.
22:12:47 - r298554
(5 days 20 hours ago)
by delphij
Affects: 
(4 files)
/vendor/netcat/dist/*
Vendor import nc(1) from OPENBSD_5_9.
21:35:01 - r298553
(5 days 21 hours ago)
by cem
Affects:  /head/sys/amd64/amd64/pmap.c
AMD64 pmap: Use howmany() macro

Use param.h howmany() instead of hand-rolled version.

Sponsored by: EMC / Isilon Storage Division
21:19:00 - r298552
(5 days 21 hours ago)
by gordon
Affects:  /head/share/misc/committers-ports.dot
Add myself (finally) to the port committer's dot file.

Approved by: mat (mentor)
Differential Revision: https://reviews.freebsd.org/D6074
20:31:22 - r298551
(5 days 22 hours ago)
by pfg
Affects:  /head/sbin/fsck_ffs/suj.c
fsck_ffs: Adopt some type safety for the journalling checks.

fs_ncg is of type uint32, and we were indexing it with an int.
Fixed this using an unsigned type and adopt some other unsigned
indexes to remind us when we are dealing with unsigned numbers.

Reviewed by: mckusick
MFC after: 5 days
19:25:11 - r298550
(5 days 23 hours ago)
by lme
Affects:  /head/etc/rc.d/geli2
Fix duplicate "name" variable that sneaked in with the rc description commit.

Approved by: jhibbits
17:09:51 - r298549
(6 days 1 hour ago)
by ae
Affects:  /head/sys/netipsec/xform_ipcomp.c
Fix build for NOINET and NOINET6 kernels.

Use own protosw structures for both address families.
Check proto in encapcheck function and use -1 as proto argument in
encap_attach_func(), both address families can have IPPROTO_IPV4
and IPPROTO_IPV6 protocols.

Reported by: bz
16:41:54 - r298548
(6 days 2 hours ago)
by bz
Affects: 
(8 files)
/projects/vnet/sys/net/*
/projects/vnet/sys/netinet/*
/projects/vnet/sys/netinet6/ip6_input.c
Virtualise the netisr registration in order to do a per-vnet
de-registration to prevent further packets for a specific protocol
(IP, ARP, IPv6) to come up from ether_demux().
We currently have not better "plug-and-play" hook in place at that
level but should think about that in some distant future (e.g.,
to one day be able to load ip, or ipv6).

Note: this commit will be reverted soon. It turns out that while
the idea is good, and basically works, it can possibly lead to
deadlocks.

Sponsored by: The FreeBSD Foundation
16:36:33 - r298547
(6 days 2 hours ago)
by bz
Affects:  /projects/vnet/sys/net/if.c
Remove the "shutdown" argument again to if_detach_internal().
Using the sysuninit state we do not need this anymore and this simplifies
the logic.

Make sure we always call the dom_ifdetach handler, aas this is the only
place this can happen.

Sponsored by: The FreeBSD Foundation
16:33:25 - r298546
(6 days 2 hours ago)
by bz
Affects:  /projects/vnet/sys/net/vnet.c
Update the sysuninit subsystem before calling into the function
handler so we always know at which stage we are running.

Sponsored by: The FreeBSD Foundation
16:07:50 - r298545
(6 days 2 hours ago)
by bz
Affects:  /projects/vnet/sys/net/vnet.h
Move counters to SI_SUB_INIT_IF; cannot free them before all protcols
and interfaces are gone as otherwise we will try to update them and
modified freed memory.

Sponsored by: The FreeBSD Foundation
16:05:09 - r298544
(6 days 2 hours ago)
by bz
Affects:  /projects/vnet/sys/net/if_disc.c
Move if_disc(4) to SI_SUB_INIT_IF.
15:56:05 - r298543
(6 days 2 hours ago)
by bz
Affects:  /head/sys/ofed/drivers/infiniband/core/cma.c
Fix NOIP kernels to compile.
14:49:01 - r298542
(6 days 3 hours ago)
by manu
Affects:  /head/share/misc/committers-src.dot
Add myself as src commiter.

Approved by: cognet (mentor)
13:19:30 - r298541
(6 days 5 hours ago)
by andrew
Affects:  /svnadmin/conf/access
/svnadmin/conf/mentors
Add Emmanuel Vadot (manu@) as a src committer. Emmanuel has been working
on improving support for the Allwinner ARM SoCs.

I will be his mentor with cognet co-mentoring.

Approved by: core (implicit)
13:15:36 - r298540
(6 days 5 hours ago)
by andrew
Affects:  /svnadmin/conf/sizelimit.conf
I don't need a raised limit anymore
12:07:44 - r298539
(6 days 6 hours ago)
by se
Affects:  /head/etc/rc.d/ccd
Fix typo (forgotten "=" after desc).
11:41:36 - r298538
(6 days 7 hours ago)
by brueffer
Affects:  /head/share/man/man4/Makefile
MLINK mfi.4 to mfi_linux.4 and mfip.4 to cover these kernel modules.

The mfi(4) manpage doesn't explain the modules yet, but at least we direct
users to the right place.

PR: 205925
Submitted by: dvl
MFC after: 1 week
Sponsored by: Essen Hackathon 2016
10:52:59 - r298537
(6 days 7 hours ago)
by schweikh
Affects:  /head/etc/rc.d/zvol
Cosmetics: - no need to escape the newline after '|'
  - parenthesize the "case" string for symmetry and improved
  search for matching paren (e.g. with vi's %)
09:05:29 - r298536
(6 days 9 hours ago)
by ae
Affects:  /head/sys/netipsec/key_debug.c
Use ipsec_address() function to print IP addresses.
09:02:17 - r298535
(6 days 9 hours ago)
by ae
Affects:  /head/sys/netipsec/key.c
/head/sys/netipsec/key.h
/head/sys/netipsec/xform_ipcomp.c
Handle non-compressed packets for IPComp in tunnel mode.

RFC3173 says that the IP datagram MUST be sent in the original
non-compressed form, when the total size of a compressed payload
and the IPComp header is not smaller than the size of the original
payload. In tunnel mode for small packets IPComp will send
encapsulated IP datagrams without IPComp header.
Add ip_encap handler for IPPROTO_IPV4 and IPPROTO_IPV6 to handle
these datagrams. The handler does lookup for SA related to IPComp
protocol and given from mbuf source and destination addresses as
tunnel endpoints. It decapsulates packets only when corresponding SA
is found.

Reported by: gnn
Reviewed by: gnn
Differential Revision: https://reviews.freebsd.org/D6062
08:45:43 - r298534
(6 days 9 hours ago)
by avg
Affects: 
(6 files)
/stable/9/sys/cddl/compat/opensolaris/sys/vfs.h
/stable/9/sys/cddl/contrib/opensolaris/uts/common/fs/gfs.c
/stable/9/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/*
MFC r297513: remove emulation of VFS_HOLD and VFS_RELE from opensolaris compat
08:39:55 - r298533
(6 days 10 hours ago)
by avg
Affects: 
(5 files)
/stable/10/sys/cddl/compat/opensolaris/sys/vfs.h
/stable/10/sys/cddl/contrib/opensolaris/uts/common/fs/gfs.c
/stable/10/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/*
MFC r297513: remove emulation of VFS_HOLD and VFS_RELE from opensolaris compat
08:31:32 - r298532
(6 days 10 hours ago)
by brueffer
Affects:  /head/share/man/man9/g_geom.9
Correct types for g_example_start() and g_example_access().

PR: 203498
Submitted by: chadf@triularity.org, ae
MFC after: 1 week
Sponsored by: Essen Hackathon 2016
04:28:04 - r298531
(6 days 14 hours ago)
by pfg
Affects:  /head/usr.bin/patch/patch.c
Adjust a type from r267490.

Independent of the maximum length, the return type for strnlen(3)
is always size_t.
04:08:36 - r298530
(6 days 14 hours ago)
by pfg
Affects:  /head/usr.bin/patch/pch.c
patch(1): avoid signed integer overflow when debugging.

Integer i is used to index p_end of type LINENUM (actually long).

Match the types.

MFC after: 5 days
03:15:10 - r298529
(6 days 15 hours ago)
by wblock
Affects: 
(2 files)
/stable/10/lib/libc/stdlib/lsearch.3
MFC r298156:

Fix markup on "\n" in printf so it renders correctly.
03:13:02 - r298528
(6 days 15 hours ago)
by pfg
Affects: 
(5 files)
/stable/9/sys/ufs/ffs/*
/stable/9/sys/ufs/ufs/ufs_lookup.c
MFC r297791:
UFS: replace 0 with NULL for pointers.

While here also do late initialization of the variables we are
changing.

Found with devel/coccinelle.

Reviewed by: mckusick
03:11:52 - r298527
(6 days 15 hours ago)
by pfg
Affects: 
(5 files)
/stable/10/sys/ufs/ffs/*
/stable/10/sys/ufs/ufs/ufs_lookup.c
MFC r297791:
UFS: replace 0 with NULL for pointers.

While here also do late initialization of the variables we are
changing.

Found with devel/coccinelle.

Reviewed by: mckusick
01:38:45 - r298526
(6 days 17 hours ago)
by jhibbits
Affects:  /head/sys/contrib/ncsw/user/env/xx.c
Zero the newly allocated spinlock.

Not sure how this worked testing with DIAGNOSTIC set, but with it disabled this
fails due to the spinlock being "initialized" with 0xdeadc0de.

 


Powered by Python FreeBSD support by secnetix GmbH & Co. KG

Page generated in 31 ms, 330 revisions printed. Current time is 2016-04-30 18:45:23. All times are in UTC/GMT.