SVNews

NOTE: This service is experimental and subject to change! Use at your own risk!

Year:   Month: - or - Filter committers: - or -
Filter paths:
Include diffs if smaller than lines.

2017 - 12 - 17   (today)
06:00:49 - r326918
( 13 minutes ago)
by cy
Affects: 
(10 files)
/stable/10/*
/stable/11/*
MFC r326558, r326566:

fdformat is a sysadmin command and thus its man page should be in
volume 8 instead of volume 1.

Reviewed by: imp
04:19:19 - r326917
(1 hour 55 minutes ago)
by jeff
Affects:  /user/jeff/numa/sys/kern/subr_vmem.c
Use the correct KVA domain when allocating vmem boundary tags so that we
don't end up mixing super-page and non-super-page allocations.
04:17:36 - r326916
(1 hour 56 minutes ago)
by jeff
Affects:  /user/jeff/numa/sys/vm/vm_init.c
Correct a format string so it works on every arch.
04:16:57 - r326915
(1 hour 57 minutes ago)
by jeff
Affects:  /user/jeff/numa/sys/kern/kern_thread.c
/user/jeff/numa/sys/kern/sched_4bsd.c
Correct some simple compile errors.
2017 - 12 - 16   (yesterday)
21:33:21 - r326914
(8 hours 41 minutes ago)
by imp
Affects:  /head/stand/defs.mk
/head/stand/loader.mk
Move loader-only defines to loader.mk from defs.mk

Produces the same .o's, verified with md5.

Sponsored by: Netflix
20:25:50 - r326913
(9 hours 48 minutes ago)
by imp
Affects:  /head/share/dict/web2
Sync with NetBSD's /usr/share/dict/words, with the exception of quim
due to its vulgar nature.

Submitted by: sevan@
Differential Revision: https://reviews.freebsd.org/D13510
20:19:00 - r326912
(9 hours 55 minutes ago)
by markj
Affects:  /head/usr.sbin/makefs/ffs.c
Fix a logic bug in makefs lazy inode initialization.

We may need to initialize multiple inode blocks before writing a given
inode. makefs(8) was only initializing a single block at a time, so
certain inode allocation patterns could lead to a situation where it
wrote an inode to an uninitialized block. That inode might be clobbered
by a later initialization, resulting in a filesystem image containing
directory entries that point to a seemingly unused inode.

Reviewed by: imp
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D13505
19:40:28 - r326911
(10 hours 33 minutes ago)
by ed
Affects:  /head/usr.bin/truss/Makefile
/head/usr.bin/truss/amd64-cloudabi32.c
Make truss(8) work for i686-unknown-cloudabi binaries on FreeBSD/amd64.

This change copies the existing amd64_cloudabi64.c to amd64_cloudabi32.c
and reimplements the functions for fetching system call arguments and
return values to use the same scheme as used by the vDSO that is used
when running cloudabi32 executables.

As arguments are automatically padded to 64-bit words by the vDSO in
userspace, we can copy the arguments directly into the array used by
truss(8) internally.

Reviewed by: jhb
Differential Revision: https://reviews.freebsd.org/D13516
19:37:55 - r326910
(10 hours 36 minutes ago)
by ed
Affects: 
(4 files)
/head/lib/libsysdecode/*
libsysdecode: Add a new ABI type, SYSDECODE_ABI_CLOUDABI32.

In order to let truss(8) support tracing of 32-bit CloudABI
applications, we need to add a new ABI type to libsysdecode. We can
reuse the existing errno mapping table. Also link in the cloudabi32
system call table to translate system call names.

While there, remove all of the architecture ifdefs. There are not
needed, as the CloudABI data types and system call tables build fine on
any architecture. Building this unconditionally will make it easier to
do tracing for different compat modes, emulation, etc.

Reviewed by: jhb
Differential Revision: https://reviews.freebsd.org/D13516
18:06:30 - r326909
(12 hours 7 minutes ago)
by dim
Affects: 
(22 files)
/head/contrib/*
/head/lib/clang/include/*
Upgrade our copies of clang, llvm, lld, lldb, compiler-rt and libc++ to
5.0.1 release (upstream r320880).

Relnotes: yes
MFC after: 2 weeks
15:17:54 - r326908
(14 hours 56 minutes ago)
by emaste
Affects:  /head/lib/libc/i386/Makefile.inc
revert r322589: force use of ld.bfd for linking i386 libc

As of r326897 ld.lld can link a working i386 libc.so, so we no longer
need to force use of ld.bfd.

Sponsored by: The FreeBSD Foundation
14:47:12 - r326907
(15 hours 27 minutes ago)
by dim
Affects:  /vendor/lldb/lldb-release_501-r320880
Tag lldb 5.0.1 release r320880.
14:46:42 - r326906
(15 hours 27 minutes ago)
by dim
Affects:  /vendor/lld/lld-release_501-r320880
Tag lld 5.0.1 release r320880.
14:46:38 - r326905
(15 hours 27 minutes ago)
by dim
Affects: 
(7 files)
/vendor/lld/dist/lib/ReaderWriter/MachO/*
/vendor/lld/dist/test/mach-o/lazy-bind-x86_64.yaml
Vendor import of lld 5.0.1 release r320880:
https://llvm.org/svn/llvm-project/lld/tags/RELEASE_501/final@320880
14:46:24 - r326904
(15 hours 28 minutes ago)
by dim
Affects:  /vendor/libc++/libc++-release_501-r320880
Tag libc++ 5.0.1 release r320880.
14:45:59 - r326903
(15 hours 28 minutes ago)
by dim
Affects:  /vendor/compiler-rt/compiler-rt-release_501-r320880
Tag compiler-rt 5.0.1 release r320880.
14:45:41 - r326902
(15 hours 28 minutes ago)
by dim
Affects:  /vendor/clang/clang-release_501-r320880
Tag clang 5.0.1 release r320880.
14:45:37 - r326901
(15 hours 28 minutes ago)
by dim
Affects: 
(5 files)
/vendor/clang/dist/lib/Basic/Version.cpp
/vendor/clang/dist/lib/Sema/*
/vendor/clang/dist/test/SemaCXX/unused.cpp
Vendor import of clang 5.0.1 release r320880:
https://llvm.org/svn/llvm-project/cfe/tags/RELEASE_501/final@320880
14:44:39 - r326900
(15 hours 29 minutes ago)
by dim
Affects:  /vendor/llvm/llvm-release_501-r320880
Tag llvm 5.0.1 release r320880.
14:44:35 - r326899
(15 hours 29 minutes ago)
by dim
Affects: 
(5 files)
/vendor/llvm/dist/lib/*
/vendor/llvm/dist/test/*
Vendor import of llvm 5.0.1 release r320880:
https://llvm.org/svn/llvm-project/llvm/tags/RELEASE_501/final@320880
14:36:21 - r326898
(15 hours 38 minutes ago)
by ae
Affects:  /head/sys/net/if_vxlan.c
Fix possible memory leak.

vxlan_ftable entries are sorted in ascending order, due to wrong arguments
order it is possible to stop search before existing element will be found.
Then new element will be allocated in vxlan_ftable_update_locked() and can
be inserted in the list second time or trigger MPASS() assertion with
enabled INVARIANTS.

PR: 224371
MFC after: 1 week
14:26:11 - r326897
(15 hours 48 minutes ago)
by emaste
Affects:  /head/contrib/llvm/tools/lld/ELF/Relocations.cpp
lld: Slightly simplify code and add comment.

Cherry-pick lld r315658 by Rui Ueyama:
  This is not a mechanical transformation. Even though I believe this
  patch is correct, I'm not 100% sure if lld with this patch behaves
  exactly the same way as before on all edge cases. At least all tests
  still pass.

  I'm submitting this patch because it took almost a day to understand
  this function, and I don't want to lose it.

This fixes jemalloc assertion failures observed at startup with i386
binaries and an lld-linked libc.so.

Reviewed by: dim
Obtained from: LLVM r315658
MFC after: 1 week
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D13503
12:23:59 - r326896
(17 hours 50 minutes ago)
by schweikh
Affects:  /head/share/examples/etc/make.conf
Remove white space at EOL.
11:49:30 - r326895
(18 hours 24 minutes ago)
by schweikh
Affects:  /head/UPDATING
Correct a typo; remove white space at EOL.
05:22:16 - r326894
(1 day ago)
by landonf
Affects:  /head/sys/dev/bhnd/nvram/nvram_map
bhnd(4): Fix the pa0itssit/pa1itssit NVRAM variable type definitions
required by bwn(4); idle TSSI target values are expressed as signed
integers.

Sponsored by: The FreeBSD Foundation
04:35:37 - r326893
(1 day 1 hour ago)
by landonf
Affects:  /head/sys/dev/bhnd/bhndb/bhndb_pci_hwdata.c
/head/sys/dev/bhnd/bhndb/bhndb_subr.c
bhndb(4): Enable addrext support on DMA64 devices, and fix an incorrect DMA
DMA boundary constraint applied in bhndb_dma_tag_create().

Sponsored by: The FreeBSD Foundation
00:47:45 - r326892
(1 day 5 hours ago)
by cperciva
Affects: 
(2 files)
/stable/11/release/tools/ec2.conf
MFC r326565: Make EC2 instances use Amazon's NTP service for time
synchronization.

Relnotes: EC2 instances now keep their clocks synchronized using
  the Amazon Time Sync Service (aka. NTP).
00:44:11 - r326891
(1 day 5 hours ago)
by cperciva
Affects:  /stable/11/sys/fs/nfs/nfs_commonsubs.c
Add vfs.nfs.suppress_32bits_warning sysctl which reduces the frequency
of 'fileid > 32bits' warnings from at most once per minute to at most
once per day.

Direct commit to stable/11 since the relevant code was removed from HEAD
following the switch to 64-bit inodes.

Requested by: Rafal Lukawiecki
Approved by: rmacklem
2017 - 12 - 15   (2 days ago)
23:50:26 - r326890
(1 day 6 hours ago)
by jeff
Affects: 
(1584 files)
/user/jeff/numa/*
Merge to head
23:35:20 - r326889
(1 day 6 hours ago)
by jeff
Affects: 
(36 files)
/user/jeff/numa/lib/libc/sys/Symbol.map
/user/jeff/numa/sys/*
/user/jeff/numa/usr.bin/cpuset/cpuset.c
First cut of NUMA domain integration into cpuset.
23:19:49 - r326888
(1 day 6 hours ago)
by imp
Affects:  /head/UPDATING
/head/share/mk/src.opts.mk
Note GELI-enabled zfsboot issues have been solved. Flip the switch
back to enabling GELI in boot and loader builds.

Sponsored by: Netflix
23:16:53 - r326887
(1 day 6 hours ago)
by imp
Affects: 
(10 files)
/head/stand/i386/*
/head/stand/libsa/*
/head/stand/mips/beri/common/*
Remove the 'mini libstand in libstand' that util.[ch] provided. These
weren't needed, and their existance interfered with things in subtle
ways. One of these subtle ways was that malloc could be different
based on what files were included when (even within the same .c file,
it turns out). Move to a single malloc implementation as well by
adding the calls to setheap() to gptboot.c and zfsboot.c. Once upon a
time, these boot loaders strove to not use libstand. However, with the
proliferation of features, that striving is too hard for too little
gain and lead to stupid mistakes.

This fixes the GELI-enabled (but not even using) boot environment. The
geli routines were calling libstand malloc but zfsboot.c and gptboot.c
were using the mini libstand malloc, so this failed when we tried to
probe for GELI partitions. Subtle changes in build order when moving
to self-contained stand build in r326593 toggled what it used from one
type to another due to odd nesting of the zfs implementation code that
differed subtly between zfsloader and zfsboot.

Sponsored by: Netflix
23:16:47 - r326886
(1 day 6 hours ago)
by imp
Affects:  /head/stand/libsa/sbrk.c
Panic in sbrk if setheap hasn't been called yet. This is preferable to
a mysterious crash.

Sponsored by: Netflix
23:16:42 - r326885
(1 day 6 hours ago)
by imp
Affects:  /head/tools/boot/rootgen.sh
Use -h -D in preference to -D so that the serial port gets the
interactive console rather than the video port. qemu has issues with X
on my mac at the moment and this is the easiest path forward.

Sponsored by: Netflix
23:16:37 - r326884
(1 day 6 hours ago)
by imp
Affects:  /head/tools/boot/rootgen.sh
Be a little verbose and list the loader files we're putting on the
drive when making zfs roots as a sanity check for what's on there.
23:16:27 - r326883
(1 day 6 hours ago)
by imp
Affects:  /head/tools/boot/install-boot.sh
For now, make the gpart commands verbose so we know exactly what's
being installed.

Fix problem with gpt + zfs installing the wrong loader...

Sponsored by: Netflix
19:14:21 - r326882
(1 day 11 hours ago)
by markj
Affects:  /head/sys/geom/mirror/g_mirror.c
Give a couple of predication functions a bool return type.

No functional change intended.

MFC after: 1 week
Sponsored by: Dell EMC Isilon
19:03:03 - r326881
(1 day 11 hours ago)
by markj
Affects:  /head/sys/geom/mirror/g_mirror.c
Typo.

MFC after: 1 week
18:58:21 - r326880
(1 day 11 hours ago)
by dim
Affects:  /head/contrib/llvm/tools/clang/lib/Sema/SemaDeclCXX.cpp
Pull in r320755 from upstream clang trunk (by me):

  Don't trigger -Wuser-defined-literals for system headers

  Summary:
  In D41064, I proposed adding `#pragma clang diagnostic ignored
  "-Wuser-defined-literals"` to some of libc++'s headers, since these
  warnings are now triggered by clang's new `-std=gnu++14` default:

  $ cat test.cpp
  #include <string>

  $ clang -std=c++14 -Wsystem-headers -Wall -Wextra -c test.cpp
  In file included from test.cpp:1:
  In file included from /usr/include/c++/v1/string:470:
  /usr/include/c++/v1/string_view:763:29: warning: user-defined literal
suffixes not starting with '_' are reserved [-Wuser-defined-literals]
  basic_string_view<char> operator "" sv(const char *__str, size_t __len)
  ^
  /usr/include/c++/v1/string_view:769:32: warning: user-defined literal
suffixes not starting with '_' are reserved [-Wuser-defined-literals]
  basic_string_view<wchar_t> operator "" sv(const wchar_t *__str, size_t
__len)
  ^
  /usr/include/c++/v1/string_view:775:33: warning: user-defined literal
suffixes not starting with '_' are reserved [-Wuser-defined-literals]
  basic_string_view<char16_t> operator "" sv(const char16_t *__str, size_t
__len)
  ^
  /usr/include/c++/v1/string_view:781:33: warning: user-defined literal
suffixes not starting with '_' are reserved [-Wuser-defined-literals]
  basic_string_view<char32_t> operator "" sv(const char32_t *__str, size_t
__len)
  ^
  In file included from test.cpp:1:
  /usr/include/c++/v1/string:4012:24: warning: user-defined literal suffixes
not starting with '_' are reserved [-Wuser-defined-literals]
  basic_string<char> operator "" s( const char *__str, size_t __len )
  ^
  /usr/include/c++/v1/string:4018:27: warning: user-defined literal suffixes
not starting with '_' are reserved [-Wuser-defined-literals]
  basic_string<wchar_t> operator "" s( const wchar_t *__str, size_t __len )
  ^
  /usr/include/c++/v1/string:4024:28: warning: user-defined literal suffixes
not starting with '_' are reserved [-Wuser-defined-literals]
  basic_string<char16_t> operator "" s( const char16_t *__str, size_t __len
)
  ^
  /usr/include/c++/v1/string:4030:28: warning: user-defined literal suffixes
not starting with '_' are reserved [-Wuser-defined-literals]
  basic_string<char32_t> operator "" s( const char32_t *__str, size_t __len
)
  ^
  8 warnings generated.

  Both @aaron.ballman and @mclow.lists felt that adding this workaround
  to the libc++ headers was the wrong way, and it should be fixed in
  clang instead.

  Here is a proposal to do just that. I verified that this suppresses
  the warning, even when -Wsystem-headers is used, and that the warning
  is still emitted for a declaration outside of system headers.

  Reviewers: aaron.ballman, mclow.lists, rsmith

  Reviewed By: aaron.ballman

  Subscribers: mclow.lists, aaron.ballman, andrew, emaste, cfe-commits

  Differential Revision: https://reviews.llvm.org/D41080

This will allow to compile some of the libc++ headers in C++14 mode
(which is the default for gcc 6 and higher, and will be the default for
clang 6.0.0 and higher), with -Wsystem-headers and -Werror enabled.

Reported by: andrew
MFC after: 3 days
18:56:12 - r326879
(1 day 11 hours ago)
by emaste
Affects:  /head/contrib/llvm/tools/lld/ELF/Relocations.cpp
lld: Simplify a boolean expression by De Morgan's laws.

Cherry-pick lld r315653 by Rui Ueyama:
  I don't really understand what exactly this expression means,
  but at least I can mechanically transform it.

Obtained from: LLVM r315653
MFC after: 1 week
18:09:23 - r326878
(1 day 12 hours ago)
by markj
Affects:  /head/cddl/usr.sbin/dtrace/tests/tools/exclude.sh
Mark uctf/err.user64mode.ksh as EXFAIL for now.

MFC after: 1 week
17:10:51 - r326877
(1 day 13 hours ago)
by markj
Affects:  /head/tests/sys/geom/class/nop/nop_test.sh
Skip gnop tests if the corresponding kernel module isn't available.

Reviewed by: asomers
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D13500
12:37:32 - r326876
(1 day 17 hours ago)
by ae
Affects: 
(5 files)
/head/sys/netinet6/*
Follow the RFC6980 and silently ignore following IPv6 NDP messages
that had the IPv6 fragmentation header:
 o Neighbor Solicitation
 o Neighbor Advertisement
 o Router Solicitation
 o Router Advertisement
 o Redirect

Introduce M_FRAGMENTED mbuf flag, and set it after IPv6 fragment reassembly
is completed. Then check the presence of this flag in correspondig ND6
handling routines.

PR: 224247
MFC after: 2 weeks
06:44:11 - r326875
(1 day 23 hours ago)
by imp
Affects:  /head/tools/boot/install-boot.sh
Add missing of=/dev/${dev}s${s} when installing zfsboot.
06:34:27 - r326874
(1 day 23 hours ago)
by imp
Affects:  /head/tools/boot/rootgen.sh
Script to generate minimal boot images for each of the 24 supported
boot images for x86. This will be enhanced to generate all the other
images (u-boot, powerpc CHRP, etc).

At the moment, it's only generating three of them. zfs+gpt+legacy
works with qemu:
  qemu-system-x86_64 --drive file=${file},format=raw -serial telnet::4444,server
but the ufs ones still have issues I'm tracking down.

These images are the boot blocks, /boot/loader, a kernel, maybe a
couple of modules, /sbin/init, /bin/sh, /libexec/ld-elf.so, libc.so,
libedit and libncursesw. This is just enough to get to single user. At
the moment, these come from the host system, but should come from
OBJTOP.

At the moment, this requires root to build since the zfs tools require
it (and GELI will too when we add support for that).

Sponsored by: Netflix
06:34:11 - r326873
(1 day 23 hours ago)
by imp
Affects:  /head/tools/boot/install-boot.sh
Script that knows how to put boot blocks onto a device. Eventually,
this will be installed into /usr/sbin, but for now it's just used for
the boot loader regression script. It's still a bit green, and likely
will get edge cases wrong still. It's also x86 centric at the moment,
but will be enhanced shortly for u-boot, CHRP PowerPC and other
methods.

Sponsored by: Netflix
06:05:16 - r326872
(2 days ago)
by eugen
Affects:  /head/usr.sbin/pw/pw_user.c
pw(8): r326738 broke expiration arithmetic in case of `-D' flag not supplied.

Fix it and rename misnamed time_t variables `expire_days, password_days'
(always holding absolute time) to `expire_time, password_time'.

Add a comment for a case of overloading `cmdcnf->password_days'
and `cmdcnf->expire_days' with absolute time.

Reported by: markj
Approved by: mav (mentor)
MFC after: 1 week
04:51:47 - r326871
(2 days 1 hour ago)
by landonf
Affects: 
(9 files)
/head/sys/dev/bhnd/*
/head/sys/dev/bwn/if_bwn_siba_compat.c
bhnd(4)/bwn(4): Fix a number of small issues reported by Coverity.

- Fix reference of uninitialized error value in bhndb_generic_resume() if
  the dynamic window count is 0.

- Fix incorrect bhnd_pmu(4) UPTME_MASK and PLL0_PC2_WILD_INT_MASK
  constants.

- Variable definitions referenced by our generated SPROM layouts will never
  be NULL, but add explicit asserts to make that clear.

- Add missing variable initialization in bhnd_nvram_sprom_ident().

- Fix leak of driver array in bhnd_erom_probe_driver_classes().

- Fix zero-length memset() in bhndb_pci_eio_init().

- Fix an off-by-one error and potential invalid OOBSEL bit shift operation
  in bcma_dinfo_init_intrs().

- Remove dead code in siba_suspend_hw().

- Fix duplicate call to bhnd_pmu_enable_regulator() in both the enable and
  disable code paths of bhnd_compat_cc_pmu_set_ldoparef().

Reported by: Coverity
CIDs: 1355194, 1362020, 1362022, 1373114, 1366563, 1373115,
  1381569, 1381579, 1383555, 1383566, 1383571
Sponsored by: The FreeBSD Foundation
04:11:20 - r326870
(2 days 2 hours ago)
by jhibbits
Affects:  /head/sys/powerpc/include/trap.h
/head/sys/powerpc/powerpc/trap.c
Handle the Facility Unavailable exception as a SIGILL

Currently Facility Unavailable is absent and once an application
tries to use or access a register from a feature disabled in the
CPU it causes a kernel panic.

A simple test-case is:

int main() { asm volatile ("tbegin.;"); }

which will use TM (Hardware Transactional Memory) feature which
is not supported by the kernel and so will trigger the following
kernel panic:

----

fatal user trap:

  exception = 0xf60 (unknown)
  srr0 = 0x10000890
  srr1 = 0x800000000000f032
  lr = 0x100004e4
  curthread = 0x5f93000
  pid = 1021, comm = htm

panic: unknown trap
cpuid = 40
KDB: stack backtrace:
Uptime: 3m18s
Dumping 10 MB (3 chunks)
  chunk 0: 11MB (2648 pages) ... ok
  chunk 1: 1MB (24 pages) ... ok
  chunk 2: 1MB (2 pages)panic: IOMMU mapping error: -4

cpuid = 40
Uptime: 3m18s

----

Since Hardware Transactional Memory is not yet supported by FreeBSD, treat
this as an illegal instruction.

PR: 224350
Submitted by: Gustavo Romero <gromero_AT_ibm_DOT_com>
MFC after: 2 weeks
03:46:52 - r326869
(2 days 2 hours ago)
by eadler
Affects:  /head/share/misc/bsd-family-tree
bsd-family-tree: add dfly 5.0.[12]
03:36:48 - r326868
(2 days 2 hours ago)
by eadler
Affects:  /head/share/misc/bsd-family-tree
bsd-family-tree: Add NetBSD 7.0.2

Pulled directly from NetBSD
03:05:14 - r326867
(2 days 3 hours ago)
by bde
Affects:  /head/sys/i386/acpica/acpi_wakecode.S
Minor cleanups found while fixing a bug involving double mapping of low
memory:

Load the kernel eflags less magically, as in locore. The magic increased
when I removed eflags from the pcb in r305899.

Remove a jump to low memory that became garbage when the i386 version was
mostly replaced by the amd64 version in r235622.

The amd64 version is very similar. It still loads the flags magically,
but is not missing comments about using the special page table.

Reviewed by: kib
2017 - 12 - 14   (3 days ago)
23:21:31 - r326866
(2 days 6 hours ago)
by jkim
Affects: 
(40 files)
/head/sys/contrib/dev/acpica/*
MFC: r326864

Merge ACPICA 20171214.
22:57:22 - r326865
(2 days 7 hours ago)
by jkim
Affects:  /vendor-sys/acpica/20171214
Tag ACPICA 20171214.
22:56:53 - r326864
(2 days 7 hours ago)
by jkim
Affects: 
(45 files)
/vendor-sys/acpica/dist/changes.txt
/vendor-sys/acpica/dist/generate/unix/acpinames/Makefile
/vendor-sys/acpica/dist/source/*
Import ACPICA 20171214.
22:15:46 - r326863
(2 days 7 hours ago)
by markj
Affects:  /head/tests/sys/geom/class/mirror/conf.sh
Belatedly add syncwait.

X-MFC with: r326861
22:14:07 - r326862
(2 days 8 hours ago)
by markj
Affects:  /head/tests/sys/geom/class/mirror/8_test.sh
/head/tests/sys/geom/class/mirror/9_test.sh
Make indentation consistent with other tests, and use syncwait.

MFC after: 2 weeks
Sponsored by: Dell EMC Isilon
22:11:35 - r326861
(2 days 8 hours ago)
by markj
Affects: 
(6 files)
/head/tests/sys/geom/class/geom_subr.sh
/head/tests/sys/geom/class/mirror/*
Add some basic tests for gmirror read and write error handling.

MFC after: 2 weeks
Sponsored by: Dell EMC Isilon
20:48:50 - r326860
(2 days 9 hours ago)
by rstone
Affects:  /head/sys/net/route.c
Plug an ifaddr leak when changing a route's src

If a route is modified in a way that changes the route's source
address (i.e. the address used to access the gateway), then a
reference on the ifaddr representing the old source address will
be leaked if the address type does not have an ifa_rtrequest
method defined. Plug the leak by releasing the reference in
all cases.

Differential Revision: https://reviews.freebsd.org/D13417
Reviewed by: ae
MFC after: 3 weeks
Sponsored by: Dell
20:01:04 - r326859
(2 days 10 hours ago)
by jhibbits
Affects:  /head/sys/powerpc/powerpc/cpu.c
Add identifier for POWER9 CPU to CPU list

Without the identifier in the list booting FreeBSD results in printing the
following (from a PowerKVM boot):

cpu0: Unknown PowerPC CPU revision 0x1201, 2550.00 MHz

For now, add the same feature list as POWER8. As new capabilities are added to
support POWER9 specific features, they will be added to this.

PR: 224344
Submitted by: Breno Leitao <breno_DOT_leitao_AT_gmail_DOT_com>
18:57:17 - r326858
(2 days 11 hours ago)
by imp
Affects:  /head/stand/ficl/float.c
Revert r326855: Cargo cut a fix for the regressions r326585 caused.

This was an experiment that landed in the wrong branch and was pushed
accidentally. It's best if it is ignored because the difference was
due to vers.o being different, not float.o... And it was confirmed to
not fix anything...

Pointy Hat to: imp
17:00:24 - r326857
(2 days 13 hours ago)
by imp
Affects:  /head/UPDATING
/head/share/mk/src.opts.mk
/head/stand/i386/zfsboot/zfsldr.S
Turn loader GELI support in the boot loaders off by default as a
temporary workaround. This fixes zfs booting generally, but breaks all
GELI booting by default. Add note to UPDATING to this effect. When the
GELI issues are resolved, this will be reverted.
16:51:43 - r326856
(2 days 13 hours ago)
by imp
Affects:  /head/stand/i386/gptboot/gptldr.S
Fix comments after bump in size.
16:51:26 - r326855
(2 days 13 hours ago)
by imp
Affects:  /head/stand/ficl/float.c
Cargo cut a fix for the regressions r326585 caused.

We need to include ficl.h after the standard includes, rather than
before them. It changes the generated code in ways that haven't been
completely analyized. This restores the old code generation (as
verified by md5 changing back for zfsloader).

This should restore GPT + ZFS and GPT + ZFS + GELI booting that was
broken in r326585 (or would have been if r326584 hadn't broken the
build).

Sponsored by: Netflix
16:41:52 - r326854
(2 days 13 hours ago)
by tsoome
Affects: 
(5 files)
/head/stand/efi/boot1/boot1.c
/head/stand/efi/include/efichar.h
/head/stand/efi/libefi/*
libefi: make efichar.h more usable in stand code

Use _STANDALONE for guard expression in efichar.[ch] and add efi_char typedef.
clean up boot1.c, and replace for loop in efipart.c with ucs2len().

Reviewed by: imp
Differential Revision: https://reviews.freebsd.org/D13488
15:41:32 - r326853
(2 days 14 hours ago)
by asomers
Affects: 
(11 files)
/head/sbin/dhclient/*
dhclient(8): raise WARNS to 3

Mostly had to fix a lot of signed/unsigned comparison warnings

MFC after: 3 weeks
Sponsored by: Spectra Logic Corp
15:40:03 - r326852
(2 days 14 hours ago)
by markj
Affects:  /head/usr.bin/vmstat/vmstat.c
Re-add spaces lost in r326436.

X-MFC with: r326436
13:41:11 - r326851
(2 days 16 hours ago)
by kib
Affects:  /head/sys/fs/devfs/devfs_vnops.c
In devfs_lookupx() dotdot lookup case, avoid dereferencing
dvp->v_mount after dvp is unlocked.

The vnode might be reclaimed after unlock, so v_mount becomes NULL.
Cache the struct mount pointer before the unlock, the struct is
type-stable.

Note that devfs_allocv() reads mp->mnt_data but does not operate on it
further when dirent is doomed. The unmount cannot proceed until all
dirents are reclaimed.

Reported and tested by: pho
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
13:19:43 - r326850
(2 days 16 hours ago)
by andrew
Affects:  /head/sys/arm/include/sysreg.h
Add the virtualisation special register definitions.

Submitted by: Mihai Carabas <mihai.carabas@gmail.com>
Reviewed by: mmel
Differential Revision: https://reviews.freebsd.org/D11846
13:10:22 - r326849
(2 days 17 hours ago)
by eugen
Affects: 
(7 files)
/stable/10/usr.sbin/pw/*
MFC r326738: pw(8): correct expiration period handling
  and command line overrides to preconfigured values for -e, -p and -w flags.

  Use non-negative symbols instead of magic values
  in passwd_val/pw_password functions.

PR: 223431
Submitted by: Yuri Pankov (in part, patch for the manual)
Approved by: mav (mentor)
Relnotes: yes
13:06:41 - r326848
(2 days 17 hours ago)
by eugen
Affects: 
(7 files)
/stable/11/usr.sbin/pw/*
MFC r326738: pw(8): correct expiration period handling
  and command line overrides to preconfigured values for -e, -p and -w flags.

  Use non-negative symbols instead of magic values
  in passwd_val/pw_password functions.

PR: 223431
Submitted by: Yuri Pankov (in part, patch for the manual)
Approved by: mav (mentor)
Relnotes: yes
12:54:20 - r326847
(2 days 17 hours ago)
by ae
Affects:  /head/sys/netinet/tcp_output.c
Fix mbuf leak when TCPMD5_OUTPUT() method returns error.

PR: 223817
MFC after: 1 week
11:45:02 - r326846
(2 days 18 hours ago)
by kib
Affects: 
(2 files)
/stable/10/sys/ufs/ufs/ufs_dirhash.c
MFC r326657:
Fix livelock in ufsdirhash_create().
11:41:12 - r326845
(2 days 18 hours ago)
by kib
Affects: 
(2 files)
/stable/11/sys/ufs/ufs/ufs_dirhash.c
MFC r326657:
Fix livelock in ufsdirhash_create().
08:57:37 - r326844
(2 days 21 hours ago)
by bapt
Affects:  /head/usr.sbin/mailwrapper/Makefile
/head/usr.sbin/mailwrapper/Makefile.depend
/head/usr.sbin/mailwrapper/mailwrapper.c
Replace usage of fparselen(3) by a getline(3)

This allow to remove the dependency on libutil
07:55:11 - r326843
(2 days 22 hours ago)
by delphij
Affects: 
(2 files)
/stable/10/sbin/fsck_msdosfs/dir.c
MFC r326391: Prevent OOB access on corrupted msdos directories.

Submitted by: Veo Zhang <veo live com>
07:52:38 - r326842
(2 days 22 hours ago)
by delphij
Affects: 
(2 files)
/stable/11/sbin/fsck_msdosfs/dir.c
MFC r326391: Prevent OOB access on corrupted msdos directories.

Submitted by: Veo Zhang <veo live com>
06:45:04 - r326841
(2 days 23 hours ago)
by landonf
Affects: 
(4 files)
/head/sys/dev/bwn/*
Add basic bwn(4) support for the (BCMA-based) BCM43224 and BCM43225.

- Add the BCM4322X D11 core revision and missing BCM43224 PCI device ID to
  our device tables.
- Disable the DMA engine parity check (rather than adding parity support
  to the to-be-replaced bwn(4) DMA implementation).

Currently, N-PHY support in bwn(4) is GPL licensed, and is not included by
default. Until this is replaced with Broadcom's ISC-licensed N-PHY
implementation, bwn(4) must be rebuilt to enable N-PHY support.

To build bwn(4) with N-PHY support, add the following lines to your kernel
configuration file and rebuild the kernel (and modules):

  options BWN_GPL_PHY

To test bwn(4) with a BCM43224/BCM43225 device, install the firmware from
the net/bwn-firmware-kmod port, and place the following lines in
loader.conf(5):

  hw.bwn_pci.preferred="1"

  if_bwn_pci_load="YES
  bwn_v4_ucode_load="YES"
  bwn_v4_n_ucode_load="YES"
  bwn_v4_lp_ucode_load="YES"

Approved by: adrian (mentor, implicit)
Sponsored by: The FreeBSD Foundation
04:41:07 - r326840
(3 days 1 hour ago)
by jhibbits
Affects:  /head/sys/dev/dpaa/bman_fdt.c
/head/sys/dev/dpaa/qman_fdt.c
Allow bman-portals and qman-portals to attach to simple-bus

Official Linux dts's put the individual portals under a simple-bus, rather
than under a '*-portals' grouping. This adds a hack to permit that, which
gets us closer to using stock device trees for DPAA-based devices.
03:41:12 - r326839
(3 days 2 hours ago)
by landonf
Affects:  /head/sys/dev/bhnd/bhndb/bhndb.c
bhndb(4): Fix two register window overcommit bugs introduced in r326297:

- The window target must always be updated when stealing a register window.
- Fix missing initialization of bhndb(4) region alloc_flags when
  registering statically mapped port regions (caught by scan-build).

Approved by: adrian (mentor, implicit)
Sponsored by: The FreeBSD Foundation
03:12:05 - r326838
(3 days 3 hours ago)
by landonf
Affects:  /head/sys/dev/bhnd/cores/chipc/chipc_gpiovar.h
bhnd_chipc(4): Correct typo in flag macros that broke clearing of GPIO
pin flags.

Approved by: adrian (mentor, implicit)
Sponsored by: The FreeBSD Foundation
03:03:08 - r326837
(3 days 3 hours ago)
by landonf
Affects:  /head/sys/dev/bhnd/bhnd.h
/head/sys/dev/bhnd/tools/bus_macro.sh
bhnd(4): Add missing enclosing parentheses to the bhnd bus space macros to
avoid precedence bugs.

Approved by: adrian (mentor, implicit)
Sponsored by: The FreeBSD Foundation
01:58:05 - r326836
(3 days 4 hours ago)
by landonf
Affects: 
(7 files)
/head/share/man/man9/bhnd.9
/head/sys/dev/bhnd/*
/head/sys/mips/broadcom/bhnd_nexus.c
bhnd(4): Include board_devid in the bhnd_board_info structure, and populate
the expected default board_vendor value on MIPS SoCs.

This is required by bwn(4) to differentiate between single-band and
dual-band device variants that otherwise share a common chip ID.

Approved by: adrian (mentor, implicit)
Sponsored by: The FreeBSD Foundation
2017 - 12 - 13   (4 days ago)
21:17:00 - r326835
(3 days 8 hours ago)
by mav
Affects: 
(6 files)
/head/sys/cam/ata/*
/head/sys/cam/nvme/nvme_da.c
/head/sys/cam/scsi/*
Reduce size of several on-stack string buffers.

Submitted by: Dmitry Luhtionov <dmitryluhtionov@gmail.com>
MFC after: 2 weeks
20:48:20 - r326834
(3 days 9 hours ago)
by asomers
Affects:  /head/sbin/dhclient/dhclient.c
dhclient(8): Don't shift through the sign bit of a signed int

PR: 208007
Submitted by: Michael McConville <mmcco@mykolab.com>
MFC after: 3 weeks
20:15:23 - r326833
(3 days 9 hours ago)
by cy
Affects: 
(6 files)
/stable/10/*
/stable/11/*
MFC r324248:

hen building multiple kernels using KERNCONF, non-existent KERNCONF
files will produce an error and buildkernel will fail. Previously missing
KERNCONF files silently failed giving no indication as to why, only to
subsequently discover during installkernel that the desired kernel was
never built in the first place.

This is a rework of r302865.

This is the correct patch.

Reviewed by: ngie (previous version, r302865)
Differential Revision: https://reviews.freebsd.org/D7167
19:36:29 - r326832
(3 days 10 hours ago)
by cem
Affects:  /head/tools/tools/netmap/pkt-gen.c
netmap pkt-gen tool: Fix memset(3) argument order

Submitted by: Michael McConville <mmcco AT mykolab.com>
Sponsored by: Dell EMC Isilon
19:03:48 - r326831
(3 days 11 hours ago)
by dim
Affects: 
(4 files)
/head/contrib/llvm/tools/lld/ELF/*
Pull in r315334 from upstream lld trunk (by Rafael Espindola):

  Don't create a dummy __tls_get_addr.

  We just don't need one with the current setup.

  We only error on undefined references that are used by some
  relocation.

  If we managed to relax all uses of __tls_get_addr, no relocation uses
  it and we don't produce an error.

  This is less code and fixes the case were we fail to relax. Before we
  would produce a broken output, but now we produce an error.

Pull in r320390 from upstream lld trunk (by Rafael Espindola):

  Create reserved symbols early so they can be versioned.

  This fixes pr35570.

  We were creating these symbols after parsing version scripts, so they
  could not be versioned.

  We cannot move the version script parsing later because we need it for
  lto.

  One option is to move both addReservedSymbols and
  createSyntheticSections earlier. The disadvantage is that some
  sections created by createSyntheticSections replace other input
  sections. For example, gdb index replaces .debug_gnu_pubnames, so it
  wants to run after gc sections so that it can set S->Live to false.

  What this patch does instead is to move just the ElfHeader creation
  early.

Pull in r320412 from upstream lld trunk (by Rafael Espindola):

  Handle symbols pointing to output sections.

  Now that gc sections runs after linker defined symbols are added it
  can see symbols that point to an OutputSection.

  Should fix a bot failure.

Pull in r320431 from upstream lld trunk (by Peter Collingbourne):

  ELF: Do not follow relocation edges to output sections during GC.

  This fixes an assertion error introduced by r320390.

  Differential Revision: https://reviews.llvm.org/D41095

Together these fix handling of reserved symbols, in particular _end,
which is needed to make brk(2) and sbrk(2) work correctly. This
unbreaks the emacs ports on amd64, and also appears to unbreak most of
world on i386.

MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D13466
18:38:02 - r326830
(3 days 11 hours ago)
by dim
Affects: 
(6 files)
/stable/10/lib/msun/man/*
/stable/11/lib/msun/man/*
MFC r326748:

Document the existence and precision of the remaining long double
functions for which an imprecise stub implementation was added in
r255294, namely powl(3) and tgammal(3).

Submitted by: Steve Kargl

MFC r326753:

Correct r326748, indicating that tgammal(3) is mapped to tgamma(3), not
to itself.

Noticed by: jilles
17:11:57 - r326829
(3 days 13 hours ago)
by tuexen
Affects:  /head/sys/netinet/sctp_input.c
/head/sys/netinet/sctp_output.c
Cleaup, no functional change.
16:30:39 - r326828
(3 days 13 hours ago)
by pfg
Affects: 
(10 files)
/head/lib/libmd/*
/head/sys/*
SPDX: some uses of the RSA-MD license.
16:22:02 - r326827
(3 days 13 hours ago)
by asomers
Affects: 
(2 files)
/stable/11/lib/libcam/tests/libcam_test.c
MFC r326101:

Add a test case for cam_get_device with sa(4) devices

sa(4) has some unique behavior that is special-cased in cam_get_device. The
existing tests don't provide coverage for this special case.

Reviewed by: ken
Sponsored by: Spectra Logic Corp
Differential Revision: https://reviews.freebsd.org/D13185
16:20:55 - r326826
(3 days 13 hours ago)
by asomers
Affects: 
(2 files)
/stable/11/sys/cam/cam_xpt.c
MFC r326100:

Always null-terminate CAM periph_name and dev_name

Reported by: Coverity
CID: 1010039, 1010040, 1010041, 1010043
Reviewed by: ken, imp
Sponsored by: Spectra Logic Corp
Differential Revision: https://reviews.freebsd.org/D13194
16:17:37 - r326825
(3 days 13 hours ago)
by asomers
Affects: 
(3 files)
/stable/11/sys/cam/ata/ata_da.c
/stable/11/sys/cam/scsi/scsi_da.c
MFC r326040:

Quirk Seagate ST8000AS0003-2HH

Like its predecessor ST8000AS0002, this is a drive-managed SMR drive, but
doesn't declare that in its ATA identify data.

Sponsored by: Spectra Logic Corp
16:14:38 - r326824
(3 days 13 hours ago)
by fsu
Affects:  /head/sys/kern/vfs_extattr.c
Fix kernel build if MAC is not defined.

Reported by: Ravi Pokala, Andrew Turner
Approved by: pfg (mentor)
MFC after: 1 week
16:13:17 - r326823
(3 days 14 hours ago)
by pfg
Affects: 
(37 files)
/head/*
SPDX: mostly fixes to previous changes.

Introduce the recently approved BSD-1-Clause and replace 0BSD which
never did fit well our use cases.
16:09:00 - r326822
(3 days 14 hours ago)
by bapt
Affects:  /head/usr.bin/diff/diffreg.c
Replace homemade equivalent of tolower(3) by towlower(3)

This will help in the futur making diff -i works with multibyte
15:20:11 - r326821
(3 days 14 hours ago)
by markj
Affects: 
(2 files)
/stable/11/sys/vm/vm_pageout.c
MFC r326629:
Use unique wait messages in the page daemon control loop.
14:08:33 - r326820
(3 days 16 hours ago)
by trasz
Affects:  /head/sbin/growfs/growfs.8
Tone down the description for the growfs "-y" flag.

MFC after: 2 weeks
07:07:27 - r326819
(3 days 23 hours ago)
by imp
Affects:  /head/sys/cam/ata/ata_da.c
Use ataio ccb instead of general ccb to avoid excessice stack usage.
06:20:18 - r326818
(3 days 23 hours ago)
by delphij
Affects: 
(2 files)
/stable/10/usr.bin/ipcs/ipc.c
MFC r326361: Remove unused include.
06:17:20 - r326817
(3 days 23 hours ago)
by delphij
Affects: 
(2 files)
/stable/11/usr.bin/ipcs/ipc.c
MFC r326361: Remove unused include.
03:36:33 - r326816
(4 days 2 hours ago)
by eadler
Affects:  /head/usr.bin/find/extern.h
/head/usr.bin/find/main.c
find(1): remove unused variable
2017 - 12 - 12   (5 days ago)
22:21:20 - r326815
(4 days 7 hours ago)
by dim
Affects:  /head/etc/mtree/BSD.root.dist
Follow-up to r325967, which removed /etc/casper, by also removing it
from BSD.root.dist, so it does not get created again on installworld.
22:10:12 - r326814
(4 days 8 hours ago)
by pfg
Affects: 
(4 files)
/stable/10/sys/amd64/linux/linux_sysvec.c
/stable/10/sys/amd64/linux32/linux32_sysvec.c
/stable/10/sys/i386/linux/linux_sysvec.c
MFC r326282: (by fsu)

Remap ENOATTR to ENODATA in the linuxulator.
In the linux ENOADATA is frequently #defined as ENOATTR. The change is
required for an xattrs support implementation.
22:08:34 - r326813
(4 days 8 hours ago)
by markj
Affects: 
(2 files)
/head/sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c
MFV r326785: 8880 improve DTrace error checking

illumos/illumos-gate@2cf374268f3e1c9e9be6367466b183d27632583a
https://github.com/illumos/illumos-gate/commit/2cf374268f3e1c9e9be6367466b183d27632583a

https://www.illumos.org/issues/8880

Reviewed by: Tim Kordas <tim.kordas@joyent.com>
Reviewed by: Bryan Cantrill <bryan@joyent.com>
Reviewed by: Richard Lowe <richlowe@richlowe.net>
Approved by: Dan McDonald <danmcd@joyent.com>
Author: Jerry Jelinek <jerry.jelinek@joyent.com>

MFC after: 1 week
22:06:22 - r326812
(4 days 8 hours ago)
by imp
Affects: 
(15 files)
/head/stand/*
Revert r326792, r326784, r326772, r326712

Something subtle is creating problems for disk access on ubldr. Back
it out unti that can be sorted out.

Sponsored by: Netflix
20:41:11 - r326811
(4 days 9 hours ago)
by markj
Affects:  /head/sys/cddl/contrib/opensolaris/uts/powerpc/dtrace/fasttrap_isa.c
Correct initialization of pc on powerpc.

PR: 224293
Submitted by: Breno Leitao <breno.leitao@gmail.com>
X-MFC with: r326774
Pointy hat: markj
20:28:54 - r326810
(4 days 9 hours ago)
by fsu
Affects: 
(4 files)
/stable/11/lib/libsysdecode/errno.c
/stable/11/sys/amd64/*
/stable/11/sys/i386/linux/linux_sysvec.c
MFC r326282, r326317:
Remap ENOATTR to ENODATA in the linuxulator.
In the linux ENOADATA is frequently #defined as ENOATTR.
The change is required for an xattrs support implementation.

Sync bsd_to_linux_errno[] table with i386 and amd64 tables in the sys directory.

Discussed with: netchild
Requested by: jhb
Approved by: pfg (mentor)
20:22:09 - r326809
(4 days 9 hours ago)
by imp
Affects:  /head/sys/dev/cardbus/cardbus_cis.c
1k objects on the stack are a bad idea. While it's likely safe in this
context, it's also safe to allocate the memory and free it instead.

Noticed by: Eugene Grosbein's script
20:15:57 - r326808
(4 days 9 hours ago)
by fsu
Affects:  /head/sys/kern/vfs_extattr.c
Move buffer size checks outside of the vnode locks.

Reviewed by: kib, cem, pfg (mentor)
Approved by: pfg (mentor)
MFC after: 1 weeks

Differential Revision: https://reviews.freebsd.org/D13405
20:02:48 - r326807
(4 days 10 hours ago)
by fsu
Affects:  /head/sys/fs/ext2fs/ext2_extattr.c
Fix extattr getters in case of neither uio nor buffer was not passed to VOP_*.

Approved by: pfg (mentor)
MFC after: 2 weeks

Differential Revision: https://reviews.freebsd.org/D13359
19:45:24 - r326806
(4 days 10 hours ago)
by imp
Affects:  /head/usr.sbin/efibootmgr/efibootmgr.c
Actually insert the free(d) call missed in r326802.

Noticed by: rpokala@
19:26:28 - r326805
(4 days 10 hours ago)
by imp
Affects:  /head/usr.sbin/efivar/efiutil.c
Iniailize str so ucs2_to_utf8 won't free stack garbage.

CID: 1381037
Sponsored by: Netflix
19:26:24 - r326804
(4 days 10 hours ago)
by imp
Affects:  /head/usr.sbin/efibootmgr/efibootmgr.c
Add sanity testing against maximum sane lengths for device paths for
loader and kernel.

CID: 1383608
Sponsored by: Netflix
19:26:19 - r326803
(4 days 10 hours ago)
by imp
Affects:  /head/usr.sbin/efibootmgr/efibootmgr.c
Free load_opt_buf after we're done with it.

CID: 1383607
Sponsored by: Netflix
19:26:15 - r326802
(4 days 10 hours ago)
by imp
Affects:  /head/usr.sbin/efibootmgr/efibootmgr.c
Fix resource leak. Free converted description after printing it.
Also minor style sort of local vars.

CID: 1383606
Sponsored by: Netflix
19:26:10 - r326801
(4 days 10 hours ago)
by imp
Affects:  /head/usr.sbin/efibootmgr/efibootmgr.c
Don't leak new_data.

CID: 1383605
Sponsored by: Netflix
19:25:54 - r326800
(4 days 10 hours ago)
by imp
Affects:  /head/usr.sbin/efibootmgr/efibootmgr.c
Check return value for set_bootvar and give a good error message.

CID: 1383601
Sponsored by: Netflix
17:34:35 - r326799
(4 days 12 hours ago)
by asomers
Affects:  /head/contrib/less/main.c
less(1): diff reduction vs upstream

No functional change.

MFC after: 3 weeks
Sponsored by: Spectra Logic Corp
17:29:34 - r326798
(4 days 12 hours ago)
by markj
Affects:  /head/sys/geom/mirror/g_mirror.c
Address a possible lost wakeup for gmirror events.

g_mirror_event_send() acquires the I/O queue lock to deliver a wakeup
to the worker thread, and this is done after enqueuing the event.
So it's sufficient to check the event queue before atomically releasing
the queue lock and going to sleep.

MFC after: 1 week
Sponsored by: Dell EMC Isilon
17:25:25 - r326797
(4 days 12 hours ago)
by markj
Affects:  /head/sys/geom/mirror/g_mirror.c
Give g_mirror_event_get() a more accurate name.

MFC after: 1 week
Sponsored by: Dell EMC Isilon
17:24:30 - r326796
(4 days 12 hours ago)
by markj
Affects:  /head/sys/geom/mirror/g_mirror.c
Decrement sc_writes when BIO_DELETE requests complete.

Otherwise a gmirror that has received a BIO_DELETE request will never be
marked clean (unless sc_writes overflows).

MFC after: 1 week
Sponsored by: Dell EMC Isilon
12:59:04 - r326795
(4 days 17 hours ago)
by danfe
Affects: 
(3 files)
/stable/8/contrib/gcclibs/include/objalloc.h
/stable/8/contrib/gcclibs/libiberty/objalloc.c
MFC r301291:

  libiberty: prevent integer overflow.

  Take care of very old bug leading to heap-buffer overflow by
  processing certain file headers via bfd binary.

  PR: 200888
  Obtained from: OpenBSD

Approved by: pfg
11:25:30 - r326794
(4 days 18 hours ago)
by mmel
Affects:  /head/lib/libc/gen/tls.c
Rework alignment handling in __libc_allocate_tls() for Variant I of TLS layout.

There are two versions of variant I of TLS
- ARM and aarch64 uses original version of variant I here TP points to
  start of TCB followed by aligned TLS segment. Both TCB and TLS must
  be aligned to alignment of TLS section. The TCB[0] points to DTV vector
  and DTV values are real addresses (without bias).

- MIPS, PowerPC and RISC-V use modified version of variant I,
  where TP points (with bias) to TLS and TCB immediately precedes TLS
  without any alignment gap. Only TLS should be aligned. The TCB[0]
  points to DTV vector and DTV values are biased by constant value (0x8000)
  from real addresses.

Take all this in account when allocating memory for TLS structures.

MFC after: 1 month
Reviewed by: kib, mizhka
Tested by: mizhka(on mips)
Differential Revision: https://reviews.freebsd.org/D13378
11:09:46 - r326793
(4 days 19 hours ago)
by kib
Affects: 
(2 files)
/stable/11/sys/amd64/amd64/efirt.c
MFC r326311:
Fix index calculation for the page table pages for efirt 1:1 map.
09:46:53 - r326792
(4 days 20 hours ago)
by antoine
Affects:  /head/stand/uboot/common/main.c
Attempt to unbreak buildworld
06:56:21 - r326791
(4 days 23 hours ago)
by delphij
Affects:  /head/usr.bin/gzip/gzip.c
Close the correct file descriptor.

MFC after: 2 weeks
04:08:30 - r326790
(5 days 2 hours ago)
by delphij
Affects: 
(2 files)
/stable/10/usr.bin/find/function.c
Revert r326763. The change depends on r264387 which was not merged.

Pointy hat to: delphij
03:16:10 - r326789
(5 days 2 hours ago)
by jhibbits
Affects:  /head/sys/powerpc/powerpc/trap.c
Decode some PowerPC trap registers

Decode on Book-E:
* ESR (Exception Syndrome Register)
* MCSR (Machine Check Status Register)

On AIM:
* MSSSR (Memory Subsystem Status Register)

Makes it easier to tell at a glance the type of trap and machine check
conditions now.
01:20:46 - r326788
(5 days 4 hours ago)
by emaste
Affects: 
(2 files)
/stable/11/sys/dev/vnic/nicvf_queues.c
MFC r326597: vnic: apply hardware L3 checksum only for IPv4

Previously we set the csum_l3 flag for IPv4 and IPv6, but only IPv4
should have header checksumming applied.

Prompted by Linux commit fa6d7cb5d76cf0467c61420fc9238045aedfd379.

Sponsored by: The FreeBSD Foundation
01:19:18 - r326787
(5 days 4 hours ago)
by emaste
Affects: 
(2 files)
/stable/11/contrib/llvm/tools/lld/ELF/Driver.cpp
MFC r326547: lld: make -v behave similarly to GNU ld.bfd

Previously, lld exited with an error status if the only option given to
the command was -v. GNU linkers gracefully exit in that case. This patch
makes lld behave like GNU.

Note that even with this patch, lld's -v and --version options behave
slightly differently than GNU linkers' counterparts. For example,
if you run ld.bfd -v -v, the version string is printed out twice.
But that is an edge case that I don't think we need to take care of.

Fixes https://bugs.llvm.org/show_bug.cgi?id=31582

Obtained from: LLVM r319717
01:19:08 - r326786
(5 days 4 hours ago)
by cem
Affects:  /head/usr.bin/gzip/gzip.c
gzip(1): Remove duplicate close()

CID: 1383560
Reported by: Coverity
Sponsored by: Dell EMC Isilon
00:51:39 - r326785
(5 days 5 hours ago)
by markj
Affects:  /vendor-sys/illumos/dist/uts/common/dtrace/dtrace.c
8880 improve DTrace error checking

illumos/illumos-gate@2cf374268f3e1c9e9be6367466b183d27632583a
https://github.com/illumos/illumos-gate/commit/2cf374268f3e1c9e9be6367466b183d27632583a

https://www.illumos.org/issues/8880

Reviewed by: Tim Kordas <tim.kordas@joyent.com>
Reviewed by: Bryan Cantrill <bryan@joyent.com>
Reviewed by: Richard Lowe <richlowe@richlowe.net>
Approved by: Dan McDonald <danmcd@joyent.com>
Author: Jerry Jelinek <jerry.jelinek@joyent.com>
2017 - 12 - 11   (6 days ago)
23:15:43 - r326784
(5 days 6 hours ago)
by imp
Affects:  /head/stand/common/interp_forth.c
Revert part of 362772. It was causing problems for includes and making
the menus disappear.

Sponsored by: Netflix
22:55:51 - r326783
(5 days 7 hours ago)
by kevans
Affects:  /head/sys/dev/syscon/syscon.c
Correct a typo in syscon driver 'modify' logic

Not previously caught because the current consumer (not yet in tree) doesn't
use the 'modify' bits (yet).

Reported by: rpokala
20:47:26 - r326782
(5 days 9 hours ago)
by asomers
Affects: 
(5 files)
/stable/11/lib/libcam/tests/*
/stable/11/sys/cam/cam.c
MFC r304443, r326034, r326065

r304443 by imp:
Improve the pattern matching so that internal *'s work, as well as
[set] notation. This fixes pattern matching for recently added drives
that would set the NCQ Trim being broken incorrectly.

PR: 210686
Tested-by: Tomoaki AOKI

r326034:
Fix multiple bugs in cam_strmatch

* Wrongly matches strings that are shorter than the pattern
* Fails to match negative character sets
* Fails to match character sets that aren't at the end of the pattern
* Fails to match character ranges

Reviewed by: imp
Sponsored by: Spectra Logic Corp
Differential Revision: https://reviews.freebsd.org/D13173

r326065:
Fix uninitialized variable from 326034

Reported by: Coverity
CID: 1382887
X-MFC-With: 326034
Sponsored by: Spectra Logic Corp
20:36:01 - r326781
(5 days 9 hours ago)
by asomers
Affects: 
(2 files)
/stable/11/usr.sbin/periodic/periodic.sh
MFC r326041:

periodic: fix exit status for nonexistent arguments

When called with an absolute pathname, periodic should attempt to execute
every script in that directory. If the directory does not exist, it should
print an error and exit 1. Due to a copy/paste mistake in r231568, it exits
0 in that case.

Reported by: devel/hs-ShellCheck
Sponsored by: Spectra Logic Corp
Differential Revision: https://reviews.freebsd.org/D13070
20:33:11 - r326780
(5 days 9 hours ago)
by asomers
Affects: 
(4 files)
/stable/11/etc/mtree/BSD.tests.dist
/stable/11/usr.bin/head/Makefile
/stable/11/usr.bin/head/tests
MFC r326039:

Add ATF tests for head(1)

Submitted by: Fred Schlecter <https://github.com/fjs-github>
Reviewed by: asomers, jilles
Differential Revision: https://github.com/freebsd/freebsd/pull/127
20:30:58 - r326779
(5 days 9 hours ago)
by asomers
Affects: 
(2 files)
/stable/11/sys/cam/scsi/scsi_da.c
MFC r326036:

da(4): Short-circuit unnecessary BIO_FLUSH commands

sys/cam/scsi/scsi_da.c
  Complete BIO_FLUSH commands immediately if the da(4) device hasn't
  been written to since the last flush. If we haven't written to the
  device, there is no reason to send a flush.

Submitted by: gibbs
Reviewed by: imp
Sponsored by: Spectra Logic Corp
Differential Revision: https://reviews.freebsd.org/D13106
20:24:29 - r326778
(5 days 9 hours ago)
by asomers
Affects: 
(2 files)
/stable/11/sbin/camcontrol/camcontrol.c
MFC r326032:

Print ZAC device type in "camcontrol identify" output

ZAC (Zoned-device ATA Command set) is the standard for addressing SMR
(shingled magnetic recording) devices over SATA. Drives indicate their
support for ZAC in their IDENTIFY block. Print whether and how a drive
supports ZAC in the output of "camcontrol identify".

Reviewed by: ken, imp
Sponsored by: Spectra Logic Corp
Differential Revision: https://reviews.freebsd.org/D13171
20:21:35 - r326777
(5 days 9 hours ago)
by asomers
Affects: 
(2 files)
/stable/11/sys/cam/scsi/scsi_xpt.c
MFC r325959:

Add assertion in probedone() that we're holding the device lock.

Submitted by: ken
Reviewed by: asomers
Sponsored by: Spectra Logic Corp
20:04:40 - r326776
(5 days 10 hours ago)
by dim
Affects:  /head/contrib/llvm/tools/clang/include/clang/Sema/ScopeInfo.h
/head/contrib/llvm/tools/clang/lib/Sema/SemaLambda.cpp
Pull in r320396 from upstream clang trunk (by Malcolm Parsons):

  [Sema] Fix crash in unused-lambda-capture warning for VLAs

  Summary:
  Clang was crashing when diagnosing an unused-lambda-capture for a VLA
  because From.getVariable() is null for the capture of a VLA bound.
  Warning about the VLA bound capture is not helpful, so only warn for
  the VLA itself.

  Fixes: PR35555

  Reviewers: aaron.ballman, dim, rsmith

  Reviewed By: aaron.ballman, dim

  Subscribers: cfe-commits

  Differential Revision: https://reviews.llvm.org/D41016

This fixes a segfault when building recent audio/zynaddsubfx port
versions.

Reported by: hps
MFC after: 3 days
20:01:28 - r326775
(5 days 10 hours ago)
by shurd
Affects:  /head/sys/net/iflib.c
Increment encap_pad_mbuf_fail when m_dup() fails in padding

Previously, the counter was only incremented when m_append() failed. Since
the function can also fail on m_dup() now, increment the counter there as
well.

Sponsored by: Limelight Networks
19:21:39 - r326774
(5 days 10 hours ago)
by markj
Affects: 
(7 files)
/head/sys/*
Pass the trap frame to fasttrap hooks.

The DTrace fasttrap entry points expect a struct reg containing the
register values of the calling thread. Perform the conversion in
fasttrap rather than in the trap handler: this reduces the number of
ifdefs and avoids wasting stack space for traps that don't involve
DTrace.

MFC after: 2 weeks
18:04:04 - r326773
(5 days 12 hours ago)
by kevans
Affects: 
(4 files)
/head/sys/conf/files
/head/sys/dev/syscon/syscon.c
/head/sys/dev/syscon/syscon_if.m
Add generic 'syscon' driver

Upstream dts for allwinner will require a syscon driver, since the emac node
coming in 4.15 will be using xref to /soc/syscon for configuring the emac
clock. Add a generic syscon driver to attach to /soc/syscon for use by
if_awg, providing basic read/write functionality to consumers.

syscon driver will also be used by arm64 at least for A64+H5 emac/if_awg.

Written by: mmel
Reviewed by: manu
Differential Revision: https://reviews.freebsd.org/D13295
16:18:05 - r326772
(5 days 13 hours ago)
by imp
Affects: 
(11 files)
/head/stand/*
Fix regression with lua import

Don't print when we can't find a file. Copy it instead to the error
buffer. Higher level routines determine if it's appropriate to print
the error message.

Also, remove dead code (labeled bogusly lost functionality) since we
never used that functionality. Remove unused arg from interact() too.

Sponsored by: Netflix
16:17:53 - r326771
(5 days 13 hours ago)
by imp
Affects:  /head/usr.sbin/efibootmgr/efibootmgr.c
Unbreak gcc build by using (void) for functions that take no args.

Sponsored by: Netflix
15:33:24 - r326770
(5 days 14 hours ago)
by markj
Affects:  /head/sys/vm/vm_pageout.c
Use a dedicated counter for inactive queue scans.

The laundry thread keeps track of the number of inactive queue scans
performed by the page daemon, and was previously using the v_pdwakeups
counter to count them. However, in some cases the inactive queue may
be scanned multiple times after a single wakeup, so it's more accurate
to use a dedicated counter.

Reviewed by: alc, kib (previous version)
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D13422
14:54:42 - r326769
(5 days 15 hours ago)
by bapt
Affects:  /head/usr.bin/ctlstat/ctlstat.c
Remove hard coded number of lun definition

The number of lun exposed is now exposed via sysctl by the kernel.
Use that number in ctlstat instead of the hardcoded version
Add a backward compatibility in case the sysctl(2) request fails.

This also allows ctlstat -l 1118 to actually work when having more than
1024 luns.

Reviewed by: avg, manu (both before the backward compatibility addition)
Approved by: avg, manu (both before the backward compatibility addition)
MFC after: 2 weeks
Sponsored by: Gandi.net
Differential Revision: https://reviews.freebsd.org/D13446
14:47:23 - r326768
(5 days 15 hours ago)
by imp
Affects:  /head/stand/defs.mk
Fix a comment to be more accurate
14:38:42 - r326767
(5 days 15 hours ago)
by mav
Affects: 
(2 files)
/stable/11/usr.bin/ctlstat/ctlstat.c
MFC r326273: Make ctlstat -n option work reasonably for sparse LUN list.
12:38:50 - r326766
(5 days 17 hours ago)
by ae
Affects: 
(2 files)
/stable/11/contrib/bsnmp/snmpd/config.c
MFC r326510:
  Fix format string warning with enabled DEBUGGING.
11:59:45 - r326765
(5 days 18 hours ago)
by kib
Affects:  /head/contrib/ofed/include/udma_barrier.h
ofed: Define barriers for mips and arm.

I used the strongest barriers available on the architectures, so if
the future analysis show that it is excessive, the barriers could be
relaxed. Still, it is unlikely that it is meaningful to run IB on 32bit
ARM or current MIPS machines, so the change is to make WITH_OFED to pass
tinderbox.

Sponsored by: Mellanox Technologies
Reviewed by: hselasky
Differential revision: https://reviews.freebsd.org/D13329
11:57:46 - r326764
(5 days 18 hours ago)
by kib
Affects:  /head/contrib/ofed/librdmacm/librdmacm.map
ofed: Remove duplicated symbols from the version file.

ld.bfd accepts multiple listing of the same symbol in the version script.
lld is stricter and errors out. Since arm64 and sometimes amd64 use lld,
we should correct this cosmetic issue.

Sponsored by: Mellanox Technologies
Reviewed by: hselasky
Differential revision: https://reviews.freebsd.org/D13329
05:21:48 - r326763
(6 days ago)
by delphij
Affects: 
(2 files)
/stable/10/usr.bin/find/function.c
MFC r325723:

find(1): Don't treat statfs() error as fatal in f_fstype, which can happen
when a directory is removed in the middle of find.

Instead of a full err(), allow find to continue, plus print a warning with
exitstatus set when appropriate.

Reported by: 100.chksetuid via gordon
Reviewed by: jilles
05:19:45 - r326762
(6 days ago)
by delphij
Affects: 
(2 files)
/stable/11/usr.bin/find/function.c
MFC r325723:

find(1): Don't treat statfs() error as fatal in f_fstype, which can happen
when a directory is removed in the middle of find.

Instead of a full err(), allow find to continue, plus print a warning with
exitstatus set when appropriate.

Reported by: 100.chksetuid via gordon
Reviewed by: jilles
05:10:11 - r326761
(6 days 1 hour ago)
by delphij
Affects: 
(2 files)
/stable/10/usr.sbin/inetd/builtins.c
MFC r326244:

Don't assign rs as we will assign it later.
05:06:28 - r326760
(6 days 1 hour ago)
by delphij
Affects: 
(2 files)
/stable/11/usr.sbin/inetd/builtins.c
MFC r326244:

Don't assign rs as we will assign it later.
04:40:25 - r326759
(6 days 1 hour ago)
by chuck
Affects:  /head/share/misc/committers-src.dot
Add myself to committers-src.dot

Reviewed by: ken, imp
Approved by: ken (mentor), imp (mentor)
Differential Revision: https://reviews.freebsd.org/D13406
04:32:37 - r326758
(6 days 1 hour ago)
by cem
Affects:  /head/sys/i386/conf/NOTES
/head/sys/i386/include/param.h
i386: Bump KSTACK_PAGES default to match amd64

Logically, extend r286288 to cover all threads, by default.

The world has largely moved on from i386. Most FreeBSD users and developers
test on amd64 hardware. For better or worse, we have written a non-trivial
amount of kernel code that relies on stacks larger than 8 kB, and it "just
works" on amd64, so there has been little incentive to shrink it.

amd64 had its KSTACK_PAGES bumped to 4 back in Peter's initial AMD64 commit,
r114349, in 2003. Since that time, i386 has limped along on a stack half
the size. We've even observed the stack overflows years ago, but neglected
to fix the issue; see the 20121223 and 20150728 entries in UPDATING.

If anyone is concerned with this change, I suggest they configure their
AMD64 kernels with KSTACK_PAGES 2 and fix the fallout there first. Eugene
has identified a list of high stack usage functions in the first PR below.

PR: 219476, 224218
Reported by: eugen@, Shreesh Holla <hshreesh AT yahoo.com>
Relnotes: maybe
Sponsored by: Dell EMC Isilon
02:44:15 - r326757
(6 days 3 hours ago)
by imp
Affects:  /head/tools/tools/nanobsd/embedded/qemu-amd64.cfg
Start adding commands that I know are good to build up residual
knowledge about qemu's quirks. Other qemu commands are possible, but
this is the quickest for testing.

Sponsored by: Netflix
02:44:10 - r326756
(6 days 3 hours ago)
by imp
Affects:  /head/tools/tools/nanobsd/nanobsd.sh
Add -I to just run the imaging part of nanobsd so you can test out
changes to the packaging part of nanobsd more easily, or experiment
with the image contents w/o regenerating a whole new image tree. This
can save minutes when you don't need to do the installworld /
installkernel, etc.

Sponsored by: Netflix
02:43:56 - r326755
(6 days 3 hours ago)
by imp
Affects:  /head/tools/tools/nanobsd/embedded/common
Fix the std-x86 layout to produce a bootable system. Due to
limitations in mkimg we're still not quite to where I'd like to be
(I'd like to put s3 first on the disk, then s1, but mkimg won't allow
that currently). However, the resulting image now boots with qemu using:

qemu-system-x86_64 -hdd $file -serial telnet::4444,server -nographic

We'll need tweaks to create a specialized /etc/rc.d/growfs that can
create a properly grown image for either the simple or ping-pong
cases, but that will be later. Switched to pure serial console (-h)
instead of video or serial (-P) since that fits this usecase better.

Sponsored by: Netflix

 


Powered by Python FreeBSD support by secnetix GmbH & Co. KG

Page generated in 16 ms, 164 revisions printed. Current time is 2017-12-17 06:14:27. All times are in UTC/GMT.